From: bhe@redhat.com (Baoquan He) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v20 13/14] arm64: kdump: update a kernel doc Date: Fri, 1 Jul 2016 15:45:05 +0800 [thread overview] Message-ID: <20160701074505.GB10467@x1.redhat.com> (raw) In-Reply-To: <20160701073707.GM20774@linaro.org> On 07/01/16 at 04:37pm, AKASHI Takahiro wrote: > Dave, Boaquan, > > Thank you for your reviewing. > > On Thu, Jun 30, 2016 at 05:00:45PM +0800, Baoquan He wrote: > > On 06/23/16 at 05:54pm, Geoff Levand wrote: > > > From: AKASHI Takahiro <takahiro.akashi@linaro.org> > > > > > > This patch adds arch specific descriptions about kdump usage on arm64 > > > to kdump.txt. > > > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > > > --- > > > Documentation/kdump/kdump.txt | 15 ++++++++++++++- > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt > > > index 88ff63d..5d6da09 100644 > > > --- a/Documentation/kdump/kdump.txt > > > +++ b/Documentation/kdump/kdump.txt > > > @@ -18,7 +18,7 @@ memory image to a dump file on the local disk, or across the network to > > > a remote system. > > > > > > Kdump and kexec are currently supported on the x86, x86_64, ppc64, ia64, > > > -s390x and arm architectures. > > > +s390x, arm and arm64 architectures. > > > > > > When the system kernel boots, it reserves a small section of memory for > > > the dump-capture kernel. This ensures that ongoing Direct Memory Access > > > @@ -249,6 +249,12 @@ Dump-capture kernel config options (Arch Dependent, arm) > > > > > > AUTO_ZRELADDR=y > > > > > > +Dump-capture kernel config options (Arch Dependent, arm64) > > > +---------------------------------------------------------- > > > + > > > +1) Currently, kvm will not be enabled on the dump-capture kernel even > > > + if it is configured. And here, could you say more about it? > > > + > > > Extended crashkernel syntax > > > =========================== > > > > > > @@ -305,6 +311,8 @@ Boot into System Kernel > > > kernel will automatically locate the crash kernel image within the > > > first 512MB of RAM if X is not given. > > > > > > + On arm64, use "crashkernel=Y[@X]". Note that the start address of > > ~ Why square brackets here, is it > > different than other arch? > > I want to clearly indicate that "@X" is optional, and that, when you explicitly > specify it, X must be properly aligned. > I think that "[..]" notation is quite common. Yes, I see that. Just that has been noted in "Extended crashkernel syntax" section, and adding "[]" is not consistent with other places where "crashkernel=Y at X" is referred to in this section. Just feel it's a little redundent. Anyway it's not very critical, and Dave has acked it, I am fine if you want to keep it. Thanks Baoquan > > Thanks, > -Takahiro AKASHI > > > > > Except for this, it looks good to me. > > > > Thanks > > Baoquan > > > > > + the kernel, X if explicitly specified, must be aligned to 2MiB (0x200000). > > > > > > Load the Dump-capture Kernel > > > ============================ > > > @@ -327,6 +335,8 @@ For s390x: > > > - Use image or bzImage > > > For arm: > > > - Use zImage > > > +For arm64: > > > + - Use vmlinux or Image > > > > > > If you are using a uncompressed vmlinux image then use following command > > > to load dump-capture kernel. > > > @@ -370,6 +380,9 @@ For s390x: > > > For arm: > > > "1 maxcpus=1 reset_devices" > > > > > > +For arm64: > > > + "1 maxcpus=1 reset_devices" > > > + > > > Notes on loading the dump-capture kernel: > > > > > > * By default, the ELF headers are stored in ELF64 format to support > > > -- > > > 2.5.0 > > > > > > > > > > > > _______________________________________________ > > > kexec mailing list > > > kexec at lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com> To: AKASHI Takahiro <takahiro.akashi@linaro.org>, Geoff Levand <geoff@infradead.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, marc.zyngier@arm.com, kexec@lists.infradead.org, James Morse <james.morse@arm.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v20 13/14] arm64: kdump: update a kernel doc Date: Fri, 1 Jul 2016 15:45:05 +0800 [thread overview] Message-ID: <20160701074505.GB10467@x1.redhat.com> (raw) In-Reply-To: <20160701073707.GM20774@linaro.org> On 07/01/16 at 04:37pm, AKASHI Takahiro wrote: > Dave, Boaquan, > > Thank you for your reviewing. > > On Thu, Jun 30, 2016 at 05:00:45PM +0800, Baoquan He wrote: > > On 06/23/16 at 05:54pm, Geoff Levand wrote: > > > From: AKASHI Takahiro <takahiro.akashi@linaro.org> > > > > > > This patch adds arch specific descriptions about kdump usage on arm64 > > > to kdump.txt. > > > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > > > --- > > > Documentation/kdump/kdump.txt | 15 ++++++++++++++- > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt > > > index 88ff63d..5d6da09 100644 > > > --- a/Documentation/kdump/kdump.txt > > > +++ b/Documentation/kdump/kdump.txt > > > @@ -18,7 +18,7 @@ memory image to a dump file on the local disk, or across the network to > > > a remote system. > > > > > > Kdump and kexec are currently supported on the x86, x86_64, ppc64, ia64, > > > -s390x and arm architectures. > > > +s390x, arm and arm64 architectures. > > > > > > When the system kernel boots, it reserves a small section of memory for > > > the dump-capture kernel. This ensures that ongoing Direct Memory Access > > > @@ -249,6 +249,12 @@ Dump-capture kernel config options (Arch Dependent, arm) > > > > > > AUTO_ZRELADDR=y > > > > > > +Dump-capture kernel config options (Arch Dependent, arm64) > > > +---------------------------------------------------------- > > > + > > > +1) Currently, kvm will not be enabled on the dump-capture kernel even > > > + if it is configured. And here, could you say more about it? > > > + > > > Extended crashkernel syntax > > > =========================== > > > > > > @@ -305,6 +311,8 @@ Boot into System Kernel > > > kernel will automatically locate the crash kernel image within the > > > first 512MB of RAM if X is not given. > > > > > > + On arm64, use "crashkernel=Y[@X]". Note that the start address of > > ~ Why square brackets here, is it > > different than other arch? > > I want to clearly indicate that "@X" is optional, and that, when you explicitly > specify it, X must be properly aligned. > I think that "[..]" notation is quite common. Yes, I see that. Just that has been noted in "Extended crashkernel syntax" section, and adding "[]" is not consistent with other places where "crashkernel=Y@X" is referred to in this section. Just feel it's a little redundent. Anyway it's not very critical, and Dave has acked it, I am fine if you want to keep it. Thanks Baoquan > > Thanks, > -Takahiro AKASHI > > > > > Except for this, it looks good to me. > > > > Thanks > > Baoquan > > > > > + the kernel, X if explicitly specified, must be aligned to 2MiB (0x200000). > > > > > > Load the Dump-capture Kernel > > > ============================ > > > @@ -327,6 +335,8 @@ For s390x: > > > - Use image or bzImage > > > For arm: > > > - Use zImage > > > +For arm64: > > > + - Use vmlinux or Image > > > > > > If you are using a uncompressed vmlinux image then use following command > > > to load dump-capture kernel. > > > @@ -370,6 +380,9 @@ For s390x: > > > For arm: > > > "1 maxcpus=1 reset_devices" > > > > > > +For arm64: > > > + "1 maxcpus=1 reset_devices" > > > + > > > Notes on loading the dump-capture kernel: > > > > > > * By default, the ELF headers are stored in ELF64 format to support > > > -- > > > 2.5.0 > > > > > > > > > > > > _______________________________________________ > > > kexec mailing list > > > kexec@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/kexec _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-07-01 7:45 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-23 17:54 [PATCH v20 00/14] arm64 kexec kernel patches Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 06/14] arm64/kexec: Add pr_debug output Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 07/14] arm64: kdump: reserve memory for crash dump kernel Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 04/14] arm64/kexec: Add core kexec support Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-27 11:18 ` James Morse 2016-06-27 11:18 ` James Morse 2016-06-27 14:39 ` Catalin Marinas 2016-06-27 14:39 ` Catalin Marinas 2016-06-27 16:29 ` James Morse 2016-06-27 16:29 ` James Morse 2016-06-27 17:00 ` Geoff Levand 2016-06-27 17:00 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 02/14] arm64: smp: Add function to determine if cpus are stuck in the kernel Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 08/14] arm64: limit memory regions based on DT property, usable-memory Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 11/14] arm64: kdump: add VMCOREINFO's for user-space coredump tools Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 10/14] arm64: kdump: add kdump support Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 12/14] arm64: kdump: enable kdump in the arm64 defconfig Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 03/14] arm64: Add back cpu reset routines Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 01/14] arm64: hibernate: Don't hibernate on systems with stuck CPUs Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-27 11:04 ` James Morse 2016-06-27 11:04 ` James Morse 2016-06-27 16:44 ` Geoff Levand 2016-06-27 16:44 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 05/14] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 09/14] arm64: kdump: implement machine_crash_shutdown() Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-23 17:54 ` [PATCH v20 14/14] Documentation: dt: usable-memory and elfcorehdr nodes for arm64 kexec Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-27 18:22 ` Thiago Jung Bauermann 2016-06-27 18:22 ` Thiago Jung Bauermann 2016-06-28 3:59 ` Michael Ellerman 2016-06-28 3:59 ` Michael Ellerman 2016-06-23 17:54 ` [PATCH v20 13/14] arm64: kdump: update a kernel doc Geoff Levand 2016-06-23 17:54 ` Geoff Levand 2016-06-30 9:00 ` Baoquan He 2016-06-30 9:00 ` Baoquan He 2016-07-01 7:37 ` AKASHI Takahiro 2016-07-01 7:37 ` AKASHI Takahiro 2016-07-01 7:45 ` Baoquan He [this message] 2016-07-01 7:45 ` Baoquan He 2016-07-04 3:04 ` AKASHI Takahiro 2016-07-04 3:04 ` AKASHI Takahiro 2016-06-30 13:00 ` Dave Young 2016-06-30 13:00 ` Dave Young 2016-06-27 17:00 ` [PATCH v20 00/14] arm64 kexec kernel patches Catalin Marinas 2016-06-27 17:00 ` Catalin Marinas 2016-06-27 17:07 ` Geoff Levand 2016-06-27 17:07 ` Geoff Levand 2016-06-29 0:54 ` AKASHI Takahiro 2016-06-29 0:54 ` AKASHI Takahiro 2016-06-29 9:20 ` Catalin Marinas 2016-06-29 9:20 ` Catalin Marinas 2016-06-30 1:46 ` AKASHI Takahiro 2016-06-30 1:46 ` AKASHI Takahiro 2016-07-01 2:39 ` Pratyush Anand 2016-07-01 2:39 ` Pratyush Anand 2016-07-04 7:14 ` AKASHI Takahiro 2016-07-04 7:14 ` AKASHI Takahiro 2016-07-04 10:15 ` Pratyush Anand 2016-07-04 10:15 ` Pratyush Anand 2016-07-15 4:17 ` Simon Horman 2016-07-15 4:17 ` Simon Horman 2016-07-15 16:18 ` Geoff Levand 2016-07-15 16:18 ` Geoff Levand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160701074505.GB10467@x1.redhat.com \ --to=bhe@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.