All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] openblas: build only C-language BLAS if the toolchain doesn't have Fortran
@ 2016-07-04 15:22 Vicente Olivert Riera
  2016-07-04 15:39 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Vicente Olivert Riera @ 2016-07-04 15:22 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/openblas/openblas.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/openblas/openblas.mk b/package/openblas/openblas.mk
index d07d09d..609169f 100644
--- a/package/openblas/openblas.mk
+++ b/package/openblas/openblas.mk
@@ -19,9 +19,10 @@ OPENBLAS_MAKE_OPTS += CROSS=1
 # Set OpenBLAS target
 OPENBLAS_MAKE_OPTS += TARGET=$(BR2_PACKAGE_OPENBLAS_TARGET)
 
-# Disable fortran by default until we add BR2_TOOLCHAIN_HAS_FORTRAN
-# hidden symbol to our toolchain infrastructure
+# Build only C-language BLAS if the toolchain doesn't have Fortran
+ifeq ($(BR2_TOOLCHAIN_HAS_FORTRAN),)
 OPENBLAS_MAKE_OPTS += ONLY_CBLAS=1
+endif
 
 # Enable/Disable multi-threading (not for static-only since it uses dlfcn.h)
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS):$(BR2_STATIC_LIBS),y:)
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] openblas: build only C-language BLAS if the toolchain doesn't have Fortran
  2016-07-04 15:22 [Buildroot] [PATCH] openblas: build only C-language BLAS if the toolchain doesn't have Fortran Vicente Olivert Riera
@ 2016-07-04 15:39 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-07-04 15:39 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 4 Jul 2016 16:22:59 +0100, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/openblas/openblas.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I've applied, after reworking the commit title and comment. Indeed when
you say "openblas: build only C-language BLAS if the toolchain doesn't
have Fortran" one might think that the C-language BLAS will only be
built when Fortran is not available.

While what you are doing is just making sure that BLAS tries to only
build the C version when Fortran support is not available.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-04 15:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 15:22 [Buildroot] [PATCH] openblas: build only C-language BLAS if the toolchain doesn't have Fortran Vicente Olivert Riera
2016-07-04 15:39 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.