All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Michal Hocko <mhocko@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries
Date: Tue, 5 Jul 2016 11:55:26 +0100	[thread overview]
Message-ID: <20160705105526.GK11498@techsingularity.net> (raw)
In-Reply-To: <00fa01d1d694$42f6a7e0$c8e3f7a0$@alibaba-inc.com>

On Tue, Jul 05, 2016 at 04:07:23PM +0800, Hillf Danton wrote:
> > +		/*
> > +		 * Would the allocation succeed if we reclaimed the whole
> > +		 * available? This is approximate because there is no
> > +		 * accurate count of reclaimable pages per zone.
> > +		 */
> > +		for (zid = 0; zid <= zone_idx(zone); zid++) {
> > +			struct zone *check_zone = &current_pgdat->node_zones[zid];
> > +			unsigned long estimate;
> > +
> > +			estimate = min(check_zone->managed_pages, available);
> > +			if (__zone_watermark_ok(check_zone, order,
> > +					min_wmark_pages(check_zone), ac_classzone_idx(ac),
> > +					alloc_flags, available)) {
> > +			}
> Stray indent?
> 

Last minute rebase-related damage. I'll fix it.

-- 
Mel Gorman
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Michal Hocko <mhocko@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries
Date: Tue, 5 Jul 2016 11:55:26 +0100	[thread overview]
Message-ID: <20160705105526.GK11498@techsingularity.net> (raw)
In-Reply-To: <00fa01d1d694$42f6a7e0$c8e3f7a0$@alibaba-inc.com>

On Tue, Jul 05, 2016 at 04:07:23PM +0800, Hillf Danton wrote:
> > +		/*
> > +		 * Would the allocation succeed if we reclaimed the whole
> > +		 * available? This is approximate because there is no
> > +		 * accurate count of reclaimable pages per zone.
> > +		 */
> > +		for (zid = 0; zid <= zone_idx(zone); zid++) {
> > +			struct zone *check_zone = &current_pgdat->node_zones[zid];
> > +			unsigned long estimate;
> > +
> > +			estimate = min(check_zone->managed_pages, available);
> > +			if (__zone_watermark_ok(check_zone, order,
> > +					min_wmark_pages(check_zone), ac_classzone_idx(ac),
> > +					alloc_flags, available)) {
> > +			}
> Stray indent?
> 

Last minute rebase-related damage. I'll fix it.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-07-05 10:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <00f601d1d691$d790ad40$86b207c0$@alibaba-inc.com>
2016-07-05  8:07 ` [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Hillf Danton
2016-07-05  8:07   ` Hillf Danton
2016-07-05 10:55   ` Mel Gorman [this message]
2016-07-05 10:55     ` Mel Gorman
2016-07-01 20:01 [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Mel Gorman
2016-07-01 20:01 ` [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Mel Gorman
2016-07-01 20:01   ` Mel Gorman
2016-07-06  0:02   ` Minchan Kim
2016-07-06  0:02     ` Minchan Kim
2016-07-06  8:58     ` Mel Gorman
2016-07-06  8:58       ` Mel Gorman
2016-07-06  9:33       ` Mel Gorman
2016-07-06  9:33         ` Mel Gorman
2016-07-07  6:47       ` Minchan Kim
2016-07-07  6:47         ` Minchan Kim
2016-07-06 18:12   ` Dave Hansen
2016-07-06 18:12     ` Dave Hansen
2016-07-07 11:26     ` Mel Gorman
2016-07-07 11:26       ` Mel Gorman
  -- strict thread matches above, loose matches on Subject: below --
2016-07-01 15:37 [PATCH 00/31] Move LRU page reclaim from zones to nodes v8 Mel Gorman
2016-07-01 15:37 ` [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries Mel Gorman
2016-07-01 15:37   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705105526.GK11498@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=akpm@linux-foundation.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.