All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] dt/bindings: Add bindings for JC-42.4 compatible temperature sensors
Date: Tue, 5 Jul 2016 10:48:11 -0500	[thread overview]
Message-ID: <20160705154811.GA3982@rob-hp-laptop> (raw)
In-Reply-To: <1467479142-8249-1-git-send-email-linux@roeck-us.net>

On Sat, Jul 02, 2016 at 10:05:42AM -0700, Guenter Roeck wrote:
> Provide generic bindings for all Jedec JC-42.4 compatible temperature
> sensor chips.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> RFC to address:
> - Is "jc-42-4" ok to use for JC-42.4 ?
> - JC42.4 really specifies an SPD EEPROM with included temperature sensor.

That would be at a different address?

>   Is "jedec,jc42-4" appropriate, or should it rather be something like
>   "jedec,jc-42-4-sensor" ?

If yes, then probably the latter. Though I would do "temp" rather than 
"sensor".

Also, "-42.4" is fine.
 
>  Documentation/devicetree/bindings/hwmon/jc42.txt | 42 ++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/jc42.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/jc42.txt b/Documentation/devicetree/bindings/hwmon/jc42.txt
> new file mode 100644
> index 000000000000..2bd604a93430
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/jc42.txt
> @@ -0,0 +1,42 @@
> +Properties for Jedec JC-42.4 compatible temperature sensors
> +
> +Required properties:
> +- compatible: May include a device-specific string consisting of the
> +	      manufacturer and the name of the chip. A list of supported
> +	      chip names follows.
> +	      Must include "jedec,jc-42-4" for any Jedec JC-42.4 compatible
> +	      temperature sensor.
> +
> +	      Supported chip names:
> +		adt7408
> +		at30ts00
> +		at30tse004
> +		cat6095
> +		cat34ts02
> +		max6604
> +		mcp9804
> +		mcp9805
> +		mcp9808
> +		mcp98243
> +		mcp98244
> +		mcp9843
> +		se97
> +		se98
> +		stts2002
> +		stts2004
> +		stts3000
> +		stts424
> +		stts424e
> +		tse2002
> +		tse2004
> +		ts3000
> +		ts3001

These are all vendor independent names?

> +
> +- reg: I2C address
> +
> +Example:
> +
> +temp-sensor@1a {
> +	compatible = "jedec,jc-42-4";
> +	reg = <0x18>;
> +};
> -- 
> 2.5.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH] dt/bindings: Add bindings for JC-42.4 compatible temperature sensors
Date: Tue, 5 Jul 2016 10:48:11 -0500	[thread overview]
Message-ID: <20160705154811.GA3982@rob-hp-laptop> (raw)
In-Reply-To: <1467479142-8249-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>

On Sat, Jul 02, 2016 at 10:05:42AM -0700, Guenter Roeck wrote:
> Provide generic bindings for all Jedec JC-42.4 compatible temperature
> sensor chips.
> 
> Signed-off-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> ---
> RFC to address:
> - Is "jc-42-4" ok to use for JC-42.4 ?
> - JC42.4 really specifies an SPD EEPROM with included temperature sensor.

That would be at a different address?

>   Is "jedec,jc42-4" appropriate, or should it rather be something like
>   "jedec,jc-42-4-sensor" ?

If yes, then probably the latter. Though I would do "temp" rather than 
"sensor".

Also, "-42.4" is fine.
 
>  Documentation/devicetree/bindings/hwmon/jc42.txt | 42 ++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/jc42.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/jc42.txt b/Documentation/devicetree/bindings/hwmon/jc42.txt
> new file mode 100644
> index 000000000000..2bd604a93430
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/jc42.txt
> @@ -0,0 +1,42 @@
> +Properties for Jedec JC-42.4 compatible temperature sensors
> +
> +Required properties:
> +- compatible: May include a device-specific string consisting of the
> +	      manufacturer and the name of the chip. A list of supported
> +	      chip names follows.
> +	      Must include "jedec,jc-42-4" for any Jedec JC-42.4 compatible
> +	      temperature sensor.
> +
> +	      Supported chip names:
> +		adt7408
> +		at30ts00
> +		at30tse004
> +		cat6095
> +		cat34ts02
> +		max6604
> +		mcp9804
> +		mcp9805
> +		mcp9808
> +		mcp98243
> +		mcp98244
> +		mcp9843
> +		se97
> +		se98
> +		stts2002
> +		stts2004
> +		stts3000
> +		stts424
> +		stts424e
> +		tse2002
> +		tse2004
> +		ts3000
> +		ts3001

These are all vendor independent names?

> +
> +- reg: I2C address
> +
> +Example:
> +
> +temp-sensor@1a {
> +	compatible = "jedec,jc-42-4";
> +	reg = <0x18>;
> +};
> -- 
> 2.5.0
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-07-05 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-02 17:05 [RFC PATCH] dt/bindings: Add bindings for JC-42.4 compatible temperature sensors Guenter Roeck
2016-07-05 15:48 ` Rob Herring [this message]
2016-07-05 15:48   ` Rob Herring
2016-07-05 16:30   ` Guenter Roeck
2016-07-05 16:30     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705154811.GA3982@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.