All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Octavian Purdila <octavian.purdila@intel.com>
Subject: Re: linux-next: build failure after merge of the pm tree
Date: Mon, 11 Jul 2016 07:48:17 +0300	[thread overview]
Message-ID: <20160711044817.GE14693@lahna.fi.intel.com> (raw)
In-Reply-To: <20160711114653.066355ae@canb.auug.org.au>

On Mon, Jul 11, 2016 at 11:46:53AM +1000, Stephen Rothwell wrote:
> Hi Rafael,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> ERROR: "config_item_put" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> ERROR: "config_item_init_type_name" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
> 
> ... and many more ...
> 
> Presumably (maybe?) caused by commit
> 
>   0bf54fcd9504 ("ACPI: add support for configfs")
> 
> though it is not obvious why this should be a problem.

Looks like it is the module name (configfs.o) that confuses modpost or
linker. The below patch fixes it for me.

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH] ACPI: Rename configfs.c to acpi_configfs.c to prevent link error

If we compile ACPI configfs.c as module it will confuse the linker as it
hides symbols from the actual configfs:

Kernel: arch/x86/boot/bzImage is ready  (#1236)
  MODPOST 5739 modules
ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_item_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "config_group_init_type_name" [samples/configfs/configfs_sample.ko] undefined!
ERROR: "configfs_undepend_item" [fs/ocfs2/cluster/ocfs2_nodemanager.ko] undefined!
...

Prevent these by renaming the file to acpi_configfs.c instead.

Reported-by: Scott Lawson <scott.lawson@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/acpi/Makefile                        | 2 +-
 drivers/acpi/{configfs.c => acpi_configfs.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/acpi/{configfs.c => acpi_configfs.c} (100%)

diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 1dc2173ad8d0..f72a83df1cf3 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -99,6 +99,6 @@ obj-$(CONFIG_ACPI_EXTLOG)	+= acpi_extlog.o
 obj-$(CONFIG_PMIC_OPREGION)	+= pmic/intel_pmic.o
 obj-$(CONFIG_CRC_PMIC_OPREGION) += pmic/intel_pmic_crc.o
 obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
-obj-$(CONFIG_ACPI_CONFIGFS)	+= configfs.o
+obj-$(CONFIG_ACPI_CONFIGFS)	+= acpi_configfs.o
 
 video-objs			+= acpi_video.o video_detect.o
diff --git a/drivers/acpi/configfs.c b/drivers/acpi/acpi_configfs.c
similarity index 100%
rename from drivers/acpi/configfs.c
rename to drivers/acpi/acpi_configfs.c
-- 
2.8.1

  reply	other threads:[~2016-07-11  4:48 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11  1:46 linux-next: build failure after merge of the pm tree Stephen Rothwell
2016-07-11  4:48 ` Mika Westerberg [this message]
2016-07-11  5:29   ` Stephen Rothwell
2016-07-11 12:57     ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2024-02-08  3:42 Stephen Rothwell
2024-01-24  0:51 Stephen Rothwell
2024-01-24 15:56 ` Wysocki, Rafael J
2023-12-18 23:37 Stephen Rothwell
2023-11-21  2:46 Stephen Rothwell
2023-07-14  1:00 Stephen Rothwell
2023-07-14 18:19 ` Wysocki, Rafael J
2023-07-14 18:50   ` Rafael J. Wysocki
2023-04-03 10:18 Stephen Rothwell
2023-04-03  1:25 Stephen Rothwell
2023-04-03  1:16 Stephen Rothwell
2023-04-03  1:06 Stephen Rothwell
2022-06-29  0:23 Stephen Rothwell
2022-06-29 13:01 ` Rafael J. Wysocki
2022-04-28  1:00 Stephen Rothwell
2022-04-28  3:07 ` Zhang Rui
2022-04-28  8:53 ` Zhang Rui
2022-04-28  8:56 ` Zhang Rui
2022-04-28 12:32   ` Rafael J. Wysocki
2022-01-04  0:15 Stephen Rothwell
2022-01-04  7:29 ` Heiner Kallweit
2022-01-04  8:02   ` Stephen Rothwell
2022-01-04 14:43     ` Heiner Kallweit
2022-01-04 14:57       ` Rafael J. Wysocki
2021-12-01 23:28 Stephen Rothwell
2021-12-02 10:04 ` Daniel Lezcano
2021-12-03 16:50   ` Rafael J. Wysocki
2021-12-03 17:22     ` Daniel Lezcano
2021-02-05  0:51 Stephen Rothwell
     [not found] ` <CAHp75VfiyAtxg+wqZ30kSzCfFFsLndLjzrUc1njZG0x6vQeyBQ@mail.gmail.com>
2021-02-05 11:15   ` Andy Shevchenko
2021-02-08 19:30     ` Rafael J. Wysocki
2021-02-08 19:47       ` Andy Shevchenko
2021-02-08 19:48         ` Andy Shevchenko
2021-02-09 14:32           ` Rafael J. Wysocki
2021-02-09 16:04             ` Andy Shevchenko
2020-12-09  9:57 Stephen Rothwell
2020-03-17  7:52 Stephen Rothwell
2020-03-18 11:44 ` Stephen Rothwell
2020-03-18 11:52   ` Colin Ian King
2020-03-18 12:18     ` Stephen Rothwell
2020-03-19  5:42       ` Stephen Rothwell
2020-03-19  9:32         ` Rafael J. Wysocki
2019-07-31  5:34 Stephen Rothwell
2019-07-31 10:27 ` Rafael J. Wysocki
2019-07-15  0:02 Stephen Rothwell
2019-07-15  9:44 ` Rafael J. Wysocki
2019-07-04  9:41 Stephen Rothwell
2019-07-04  9:48 ` Viresh Kumar
2019-07-04 10:33   ` Rafael J. Wysocki
2019-07-01  3:37 Stephen Rothwell
2019-07-01  7:48 ` Viresh Kumar
2018-05-24 14:16 Mark Brown
2018-05-24 14:16 ` Mark Brown
2016-09-14  4:27 Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
2016-07-22  1:56 Stephen Rothwell
2016-07-22  2:26 ` Steve Muckle
2016-07-22 12:08   ` Rafael J. Wysocki
2016-07-22 12:16     ` Fengguang Wu
2016-06-02  2:12 Stephen Rothwell
2016-04-01  1:27 Stephen Rothwell
2016-04-01 20:51 ` Rafael J. Wysocki
2015-12-09  1:54 Stephen Rothwell
2015-12-09  2:00 ` Viresh Kumar
2015-11-01  6:57 Stephen Rothwell
2015-11-01  6:57 ` Stephen Rothwell
2015-11-01  6:57 ` Stephen Rothwell
2015-11-02  0:37 ` Rafael J. Wysocki
2015-11-02  0:37   ` Rafael J. Wysocki
2015-04-13  4:24 Stephen Rothwell
2015-04-13  4:24 ` Stephen Rothwell
2015-04-13 12:06 ` Rafael J. Wysocki
2015-04-13 12:06   ` Rafael J. Wysocki
2015-04-15  2:30 ` Stephen Rothwell
2015-04-15  2:30   ` Stephen Rothwell
2015-02-09  2:26 Stephen Rothwell
2015-02-09  2:53 ` Jiang Liu
2015-02-09  3:22   ` Rafael J. Wysocki
2015-02-09  5:36     ` Jiang Liu
2015-02-09  6:23       ` Lorenzo Pieralisi
2015-02-09 15:10         ` Rafael J. Wysocki
2015-02-09 15:21           ` Jiang Liu
2015-02-09 15:50             ` Lorenzo Pieralisi
2015-02-09  3:19 ` Rafael J. Wysocki
2015-02-09  3:53   ` Lorenzo Pieralisi
2014-08-11  1:57 Stephen Rothwell
2014-08-12  1:10 ` Rafael J. Wysocki
2013-12-18  1:00 Stephen Rothwell
2013-12-18  1:17 ` Rafael J. Wysocki
2013-07-05  1:24 Stephen Rothwell
2013-07-05  1:37 ` Rafael J. Wysocki
2013-03-03 23:58 Stephen Rothwell
2013-03-04 11:54 ` Rafael J. Wysocki
2013-01-30  8:48 Stephen Rothwell
2013-01-30 12:50 ` Rafael J. Wysocki
2013-01-14  0:03 Stephen Rothwell
2013-01-14 12:37 ` Rafael J. Wysocki
2013-01-14 13:22 ` Sedat Dilek
2013-01-14 18:54   ` Rafael J. Wysocki
2012-11-28  4:02 Stephen Rothwell
2012-11-28  9:32 ` Rafael J. Wysocki
2012-11-26  6:09 Stephen Rothwell
2012-11-26 10:10 ` Rafael J. Wysocki
2012-09-25  4:30 Stephen Rothwell
2012-09-25 11:51 ` Rafael J. Wysocki
2012-06-20  5:01 Stephen Rothwell
2012-06-20 22:54 ` Rafael J. Wysocki
2012-01-27  1:53 Stephen Rothwell
2012-01-27  9:35 ` Rafael J. Wysocki
2011-11-10  2:31 Stephen Rothwell
2011-11-10 12:11 ` Rafael J. Wysocki
2011-11-10 15:48   ` Tejun Heo
2011-11-11 12:27 ` Rafael J. Wysocki
2011-09-28  4:51 Stephen Rothwell
2011-09-28  5:11 ` Ming Lei
2011-09-28 13:58   ` Rafael J. Wysocki
2011-09-28 14:47     ` Ming Lei
2011-09-28 19:32       ` Rafael J. Wysocki
2011-09-29  1:32         ` Ming Lei
2011-09-29  9:26           ` Rafael J. Wysocki
2011-09-29  9:32             ` Ming Lei
2011-09-29 20:25               ` Rafael J. Wysocki
2011-09-28 14:47     ` Rafael J. Wysocki
2011-08-19 13:47 Stephen Rothwell
2011-08-19 21:31 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711044817.GE14693@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.