All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Rob Herring <robh@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the pm tree
Date: Mon, 3 Apr 2023 20:18:01 +1000	[thread overview]
Message-ID: <20230403201801.02839c9a@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 4829 bytes --]

Hi all,

After merging the pm tree, today's linux-next build (powerpc allyesconfig)
failed like this:

In file included from drivers/char/tpm/tpm_atmel.c:18:
drivers/char/tpm/tpm_atmel.h: In function 'atmel_get_base_addr':
drivers/char/tpm/tpm_atmel.h:50:14: error: implicit declaration of function 'of_find_node_by_name'; did you mean 'bus_find_device_by_name'? [-Werror=implicit-function-declaration]
   50 |         dn = of_find_node_by_name(NULL, "tpm");
      |              ^~~~~~~~~~~~~~~~~~~~
      |              bus_find_device_by_name
drivers/char/tpm/tpm_atmel.h:50:12: error: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
   50 |         dn = of_find_node_by_name(NULL, "tpm");
      |            ^
drivers/char/tpm/tpm_atmel.h:55:14: error: implicit declaration of function 'of_device_is_compatible'; did you mean 'fwnode_device_is_compatible'? [-Werror=implicit-function-declaration]
   55 |         if (!of_device_is_compatible(dn, "AT97SC3201")) {
      |              ^~~~~~~~~~~~~~~~~~~~~~~
      |              fwnode_device_is_compatible
drivers/char/tpm/tpm_atmel.h:56:17: error: implicit declaration of function 'of_node_put' [-Werror=implicit-function-declaration]
   56 |                 of_node_put(dn);
      |                 ^~~~~~~~~~~
drivers/char/tpm/tpm_atmel.h:60:15: error: implicit declaration of function 'of_get_property' [-Werror=implicit-function-declaration]
   60 |         reg = of_get_property(dn, "reg", &reglen);
      |               ^~~~~~~~~~~~~~~
drivers/char/tpm/tpm_atmel.h:60:13: error: assignment to 'const unsigned int *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
   60 |         reg = of_get_property(dn, "reg", &reglen);
      |             ^
drivers/char/tpm/tpm_atmel.h:61:18: error: implicit declaration of function 'of_n_addr_cells' [-Werror=implicit-function-declaration]
   61 |         naddrc = of_n_addr_cells(dn);
      |                  ^~~~~~~~~~~~~~~
drivers/char/tpm/tpm_atmel.h:62:18: error: implicit declaration of function 'of_n_size_cells' [-Werror=implicit-function-declaration]
   62 |         nsizec = of_n_size_cells(dn);
      |                  ^~~~~~~~~~~~~~~
drivers/perf/arm_dmc620_pmu.c:710:36: error: array type has incomplete element type 'struct acpi_device_id'
  710 | static const struct acpi_device_id dmc620_acpi_match[] = {
      |                                    ^~~~~~~~~~~~~~~~~
drivers/perf/arm_dmc620_pmu.c:710:36: error: 'dmc620_acpi_match' defined but not used [-Werror=unused-variable]
drivers/perf/alibaba_uncore_drw_pmu.c:757:36: error: array type has incomplete element type 'struct acpi_device_id'
  757 | static const struct acpi_device_id ali_drw_acpi_match[] = {
      |                                    ^~~~~~~~~~~~~~~~~~
drivers/perf/alibaba_uncore_drw_pmu.c:757:36: error: 'ali_drw_acpi_match' defined but not used [-Werror=unused-variable]

Caused by commit

  054e68aae050 ("ACPI: Replace irqdomain.h include with struct declarations")

I have applied the following fixup patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 3 Apr 2023 19:58:19 +1000
Subject: [PATCH] more fixups for "ACPI: Replace irqdomain.h include with
 struct declarations"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/tpm/tpm_atmel.h          | 2 ++
 drivers/perf/alibaba_uncore_drw_pmu.c | 1 +
 drivers/perf/arm_dmc620_pmu.c         | 1 +
 3 files changed, 4 insertions(+)

diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
index ba37e77e8af3..0129d76a4fa3 100644
--- a/drivers/char/tpm/tpm_atmel.h
+++ b/drivers/char/tpm/tpm_atmel.h
@@ -26,6 +26,8 @@ struct tpm_atmel_priv {
 
 #ifdef CONFIG_PPC64
 
+#include <linux/of.h>
+
 #include <asm/prom.h>
 
 #define atmel_getb(priv, offset) readb(priv->iobase + offset)
diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
index 5c5be9fc1b15..208b1fe1d247 100644
--- a/drivers/perf/alibaba_uncore_drw_pmu.c
+++ b/drivers/perf/alibaba_uncore_drw_pmu.c
@@ -28,6 +28,7 @@
 #include <linux/printk.h>
 #include <linux/rculist.h>
 #include <linux/refcount.h>
+#include <linux/mod_devicetable.h>
 
 
 #define ALI_DRW_PMU_COMMON_MAX_COUNTERS			16
diff --git a/drivers/perf/arm_dmc620_pmu.c b/drivers/perf/arm_dmc620_pmu.c
index 5de06f9a4dd3..3a006b34b515 100644
--- a/drivers/perf/arm_dmc620_pmu.c
+++ b/drivers/perf/arm_dmc620_pmu.c
@@ -27,6 +27,7 @@
 #include <linux/printk.h>
 #include <linux/rculist.h>
 #include <linux/refcount.h>
+#include <linux/mod_devicetable.h>
 
 #define DMC620_PA_SHIFT					12
 #define DMC620_CNT_INIT					0x80000000
-- 
2.39.2



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2023-04-03 10:18 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 10:18 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-08  3:42 linux-next: build failure after merge of the pm tree Stephen Rothwell
2024-01-24  0:51 Stephen Rothwell
2024-01-24 15:56 ` Wysocki, Rafael J
2023-12-18 23:37 Stephen Rothwell
2023-11-21  2:46 Stephen Rothwell
2023-07-14  1:00 Stephen Rothwell
2023-07-14 18:19 ` Wysocki, Rafael J
2023-07-14 18:50   ` Rafael J. Wysocki
2023-04-03  1:25 Stephen Rothwell
2023-04-03  1:16 Stephen Rothwell
2023-04-03  1:06 Stephen Rothwell
2022-06-29  0:23 Stephen Rothwell
2022-06-29 13:01 ` Rafael J. Wysocki
2022-04-28  1:00 Stephen Rothwell
2022-04-28  3:07 ` Zhang Rui
2022-04-28  8:53 ` Zhang Rui
2022-04-28  8:56 ` Zhang Rui
2022-04-28 12:32   ` Rafael J. Wysocki
2022-01-04  0:15 Stephen Rothwell
2022-01-04  7:29 ` Heiner Kallweit
2022-01-04  8:02   ` Stephen Rothwell
2022-01-04 14:43     ` Heiner Kallweit
2022-01-04 14:57       ` Rafael J. Wysocki
2021-12-01 23:28 Stephen Rothwell
2021-12-02 10:04 ` Daniel Lezcano
2021-12-03 16:50   ` Rafael J. Wysocki
2021-12-03 17:22     ` Daniel Lezcano
2021-02-05  0:51 Stephen Rothwell
     [not found] ` <CAHp75VfiyAtxg+wqZ30kSzCfFFsLndLjzrUc1njZG0x6vQeyBQ@mail.gmail.com>
2021-02-05 11:15   ` Andy Shevchenko
2021-02-08 19:30     ` Rafael J. Wysocki
2021-02-08 19:47       ` Andy Shevchenko
2021-02-08 19:48         ` Andy Shevchenko
2021-02-09 14:32           ` Rafael J. Wysocki
2021-02-09 16:04             ` Andy Shevchenko
2020-12-09  9:57 Stephen Rothwell
2020-03-17  7:52 Stephen Rothwell
2020-03-18 11:44 ` Stephen Rothwell
2020-03-18 11:52   ` Colin Ian King
2020-03-18 12:18     ` Stephen Rothwell
2020-03-19  5:42       ` Stephen Rothwell
2020-03-19  9:32         ` Rafael J. Wysocki
2019-07-31  5:34 Stephen Rothwell
2019-07-31 10:27 ` Rafael J. Wysocki
2019-07-15  0:02 Stephen Rothwell
2019-07-15  9:44 ` Rafael J. Wysocki
2019-07-04  9:41 Stephen Rothwell
2019-07-04  9:48 ` Viresh Kumar
2019-07-04 10:33   ` Rafael J. Wysocki
2019-07-01  3:37 Stephen Rothwell
2019-07-01  7:48 ` Viresh Kumar
2018-05-24 14:16 Mark Brown
2018-05-24 14:16 ` Mark Brown
2016-09-14  4:27 Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
2016-07-22  1:56 Stephen Rothwell
2016-07-22  2:26 ` Steve Muckle
2016-07-22 12:08   ` Rafael J. Wysocki
2016-07-22 12:16     ` Fengguang Wu
2016-07-11  1:46 Stephen Rothwell
2016-07-11  4:48 ` Mika Westerberg
2016-07-11  5:29   ` Stephen Rothwell
2016-07-11 12:57     ` Rafael J. Wysocki
2016-06-02  2:12 Stephen Rothwell
2016-04-01  1:27 Stephen Rothwell
2016-04-01 20:51 ` Rafael J. Wysocki
2015-12-09  1:54 Stephen Rothwell
2015-12-09  2:00 ` Viresh Kumar
2015-11-01  6:57 Stephen Rothwell
2015-11-01  6:57 ` Stephen Rothwell
2015-11-01  6:57 ` Stephen Rothwell
2015-11-02  0:37 ` Rafael J. Wysocki
2015-11-02  0:37   ` Rafael J. Wysocki
2015-04-13  4:24 Stephen Rothwell
2015-04-13  4:24 ` Stephen Rothwell
2015-04-13 12:06 ` Rafael J. Wysocki
2015-04-13 12:06   ` Rafael J. Wysocki
2015-04-15  2:30 ` Stephen Rothwell
2015-04-15  2:30   ` Stephen Rothwell
2015-02-09  2:26 Stephen Rothwell
2015-02-09  2:53 ` Jiang Liu
2015-02-09  3:22   ` Rafael J. Wysocki
2015-02-09  5:36     ` Jiang Liu
2015-02-09  6:23       ` Lorenzo Pieralisi
2015-02-09 15:10         ` Rafael J. Wysocki
2015-02-09 15:21           ` Jiang Liu
2015-02-09 15:50             ` Lorenzo Pieralisi
2015-02-09  3:19 ` Rafael J. Wysocki
2015-02-09  3:53   ` Lorenzo Pieralisi
2014-08-11  1:57 Stephen Rothwell
2014-08-12  1:10 ` Rafael J. Wysocki
2013-12-18  1:00 Stephen Rothwell
2013-12-18  1:17 ` Rafael J. Wysocki
2013-07-05  1:24 Stephen Rothwell
2013-07-05  1:37 ` Rafael J. Wysocki
2013-03-03 23:58 Stephen Rothwell
2013-03-04 11:54 ` Rafael J. Wysocki
2013-01-30  8:48 Stephen Rothwell
2013-01-30 12:50 ` Rafael J. Wysocki
2013-01-14  0:03 Stephen Rothwell
2013-01-14 12:37 ` Rafael J. Wysocki
2013-01-14 13:22 ` Sedat Dilek
2013-01-14 18:54   ` Rafael J. Wysocki
2012-11-28  4:02 Stephen Rothwell
2012-11-28  9:32 ` Rafael J. Wysocki
2012-11-26  6:09 Stephen Rothwell
2012-11-26 10:10 ` Rafael J. Wysocki
2012-09-25  4:30 Stephen Rothwell
2012-09-25 11:51 ` Rafael J. Wysocki
2012-06-20  5:01 Stephen Rothwell
2012-06-20 22:54 ` Rafael J. Wysocki
2012-01-27  1:53 Stephen Rothwell
2012-01-27  9:35 ` Rafael J. Wysocki
2011-11-10  2:31 Stephen Rothwell
2011-11-10 12:11 ` Rafael J. Wysocki
2011-11-10 15:48   ` Tejun Heo
2011-11-11 12:27 ` Rafael J. Wysocki
2011-09-28  4:51 Stephen Rothwell
2011-09-28  5:11 ` Ming Lei
2011-09-28 13:58   ` Rafael J. Wysocki
2011-09-28 14:47     ` Ming Lei
2011-09-28 19:32       ` Rafael J. Wysocki
2011-09-29  1:32         ` Ming Lei
2011-09-29  9:26           ` Rafael J. Wysocki
2011-09-29  9:32             ` Ming Lei
2011-09-29 20:25               ` Rafael J. Wysocki
2011-09-28 14:47     ` Rafael J. Wysocki
2011-08-19 13:47 Stephen Rothwell
2011-08-19 21:31 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230403201801.02839c9a@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.