From: Michal Hocko <mhocko@kernel.org> To: Janani Ravichandran <janani.rvchndrn@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, riel@surriel.com, akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov@virtuozzo.com, vbabka@suse.cz, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, bywxiaobai@163.com Subject: Re: [PATCH 1/3] Add a new field to struct shrinker Date: Mon, 11 Jul 2016 08:37:31 +0200 [thread overview] Message-ID: <20160711063730.GA5284@dhcp22.suse.cz> (raw) In-Reply-To: <85a9712f3853db5d9bc14810b287c23776235f01.1468051281.git.janani.rvchndrn@gmail.com> On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > Struct shrinker does not have a field to uniquely identify the shrinkers > it represents. It would be helpful to have a new field to hold names of > shrinkers. This information would be useful while analyzing their > behavior using tracepoints. This will however increase the vmlinux size even when no tracing is enabled. Why cannot we simply print the name of the shrinker callbacks? > > --- > include/linux/shrinker.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index 4fcacd9..431125c 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -52,6 +52,7 @@ struct shrinker { > unsigned long (*scan_objects)(struct shrinker *, > struct shrink_control *sc); > > + const char *name; > int seeks; /* seeks to recreate an obj */ > long batch; /* reclaim batch size, 0 = default */ > unsigned long flags; > -- > 2.7.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Janani Ravichandran <janani.rvchndrn@gmail.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, riel@surriel.com, akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov@virtuozzo.com, vbabka@suse.cz, mgorman@techsingularity.net, kirill.shutemov@linux.intel.com, bywxiaobai@163.com Subject: Re: [PATCH 1/3] Add a new field to struct shrinker Date: Mon, 11 Jul 2016 08:37:31 +0200 [thread overview] Message-ID: <20160711063730.GA5284@dhcp22.suse.cz> (raw) In-Reply-To: <85a9712f3853db5d9bc14810b287c23776235f01.1468051281.git.janani.rvchndrn@gmail.com> On Sat 09-07-16 04:43:31, Janani Ravichandran wrote: > Struct shrinker does not have a field to uniquely identify the shrinkers > it represents. It would be helpful to have a new field to hold names of > shrinkers. This information would be useful while analyzing their > behavior using tracepoints. This will however increase the vmlinux size even when no tracing is enabled. Why cannot we simply print the name of the shrinker callbacks? > > --- > include/linux/shrinker.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h > index 4fcacd9..431125c 100644 > --- a/include/linux/shrinker.h > +++ b/include/linux/shrinker.h > @@ -52,6 +52,7 @@ struct shrinker { > unsigned long (*scan_objects)(struct shrinker *, > struct shrink_control *sc); > > + const char *name; > int seeks; /* seeks to recreate an obj */ > long batch; /* reclaim batch size, 0 = default */ > unsigned long flags; > -- > 2.7.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-11 6:37 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-09 8:33 [PATCH 0/3] Add names of shrinkers and have tracepoints display them Janani Ravichandran 2016-07-09 8:33 ` Janani Ravichandran 2016-07-09 8:43 ` [PATCH 1/3] Add a new field to struct shrinker Janani Ravichandran 2016-07-09 8:43 ` Janani Ravichandran 2016-07-11 6:37 ` Michal Hocko [this message] 2016-07-11 6:37 ` Michal Hocko 2016-07-11 14:12 ` Rik van Riel 2016-07-11 14:33 ` Michal Hocko 2016-07-11 14:33 ` Michal Hocko 2016-07-20 14:41 ` Janani Ravichandran 2016-07-20 14:41 ` Janani Ravichandran 2016-07-20 14:54 ` Michal Hocko 2016-07-20 14:54 ` Michal Hocko 2016-07-23 1:27 ` Tony Jones 2016-07-23 1:27 ` Tony Jones 2016-07-23 4:05 ` Tony Jones 2016-07-23 4:05 ` Tony Jones 2016-07-23 19:43 ` Rik van Riel 2016-07-23 23:21 ` Tony Jones 2016-07-23 23:21 ` Tony Jones 2016-07-26 16:40 ` Tony Jones 2016-07-26 16:40 ` Tony Jones 2016-07-28 5:49 ` Dave Chinner 2016-07-28 5:49 ` Dave Chinner 2016-07-28 10:25 ` Mel Gorman 2016-07-28 10:25 ` Mel Gorman 2016-07-29 0:13 ` Dave Chinner 2016-07-29 0:13 ` Dave Chinner 2016-07-29 13:00 ` Mel Gorman 2016-07-29 13:00 ` Mel Gorman 2016-08-12 3:09 ` Tony Jones 2016-08-12 3:09 ` Tony Jones 2016-07-09 8:52 ` [PATCH 2/3] Update name field for all shrinker instances Janani Ravichandran 2016-07-09 8:52 ` Janani Ravichandran 2016-07-13 0:43 ` Tony Jones 2016-07-13 0:43 ` Tony Jones 2016-07-09 9:05 ` [PATCH 3/3] Add name fields in shrinker tracepoint definitions Janani Ravichandran 2016-07-09 9:05 ` Janani Ravichandran 2016-07-09 9:45 ` kbuild test robot 2016-07-09 16:18 ` Janani Ravichandran 2016-07-11 14:18 ` Vlastimil Babka 2016-07-11 14:18 ` Vlastimil Babka 2016-07-13 0:35 ` Tony Jones 2016-07-13 0:35 ` Tony Jones 2016-07-13 6:16 ` Janani Ravichandran 2016-07-13 6:16 ` Janani Ravichandran 2016-07-13 19:12 ` Tony Jones 2016-07-13 19:12 ` Tony Jones 2016-07-13 19:48 ` Rik van Riel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160711063730.GA5284@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=bywxiaobai@163.com \ --cc=hannes@cmpxchg.org \ --cc=janani.rvchndrn@gmail.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=riel@surriel.com \ --cc=vbabka@suse.cz \ --cc=vdavydov@virtuozzo.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.