* [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init()
@ 2016-07-12 11:21 weiyj_lk
2016-07-12 18:08 ` David Miller
2016-07-14 14:19 ` David Howells
0 siblings, 2 replies; 3+ messages in thread
From: weiyj_lk @ 2016-07-12 11:21 UTC (permalink / raw)
To: David Howells, David S. Miller; +Cc: Wei Yongjun, linux-afs, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
security initialized after alloc workqueue, so we should exit security
before destroy workqueue in the error handing.
Fixes: 648af7fca159 ("rxrpc: Absorb the rxkad security module")
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
net/rxrpc/af_rxrpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
index d6e4e3b..88effad 100644
--- a/net/rxrpc/af_rxrpc.c
+++ b/net/rxrpc/af_rxrpc.c
@@ -766,9 +766,9 @@ error_key_type:
error_sock:
proto_unregister(&rxrpc_proto);
error_proto:
- destroy_workqueue(rxrpc_workqueue);
-error_security:
rxrpc_exit_security();
+error_security:
+ destroy_workqueue(rxrpc_workqueue);
error_work_queue:
kmem_cache_destroy(rxrpc_call_jar);
error_call_jar:
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init()
2016-07-12 11:21 [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init() weiyj_lk
@ 2016-07-12 18:08 ` David Miller
2016-07-14 14:19 ` David Howells
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-07-12 18:08 UTC (permalink / raw)
To: weiyj_lk; +Cc: dhowells, yongjun_wei, linux-afs, netdev
From: weiyj_lk@163.com
Date: Tue, 12 Jul 2016 11:21:17 +0000
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> security initialized after alloc workqueue, so we should exit security
> before destroy workqueue in the error handing.
>
> Fixes: 648af7fca159 ("rxrpc: Absorb the rxkad security module")
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init()
2016-07-12 11:21 [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init() weiyj_lk
2016-07-12 18:08 ` David Miller
@ 2016-07-14 14:19 ` David Howells
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2016-07-14 14:19 UTC (permalink / raw)
To: David Miller; +Cc: dhowells, weiyj_lk, netdev, yongjun_wei, linux-afs
David Miller <davem@davemloft.net> wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > security initialized after alloc workqueue, so we should exit security
> > before destroy workqueue in the error handing.
> >
> > Fixes: 648af7fca159 ("rxrpc: Absorb the rxkad security module")
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Applied.
Thanks.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-14 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-12 11:21 [PATCH -next] rxrpc: Fix error handling in af_rxrpc_init() weiyj_lk
2016-07-12 18:08 ` David Miller
2016-07-14 14:19 ` David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.