From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v22 8/8] Documentation: dt: chosen properties for arm64 kdump Date: Tue, 12 Jul 2016 11:07:45 +0100 [thread overview] Message-ID: <20160712100745.GA21909@leverpostej> (raw) In-Reply-To: <20160712050514.22307-9-takahiro.akashi@linaro.org> Hi, Apologies for the delay on this. On Tue, Jul 12, 2016 at 02:05:14PM +0900, AKASHI Takahiro wrote: > From: James Morse <james.morse@arm.com> > > Add documentation for > linux,crashkernel-base and crashkernel-size, > linux,usable-memory-range, and > linux,elfcorehdr > used by arm64 kexec/kdump to decribe the kdump reserved area, and > the elfcorehdr's location within it. > > Signed-off-by: James Morse <james.morse@arm.com> > [takahiro.akashi at linaro.org: > renamed "usable-memory" to "usable-memory-range", > added "linux,crashkernel-base" and "-size" ] > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- > Documentation/devicetree/bindings/chosen.txt | 45 ++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt > index 6ae9d82..d7a3a86 100644 > --- a/Documentation/devicetree/bindings/chosen.txt > +++ b/Documentation/devicetree/bindings/chosen.txt > @@ -52,3 +52,48 @@ This property is set (currently only on PowerPC, and only needed on > book3e) by some versions of kexec-tools to tell the new kernel that it > is being booted by kexec, as the booting environment may differ (e.g. > a different secondary CPU release mechanism) > + > +linux,crashkernel-base > +linux,crashkernel-size > +---------------------- > +These properties are set (on PowerPC and arm64) during kdump to tell > +use-space tools, like kexec-tools, the base address of the crash-dump > +kernel's reserved area of memory and the size. e.g. No need to mention what consumes this. Just state what it describes, e.g. These properties describe the base and size of the crash-dump kernel's reserved area of memory. Valid for PowerPC and arm64. > + > +/ { > + chosen { > + linux,crashkernel-base = <0x9 0xf0000000>; > + linux,crashkernel-size = <0x0 0x10000000>; > + }; > +}; > + > +linux,usable-memory-range > +------------------------- > + > +This property is set (currently only on arm64) during kdump to tell > +the crash-dump kernel the base address of its reserved area of memory, > +and the size. e.g. The description sounds like this duplicates linux,crashkernel-*. What is the difference between the two? On powerpc it looks like there's a linux,usable-memory property (without the -range suffix). How do these differ? > + > +/ { > + chosen { > + linux,usable-memory-range = <0x9 0xf0000000 0x0 0x10000000>; > + }; > +}; > + > +Please note that, if this property is present, any memory regions under > +"memory" nodes will be ignored. What exactly do you mean by "ignored"? Do we truly ignore this property, or do we map that memory at some point, even if not used for general allocation? > + > +linux,elfcorehdr > +---------------- > + > +This property is set (currently only on arm64) during kdump to tell > +the crash-dump kernel the address and size of the elfcorehdr that describes > +the old kernel's memory as an elf file. This memory must reside within > +the area described by 'linux,usable-memory-range'. e.g. As with the linux,crashkernel-* properties, just state what this describes, e.g. This property describes the base and size of the ELF core header, which describes the old kernel's memory as an ELF file. This memory must reside within the range described by linux,usable-memory-range. That said, this falling within usable-memory feels very odd, because it's not actually usable for general purposes. Why can the kernel not memremap this, such that it need not be in usable-memory? Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com> To: AKASHI Takahiro <takahiro.akashi@linaro.org> Cc: geoff@infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org, james.morse@arm.com, bauerman@linux.vnet.ibm.com, dyoung@redhat.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v22 8/8] Documentation: dt: chosen properties for arm64 kdump Date: Tue, 12 Jul 2016 11:07:45 +0100 [thread overview] Message-ID: <20160712100745.GA21909@leverpostej> (raw) In-Reply-To: <20160712050514.22307-9-takahiro.akashi@linaro.org> Hi, Apologies for the delay on this. On Tue, Jul 12, 2016 at 02:05:14PM +0900, AKASHI Takahiro wrote: > From: James Morse <james.morse@arm.com> > > Add documentation for > linux,crashkernel-base and crashkernel-size, > linux,usable-memory-range, and > linux,elfcorehdr > used by arm64 kexec/kdump to decribe the kdump reserved area, and > the elfcorehdr's location within it. > > Signed-off-by: James Morse <james.morse@arm.com> > [takahiro.akashi@linaro.org: > renamed "usable-memory" to "usable-memory-range", > added "linux,crashkernel-base" and "-size" ] > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- > Documentation/devicetree/bindings/chosen.txt | 45 ++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt > index 6ae9d82..d7a3a86 100644 > --- a/Documentation/devicetree/bindings/chosen.txt > +++ b/Documentation/devicetree/bindings/chosen.txt > @@ -52,3 +52,48 @@ This property is set (currently only on PowerPC, and only needed on > book3e) by some versions of kexec-tools to tell the new kernel that it > is being booted by kexec, as the booting environment may differ (e.g. > a different secondary CPU release mechanism) > + > +linux,crashkernel-base > +linux,crashkernel-size > +---------------------- > +These properties are set (on PowerPC and arm64) during kdump to tell > +use-space tools, like kexec-tools, the base address of the crash-dump > +kernel's reserved area of memory and the size. e.g. No need to mention what consumes this. Just state what it describes, e.g. These properties describe the base and size of the crash-dump kernel's reserved area of memory. Valid for PowerPC and arm64. > + > +/ { > + chosen { > + linux,crashkernel-base = <0x9 0xf0000000>; > + linux,crashkernel-size = <0x0 0x10000000>; > + }; > +}; > + > +linux,usable-memory-range > +------------------------- > + > +This property is set (currently only on arm64) during kdump to tell > +the crash-dump kernel the base address of its reserved area of memory, > +and the size. e.g. The description sounds like this duplicates linux,crashkernel-*. What is the difference between the two? On powerpc it looks like there's a linux,usable-memory property (without the -range suffix). How do these differ? > + > +/ { > + chosen { > + linux,usable-memory-range = <0x9 0xf0000000 0x0 0x10000000>; > + }; > +}; > + > +Please note that, if this property is present, any memory regions under > +"memory" nodes will be ignored. What exactly do you mean by "ignored"? Do we truly ignore this property, or do we map that memory at some point, even if not used for general allocation? > + > +linux,elfcorehdr > +---------------- > + > +This property is set (currently only on arm64) during kdump to tell > +the crash-dump kernel the address and size of the elfcorehdr that describes > +the old kernel's memory as an elf file. This memory must reside within > +the area described by 'linux,usable-memory-range'. e.g. As with the linux,crashkernel-* properties, just state what this describes, e.g. This property describes the base and size of the ELF core header, which describes the old kernel's memory as an ELF file. This memory must reside within the range described by linux,usable-memory-range. That said, this falling within usable-memory feels very odd, because it's not actually usable for general purposes. Why can the kernel not memremap this, such that it need not be in usable-memory? Thanks, Mark. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-07-12 10:07 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-12 5:05 [PATCH v22 0/8] arm64: add kdump support AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 1/8] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-13 9:12 ` Suzuki K Poulose 2016-07-13 9:12 ` Suzuki K Poulose 2016-07-13 15:42 ` AKASHI Takahiro 2016-07-13 15:42 ` AKASHI Takahiro 2016-07-19 9:39 ` Dennis Chen 2016-07-19 9:39 ` Dennis Chen 2016-07-19 10:28 ` AKASHI Takahiro 2016-07-19 10:28 ` AKASHI Takahiro 2016-07-19 10:41 ` Dennis Chen 2016-07-19 10:41 ` Dennis Chen 2016-07-19 12:48 ` Mark Salter 2016-07-19 12:48 ` Mark Salter 2016-07-19 13:27 ` Mark Rutland 2016-07-19 13:27 ` Mark Rutland 2016-07-20 2:17 ` AKASHI Takahiro 2016-07-20 2:17 ` AKASHI Takahiro 2016-07-20 3:48 ` Dennis Chen 2016-07-20 3:48 ` Dennis Chen 2016-07-19 23:34 ` AKASHI Takahiro 2016-07-19 23:34 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 2/8] arm64: limit memory regions based on DT property, usable-memory-range AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-18 18:04 ` James Morse 2016-07-18 18:04 ` James Morse 2016-07-19 8:35 ` AKASHI Takahiro 2016-07-19 8:35 ` AKASHI Takahiro 2016-07-19 10:06 ` Dennis Chen 2016-07-19 10:06 ` Dennis Chen 2016-07-19 11:01 ` AKASHI Takahiro 2016-07-19 11:01 ` AKASHI Takahiro 2016-07-20 3:39 ` Dennis Chen 2016-07-20 3:39 ` Dennis Chen 2016-07-20 4:22 ` AKASHI Takahiro 2016-07-20 4:22 ` AKASHI Takahiro 2016-07-20 4:36 ` Dennis Chen 2016-07-20 4:36 ` Dennis Chen 2016-07-21 0:57 ` AKASHI Takahiro 2016-07-21 0:57 ` AKASHI Takahiro 2016-07-22 13:55 ` James Morse 2016-07-22 13:55 ` James Morse 2016-07-25 5:27 ` AKASHI Takahiro 2016-07-25 5:27 ` AKASHI Takahiro 2016-08-04 6:21 ` AKASHI Takahiro 2016-08-04 6:21 ` AKASHI Takahiro 2016-08-09 16:22 ` James Morse 2016-08-09 16:22 ` James Morse 2016-07-12 5:05 ` [PATCH v22 3/8] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-13 9:32 ` Suzuki K Poulose 2016-07-13 9:32 ` Suzuki K Poulose 2016-07-13 16:00 ` AKASHI Takahiro 2016-07-13 16:00 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 4/8] arm64: kdump: add kdump support AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 5/8] arm64: kdump: add VMCOREINFO's for user-space coredump tools AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 6/8] arm64: kdump: enable kdump in the arm64 defconfig AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 7/8] arm64: kdump: update a kernel doc AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-12 5:05 ` [PATCH v22 8/8] Documentation: dt: chosen properties for arm64 kdump AKASHI Takahiro 2016-07-12 5:05 ` AKASHI Takahiro 2016-07-12 10:07 ` Mark Rutland [this message] 2016-07-12 10:07 ` Mark Rutland 2016-07-13 15:14 ` AKASHI Takahiro 2016-07-13 15:14 ` AKASHI Takahiro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160712100745.GA21909@leverpostej \ --to=mark.rutland@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.