* [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>
@ 2016-07-12 0:57 Christoph Hellwig
2016-07-13 15:13 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2016-07-12 0:57 UTC (permalink / raw)
To: ananth, anil.s.keshavamurthy, davem, mhiramat; +Cc: linux-kernel
asm-generic headers are generic implementations for architecture specific
code and should not be included by common code. Thus use the asm/ version
of sections.h to get at the linker sections.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
kernel/kprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index d10ab6b..d630954 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -49,7 +49,7 @@
#include <linux/cpu.h>
#include <linux/jump_label.h>
-#include <asm-generic/sections.h>
+#include <asm/sections.h>
#include <asm/cacheflush.h>
#include <asm/errno.h>
#include <asm/uaccess.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>
2016-07-12 0:57 [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h> Christoph Hellwig
@ 2016-07-13 15:13 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2016-07-13 15:13 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: ananth, anil.s.keshavamurthy, davem, linux-kernel
On Tue, 12 Jul 2016 09:57:36 +0900
Christoph Hellwig <hch@lst.de> wrote:
> asm-generic headers are generic implementations for architecture specific
> code and should not be included by common code. Thus use the asm/ version
> of sections.h to get at the linker sections.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me. Thanks Christoph!
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index d10ab6b..d630954 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -49,7 +49,7 @@
> #include <linux/cpu.h>
> #include <linux/jump_label.h>
>
> -#include <asm-generic/sections.h>
> +#include <asm/sections.h>
> #include <asm/cacheflush.h>
> #include <asm/errno.h>
> #include <asm/uaccess.h>
> --
> 2.1.4
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>
@ 2016-09-11 13:58 Christoph Hellwig
2016-09-12 10:46 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2016-09-11 13:58 UTC (permalink / raw)
To: mhiramat, akpm; +Cc: linux-kernel
asm-generic headers are generic implementations for architecture specific
code and should not be included by common code. Thus use the asm/ version
of sections.h to get at the linker sections.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
kernel/kprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index d10ab6b..d630954 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -49,7 +49,7 @@
#include <linux/cpu.h>
#include <linux/jump_label.h>
-#include <asm-generic/sections.h>
+#include <asm/sections.h>
#include <asm/cacheflush.h>
#include <asm/errno.h>
#include <asm/uaccess.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>
2016-09-11 13:58 Christoph Hellwig
@ 2016-09-12 10:46 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2016-09-12 10:46 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, linux-kernel
On Sun, 11 Sep 2016 15:58:22 +0200
Christoph Hellwig <hch@lst.de> wrote:
> asm-generic headers are generic implementations for architecture specific
> code and should not be included by common code. Thus use the asm/ version
> of sections.h to get at the linker sections.
>
OK, I see.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index d10ab6b..d630954 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -49,7 +49,7 @@
> #include <linux/cpu.h>
> #include <linux/jump_label.h>
>
> -#include <asm-generic/sections.h>
> +#include <asm/sections.h>
> #include <asm/cacheflush.h>
> #include <asm/errno.h>
> #include <asm/uaccess.h>
> --
> 2.1.4
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-12 10:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-12 0:57 [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h> Christoph Hellwig
2016-07-13 15:13 ` Masami Hiramatsu
2016-09-11 13:58 Christoph Hellwig
2016-09-12 10:46 ` Masami Hiramatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.