* [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
@ 2016-07-13 17:19 kbuild test robot
2016-07-13 17:43 ` Jason Baron
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2016-07-13 17:19 UTC (permalink / raw)
Cc: kbuild-all, linux-mm, Michal Hocko, Jason Baron, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 3575 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.6
head: 92b971babd4ca0b796a247752839f82b6f77a5e7
commit: 92b971babd4ca0b796a247752839f82b6f77a5e7 [827/827] jump_label: remove bug.h, atomic.h dependencies for HAVE_JUMP_LABEL
config: s390-default_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 92b971babd4ca0b796a247752839f82b6f77a5e7
# save the attached .config to linux build tree
make.cross ARCH=s390
All error/warnings (new ones prefixed by >>):
In file included from include/linux/compiler.h:60:0,
from include/uapi/linux/stddef.h:1,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/jump_label.h:77,
from arch/s390/lib/uaccess.c:10:
arch/s390/include/asm/jump_label.h: In function 'arch_static_branch':
>> arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
asm_volatile_goto("0: brcl 0,"__stringify(JUMP_LABEL_NOP_OFFSET)"\n"
^
include/linux/compiler-gcc.h:243:47: note: in definition of macro 'asm_volatile_goto'
#define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while (0)
^
In file included from include/linux/jump_label.h:105:0,
from arch/s390/lib/uaccess.c:10:
>> arch/s390/include/asm/jump_label.h:25:1: warning: label 'label' defined but not used [-Wunused-label]
label:
^
vim +17 arch/s390/include/asm/jump_label.h
d5caa4db Heiko Carstens 2015-01-29 11 /*
d5caa4db Heiko Carstens 2015-01-29 12 * We use a brcl 0,2 instruction for jump labels at compile time so it
d5caa4db Heiko Carstens 2015-01-29 13 * can be easily distinguished from a hotpatch generated instruction.
d5caa4db Heiko Carstens 2015-01-29 14 */
11276d53 Peter Zijlstra 2015-07-24 15 static __always_inline bool arch_static_branch(struct static_key *key, bool branch)
5373db88 Jan Glauber 2011-03-16 16 {
d5caa4db Heiko Carstens 2015-01-29 @17 asm_volatile_goto("0: brcl 0,"__stringify(JUMP_LABEL_NOP_OFFSET)"\n"
5373db88 Jan Glauber 2011-03-16 18 ".pushsection __jump_table, \"aw\"\n"
5a79859a Heiko Carstens 2015-02-12 19 ".balign 8\n"
5a79859a Heiko Carstens 2015-02-12 20 ".quad 0b, %l[label], %0\n"
5373db88 Jan Glauber 2011-03-16 21 ".popsection\n"
11276d53 Peter Zijlstra 2015-07-24 22 : : "X" (&((char *)key)[branch]) : : label);
11276d53 Peter Zijlstra 2015-07-24 23
11276d53 Peter Zijlstra 2015-07-24 24 return false;
11276d53 Peter Zijlstra 2015-07-24 @25 label:
11276d53 Peter Zijlstra 2015-07-24 26 return true;
11276d53 Peter Zijlstra 2015-07-24 27 }
11276d53 Peter Zijlstra 2015-07-24 28
:::::: The code at line 17 was first introduced by commit
:::::: d5caa4dbf9bd2ad8cd7f6be0ca76722be947182b s390/jump label: use different nop instruction
:::::: TO: Heiko Carstens <heiko.carstens@de.ibm.com>
:::::: CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 16172 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
2016-07-13 17:19 [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify' kbuild test robot
@ 2016-07-13 17:43 ` Jason Baron
2016-07-13 18:05 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Jason Baron @ 2016-07-13 17:43 UTC (permalink / raw)
To: kbuild test robot, Andrew Morton; +Cc: kbuild-all, linux-mm, Michal Hocko
Hi,
This is likely due to the fact that the s390 bits
bits were not pulled into -mm here:
http://lkml.iu.edu/hypermail/linux/kernel/1607.0/03114.html
However, I do see them in linux-next, I think from
the s390 tree. So perhaps, that patch can be pulled
in here as well?
Thanks,
-Jason
On 07/13/2016 01:19 PM, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.6
> head: 92b971babd4ca0b796a247752839f82b6f77a5e7
> commit: 92b971babd4ca0b796a247752839f82b6f77a5e7 [827/827] jump_label: remove bug.h, atomic.h dependencies for HAVE_JUMP_LABEL
> config: s390-default_defconfig (attached as .config)
> compiler: s390x-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 92b971babd4ca0b796a247752839f82b6f77a5e7
> # save the attached .config to linux build tree
> make.cross ARCH=s390
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/linux/compiler.h:60:0,
> from include/uapi/linux/stddef.h:1,
> from include/linux/stddef.h:4,
> from include/uapi/linux/posix_types.h:4,
> from include/uapi/linux/types.h:13,
> from include/linux/types.h:5,
> from include/linux/jump_label.h:77,
> from arch/s390/lib/uaccess.c:10:
> arch/s390/include/asm/jump_label.h: In function 'arch_static_branch':
>>> arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
> asm_volatile_goto("0: brcl 0,"__stringify(JUMP_LABEL_NOP_OFFSET)"\n"
> ^
> include/linux/compiler-gcc.h:243:47: note: in definition of macro 'asm_volatile_goto'
> #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while (0)
> ^
> In file included from include/linux/jump_label.h:105:0,
> from arch/s390/lib/uaccess.c:10:
>>> arch/s390/include/asm/jump_label.h:25:1: warning: label 'label' defined but not used [-Wunused-label]
> label:
> ^
>
> vim +17 arch/s390/include/asm/jump_label.h
>
> d5caa4db Heiko Carstens 2015-01-29 11 /*
> d5caa4db Heiko Carstens 2015-01-29 12 * We use a brcl 0,2 instruction for jump labels at compile time so it
> d5caa4db Heiko Carstens 2015-01-29 13 * can be easily distinguished from a hotpatch generated instruction.
> d5caa4db Heiko Carstens 2015-01-29 14 */
> 11276d53 Peter Zijlstra 2015-07-24 15 static __always_inline bool arch_static_branch(struct static_key *key, bool branch)
> 5373db88 Jan Glauber 2011-03-16 16 {
> d5caa4db Heiko Carstens 2015-01-29 @17 asm_volatile_goto("0: brcl 0,"__stringify(JUMP_LABEL_NOP_OFFSET)"\n"
> 5373db88 Jan Glauber 2011-03-16 18 ".pushsection __jump_table, \"aw\"\n"
> 5a79859a Heiko Carstens 2015-02-12 19 ".balign 8\n"
> 5a79859a Heiko Carstens 2015-02-12 20 ".quad 0b, %l[label], %0\n"
> 5373db88 Jan Glauber 2011-03-16 21 ".popsection\n"
> 11276d53 Peter Zijlstra 2015-07-24 22 : : "X" (&((char *)key)[branch]) : : label);
> 11276d53 Peter Zijlstra 2015-07-24 23
> 11276d53 Peter Zijlstra 2015-07-24 24 return false;
> 11276d53 Peter Zijlstra 2015-07-24 @25 label:
> 11276d53 Peter Zijlstra 2015-07-24 26 return true;
> 11276d53 Peter Zijlstra 2015-07-24 27 }
> 11276d53 Peter Zijlstra 2015-07-24 28
>
> :::::: The code at line 17 was first introduced by commit
> :::::: d5caa4dbf9bd2ad8cd7f6be0ca76722be947182b s390/jump label: use different nop instruction
>
> :::::: TO: Heiko Carstens <heiko.carstens@de.ibm.com>
> :::::: CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
2016-07-13 17:43 ` Jason Baron
@ 2016-07-13 18:05 ` Andrew Morton
2016-07-13 18:16 ` Jason Baron
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2016-07-13 18:05 UTC (permalink / raw)
To: Jason Baron; +Cc: kbuild test robot, kbuild-all, linux-mm, Michal Hocko
On Wed, 13 Jul 2016 13:43:44 -0400 Jason Baron <jbaron@akamai.com> wrote:
> This is likely due to the fact that the s390 bits
> bits were not pulled into -mm here:
>
> http://lkml.iu.edu/hypermail/linux/kernel/1607.0/03114.html
>
> However, I do see them in linux-next, I think from
> the s390 tree. So perhaps, that patch can be pulled
> in here as well?
Yup, I have
jump_label-remove-bugh-atomich-dependencies-for-have_jump_label.patch
staged after linux-next and it has that dependency on linux-next.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
2016-07-13 18:05 ` Andrew Morton
@ 2016-07-13 18:16 ` Jason Baron
2016-07-14 7:19 ` Michal Hocko
0 siblings, 1 reply; 5+ messages in thread
From: Jason Baron @ 2016-07-13 18:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: kbuild test robot, kbuild-all, linux-mm, Michal Hocko
On 07/13/2016 02:05 PM, Andrew Morton wrote:
> On Wed, 13 Jul 2016 13:43:44 -0400 Jason Baron <jbaron@akamai.com> wrote:
>
>> This is likely due to the fact that the s390 bits
>> bits were not pulled into -mm here:
>>
>> http://lkml.iu.edu/hypermail/linux/kernel/1607.0/03114.html
>>
>> However, I do see them in linux-next, I think from
>> the s390 tree. So perhaps, that patch can be pulled
>> in here as well?
>
> Yup, I have
> jump_label-remove-bugh-atomich-dependencies-for-have_jump_label.patch
> staged after linux-next and it has that dependency on linux-next.
>
ok, you have the dependency correct, thanks.
That dependency though is not being honored in the referenced
mm tree branch 'since-4.6', since the relevant s390 patch
is not present. So, if we want to fix it here, we need
that patch...
Thanks,
-Jason
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify'
2016-07-13 18:16 ` Jason Baron
@ 2016-07-14 7:19 ` Michal Hocko
0 siblings, 0 replies; 5+ messages in thread
From: Michal Hocko @ 2016-07-14 7:19 UTC (permalink / raw)
To: Jason Baron; +Cc: Andrew Morton, kbuild test robot, kbuild-all, linux-mm
On Wed 13-07-16 14:16:11, Jason Baron wrote:
> On 07/13/2016 02:05 PM, Andrew Morton wrote:
> > On Wed, 13 Jul 2016 13:43:44 -0400 Jason Baron <jbaron@akamai.com> wrote:
> >
> >> This is likely due to the fact that the s390 bits
> >> bits were not pulled into -mm here:
> >>
> >> http://lkml.iu.edu/hypermail/linux/kernel/1607.0/03114.html
> >>
> >> However, I do see them in linux-next, I think from
> >> the s390 tree. So perhaps, that patch can be pulled
> >> in here as well?
> >
> > Yup, I have
> > jump_label-remove-bugh-atomich-dependencies-for-have_jump_label.patch
> > staged after linux-next and it has that dependency on linux-next.
> >
>
> ok, you have the dependency correct, thanks.
>
> That dependency though is not being honored in the referenced
> mm tree branch 'since-4.6', since the relevant s390 patch
> is not present. So, if we want to fix it here, we need
> that patch...
My fault. I haven't noticed this patch. I usually apply everything that
is in appropriate sections of series file and then fix up compilation
issues. I didn't do my allarch build test the last time due to lack of
time so I haven't noticed this. Sorry about that!
That being said, I have cherry-picked the s390 part.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-14 7:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-13 17:19 [memcg:since-4.6 827/827] arch/s390/include/asm/jump_label.h:17:32: error: expected ':' before '__stringify' kbuild test robot
2016-07-13 17:43 ` Jason Baron
2016-07-13 18:05 ` Andrew Morton
2016-07-13 18:16 ` Jason Baron
2016-07-14 7:19 ` Michal Hocko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.