All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amir.jer.levy@intel.com
Cc: andreas.noever@gmail.com, gregkh@linuxfoundation.org,
	bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	thunderbolt-linux@intel.com, mika.westerberg@intel.com,
	tomas.winkler@intel.com
Subject: Re: [PATCH v3 2/8] thunderbolt: Updating device IDs
Date: Fri, 15 Jul 2016 11:49:02 -0700 (PDT)	[thread overview]
Message-ID: <20160715.114902.1149848183971707484.davem@davemloft.net> (raw)
In-Reply-To: <1468495702-7467-3-git-send-email-amir.jer.levy@intel.com>

From: Amir Levy <amir.jer.levy@intel.com>
Date: Thu, 14 Jul 2016 14:28:16 +0300

> Adding the new Thunderbolt(TM) device IDs to the list.
> 
> Signed-off-by: Amir Levy <amir.jer.levy@intel.com>

Unless these PCI-IDs, all of them, are going to be used in multiple
spots in the kernel, it is not appropriate to add them here.

They belong as private macros in the drivers themselves, instead.

  reply	other threads:[~2016-07-15 18:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 11:28 [PATCH v3 0/8] thunderbolt: Introducing Thunderbolt(TM) networking Amir Levy
2016-07-14 11:28 ` [PATCH v3 1/8] thunderbolt: Macro rename Amir Levy
2016-07-14 11:28 ` [PATCH v3 2/8] thunderbolt: Updating device IDs Amir Levy
2016-07-15 18:49   ` David Miller [this message]
2016-07-15 18:56     ` Levy, Amir (Jer)
2016-07-15 21:53       ` David Miller
2016-07-18  9:54         ` Levy, Amir (Jer)
2016-07-14 11:28 ` [PATCH v3 3/8] thunderbolt: Updating the register definitions Amir Levy
2016-07-14 11:28 ` [PATCH v3 4/8] thunderbolt: Kconfig for Thunderbolt(TM) networking Amir Levy
2016-07-14 11:28 ` [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware) Amir Levy
2016-07-14 12:44   ` Winkler, Tomas
2016-07-14 14:49     ` Levy, Amir (Jer)
2016-07-16  8:43       ` Winkler, Tomas
2016-07-14 15:08     ` Rosen, Rami
2016-07-14 18:34       ` Levy, Amir (Jer)
2016-07-14 18:59         ` Rosen, Rami
2016-07-14 11:28 ` [PATCH v3 6/8] thunderbolt: Networking state machine Amir Levy
2016-07-15  0:25   ` Paul Gortmaker
2016-07-15  0:25     ` Paul Gortmaker
2016-07-17  7:04     ` Levy, Amir (Jer)
2016-07-17  7:04       ` Levy, Amir (Jer)
2016-07-14 11:28 ` [PATCH v3 7/8] thunderbolt: Networking transmit and receive Amir Levy
2016-07-14 11:28 ` [PATCH v3 8/8] thunderbolt: Networking doc Amir Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160715.114902.1149848183971707484.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amir.jer.levy@intel.com \
    --cc=andreas.noever@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=thunderbolt-linux@intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.