From: Wolfram Sang <wsa@the-dreams.de>
To: Abhishek Sahu <absahu@codeaurora.org>
Cc: agross@codeaurora.org, sricharan@codeaurora.org,
architt@codeaurora.org, linux-arm-msm@vger.kernel.org,
ntelkar@codeaurora.org, linux-kernel@vger.kernel.org,
andy.gross@linaro.org, linux-i2c@vger.kernel.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] i2c: qup: Fixed the DMA segments length
Date: Fri, 15 Jul 2016 15:38:07 +0900 [thread overview]
Message-ID: <20160715063806.GC7675@tetsubishi> (raw)
In-Reply-To: <1462797871-8595-3-git-send-email-absahu@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Mon, May 09, 2016 at 06:14:31PM +0530, Abhishek Sahu wrote:
> 1. The current QCOM I2C driver code is failing for transfer length
> greater than 255. This is happening due to improper segments length
> as the I2C DMA segments can be maximum of 256 bytes.
>
> 2. The transfer length tlen was being initialized with 0 for 256
> bytes, which is being passed for DMA mappings resulting in improper
> DMA mapping length.
>
> This patch fixes the above said problems by initializing the block
> count with the values calculated in qup_i2c_set_blk_data and calculating
> the remaining length for last DMA segment. Also, the block data length
> need to be decremented after each transfer. Additionally, this patch
> corrects the tlen assignment for DMA mapping.
>
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i2c: qup: Fixed the DMA segments length
Date: Fri, 15 Jul 2016 15:38:07 +0900 [thread overview]
Message-ID: <20160715063806.GC7675@tetsubishi> (raw)
In-Reply-To: <1462797871-8595-3-git-send-email-absahu@codeaurora.org>
On Mon, May 09, 2016 at 06:14:31PM +0530, Abhishek Sahu wrote:
> 1. The current QCOM I2C driver code is failing for transfer length
> greater than 255. This is happening due to improper segments length
> as the I2C DMA segments can be maximum of 256 bytes.
>
> 2. The transfer length tlen was being initialized with 0 for 256
> bytes, which is being passed for DMA mappings resulting in improper
> DMA mapping length.
>
> This patch fixes the above said problems by initializing the block
> count with the values calculated in qup_i2c_set_blk_data and calculating
> the remaining length for last DMA segment. Also, the block data length
> need to be decremented after each transfer. Additionally, this patch
> corrects the tlen assignment for DMA mapping.
>
> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160715/563cf6af/attachment.sig>
next prev parent reply other threads:[~2016-07-15 6:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 12:44 [PATCH 0/2] i2c: qup: Fixed the DMA transfer errors Abhishek Sahu
2016-05-09 12:44 ` Abhishek Sahu
2016-05-09 12:44 ` Abhishek Sahu
2016-05-09 12:44 ` [PATCH 1/2] i2c: qup: Cleared the error bits in ISR Abhishek Sahu
2016-05-09 12:44 ` Abhishek Sahu
2016-05-11 15:57 ` Sricharan
2016-05-11 15:57 ` Sricharan
2016-05-11 15:57 ` Sricharan
2016-05-11 17:34 ` Abhishek Sahu
2016-05-11 17:34 ` Abhishek Sahu
2016-05-12 2:28 ` Sricharan
2016-05-12 2:28 ` Sricharan
2016-05-12 2:28 ` Sricharan
2016-05-12 5:13 ` Andy Gross
2016-05-12 5:13 ` Andy Gross
2016-05-12 6:18 ` Abhishek Sahu
2016-05-12 6:18 ` Abhishek Sahu
2016-05-12 17:58 ` Andy Gross
2016-05-12 17:58 ` Andy Gross
2016-05-12 19:32 ` Abhishek Sahu
2016-05-12 19:32 ` Abhishek Sahu
2016-05-12 20:05 ` Andy Gross
2016-05-12 20:05 ` Andy Gross
2016-05-12 20:27 ` Abhishek Sahu
2016-05-12 20:27 ` Abhishek Sahu
2016-06-18 16:32 ` Wolfram Sang
2016-06-18 16:32 ` Wolfram Sang
2016-06-20 12:48 ` Abhishek Sahu
2016-06-20 12:48 ` Abhishek Sahu
2016-07-15 6:33 ` Wolfram Sang
2016-07-15 6:33 ` Wolfram Sang
2016-05-09 12:44 ` [PATCH 2/2] i2c: qup: Fixed the DMA segments length Abhishek Sahu
2016-05-09 12:44 ` Abhishek Sahu
2016-05-11 16:18 ` Sricharan
2016-05-11 16:18 ` Sricharan
2016-05-11 16:18 ` Sricharan
2016-05-11 17:43 ` Abhishek Sahu
2016-05-11 17:43 ` Abhishek Sahu
2016-07-15 6:38 ` Wolfram Sang [this message]
2016-07-15 6:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715063806.GC7675@tetsubishi \
--to=wsa@the-dreams.de \
--cc=absahu@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntelkar@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.