* Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)
[not found] <E1bNvA3-0006oU-Ex@optimist>
@ 2016-07-15 7:42 ` Arnd Bergmann
2016-07-15 12:08 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-07-15 7:42 UTC (permalink / raw)
To: linaro-kernel
Cc: Build bot for Mark Brown, kernel-build-reports, linux-rt-users,
linux-kernel
On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:
>
> arm64-allnoconfig
> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>
> arm64-allmodconfig
> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>
> arm-multi_v7_defconfig
> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>
> arm-allmodconfig
> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>
> arm-allnoconfig
> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>
> arm64-defconfig
> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
These all started failing yesterday with v3.14.72-rt76, before it was
v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)
2016-07-15 7:42 ` v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Arnd Bergmann
@ 2016-07-15 12:08 ` Sebastian Andrzej Siewior
2016-07-15 15:33 ` Steven Rostedt
2016-07-15 18:34 ` Steven Rostedt
0 siblings, 2 replies; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-07-15 12:08 UTC (permalink / raw)
To: Arnd Bergmann, Steven Rostedt
Cc: linaro-kernel, Build bot for Mark Brown, kernel-build-reports,
linux-rt-users, linux-kernel
+ Steven
* Arnd Bergmann | 2016-07-15 09:42:40 [+0200]:
>On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:
>>
>> arm64-allnoconfig
>> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>>
>> arm64-allmodconfig
>> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>>
>> arm-multi_v7_defconfig
>> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>>
>> arm-allmodconfig
>> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>>
>> arm-allnoconfig
>> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>>
>> arm64-defconfig
>> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
>
>These all started failing yesterday with v3.14.72-rt76, before it was
>
> v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
>
> Arnd
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)
2016-07-15 12:08 ` Sebastian Andrzej Siewior
@ 2016-07-15 15:33 ` Steven Rostedt
2016-07-15 18:34 ` Steven Rostedt
1 sibling, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2016-07-15 15:33 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Arnd Bergmann, linaro-kernel, Build bot for Mark Brown,
kernel-build-reports, linux-rt-users, linux-kernel
On Fri, 15 Jul 2016 14:08:37 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> + Steven
>
> * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]:
>
> >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:
> >>
> >> arm64-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm64-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-multi_v7_defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm64-defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >
> >These all started failing yesterday with v3.14.72-rt76, before it was
> >
> > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
> >
Bah, thanks for the report. I hope I have time before to fix this
today, otherwise, I'll need to do it when I get back from my travels.
-- Steve
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)
2016-07-15 12:08 ` Sebastian Andrzej Siewior
2016-07-15 15:33 ` Steven Rostedt
@ 2016-07-15 18:34 ` Steven Rostedt
2016-07-15 20:58 ` Arnd Bergmann
1 sibling, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2016-07-15 18:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sebastian Andrzej Siewior, linaro-kernel,
Build bot for Mark Brown, kernel-build-reports, linux-rt-users,
linux-kernel
On Fri, 15 Jul 2016 14:08:37 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> + Steven
>
> * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]:
>
> >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:
> >>
> >> arm64-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm64-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-multi_v7_defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-allmodconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm-allnoconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >>
> >> arm64-defconfig
> >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> >
> >These all started failing yesterday with v3.14.72-rt76, before it was
> >
> > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
> >
> > Arnd
>
Arnd,
Does this fix the issue?
-- Steve
diff --git a/include/asm-generic/preempt.h b/include/asm-generic/preempt.h
index 65759d8b0b46..25c09df2c046 100644
--- a/include/asm-generic/preempt.h
+++ b/include/asm-generic/preempt.h
@@ -7,7 +7,7 @@
static __always_inline int preempt_count(void)
{
- return READ_ONCE(current_thread_info()->preempt_count);
+ return ACCESS_ONCE(current_thread_info()->preempt_count);
}
static __always_inline volatile int *preempt_count_ptr(void)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77)
2016-07-15 18:34 ` Steven Rostedt
@ 2016-07-15 20:58 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-07-15 20:58 UTC (permalink / raw)
To: Steven Rostedt
Cc: Sebastian Andrzej Siewior, linaro-kernel,
Build bot for Mark Brown, kernel-build-reports, linux-rt-users,
linux-kernel
On Friday, July 15, 2016 2:34:10 PM CEST Steven Rostedt wrote:
> > * Arnd Bergmann | 2016-07-15 09:42:40 [+0200]:
> >
> > >On Friday, July 15, 2016 5:55:39 AM CEST Build bot for Mark Brown wrote:
> > >>
> > >> arm64-allnoconfig
> > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> > >>
> > >> arm64-allmodconfig
> > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> > >>
> > >> arm-multi_v7_defconfig
> > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> > >>
> > >> arm-allmodconfig
> > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> > >>
> > >> arm-allnoconfig
> > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> > >>
> > >> arm64-defconfig
> > >> /home/broonie/build/linux-stable-rt/include/asm-generic/preempt.h:10:9: error: implicit declaration of function 'READ_ONCE' [-Werror=implicit-function-declaration]
> > >
> > >These all started failing yesterday with v3.14.72-rt76, before it was
> > >
> > > v3.14.72-rt75 build: 0 failures 113 warnings (v3.14.72-rt75)
> > >
> > > Arnd
> >
>
> Arnd,
>
> Does this fix the issue?
>
>From looking at it I'm fairly sure it addresses the build problem,
and semantically it looks correct as well, but I haven't had a
chance to test it on my machine yet.
The build results above come from Mark Brown's automated build setup,
so your testing is as good as mine in reproducing it.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-15 20:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1bNvA3-0006oU-Ex@optimist>
2016-07-15 7:42 ` v3.14.73-rt77 build: 6 failures 10 warnings (v3.14.73-rt77) Arnd Bergmann
2016-07-15 12:08 ` Sebastian Andrzej Siewior
2016-07-15 15:33 ` Steven Rostedt
2016-07-15 18:34 ` Steven Rostedt
2016-07-15 20:58 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.