From: Mark Brown <broonie@kernel.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: "coupled" regulator support
Date: Fri, 15 Jul 2016 13:50:39 +0100 [thread overview]
Message-ID: <20160715125039.GI30372@sirena.org.uk> (raw)
In-Reply-To: <20160715200113.0f3cd823@xhacker>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
On Fri, Jul 15, 2016 at 08:01:13PM +0800, Jisheng Zhang wrote:
> regR can only be set to v1 if devA and devB all call for set voltage to v1
> regR can set to v2 if devA or devB call for set voltage to v2
> To support this situation, I'd like to add flag to regulator structure and
> patch regulator_check_consumers() to check whether we are safe to set the vol
Surely this is just what normal set voltage calls do? If devA says
set_voltage(v1, v2) but devB still has set_voltage(v2, v2) then we will
leave the voltage at v2, we'll only allow it to be set to v1 if both
consumers agree that this is a valid voltage. It feels like there's
something else going on here that I'm missing?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: "coupled" regulator support
Date: Fri, 15 Jul 2016 13:50:39 +0100 [thread overview]
Message-ID: <20160715125039.GI30372@sirena.org.uk> (raw)
In-Reply-To: <20160715200113.0f3cd823@xhacker>
On Fri, Jul 15, 2016 at 08:01:13PM +0800, Jisheng Zhang wrote:
> regR can only be set to v1 if devA and devB all call for set voltage to v1
> regR can set to v2 if devA or devB call for set voltage to v2
> To support this situation, I'd like to add flag to regulator structure and
> patch regulator_check_consumers() to check whether we are safe to set the vol
Surely this is just what normal set voltage calls do? If devA says
set_voltage(v1, v2) but devB still has set_voltage(v2, v2) then we will
leave the voltage at v2, we'll only allow it to be set to v1 if both
consumers agree that this is a valid voltage. It feels like there's
something else going on here that I'm missing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160715/43fa8c09/attachment.sig>
next prev parent reply other threads:[~2016-07-15 12:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 12:01 "coupled" regulator support Jisheng Zhang
2016-07-15 12:01 ` Jisheng Zhang
2016-07-15 12:50 ` Mark Brown [this message]
2016-07-15 12:50 ` Mark Brown
2016-07-18 6:44 ` Jisheng Zhang
2016-07-18 6:44 ` Jisheng Zhang
2016-07-18 18:05 ` Mark Brown
2016-07-18 18:05 ` Mark Brown
2016-07-21 10:45 ` Jisheng Zhang
2016-07-21 10:45 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715125039.GI30372@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jszhang@marvell.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.