* [patch] [IA64] fix SN_DMA_ADDRTYPE() condition
@ 2016-07-15 21:12 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-07-15 21:12 UTC (permalink / raw)
To: Tony Luck, Mark Maule
Cc: Fenghua Yu, linux-ia64, linux-kernel, kernel-janitors
The parentheses are in the wrong place so it causes a static checker
warning. It means we don't mask away the high bits of dma_flags before
doing the comparison.
Fixes: 83821d3f558d ('[PATCH] PCI: altix: msi support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/ia64/sn/pci/pcibr/pcibr_dma.c b/arch/ia64/sn/pci/pcibr/pcibr_dma.c
index 1e863b2..71c9bf3 100644
--- a/arch/ia64/sn/pci/pcibr/pcibr_dma.c
+++ b/arch/ia64/sn/pci/pcibr/pcibr_dma.c
@@ -82,7 +82,7 @@ pcibr_dmamap_ate32(struct pcidev_info *info,
if (IS_PCIX(pcibus_info))
ate_flags &= ~(PCI32_ATE_PREF);
- if (SN_DMA_ADDRTYPE(dma_flags == SN_DMA_ADDR_PHYS))
+ if (SN_DMA_ADDRTYPE(dma_flags) == SN_DMA_ADDR_PHYS)
xio_addr = IS_PIC_SOFT(pcibus_info) ? PHYS_TO_DMA(paddr) :
PHYS_TO_TIODMA(paddr);
else
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] [IA64] fix SN_DMA_ADDRTYPE() condition
@ 2016-07-15 21:12 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-07-15 21:12 UTC (permalink / raw)
To: Tony Luck, Mark Maule
Cc: Fenghua Yu, linux-ia64, linux-kernel, kernel-janitors
The parentheses are in the wrong place so it causes a static checker
warning. It means we don't mask away the high bits of dma_flags before
doing the comparison.
Fixes: 83821d3f558d ('[PATCH] PCI: altix: msi support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/ia64/sn/pci/pcibr/pcibr_dma.c b/arch/ia64/sn/pci/pcibr/pcibr_dma.c
index 1e863b2..71c9bf3 100644
--- a/arch/ia64/sn/pci/pcibr/pcibr_dma.c
+++ b/arch/ia64/sn/pci/pcibr/pcibr_dma.c
@@ -82,7 +82,7 @@ pcibr_dmamap_ate32(struct pcidev_info *info,
if (IS_PCIX(pcibus_info))
ate_flags &= ~(PCI32_ATE_PREF);
- if (SN_DMA_ADDRTYPE(dma_flags = SN_DMA_ADDR_PHYS))
+ if (SN_DMA_ADDRTYPE(dma_flags) = SN_DMA_ADDR_PHYS)
xio_addr = IS_PIC_SOFT(pcibus_info) ? PHYS_TO_DMA(paddr) :
PHYS_TO_TIODMA(paddr);
else
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-15 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 21:12 [patch] [IA64] fix SN_DMA_ADDRTYPE() condition Dan Carpenter
2016-07-15 21:12 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.