[PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Alison Schofield]

I2C_CLASS_HWMON is for a hardware monitoring chip wanting
auto-detection.  IIO drivers don't typically use .class. 
Remove it.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 drivers/staging/iio/light/isl29018.c | 1 -
 drivers/staging/iio/light/isl29028.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 80b6a9e..f47a17d 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -823,7 +823,6 @@ static const struct of_device_id isl29018_of_match[] = {
 MODULE_DEVICE_TABLE(of, isl29018_of_match);
 
 static struct i2c_driver isl29018_driver = {
-	.class	= I2C_CLASS_HWMON,
 	.driver	 = {
 			.name = "isl29018",
 			.acpi_match_table = ACPI_PTR(isl29018_acpi_match),
diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index a238b16..aa413e5 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -546,7 +546,6 @@ static const struct of_device_id isl29028_of_match[] = {
 MODULE_DEVICE_TABLE(of, isl29028_of_match);
 
 static struct i2c_driver isl29028_driver = {
-	.class	= I2C_CLASS_HWMON,
 	.driver  = {
 		.name = "isl29028",
 		.of_match_table = isl29028_of_match,
-- 
2.1.4

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Laxman Dewangan]

On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
> auto-detection.  IIO drivers don't typically use .class.
> Remove it.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>

Agree.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Jonathan Cameron]

On 18/07/16 09:50, Laxman Dewangan wrote:
> 
> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
>> auto-detection.  IIO drivers don't typically use .class.
>> Remove it.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>>
> 
> Agree.
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Any resulting ABI change from dropping it?
I don't think so, as it doesn't support detection anyway,
but best to be sure ;)

> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
> On 18/07/16 09:50, Laxman Dewangan wrote:
> > 
> > On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
> >> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
> >> auto-detection.  IIO drivers don't typically use .class.
> >> Remove it.
> >>
> >> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> >> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> >>
> > 
> > Agree.
> > Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> Any resulting ABI change from dropping it?

What do you mean with ABI? This is only relevant for "automatic"
instantiation. From me:

Acked-by: Wolfram Sang <wsa@the-dreams.de>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
> On 18/07/16 09:50, Laxman Dewangan wrote:
> > 
> > On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
> >> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
> >> auto-detection.  IIO drivers don't typically use .class.
> >> Remove it.
> >>
> >> Signed-off-by: Alison Schofield <amsfield22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> Cc: Daniel Baluta <daniel.baluta-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>
> > 
> > Agree.
> > Acked-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Any resulting ABI change from dropping it?

What do you mean with ABI? This is only relevant for "automatic"
instantiation. From me:

Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Jonathan Cameron]

On 19/07/16 08:13, Wolfram Sang wrote:
> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
>> On 18/07/16 09:50, Laxman Dewangan wrote:
>>>
>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
>>>> auto-detection.  IIO drivers don't typically use .class.
>>>> Remove it.
>>>>
>>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>>>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>>>>
>>>
>>> Agree.
>>> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Any resulting ABI change from dropping it?
> 
> What do you mean with ABI? This is only relevant for "automatic"
> instantiation.
Cool, I was just being paranoid and didn't have time to check!

Thanks,

Jonathan
> From me:
> 
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
> 

Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Jonathan Cameron]

On 20/07/16 16:08, Jonathan Cameron wrote:
> On 19/07/16 08:13, Wolfram Sang wrote:
>> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
>>> On 18/07/16 09:50, Laxman Dewangan wrote:
>>>>
>>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
>>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
>>>>> auto-detection.  IIO drivers don't typically use .class.
>>>>> Remove it.
>>>>>
>>>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>>>>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>>>>>
>>>>
>>>> Agree.
>>>> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>>> Any resulting ABI change from dropping it?
>>
>> What do you mean with ABI? This is only relevant for "automatic"
>> instantiation.
> Cool, I was just being paranoid and didn't have time to check!
> 
> Thanks,
> 
> Jonathan
>> From me:
>>
>> Acked-by: Wolfram Sang <wsa@the-dreams.de>
>>
>
Applied to the togreg branch of iio.git - initially pushed out
as testing for the autoubuilders to play with it.

thanks,

Jonathan
 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>