* [Buildroot] [PATCH] mtd: Add option to install mtd integrity test
@ 2016-07-14 21:03 Matt Weber
2016-07-16 9:53 ` Thomas Petazzoni
2016-07-17 16:48 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Matt Weber @ 2016-07-14 21:03 UTC (permalink / raw)
To: buildroot
From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>
Description:
The mtd tests have proven very useful in testing both flash stability
and JFFS2 changes. Adding an option to install the integrity test.
Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
package/mtd/Config.in | 3 +++
package/mtd/mtd.mk | 12 ++++++++++++
2 files changed, 15 insertions(+)
diff --git a/package/mtd/Config.in b/package/mtd/Config.in
index 6e4346f..780ba94 100644
--- a/package/mtd/Config.in
+++ b/package/mtd/Config.in
@@ -159,4 +159,7 @@ config BR2_PACKAGE_MTD_UBIBLOCK
bool "ubiblock"
default y
+config BR2_PACKAGE_MTD_TESTS
+ bool "mtd tests"
+
endif
diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
index bf90212..a4aabd7 100644
--- a/package/mtd/mtd.mk
+++ b/package/mtd/mtd.mk
@@ -97,6 +97,18 @@ MTD_TARGETS_UBI_$(BR2_PACKAGE_MTD_UBIBLOCK) += ubiblock
MTD_TARGETS_y += $(addprefix ubi-utils/,$(MTD_TARGETS_UBI_y))
MTD_TARGETS_$(BR2_PACKAGE_MTD_MKFSUBIFS) += mkfs.ubifs/mkfs.ubifs
+ifeq ($(BR2_PACKAGE_MTD_TESTS),y)
+define MTD_TESTS_BUILD_CMDS
+ $(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
+ BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D)/tests/fs-tests all
+endef
+MTD_POST_BUILD_HOOKS += MTD_TESTS_BUILD_CMDS
+define MTD_TESTS_TARGET_INSTALL_CMDS
+ $(INSTALL) -D -m 755 $(@D)/tests/fs-tests/integrity/integck $(TARGET_DIR)/usr/sbin/integck
+endef
+MTD_POST_INSTALL_TARGET_HOOKS += MTD_TESTS_TARGET_INSTALL_CMDS
+endif
+
define MTD_BUILD_CMDS
$(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D) \
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mtd: Add option to install mtd integrity test
2016-07-14 21:03 [Buildroot] [PATCH] mtd: Add option to install mtd integrity test Matt Weber
@ 2016-07-16 9:53 ` Thomas Petazzoni
2016-07-17 16:48 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-07-16 9:53 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 14 Jul 2016 16:03:47 -0500, Matt Weber wrote:
> From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>
This From...
>
> Description:
> The mtd tests have proven very useful in testing both flash stability
> and JFFS2 changes. Adding an option to install the integrity test.
>
> Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>
... didn't match this SoB line.
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> package/mtd/Config.in | 3 +++
> package/mtd/mtd.mk | 12 ++++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> index 6e4346f..780ba94 100644
> --- a/package/mtd/Config.in
> +++ b/package/mtd/Config.in
> @@ -159,4 +159,7 @@ config BR2_PACKAGE_MTD_UBIBLOCK
> bool "ubiblock"
> default y
>
> +config BR2_PACKAGE_MTD_TESTS
Renamed to BR2_PACKAGE_MTD_INTEGCK, since it installs only this tool.
> +ifeq ($(BR2_PACKAGE_MTD_TESTS),y)
> +define MTD_TESTS_BUILD_CMDS
> + $(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
> + BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D)/tests/fs-tests all
> +endef
> +MTD_POST_BUILD_HOOKS += MTD_TESTS_BUILD_CMDS
> +define MTD_TESTS_TARGET_INSTALL_CMDS
> + $(INSTALL) -D -m 755 $(@D)/tests/fs-tests/integrity/integck $(TARGET_DIR)/usr/sbin/integck
> +endef
> +MTD_POST_INSTALL_TARGET_HOOKS += MTD_TESTS_TARGET_INSTALL_CMDS
> +endif
Instead of hooks, I've used intermediate variables.
Also, integck was not building properly with uClibc or musl due to its
use of <execinfo.h>. I've added a patch to fix that, which I've
submitted upstream.
Applied with those changes, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mtd: Add option to install mtd integrity test
2016-07-14 21:03 [Buildroot] [PATCH] mtd: Add option to install mtd integrity test Matt Weber
2016-07-16 9:53 ` Thomas Petazzoni
@ 2016-07-17 16:48 ` Yann E. MORIN
2016-07-19 13:30 ` Matthew Weber
1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2016-07-17 16:48 UTC (permalink / raw)
To: buildroot
Matt, All,
On 2016-07-14 16:03 -0500, Matt Weber spake thusly:
> From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>
>
> Description:
> The mtd tests have proven very useful in testing both flash stability
> and JFFS2 changes. Adding an option to install the integrity test.
This is causing build failures with the musl C library, because it does
not provide stdio_lim.h:
http://autobuild.buildroot.org/results/252/2526598f561dc66ae02c53ec82f6a2a1395cdaf6/build-end.log
Instead, those defines are directly available in stdio.h for musl.
Care to have a look, please?
Regards,
Yann E. MORIN.
> Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
> package/mtd/Config.in | 3 +++
> package/mtd/mtd.mk | 12 ++++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
> index 6e4346f..780ba94 100644
> --- a/package/mtd/Config.in
> +++ b/package/mtd/Config.in
> @@ -159,4 +159,7 @@ config BR2_PACKAGE_MTD_UBIBLOCK
> bool "ubiblock"
> default y
>
> +config BR2_PACKAGE_MTD_TESTS
> + bool "mtd tests"
> +
> endif
> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> index bf90212..a4aabd7 100644
> --- a/package/mtd/mtd.mk
> +++ b/package/mtd/mtd.mk
> @@ -97,6 +97,18 @@ MTD_TARGETS_UBI_$(BR2_PACKAGE_MTD_UBIBLOCK) += ubiblock
> MTD_TARGETS_y += $(addprefix ubi-utils/,$(MTD_TARGETS_UBI_y))
> MTD_TARGETS_$(BR2_PACKAGE_MTD_MKFSUBIFS) += mkfs.ubifs/mkfs.ubifs
>
> +ifeq ($(BR2_PACKAGE_MTD_TESTS),y)
> +define MTD_TESTS_BUILD_CMDS
> + $(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
> + BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D)/tests/fs-tests all
> +endef
> +MTD_POST_BUILD_HOOKS += MTD_TESTS_BUILD_CMDS
> +define MTD_TESTS_TARGET_INSTALL_CMDS
> + $(INSTALL) -D -m 755 $(@D)/tests/fs-tests/integrity/integck $(TARGET_DIR)/usr/sbin/integck
> +endef
> +MTD_POST_INSTALL_TARGET_HOOKS += MTD_TESTS_TARGET_INSTALL_CMDS
> +endif
> +
> define MTD_BUILD_CMDS
> $(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
> BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D) \
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] mtd: Add option to install mtd integrity test
2016-07-17 16:48 ` Yann E. MORIN
@ 2016-07-19 13:30 ` Matthew Weber
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Weber @ 2016-07-19 13:30 UTC (permalink / raw)
To: buildroot
All,
On Sun, Jul 17, 2016 at 11:48 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Matt, All,
>
> On 2016-07-14 16:03 -0500, Matt Weber spake thusly:
>> From: ynadupur <yugendra.sai.babu.nadupuru@rockwellcollins.com>
>>
>> Description:
>> The mtd tests have proven very useful in testing both flash stability
>> and JFFS2 changes. Adding an option to install the integrity test.
>
> This is causing build failures with the musl C library, because it does
> not provide stdio_lim.h:
>
> http://autobuild.buildroot.org/results/252/2526598f561dc66ae02c53ec82f6a2a1395cdaf6/build-end.log
>
> Instead, those defines are directly available in stdio.h for musl.
>
> Care to have a look, please?
Sure, Sai is taking a look and he might jump on IRC to get some
guidance for how to make it compatible across libs.
>
> Regards,
> Yann E. MORIN.
>
>> Signed-off-by:[YUGENDRA SAI BABU NADUPURU]<yugendra.sai.babu.nadupuru@rockwellcollins.com>
>> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
>> ---
>> package/mtd/Config.in | 3 +++
>> package/mtd/mtd.mk | 12 ++++++++++++
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/package/mtd/Config.in b/package/mtd/Config.in
>> index 6e4346f..780ba94 100644
>> --- a/package/mtd/Config.in
>> +++ b/package/mtd/Config.in
>> @@ -159,4 +159,7 @@ config BR2_PACKAGE_MTD_UBIBLOCK
>> bool "ubiblock"
>> default y
>>
>> +config BR2_PACKAGE_MTD_TESTS
>> + bool "mtd tests"
>> +
>> endif
>> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
>> index bf90212..a4aabd7 100644
>> --- a/package/mtd/mtd.mk
>> +++ b/package/mtd/mtd.mk
>> @@ -97,6 +97,18 @@ MTD_TARGETS_UBI_$(BR2_PACKAGE_MTD_UBIBLOCK) += ubiblock
>> MTD_TARGETS_y += $(addprefix ubi-utils/,$(MTD_TARGETS_UBI_y))
>> MTD_TARGETS_$(BR2_PACKAGE_MTD_MKFSUBIFS) += mkfs.ubifs/mkfs.ubifs
>>
>> +ifeq ($(BR2_PACKAGE_MTD_TESTS),y)
>> +define MTD_TESTS_BUILD_CMDS
>> + $(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
>> + BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D)/tests/fs-tests all
>> +endef
>> +MTD_POST_BUILD_HOOKS += MTD_TESTS_BUILD_CMDS
>> +define MTD_TESTS_TARGET_INSTALL_CMDS
>> + $(INSTALL) -D -m 755 $(@D)/tests/fs-tests/integrity/integck $(TARGET_DIR)/usr/sbin/integck
>> +endef
>> +MTD_POST_INSTALL_TARGET_HOOKS += MTD_TESTS_TARGET_INSTALL_CMDS
>> +endif
>> +
>> define MTD_BUILD_CMDS
>> $(TARGET_CONFIGURE_OPTS) $(MAKE1) CROSS=$(TARGET_CROSS) \
>> BUILDDIR=$(@D) $(MTD_MAKE_OPTS) -C $(@D) \
>> --
>> 1.9.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
--
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com
Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-19 13:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-14 21:03 [Buildroot] [PATCH] mtd: Add option to install mtd integrity test Matt Weber
2016-07-16 9:53 ` Thomas Petazzoni
2016-07-17 16:48 ` Yann E. MORIN
2016-07-19 13:30 ` Matthew Weber
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.