[Qemu-devel] [PATCH] AioContext: correct comments

[Qemu-devel] [PATCH] AioContext: correct comments

[Cao jin]

Correct comments of field notify_me

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
 include/block/aio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/block/aio.h b/include/block/aio.h
index 0922b69..f89a1df 100644
--- a/include/block/aio.h
+++ b/include/block/aio.h
@@ -71,7 +71,7 @@ struct AioContext {
      * event_notifier_set necessary.
      *
      * Bit 0 is reserved for GSource usage of the AioContext, and is 1
-     * between a call to aio_ctx_check and the next call to aio_ctx_dispatch.
+     * between a call to aio_ctx_prepare and the next call to aio_ctx_check.
      * Bits 1-31 simply count the number of active calls to aio_poll
      * that are in the prepare or poll phase.
      *
-- 
2.1.0

Re: [Qemu-devel] [Qemu-block] [PATCH] AioContext: correct comments

[Max Reitz]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On 15.07.2016 11:44, Cao jin wrote:
> Correct comments of field notify_me
> 
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  include/block/aio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/block/aio.h b/include/block/aio.h
> index 0922b69..f89a1df 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -71,7 +71,7 @@ struct AioContext {
>       * event_notifier_set necessary.
>       *
>       * Bit 0 is reserved for GSource usage of the AioContext, and is 1
> -     * between a call to aio_ctx_check and the next call to aio_ctx_dispatch.
> +     * between a call to aio_ctx_prepare and the next call to aio_ctx_check.
>       * Bits 1-31 simply count the number of active calls to aio_poll
>       * that are in the prepare or poll phase.
>       *

Reviewed-by: Max Reitz <mreitz@redhat.com>

CC-ing Stefan and Fam, since I think this file should actually be under
their maintainership (should we add it to MAINTAINERS?).

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]

Re: [Qemu-devel] [Qemu-block] [PATCH] AioContext: correct comments

[Fam Zheng]

On Fri, 07/15 14:57, Max Reitz wrote:
> On 15.07.2016 11:44, Cao jin wrote:
> > Correct comments of field notify_me
> > 
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Cc: Max Reitz <mreitz@redhat.com>
> > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> > ---
> >  include/block/aio.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/block/aio.h b/include/block/aio.h
> > index 0922b69..f89a1df 100644
> > --- a/include/block/aio.h
> > +++ b/include/block/aio.h
> > @@ -71,7 +71,7 @@ struct AioContext {
> >       * event_notifier_set necessary.
> >       *
> >       * Bit 0 is reserved for GSource usage of the AioContext, and is 1
> > -     * between a call to aio_ctx_check and the next call to aio_ctx_dispatch.
> > +     * between a call to aio_ctx_prepare and the next call to aio_ctx_check.
> >       * Bits 1-31 simply count the number of active calls to aio_poll
> >       * that are in the prepare or poll phase.
> >       *

Reviewed-by: Fam Zheng <famz@redhat.com>

> 
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> 
> CC-ing Stefan and Fam, since I think this file should actually be under
> their maintainership (should we add it to MAINTAINERS?).

Good idea, I'll send a patch for that. Thanks for bringing up.

Fam