* [PATCH] qqz: Add another hyperlink to black box in QQA @ 2016-07-17 5:50 Akira Yokosawa 2016-07-17 21:59 ` Paul E. McKenney 0 siblings, 1 reply; 13+ messages in thread From: Akira Yokosawa @ 2016-07-17 5:50 UTC (permalink / raw) To: Paul E. McKenney; +Cc: perfbook, Akira Yokosawa From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 From: Akira Yokosawa <akiyks@gmail.com> Date: Tue, 12 Jul 2016 20:28:08 +0900 Subject: [PATCH] qqz: Add another hyperlink to black box in QQA This commit adds another cross-link to the black boxes in QQA. I think this change would meet readers' expectation. Signed-off-by: Akira Yokosawa <akiyks@gmail.com> --- qqz.sty | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qqz.sty b/qqz.sty index 12dc85e..0c97df9 100644 --- a/qqz.sty +++ b/qqz.sty @@ -78,7 +78,8 @@ \noindent \QuickQHeading{QQA}{QQ}{\QuickQuizAnswerChapter.\thequickquizctrC} #1 ~ \\ } -\newcommand{\QuickA}[1]{\rule{7pt}{7pt} +\newcommand{\QuickA}[1]{% + \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\rule{7pt}{7pt}} \par\vspace{0.8\baselineskip} \noindent\textbf{Answer:} \\ } -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Add another hyperlink to black box in QQA 2016-07-17 5:50 [PATCH] qqz: Add another hyperlink to black box in QQA Akira Yokosawa @ 2016-07-17 21:59 ` Paul E. McKenney 2016-07-17 22:54 ` Akira Yokosawa 0 siblings, 1 reply; 13+ messages in thread From: Paul E. McKenney @ 2016-07-17 21:59 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Sun, Jul 17, 2016 at 02:50:04PM +0900, Akira Yokosawa wrote: > From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa <akiyks@gmail.com> > Date: Tue, 12 Jul 2016 20:28:08 +0900 > Subject: [PATCH] qqz: Add another hyperlink to black box in QQA > > This commit adds another cross-link to the black boxes in QQA. > I think this change would meet readers' expectation. > > Signed-off-by: Akira Yokosawa <akiyks@gmail.com> I agree! For reasons that are not clear to me, I had to hand-apply this patch. Might have been a white-space issue, which I did not think to check for... Please take a look at the patch below to make sure that I did it correctly. Also, this suggests a possibility: In the quick-quiz answer, suppose that the heading and the black box link (as they do now) to the beginning of the quick-quiz question, but that the white box links to the end (or just after the end) of the quick-quiz question. That way, the reader could choose the return point. Would that make sense? Thanx, Paul ------------------------------------------------------------------------ commit 8afdb9c1a55c7cf2300e6812cff58dd0fda4d585 Author: Akira Yokosawa <akiyks@gmail.com> Date: Sun Jul 17 14:54:03 2016 -0700 qqz: Add another hyperlink to black box in QQA This commit adds a hyperlink from the black box in the quick-quiz answer to the beginning of the corresponding quick-quiz question. Signed-off-by: Akira Yokosawa <akiyks@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> diff --git a/qqz.sty b/qqz.sty index 12dc85e30116..0c97df92cb50 100644 --- a/qqz.sty +++ b/qqz.sty @@ -78,7 +78,8 @@ \noindent \QuickQHeading{QQA}{QQ}{\QuickQuizAnswerChapter.\thequickquizctrC} #1 ~ \\ } -\newcommand{\QuickA}[1]{\rule{7pt}{7pt} +\newcommand{\QuickA}[1]{% + \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\rule{7pt}{7pt}} \par\vspace{0.8\baselineskip} \noindent\textbf{Answer:} \\ } ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Add another hyperlink to black box in QQA 2016-07-17 21:59 ` Paul E. McKenney @ 2016-07-17 22:54 ` Akira Yokosawa 2016-07-17 23:36 ` Paul E. McKenney 0 siblings, 1 reply; 13+ messages in thread From: Akira Yokosawa @ 2016-07-17 22:54 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa On 2016/07/17 14:59:00 -0700, Paul E. McKenney wrote: > On Sun, Jul 17, 2016 at 02:50:04PM +0900, Akira Yokosawa wrote: >> From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 >> From: Akira Yokosawa <akiyks@gmail.com> >> Date: Tue, 12 Jul 2016 20:28:08 +0900 >> Subject: [PATCH] qqz: Add another hyperlink to black box in QQA >> >> This commit adds another cross-link to the black boxes in QQA. >> I think this change would meet readers' expectation. >> >> Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > > I agree! For reasons that are not clear to me, I had to hand-apply > this patch. Might have been a white-space issue, which I did not > think to check for... > > Please take a look at the patch below to make sure that I did it > correctly. Yes, you did it right. I'm wondering what was wrong on my side. > > Also, this suggests a possibility: In the quick-quiz answer, suppose > that the heading and the black box link (as they do now) to the beginning > of the quick-quiz question, but that the white box links to the end > (or just after the end) of the quick-quiz question. That way, the > reader could choose the return point. > > Would that make sense? Well, yes if readers expect the behavior. But for long answers, there are cases where you can choose only the white boxes in your view. I'm hesitating because of your reaction to the first attempt the other day. Anyway, I'm going to submit a patch for you to try. Also we'd also need to update the explanation in the answer of Quick Quiz 1.3 if we actually do the change. > > Thanx, Paul > > ------------------------------------------------------------------------ > > commit 8afdb9c1a55c7cf2300e6812cff58dd0fda4d585 > Author: Akira Yokosawa <akiyks@gmail.com> > Date: Sun Jul 17 14:54:03 2016 -0700 > > qqz: Add another hyperlink to black box in QQA > > This commit adds a hyperlink from the black box in the quick-quiz > answer to the beginning of the corresponding quick-quiz question. > > Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > diff --git a/qqz.sty b/qqz.sty > index 12dc85e30116..0c97df92cb50 100644 > --- a/qqz.sty > +++ b/qqz.sty > @@ -78,7 +78,8 @@ > \noindent > \QuickQHeading{QQA}{QQ}{\QuickQuizAnswerChapter.\thequickquizctrC} #1 ~ \\ } > > -\newcommand{\QuickA}[1]{\rule{7pt}{7pt} > +\newcommand{\QuickA}[1]{% > + \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\rule{7pt}{7pt}} > \par\vspace{0.8\baselineskip} > \noindent\textbf{Answer:} \\ } > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Add another hyperlink to black box in QQA 2016-07-17 22:54 ` Akira Yokosawa @ 2016-07-17 23:36 ` Paul E. McKenney 2016-07-17 23:58 ` Akira Yokosawa 0 siblings, 1 reply; 13+ messages in thread From: Paul E. McKenney @ 2016-07-17 23:36 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Mon, Jul 18, 2016 at 07:54:27AM +0900, Akira Yokosawa wrote: > On 2016/07/17 14:59:00 -0700, Paul E. McKenney wrote: > >On Sun, Jul 17, 2016 at 02:50:04PM +0900, Akira Yokosawa wrote: > >>From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 > >>From: Akira Yokosawa <akiyks@gmail.com> > >>Date: Tue, 12 Jul 2016 20:28:08 +0900 > >>Subject: [PATCH] qqz: Add another hyperlink to black box in QQA > >> > >>This commit adds another cross-link to the black boxes in QQA. > >>I think this change would meet readers' expectation. > >> > >>Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > > > >I agree! For reasons that are not clear to me, I had to hand-apply > >this patch. Might have been a white-space issue, which I did not > >think to check for... > > > >Please take a look at the patch below to make sure that I did it > >correctly. > > Yes, you did it right. I'm wondering what was wrong on my side. My guess is whitespace. Or maybe the email got mangled along the way. > >Also, this suggests a possibility: In the quick-quiz answer, suppose > >that the heading and the black box link (as they do now) to the beginning > >of the quick-quiz question, but that the white box links to the end > >(or just after the end) of the quick-quiz question. That way, the > >reader could choose the return point. > > > >Would that make sense? > > Well, yes if readers expect the behavior. > But for long answers, there are cases where you can choose only the white > boxes in your view. I'm hesitating because of your reaction to the first > attempt the other day. All good points! > Anyway, I'm going to submit a patch for you to try. > > Also we'd also need to update the explanation in the answer of Quick Quiz 1.3 > if we actually do the change. Looking forward to it! Thanx, Paul > >------------------------------------------------------------------------ > > > >commit 8afdb9c1a55c7cf2300e6812cff58dd0fda4d585 > >Author: Akira Yokosawa <akiyks@gmail.com> > >Date: Sun Jul 17 14:54:03 2016 -0700 > > > > qqz: Add another hyperlink to black box in QQA > > > > This commit adds a hyperlink from the black box in the quick-quiz > > answer to the beginning of the corresponding quick-quiz question. > > > > Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > > >diff --git a/qqz.sty b/qqz.sty > >index 12dc85e30116..0c97df92cb50 100644 > >--- a/qqz.sty > >+++ b/qqz.sty > >@@ -78,7 +78,8 @@ > > \noindent > > \QuickQHeading{QQA}{QQ}{\QuickQuizAnswerChapter.\thequickquizctrC} #1 ~ \\ } > > > >-\newcommand{\QuickA}[1]{\rule{7pt}{7pt} > >+\newcommand{\QuickA}[1]{% > >+ \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\rule{7pt}{7pt}} > > \par\vspace{0.8\baselineskip} > > \noindent\textbf{Answer:} \\ } > > > > > > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Add another hyperlink to black box in QQA 2016-07-17 23:36 ` Paul E. McKenney @ 2016-07-17 23:58 ` Akira Yokosawa 2016-07-18 0:01 ` [PATCH] qqz: Modify back link target at end of QQA to the end of QQ Akira Yokosawa ` (2 more replies) 0 siblings, 3 replies; 13+ messages in thread From: Akira Yokosawa @ 2016-07-17 23:58 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa On 2016/07/18 8:36, Paul E. McKenney wrote: > On Mon, Jul 18, 2016 at 07:54:27AM +0900, Akira Yokosawa wrote: >> On 2016/07/17 14:59:00 -0700, Paul E. McKenney wrote: >>> On Sun, Jul 17, 2016 at 02:50:04PM +0900, Akira Yokosawa wrote: >>> >From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 >>>> From: Akira Yokosawa <akiyks@gmail.com> >>>> Date: Tue, 12 Jul 2016 20:28:08 +0900 >>>> Subject: [PATCH] qqz: Add another hyperlink to black box in QQA >>>> >>>> This commit adds another cross-link to the black boxes in QQA. >>>> I think this change would meet readers' expectation. >>>> >>>> Signed-off-by: Akira Yokosawa <akiyks@gmail.com> >>> >>> I agree! For reasons that are not clear to me, I had to hand-apply >>> this patch. Might have been a white-space issue, which I did not >>> think to check for... >>> >>> Please take a look at the patch below to make sure that I did it >>> correctly. >> >> Yes, you did it right. I'm wondering what was wrong on my side. > > My guess is whitespace. Or maybe the email got mangled along the way. > >>> Also, this suggests a possibility: In the quick-quiz answer, suppose >>> that the heading and the black box link (as they do now) to the beginning >>> of the quick-quiz question, but that the white box links to the end >>> (or just after the end) of the quick-quiz question. That way, the >>> reader could choose the return point. >>> >>> Would that make sense? >> >> Well, yes if readers expect the behavior. >> But for long answers, there are cases where you can choose only the white >> boxes in your view. I'm hesitating because of your reaction to the first >> attempt the other day. > > All good points! > >> Anyway, I'm going to submit a patch for you to try. >> >> Also we'd also need to update the explanation in the answer of Quick Quiz 1.3 >> if we actually do the change. > > Looking forward to it! So, I'm submitting 2 versions of patch in reply to this mail. 1st one makes "the white box link to the end the quick-quiz question." 2nd one makes "the white box link to just after the end of the quick-quiz question." Both of them are relative to current master. Please compare them and let me know which one you like. Or just apply the one you choose. Then I'll compose the additional explanation according to your choice. Thanks, Akira > Thanx, Paul > ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] qqz: Modify back link target at end of QQA to the end of QQ 2016-07-17 23:58 ` Akira Yokosawa @ 2016-07-18 0:01 ` Akira Yokosawa 2016-07-18 15:25 ` Paul E. McKenney 2016-07-18 0:04 ` [PATCH] qqz: Modify back link target at end of QQA to just after " Akira Yokosawa 2016-07-18 6:54 ` [PATCH] qqz: Add another hyperlink to black box in QQA Paul E. McKenney 2 siblings, 1 reply; 13+ messages in thread From: Akira Yokosawa @ 2016-07-18 0:01 UTC (permalink / raw) To: paulmck; +Cc: perfbook From e51d65d2b5e10dcf4bd4f5970010c0cded292f0e Mon Sep 17 00:00:00 2001 From: Akira Yokosawa <akiyks@gmail.com> Date: Mon, 18 Jul 2016 08:41:12 +0900 Subject: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ This commit modifies the target of back link at the end of QQA (white box) to the end of corresponding QQ in the main text. This change enables you to easily reach the text following a (possibly long) QQ by clicking a white box at the end of the QQA. Signed-off-by: Akira Yokosawa <akiyks@gmail.com> --- qqz.sty | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qqz.sty b/qqz.sty index 0c97df9..4505f8c 100644 --- a/qqz.sty +++ b/qqz.sty @@ -20,6 +20,7 @@ %% Akira Yokosawa <akiyks@gmail.com> # improvement of cross-link \newcounter{quickquizctr}[chapter] +\newcounter{quickquizctrE}[chapter] \newcounter{quickquizctrC}[section] \newcommand*{\theHNum}{\arabic{chapter}.\arabic{quickquizctr}} \newcommand{\QuickQuizAnswerChapter}{\textbf{Unknown QuickQAC!!!}} @@ -33,7 +34,10 @@ \newcommand{\QuickQuiz}[1]{ \refstepcounter{quickquizctr} \QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}} -\newcommand{\QuickQuizAnswer}[1]{\hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}} +\newcommand{\QuickQuizAnswer}[1]{% + \refstepcounter{quickquizctrE}% + \hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}% + \label{QQE.\thechapter.\thequickquizctrE}} \newcommand{\QuickQuizEnd}{} % To create a macro referencing the previously defined quick quiz: @@ -84,7 +88,7 @@ \noindent\textbf{Answer:} \\ } \newcommand{\QuickE}{% - \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} + \hyperref[QQE.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} \vspace{1.5\baselineskip} } -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ 2016-07-18 0:01 ` [PATCH] qqz: Modify back link target at end of QQA to the end of QQ Akira Yokosawa @ 2016-07-18 15:25 ` Paul E. McKenney 2016-07-18 21:48 ` Akira Yokosawa 0 siblings, 1 reply; 13+ messages in thread From: Paul E. McKenney @ 2016-07-18 15:25 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Mon, Jul 18, 2016 at 09:01:51AM +0900, Akira Yokosawa wrote: > From e51d65d2b5e10dcf4bd4f5970010c0cded292f0e Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa <akiyks@gmail.com> > Date: Mon, 18 Jul 2016 08:41:12 +0900 > Subject: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ > > This commit modifies the target of back link at the end of QQA > (white box) to the end of corresponding QQ in the main text. > This change enables you to easily reach the text following a > (possibly long) QQ by clicking a white box at the end of the QQA. > > Signed-off-by: Akira Yokosawa <akiyks@gmail.com> Hmmm... This also does not apply. Could you please apply it at your end from email and/or compare it to your original? I am beginning to suspect that the patch got corrupted in transit. Thnax, Paul > --- > qqz.sty | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/qqz.sty b/qqz.sty > index 0c97df9..4505f8c 100644 > --- a/qqz.sty > +++ b/qqz.sty > @@ -20,6 +20,7 @@ > %% Akira Yokosawa <akiyks@gmail.com> # improvement of cross-link > \newcounter{quickquizctr}[chapter] > +\newcounter{quickquizctrE}[chapter] > \newcounter{quickquizctrC}[section] > \newcommand*{\theHNum}{\arabic{chapter}.\arabic{quickquizctr}} > \newcommand{\QuickQuizAnswerChapter}{\textbf{Unknown QuickQAC!!!}} > @@ -33,7 +34,10 @@ > \newcommand{\QuickQuiz}[1]{ > \refstepcounter{quickquizctr} > \QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}} > -\newcommand{\QuickQuizAnswer}[1]{\hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}} > +\newcommand{\QuickQuizAnswer}[1]{% > + \refstepcounter{quickquizctrE}% > + \hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}% > + \label{QQE.\thechapter.\thequickquizctrE}} > \newcommand{\QuickQuizEnd}{} > % To create a macro referencing the previously defined quick quiz: > @@ -84,7 +88,7 @@ > \noindent\textbf{Answer:} \\ } > \newcommand{\QuickE}{% > - \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} > + \hyperref[QQE.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} > \vspace{1.5\baselineskip} > } > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ 2016-07-18 15:25 ` Paul E. McKenney @ 2016-07-18 21:48 ` Akira Yokosawa 2016-07-18 21:50 ` Akira Yokosawa 0 siblings, 1 reply; 13+ messages in thread From: Akira Yokosawa @ 2016-07-18 21:48 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa On 2016/07/19 0:25, Paul E. McKenney wrote: > On Mon, Jul 18, 2016 at 09:01:51AM +0900, Akira Yokosawa wrote: >> From e51d65d2b5e10dcf4bd4f5970010c0cded292f0e Mon Sep 17 00:00:00 2001 >> From: Akira Yokosawa <akiyks@gmail.com> >> Date: Mon, 18 Jul 2016 08:41:12 +0900 >> Subject: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ >> >> This commit modifies the target of back link at the end of QQA >> (white box) to the end of corresponding QQ in the main text. >> This change enables you to easily reach the text following a >> (possibly long) QQ by clicking a white box at the end of the QQA. >> >> Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > > Hmmm... This also does not apply. Could you please apply it at your > end from email and/or compare it to your original? I am beginning > to suspect that the patch got corrupted in transit. It turns out that the config setting of my Thunderbird was modified unknowingly. "mailnews.send_plaintext_flowed" should be "false," but it returned to its default "true." After I modified the setting, I tested sending the patch to myself and it applies. So I'm sending it to you and the list. Sorry to have bothered you. Thanks, Akira > > Thnax, Paul > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ 2016-07-18 21:48 ` Akira Yokosawa @ 2016-07-18 21:50 ` Akira Yokosawa 2016-07-18 22:42 ` Paul E. McKenney 0 siblings, 1 reply; 13+ messages in thread From: Akira Yokosawa @ 2016-07-18 21:50 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa From e51d65d2b5e10dcf4bd4f5970010c0cded292f0e Mon Sep 17 00:00:00 2001 From: Akira Yokosawa <akiyks@gmail.com> Date: Mon, 18 Jul 2016 08:41:12 +0900 Subject: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ This commit modifies the target of back link at the end of QQA (white box) to the end of corresponding QQ in the main text. This change enables you to easily reach the text following a (possibly long) QQ by clicking a white box at the end of the QQA. Signed-off-by: Akira Yokosawa <akiyks@gmail.com> --- qqz.sty | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qqz.sty b/qqz.sty index 0c97df9..4505f8c 100644 --- a/qqz.sty +++ b/qqz.sty @@ -20,6 +20,7 @@ %% Akira Yokosawa <akiyks@gmail.com> # improvement of cross-link \newcounter{quickquizctr}[chapter] +\newcounter{quickquizctrE}[chapter] \newcounter{quickquizctrC}[section] \newcommand*{\theHNum}{\arabic{chapter}.\arabic{quickquizctr}} \newcommand{\QuickQuizAnswerChapter}{\textbf{Unknown QuickQAC!!!}} @@ -33,7 +34,10 @@ \newcommand{\QuickQuiz}[1]{ \refstepcounter{quickquizctr} \QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}} -\newcommand{\QuickQuizAnswer}[1]{\hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}} +\newcommand{\QuickQuizAnswer}[1]{% + \refstepcounter{quickquizctrE}% + \hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}% + \label{QQE.\thechapter.\thequickquizctrE}} \newcommand{\QuickQuizEnd}{} % To create a macro referencing the previously defined quick quiz: @@ -84,7 +88,7 @@ \noindent\textbf{Answer:} \\ } \newcommand{\QuickE}{% - \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} + \hyperref[QQE.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} \vspace{1.5\baselineskip} } -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ 2016-07-18 21:50 ` Akira Yokosawa @ 2016-07-18 22:42 ` Paul E. McKenney 0 siblings, 0 replies; 13+ messages in thread From: Paul E. McKenney @ 2016-07-18 22:42 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Tue, Jul 19, 2016 at 06:50:07AM +0900, Akira Yokosawa wrote: > >From e51d65d2b5e10dcf4bd4f5970010c0cded292f0e Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa <akiyks@gmail.com> > Date: Mon, 18 Jul 2016 08:41:12 +0900 > Subject: [PATCH] qqz: Modify back link target at end of QQA to the end of QQ > > This commit modifies the target of back link at the end of QQA > (white box) to the end of corresponding QQ in the main text. > This change enables you to easily reach the text following a > (possibly long) QQ by clicking a white box at the end of the QQA. > > Signed-off-by: Akira Yokosawa <akiyks@gmail.com> Much better! Queued and pushed, thank you! Thanx, Paul > --- > qqz.sty | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/qqz.sty b/qqz.sty > index 0c97df9..4505f8c 100644 > --- a/qqz.sty > +++ b/qqz.sty > @@ -20,6 +20,7 @@ > %% Akira Yokosawa <akiyks@gmail.com> # improvement of cross-link > > \newcounter{quickquizctr}[chapter] > +\newcounter{quickquizctrE}[chapter] > \newcounter{quickquizctrC}[section] > \newcommand*{\theHNum}{\arabic{chapter}.\arabic{quickquizctr}} > \newcommand{\QuickQuizAnswerChapter}{\textbf{Unknown QuickQAC!!!}} > @@ -33,7 +34,10 @@ > \newcommand{\QuickQuiz}[1]{ > \refstepcounter{quickquizctr} > \QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}} > -\newcommand{\QuickQuizAnswer}[1]{\hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}} > +\newcommand{\QuickQuizAnswer}[1]{% > + \refstepcounter{quickquizctrE}% > + \hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}% > + \label{QQE.\thechapter.\thequickquizctrE}} > \newcommand{\QuickQuizEnd}{} > > % To create a macro referencing the previously defined quick quiz: > @@ -84,7 +88,7 @@ > \noindent\textbf{Answer:} \\ } > > \newcommand{\QuickE}{% > - \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} > + \hyperref[QQE.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} > \vspace{1.5\baselineskip} > } > > -- > 1.9.1 > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] qqz: Modify back link target at end of QQA to just after the end of QQ 2016-07-17 23:58 ` Akira Yokosawa 2016-07-18 0:01 ` [PATCH] qqz: Modify back link target at end of QQA to the end of QQ Akira Yokosawa @ 2016-07-18 0:04 ` Akira Yokosawa 2016-07-18 6:54 ` [PATCH] qqz: Add another hyperlink to black box in QQA Paul E. McKenney 2 siblings, 0 replies; 13+ messages in thread From: Akira Yokosawa @ 2016-07-18 0:04 UTC (permalink / raw) To: paulmck; +Cc: perfbook From 2441e281a03d846b9e326c02f21ba44754a3d1bc Mon Sep 17 00:00:00 2001 From: Akira Yokosawa <akiyks@gmail.com> Date: Mon, 18 Jul 2016 08:28:00 +0900 Subject: [PATCH] qqz: Modify back link target at end of QQA to just after the end of QQ This commit modifies the target of back link at the end of QQA (white box) to just after the end of corresponding QQ in the main text. This change enables you to easily reach the text following a (possibly long) QQ by clicking a white box at the end of the QQA. Signed-off-by: Akira Yokosawa <akiyks@gmail.com> --- qqz.sty | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qqz.sty b/qqz.sty index 0c97df9..6623d00 100644 --- a/qqz.sty +++ b/qqz.sty @@ -20,6 +20,7 @@ %% Akira Yokosawa <akiyks@gmail.com> # improvement of cross-link \newcounter{quickquizctr}[chapter] +\newcounter{quickquizctrE}[chapter] \newcounter{quickquizctrC}[section] \newcommand*{\theHNum}{\arabic{chapter}.\arabic{quickquizctr}} \newcommand{\QuickQuizAnswerChapter}{\textbf{Unknown QuickQAC!!!}} @@ -33,7 +34,11 @@ \newcommand{\QuickQuiz}[1]{ \refstepcounter{quickquizctr} \QuickQHeading{QQ}{QQA}{\thechapter.\thequickquizctr}} -\newcommand{\QuickQuizAnswer}[1]{\hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}}} +\newcommand{\QuickQuizAnswer}[1]{% + \hyperref[QQA.\thechapter.\thequickquizctr]{\rule{7pt}{7pt}} + + \refstepcounter{quickquizctrE}% + \label{QQE.\thechapter.\thequickquizctrE}} \newcommand{\QuickQuizEnd}{} % To create a macro referencing the previously defined quick quiz: @@ -84,7 +89,7 @@ \noindent\textbf{Answer:} \\ } \newcommand{\QuickE}{% - \hyperref[QQ.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} + \hyperref[QQE.\QuickQuizAnswerChapter.\thequickquizctrC]{\ding{113}} \vspace{1.5\baselineskip} } -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Add another hyperlink to black box in QQA 2016-07-17 23:58 ` Akira Yokosawa 2016-07-18 0:01 ` [PATCH] qqz: Modify back link target at end of QQA to the end of QQ Akira Yokosawa 2016-07-18 0:04 ` [PATCH] qqz: Modify back link target at end of QQA to just after " Akira Yokosawa @ 2016-07-18 6:54 ` Paul E. McKenney 2016-07-18 10:28 ` Akira Yokosawa 2 siblings, 1 reply; 13+ messages in thread From: Paul E. McKenney @ 2016-07-18 6:54 UTC (permalink / raw) To: Akira Yokosawa; +Cc: perfbook On Mon, Jul 18, 2016 at 08:58:59AM +0900, Akira Yokosawa wrote: > On 2016/07/18 8:36, Paul E. McKenney wrote: > >On Mon, Jul 18, 2016 at 07:54:27AM +0900, Akira Yokosawa wrote: > >>On 2016/07/17 14:59:00 -0700, Paul E. McKenney wrote: > >>>On Sun, Jul 17, 2016 at 02:50:04PM +0900, Akira Yokosawa wrote: > >>>>From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 > >>>>From: Akira Yokosawa <akiyks@gmail.com> > >>>>Date: Tue, 12 Jul 2016 20:28:08 +0900 > >>>>Subject: [PATCH] qqz: Add another hyperlink to black box in QQA > >>>> > >>>>This commit adds another cross-link to the black boxes in QQA. > >>>>I think this change would meet readers' expectation. > >>>> > >>>>Signed-off-by: Akira Yokosawa <akiyks@gmail.com> > >>> > >>>I agree! For reasons that are not clear to me, I had to hand-apply > >>>this patch. Might have been a white-space issue, which I did not > >>>think to check for... > >>> > >>>Please take a look at the patch below to make sure that I did it > >>>correctly. > >> > >>Yes, you did it right. I'm wondering what was wrong on my side. > > > >My guess is whitespace. Or maybe the email got mangled along the way. > > > >>>Also, this suggests a possibility: In the quick-quiz answer, suppose > >>>that the heading and the black box link (as they do now) to the beginning > >>>of the quick-quiz question, but that the white box links to the end > >>>(or just after the end) of the quick-quiz question. That way, the > >>>reader could choose the return point. > >>> > >>>Would that make sense? > >> > >>Well, yes if readers expect the behavior. > >>But for long answers, there are cases where you can choose only the white > >>boxes in your view. I'm hesitating because of your reaction to the first > >>attempt the other day. > > > >All good points! > > > >>Anyway, I'm going to submit a patch for you to try. > >> > >>Also we'd also need to update the explanation in the answer of Quick Quiz 1.3 > >>if we actually do the change. > > > >Looking forward to it! > > So, I'm submitting 2 versions of patch in reply to this mail. > 1st one makes "the white box link to the end the quick-quiz question." > 2nd one makes "the white box link to just after the end of the quick-quiz > question." > > Both of them are relative to current master. > Please compare them and let me know which one you like. > Or just apply the one you choose. > > Then I'll compose the additional explanation according to your choice. Before I do that -- which of the two do you prefer? Thanx, Paul ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] qqz: Add another hyperlink to black box in QQA 2016-07-18 6:54 ` [PATCH] qqz: Add another hyperlink to black box in QQA Paul E. McKenney @ 2016-07-18 10:28 ` Akira Yokosawa 0 siblings, 0 replies; 13+ messages in thread From: Akira Yokosawa @ 2016-07-18 10:28 UTC (permalink / raw) To: paulmck; +Cc: perfbook, Akira Yokosawa On 2016/07/17 23:54:14 -0700, Paul E. McKenney wrote: > On Mon, Jul 18, 2016 at 08:58:59AM +0900, Akira Yokosawa wrote: >> On 2016/07/18 8:36, Paul E. McKenney wrote: >>> On Mon, Jul 18, 2016 at 07:54:27AM +0900, Akira Yokosawa wrote: >>>> On 2016/07/17 14:59:00 -0700, Paul E. McKenney wrote: >>>>> On Sun, Jul 17, 2016 at 02:50:04PM +0900, Akira Yokosawa wrote: >>>>> >From 2a74b30f0a1d036e45c6aa5ef431034c23f790db Mon Sep 17 00:00:00 2001 >>>>>> From: Akira Yokosawa <akiyks@gmail.com> >>>>>> Date: Tue, 12 Jul 2016 20:28:08 +0900 >>>>>> Subject: [PATCH] qqz: Add another hyperlink to black box in QQA >>>>>> >>>>>> This commit adds another cross-link to the black boxes in QQA. >>>>>> I think this change would meet readers' expectation. >>>>>> >>>>>> Signed-off-by: Akira Yokosawa <akiyks@gmail.com> >>>>> >>>>> I agree! For reasons that are not clear to me, I had to hand-apply >>>>> this patch. Might have been a white-space issue, which I did not >>>>> think to check for... >>>>> >>>>> Please take a look at the patch below to make sure that I did it >>>>> correctly. >>>> >>>> Yes, you did it right. I'm wondering what was wrong on my side. >>> >>> My guess is whitespace. Or maybe the email got mangled along the way. >>> >>>>> Also, this suggests a possibility: In the quick-quiz answer, suppose >>>>> that the heading and the black box link (as they do now) to the beginning >>>>> of the quick-quiz question, but that the white box links to the end >>>>> (or just after the end) of the quick-quiz question. That way, the >>>>> reader could choose the return point. >>>>> >>>>> Would that make sense? >>>> >>>> Well, yes if readers expect the behavior. >>>> But for long answers, there are cases where you can choose only the white >>>> boxes in your view. I'm hesitating because of your reaction to the first >>>> attempt the other day. >>> >>> All good points! >>> >>>> Anyway, I'm going to submit a patch for you to try. >>>> >>>> Also we'd also need to update the explanation in the answer of Quick Quiz 1.3 >>>> if we actually do the change. >>> >>> Looking forward to it! >> >> So, I'm submitting 2 versions of patch in reply to this mail. >> 1st one makes "the white box link to the end the quick-quiz question." >> 2nd one makes "the white box link to just after the end of the quick-quiz >> question." >> >> Both of them are relative to current master. >> Please compare them and let me know which one you like. >> Or just apply the one you choose. >> >> Then I'll compose the additional explanation according to your choice. > > Before I do that -- which of the two do you prefer? The 1st one. Its behavior is identical to my first attempt. Clicking a white box will bring you to the black box of corresponding question, so you can see you are at the end of the question. 2nd one's white box will bring you to the beginning of the next paragraph of the question, so you might feel you've lost sense of where you are. As I'm trying it myself, especially in 2-column layout, 2nd one seems too aggressive. I should have tested more before submitting. So, please try the 1st one. And as I said before, it may take a while for you to get used to it. And it's okay with me if you decide to keep the behavior as it is. Thanks, Akira > > Thanx, Paul > > ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-07-18 22:42 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-07-17 5:50 [PATCH] qqz: Add another hyperlink to black box in QQA Akira Yokosawa 2016-07-17 21:59 ` Paul E. McKenney 2016-07-17 22:54 ` Akira Yokosawa 2016-07-17 23:36 ` Paul E. McKenney 2016-07-17 23:58 ` Akira Yokosawa 2016-07-18 0:01 ` [PATCH] qqz: Modify back link target at end of QQA to the end of QQ Akira Yokosawa 2016-07-18 15:25 ` Paul E. McKenney 2016-07-18 21:48 ` Akira Yokosawa 2016-07-18 21:50 ` Akira Yokosawa 2016-07-18 22:42 ` Paul E. McKenney 2016-07-18 0:04 ` [PATCH] qqz: Modify back link target at end of QQA to just after " Akira Yokosawa 2016-07-18 6:54 ` [PATCH] qqz: Add another hyperlink to black box in QQA Paul E. McKenney 2016-07-18 10:28 ` Akira Yokosawa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.