From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> To: Andrey Pronin <apronin@chromium.org> Cc: Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org Subject: Re: [PATCH 1/2] tpm: define constants for tpm2 properties Date: Mon, 18 Jul 2016 21:58:53 +0300 [thread overview] Message-ID: <20160718185853.GK31463@intel.com> (raw) In-Reply-To: <1468544838-9990-2-git-send-email-apronin@chromium.org> On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 > Signed-off-by: Andrey Pronin <apronin@chromium.org> I'm not going to apply this. The patch has no value. We only want to have a subset of constants that are *used* by the kernel. /Jarkko > --- > drivers/char/tpm/tpm.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index 8890df2..ad3b9d1 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -127,6 +127,32 @@ enum tpm2_capabilities { > TPM2_CAP_TPM_PROPERTIES = 6, > }; > > +enum tpm2_properties { > + TPM2_PT_NONE = 0, > + TPM2_PT_GROUP = 0x100, > + TPM2_PT_FIXED = TPM2_PT_GROUP, > + TPM2_PT_VAR = TPM2_PT_GROUP * 2, > + TPM2_PT_PERMANENT = TPM2_PT_VAR + 0, > + TPM2_PT_STARTUP_CLEAR = TPM2_PT_VAR + 1, > +}; > + > +enum tpm2_attr_permanent { > + TPM2_ATTR_OWNER_AUTH_SET = BIT(0), > + TPM2_ATTR_ENDORSEMENT_AUTH_SET = BIT(1), > + TPM2_ATTR_LOCKOUT_AUTH_SET = BIT(2), > + TPM2_ATTR_DISABLE_CLEAR = BIT(8), > + TPM2_ATTR_IN_LOCKOUT = BIT(9), > + TPM2_ATTR_TPM_GENERATED_EPS = BIT(10), > +}; > + > +enum tpm2_attr_startup_clear { > + TPM2_ATTR_PH_ENABLE = BIT(0), > + TPM2_ATTR_SH_ENABLE = BIT(1), > + TPM2_ATTR_EH_ENABLE = BIT(2), > + TPM2_ATTR_PH_ENABLE_NV = BIT(3), > + TPM2_ATTR_ORDERLY = BIT(31), > +}; > + > enum tpm2_startup_types { > TPM2_SU_CLEAR = 0x0000, > TPM2_SU_STATE = 0x0001, > -- > 2.6.6 >
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Subject: Re: [PATCH 1/2] tpm: define constants for tpm2 properties Date: Mon, 18 Jul 2016 21:58:53 +0300 [thread overview] Message-ID: <20160718185853.GK31463@intel.com> (raw) In-Reply-To: <1468544838-9990-2-git-send-email-apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 > Signed-off-by: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> I'm not going to apply this. The patch has no value. We only want to have a subset of constants that are *used* by the kernel. /Jarkko > --- > drivers/char/tpm/tpm.h | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index 8890df2..ad3b9d1 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -127,6 +127,32 @@ enum tpm2_capabilities { > TPM2_CAP_TPM_PROPERTIES = 6, > }; > > +enum tpm2_properties { > + TPM2_PT_NONE = 0, > + TPM2_PT_GROUP = 0x100, > + TPM2_PT_FIXED = TPM2_PT_GROUP, > + TPM2_PT_VAR = TPM2_PT_GROUP * 2, > + TPM2_PT_PERMANENT = TPM2_PT_VAR + 0, > + TPM2_PT_STARTUP_CLEAR = TPM2_PT_VAR + 1, > +}; > + > +enum tpm2_attr_permanent { > + TPM2_ATTR_OWNER_AUTH_SET = BIT(0), > + TPM2_ATTR_ENDORSEMENT_AUTH_SET = BIT(1), > + TPM2_ATTR_LOCKOUT_AUTH_SET = BIT(2), > + TPM2_ATTR_DISABLE_CLEAR = BIT(8), > + TPM2_ATTR_IN_LOCKOUT = BIT(9), > + TPM2_ATTR_TPM_GENERATED_EPS = BIT(10), > +}; > + > +enum tpm2_attr_startup_clear { > + TPM2_ATTR_PH_ENABLE = BIT(0), > + TPM2_ATTR_SH_ENABLE = BIT(1), > + TPM2_ATTR_EH_ENABLE = BIT(2), > + TPM2_ATTR_PH_ENABLE_NV = BIT(3), > + TPM2_ATTR_ORDERLY = BIT(31), > +}; > + > enum tpm2_startup_types { > TPM2_SU_CLEAR = 0x0000, > TPM2_SU_STATE = 0x0001, > -- > 2.6.6 > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev
next prev parent reply other threads:[~2016-07-18 18:59 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 1:07 [PATCH 0/2] tpm: better support for 32-bit tpm2 properties Andrey Pronin 2016-07-15 1:07 ` Andrey Pronin 2016-07-15 1:07 ` [PATCH 1/2] tpm: define constants for " Andrey Pronin 2016-07-15 1:07 ` Andrey Pronin 2016-07-15 3:08 ` Jason Gunthorpe 2016-07-15 3:08 ` Jason Gunthorpe 2016-07-18 18:58 ` Jarkko Sakkinen [this message] 2016-07-18 18:58 ` Jarkko Sakkinen 2016-07-15 1:07 ` [PATCH 2/2] tpm: fix byte-order for the value read by tpm2_get_tpm_pt Andrey Pronin 2016-07-15 1:07 ` Andrey Pronin 2016-07-15 3:10 ` Jason Gunthorpe 2016-07-15 3:17 ` Andrey Pronin 2016-07-15 3:17 ` Andrey Pronin 2016-07-15 3:35 ` Jason Gunthorpe 2016-07-15 3:35 ` Jason Gunthorpe 2016-07-15 19:31 ` Andrey Pronin 2016-07-15 19:39 ` Jason Gunthorpe 2016-07-18 19:05 ` Jarkko Sakkinen 2016-07-18 19:05 ` Jarkko Sakkinen 2016-07-18 19:04 ` Jarkko Sakkinen 2016-07-18 19:04 ` Jarkko Sakkinen 2016-07-18 19:09 ` Jarkko Sakkinen 2016-07-18 19:09 ` Jarkko Sakkinen 2016-07-18 19:13 ` Andrey Pronin 2016-07-18 19:13 ` Andrey Pronin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160718185853.GK31463@intel.com \ --to=jarkko.sakkinen@linux.intel.com \ --cc=apronin@chromium.org \ --cc=dianders@chromium.org \ --cc=groeck@chromium.org \ --cc=jgunthorpe@obsidianresearch.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peterhuewe@gmx.de \ --cc=smbarber@chromium.org \ --cc=tpmdd-devel@lists.sourceforge.net \ --cc=tpmdd@selhorst.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.