From: Rob Herring <robh@kernel.org>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: mark.rutland@arm.com, maxime.ripard@free-electrons.com,
wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Date: Wed, 20 Jul 2016 14:15:33 -0500 [thread overview]
Message-ID: <20160720191533.GA12875@rob-hp-laptop> (raw)
In-Reply-To: <1469001800-11615-4-git-send-email-clabbe.montjoie@gmail.com>
On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote:
> This patch adds documentation for Device-Tree bindings for the
> Allwinner sun8i-emac driver.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
> .../bindings/net/allwinner,sun8i-emac.txt | 65 ++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> new file mode 100644
> index 0000000..4bf4e53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> @@ -0,0 +1,65 @@
> +* Allwinner sun8i EMAC ethernet controller
> +
> +Required properties:
> +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac",
> + or "allwinner,sun50i-a64-emac"
List one per line.
> +- reg: address and length of the register sets for the device.
> +- reg-names: should be "emac" and "syscon", matching the register sets
> +- interrupts: interrupt for the device
> +- clocks: A phandle to the reference clock for this device
> +- clock-names: should be "ahb"
> +- resets: A phandle to the reset control for this device
> +- reset-names: should be "ahb"
> +- phy-mode: See ethernet.txt
> +- phy or phy-handle: See ethernet.txt
> +- #address-cells: shall be 1
> +- #size-cells: shall be 0
> +
> +"allwinner,sun8i-h3-emac" also requires:
> +- clocks: an extra phandle to the reference clock for the EPHY
> +- clock-names: an extra "ephy" entry matching the clocks property
> +- resets: an extra phandle to the reset control for the EPHY
> +- resets-names: an extra "ephy" entry matching the resets property
> +
> +See ethernet.txt in the same directory for generic bindings for ethernet
> +controllers.
> +
> +The device node referenced by "phy" or "phy-handle" should be a child node
> +of this node. See phy.txt for the generic PHY bindings.
> +
> +Optional properties:
> +- phy-supply: phandle to a regulator if the PHY needs one
> +- phy-io-supply: phandle to a regulator if the PHY needs a another one for I/O.
> + This is sometimes found with RGMII PHYs, which use a second
> + regulator for the lower I/O voltage.
I previously said these should go in the phy node, and you said you
would remove them.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: LABBE Corentin <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Date: Wed, 20 Jul 2016 14:15:33 -0500 [thread overview]
Message-ID: <20160720191533.GA12875@rob-hp-laptop> (raw)
In-Reply-To: <1469001800-11615-4-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote:
> This patch adds documentation for Device-Tree bindings for the
> Allwinner sun8i-emac driver.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> .../bindings/net/allwinner,sun8i-emac.txt | 65 ++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> new file mode 100644
> index 0000000..4bf4e53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> @@ -0,0 +1,65 @@
> +* Allwinner sun8i EMAC ethernet controller
> +
> +Required properties:
> +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac",
> + or "allwinner,sun50i-a64-emac"
List one per line.
> +- reg: address and length of the register sets for the device.
> +- reg-names: should be "emac" and "syscon", matching the register sets
> +- interrupts: interrupt for the device
> +- clocks: A phandle to the reference clock for this device
> +- clock-names: should be "ahb"
> +- resets: A phandle to the reset control for this device
> +- reset-names: should be "ahb"
> +- phy-mode: See ethernet.txt
> +- phy or phy-handle: See ethernet.txt
> +- #address-cells: shall be 1
> +- #size-cells: shall be 0
> +
> +"allwinner,sun8i-h3-emac" also requires:
> +- clocks: an extra phandle to the reference clock for the EPHY
> +- clock-names: an extra "ephy" entry matching the clocks property
> +- resets: an extra phandle to the reset control for the EPHY
> +- resets-names: an extra "ephy" entry matching the resets property
> +
> +See ethernet.txt in the same directory for generic bindings for ethernet
> +controllers.
> +
> +The device node referenced by "phy" or "phy-handle" should be a child node
> +of this node. See phy.txt for the generic PHY bindings.
> +
> +Optional properties:
> +- phy-supply: phandle to a regulator if the PHY needs one
> +- phy-io-supply: phandle to a regulator if the PHY needs a another one for I/O.
> + This is sometimes found with RGMII PHYs, which use a second
> + regulator for the lower I/O voltage.
I previously said these should go in the phy node, and you said you
would remove them.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
Date: Wed, 20 Jul 2016 14:15:33 -0500 [thread overview]
Message-ID: <20160720191533.GA12875@rob-hp-laptop> (raw)
In-Reply-To: <1469001800-11615-4-git-send-email-clabbe.montjoie@gmail.com>
On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote:
> This patch adds documentation for Device-Tree bindings for the
> Allwinner sun8i-emac driver.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
> .../bindings/net/allwinner,sun8i-emac.txt | 65 ++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
>
> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> new file mode 100644
> index 0000000..4bf4e53
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt
> @@ -0,0 +1,65 @@
> +* Allwinner sun8i EMAC ethernet controller
> +
> +Required properties:
> +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac",
> + or "allwinner,sun50i-a64-emac"
List one per line.
> +- reg: address and length of the register sets for the device.
> +- reg-names: should be "emac" and "syscon", matching the register sets
> +- interrupts: interrupt for the device
> +- clocks: A phandle to the reference clock for this device
> +- clock-names: should be "ahb"
> +- resets: A phandle to the reset control for this device
> +- reset-names: should be "ahb"
> +- phy-mode: See ethernet.txt
> +- phy or phy-handle: See ethernet.txt
> +- #address-cells: shall be 1
> +- #size-cells: shall be 0
> +
> +"allwinner,sun8i-h3-emac" also requires:
> +- clocks: an extra phandle to the reference clock for the EPHY
> +- clock-names: an extra "ephy" entry matching the clocks property
> +- resets: an extra phandle to the reset control for the EPHY
> +- resets-names: an extra "ephy" entry matching the resets property
> +
> +See ethernet.txt in the same directory for generic bindings for ethernet
> +controllers.
> +
> +The device node referenced by "phy" or "phy-handle" should be a child node
> +of this node. See phy.txt for the generic PHY bindings.
> +
> +Optional properties:
> +- phy-supply: phandle to a regulator if the PHY needs one
> +- phy-io-supply: phandle to a regulator if the PHY needs a another one for I/O.
> + This is sometimes found with RGMII PHYs, which use a second
> + regulator for the lower I/O voltage.
I previously said these should go in the phy node, and you said you
would remove them.
Rob
next prev parent reply other threads:[~2016-07-20 19:15 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 8:03 [PATCH v2 0/5] net-next: ethernet: add sun8i-emac driver LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` [PATCH v2 1/5] " LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 9:56 ` Arnd Bergmann
2016-07-20 9:56 ` Arnd Bergmann
2016-07-20 9:56 ` Arnd Bergmann
2016-07-28 13:18 ` LABBE Corentin
2016-07-28 13:18 ` LABBE Corentin
2016-07-28 13:18 ` LABBE Corentin
2016-07-29 9:26 ` Arnd Bergmann
2016-07-29 9:26 ` Arnd Bergmann
2016-07-29 9:26 ` Arnd Bergmann
2016-07-25 19:54 ` Maxime Ripard
2016-07-25 19:54 ` Maxime Ripard
2016-07-25 19:54 ` Maxime Ripard
2016-07-28 14:57 ` LABBE Corentin
2016-07-28 14:57 ` LABBE Corentin
2016-07-28 14:57 ` LABBE Corentin
2016-07-29 17:25 ` Maxime Ripard
2016-07-29 17:25 ` Maxime Ripard
2016-07-29 17:25 ` Maxime Ripard
2016-07-30 1:30 ` Chen-Yu Tsai
2016-07-30 1:30 ` Chen-Yu Tsai
2016-07-30 1:30 ` Chen-Yu Tsai
2016-07-30 7:34 ` Maxime Ripard
2016-07-30 7:34 ` Maxime Ripard
2016-07-30 7:34 ` Maxime Ripard
2016-07-29 10:12 ` Andre Przywara
2016-07-29 10:12 ` Andre Przywara
2016-07-29 10:12 ` Andre Przywara
2016-08-24 12:02 ` LABBE Corentin
2016-08-24 12:02 ` LABBE Corentin
2016-08-24 12:02 ` LABBE Corentin
2016-08-26 20:49 ` Maxime Ripard
2016-08-26 20:49 ` Maxime Ripard
2016-08-26 20:49 ` Maxime Ripard
2016-07-20 8:03 ` [PATCH v2 2/5] MAINTAINERS: Add myself as maintainers of sun8i-emac LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 19:15 ` Rob Herring [this message]
2016-07-20 19:15 ` Rob Herring
2016-07-20 19:15 ` Rob Herring
2016-07-28 13:21 ` LABBE Corentin
2016-07-28 13:21 ` LABBE Corentin
2016-07-28 13:21 ` LABBE Corentin
2016-07-21 7:55 ` Maxime Ripard
2016-07-21 7:55 ` Maxime Ripard
2016-07-21 7:55 ` Maxime Ripard
2016-07-28 13:40 ` LABBE Corentin
2016-07-28 13:40 ` LABBE Corentin
2016-07-28 13:40 ` LABBE Corentin
2016-07-28 18:49 ` Maxime Ripard
2016-07-28 18:49 ` Maxime Ripard
2016-07-28 18:49 ` Maxime Ripard
2016-07-29 8:15 ` LABBE Corentin
2016-07-29 8:15 ` LABBE Corentin
2016-07-29 8:15 ` LABBE Corentin
2016-07-29 18:12 ` Maxime Ripard
2016-07-29 18:12 ` Maxime Ripard
2016-07-29 18:12 ` Maxime Ripard
2016-07-20 8:03 ` [PATCH v2 4/5] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` [PATCH v2 5/5] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-20 8:03 ` LABBE Corentin
2016-07-25 13:16 ` [PATCH v2 0/5] net-next: ethernet: add sun8i-emac driver paulo
2016-07-25 13:16 ` paulo at inutilfutil.com
2016-07-25 13:16 ` paulo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160720191533.GA12875@rob-hp-laptop \
--to=robh@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.