All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/3] mmc: sunxi: Add support to the Allwinner A83T
Date: Thu, 21 Jul 2016 11:18:51 +0200	[thread overview]
Message-ID: <20160721111851.133a3f16d6e9de1ee45b3654@free.fr> (raw)
In-Reply-To: <20160721085838.GH5993@lukather>

On Thu, 21 Jul 2016 10:58:38 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Wed, Jul 20, 2016 at 08:28:47PM +0200, Jean-Francois Moine wrote:
> > The rate of the PLL-PERIPH clock is usually set to 1.2GHz in the A83T.
> 
> Uh? The datasheet says to set it to 600MHz.

Right. But the driver of the SDK for the Banana Pi M3 (A83T) sets it
to 1.2GHz.

> > This patch sets the phase delays of the output and sample clocks
> > accordingly.
> > 
> > Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> > ---
> > Note: The impacted phase delays are only for 50MHz.
> > The phase delays are not used in 50MHz 8 bits DDR (new timing mode).
> 
> Actually, they seem to be, in the new timing mode register.

In the SDK driver, nothing is set in the new timing mode register.
Anyway, the eMMC works fine in both the Banana Pis M2+ and M3
with no delay.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

WARNING: multiple messages have this Message-ID (diff)
From: moinejf@free.fr (Jean-Francois Moine)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mmc: sunxi: Add support to the Allwinner A83T
Date: Thu, 21 Jul 2016 11:18:51 +0200	[thread overview]
Message-ID: <20160721111851.133a3f16d6e9de1ee45b3654@free.fr> (raw)
In-Reply-To: <20160721085838.GH5993@lukather>

On Thu, 21 Jul 2016 10:58:38 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Wed, Jul 20, 2016 at 08:28:47PM +0200, Jean-Francois Moine wrote:
> > The rate of the PLL-PERIPH clock is usually set to 1.2GHz in the A83T.
> 
> Uh? The datasheet says to set it to 600MHz.

Right. But the driver of the SDK for the Banana Pi M3 (A83T) sets it
to 1.2GHz.

> > This patch sets the phase delays of the output and sample clocks
> > accordingly.
> > 
> > Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
> > ---
> > Note: The impacted phase delays are only for 50MHz.
> > The phase delays are not used in 50MHz 8 bits DDR (new timing mode).
> 
> Actually, they seem to be, in the new timing mode register.

In the SDK driver, nothing is set in the new timing mode register.
Anyway, the eMMC works fine in both the Banana Pis M2+ and M3
with no delay.

-- 
Ken ar c'henta?	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

  reply	other threads:[~2016-07-21  9:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21  6:28 [PATCH 0/3] mmc: sunxi: Changes in the host driver Jean-Francois Moine
2016-07-21  6:28 ` Jean-Francois Moine
     [not found] ` <cover.1469082481.git.moinejf-GANU6spQydw@public.gmane.org>
2016-07-20 18:01   ` [PATCH 1/3] mmc: sunxi: Check the value returned by clk_round_rate Jean-Francois Moine
2016-07-20 18:01     ` Jean-Francois Moine
     [not found]     ` <c2231f3df66cf77e4fb9051f7b0c27ea69b8e63d.1469082481.git.moinejf-GANU6spQydw@public.gmane.org>
2016-07-21  8:49       ` Maxime Ripard
2016-07-21  8:49         ` Maxime Ripard
2016-07-20 18:16   ` [PATCH 2/3] mmc: sunxi: Set the 'New Timing' register for 8 bits DDR transfers Jean-Francois Moine
2016-07-20 18:16     ` Jean-Francois Moine
     [not found]     ` <bc7b767cad6db159a44c4b98d5b1f3eb53c26bd3.1469082481.git.moinejf-GANU6spQydw@public.gmane.org>
2016-07-21  8:56       ` Maxime Ripard
2016-07-21  8:56         ` Maxime Ripard
2016-07-21  9:26         ` Jean-Francois Moine
2016-07-21  9:26           ` Jean-Francois Moine
     [not found]           ` <20160721112655.941b1dad04f7a5b94d4172c1-GANU6spQydw@public.gmane.org>
2016-07-29 19:17             ` Maxime Ripard
2016-07-29 19:17               ` Maxime Ripard
2016-07-30  5:18               ` Jean-Francois Moine
2016-07-30  5:18                 ` Jean-Francois Moine
2016-07-30 10:19               ` [linux-sunxi] " Hans de Goede
2016-07-30 10:19                 ` Hans de Goede
     [not found]                 ` <9414aab0-ac2b-01c2-e16b-8f7394ea7b68-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-08-01 13:52                   ` Jean-Francois Moine
2016-08-01 13:52                     ` [linux-sunxi] " Jean-Francois Moine
     [not found]                     ` <20160801155246.b7b3c7f0f582394b4c25f6dc-GANU6spQydw@public.gmane.org>
2016-08-02  8:37                       ` Hans de Goede
2016-08-02  8:37                         ` [linux-sunxi] " Hans de Goede
2016-07-29 19:36             ` Maxime Ripard
2016-07-29 19:36               ` Maxime Ripard
2016-07-30  5:20               ` Jean-Francois Moine
2016-07-30  5:20                 ` Jean-Francois Moine
2016-07-20 18:28   ` [PATCH 3/3] mmc: sunxi: Add support to the Allwinner A83T Jean-Francois Moine
2016-07-20 18:28     ` Jean-Francois Moine
2016-07-21  8:58     ` Maxime Ripard
2016-07-21  8:58       ` Maxime Ripard
2016-07-21  9:18       ` Jean-Francois Moine [this message]
2016-07-21  9:18         ` Jean-Francois Moine
     [not found]         ` <20160721111851.133a3f16d6e9de1ee45b3654-GANU6spQydw@public.gmane.org>
2016-07-22 19:00           ` Jean-Francois Moine
2016-07-22 19:00             ` Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721111851.133a3f16d6e9de1ee45b3654@free.fr \
    --to=moinejf@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.