[PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

[PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

[Saeed Mahameed]

memset the command buffers rather than the pointers to them.

Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling")
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
---

V2:
 - Improved log message.

 drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
index 05de772..e25a73ed 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
@@ -72,8 +72,8 @@ static int mlx5e_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port)
 	u32 in[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_in)];
 	u32 out[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_out)];
 
-	memset(&in, 0, sizeof(in));
-	memset(&out, 0, sizeof(out));
+	memset(in, 0, sizeof(in));
+	memset(out, 0, sizeof(out));
 
 	MLX5_SET(delete_vxlan_udp_dport_in, in, opcode,
 		 MLX5_CMD_OP_DELETE_VXLAN_UDP_DPORT);
-- 
2.8.0

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

[David Miller]

From: Saeed Mahameed <saeedm@mellanox.com>
Date: Thu, 21 Jul 2016 00:39:53 +0300

> memset the command buffers rather than the pointers to them.
> 
> Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling")
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> ---
> 
> V2:
>  - Improved log message.

Applied.

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

[Alexei Starovoitov]

On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote:
> memset the command buffers rather than the pointers to them.

that is still wrong commit log.
This patch makes zero difference to generated code.
'&in' is the same as 'in'

> Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling")
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> ---
> 
> V2:
>  - Improved log message.
> 
>  drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
> index 05de772..e25a73ed 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/vxlan.c
> @@ -72,8 +72,8 @@ static int mlx5e_vxlan_core_del_port_cmd(struct mlx5_core_dev *mdev, u16 port)
>  	u32 in[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_in)];
>  	u32 out[MLX5_ST_SZ_DW(delete_vxlan_udp_dport_out)];
>  
> -	memset(&in, 0, sizeof(in));
> -	memset(&out, 0, sizeof(out));
> +	memset(in, 0, sizeof(in));
> +	memset(out, 0, sizeof(out));
>  
>  	MLX5_SET(delete_vxlan_udp_dport_in, in, opcode,
>  		 MLX5_CMD_OP_DELETE_VXLAN_UDP_DPORT);
> -- 
> 2.8.0
> 

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

[Saeed Mahameed]

On Thu, Jul 21, 2016 at 3:53 AM, Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
> On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote:
>> memset the command buffers rather than the pointers to them.
>
> that is still wrong commit log.
> This patch makes zero difference to generated code.
> '&in' is the same as 'in'
>

Who said they are not ? There was a mistake in the original log
message and it was fixed here.
The patch was made to make the code consistent with other places in
the code, and i don't see anything wrong with the log message.

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

[Alexei Starovoitov]

On Thu, Jul 21, 2016 at 11:08:06AM +0300, Saeed Mahameed wrote:
> On Thu, Jul 21, 2016 at 3:53 AM, Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
> > On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote:
> >> memset the command buffers rather than the pointers to them.
> >
> > that is still wrong commit log.
> > This patch makes zero difference to generated code.
> > '&in' is the same as 'in'
> >
> 
> Who said they are not ? There was a mistake in the original log
> message and it was fixed here.
> The patch was made to make the code consistent with other places in
> the code, and i don't see anything wrong with the log message.

the commit log implies that there is a bug. There is none.
old code does 'memset the command buffers'.
'rather than the pointers' is not correct.