* [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock
@ 2016-02-19 1:12 ` Eric Anholt
0 siblings, 0 replies; 6+ messages in thread
From: Eric Anholt @ 2016-02-19 1:12 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stephen Warren,
Lee Jones, linux-i2c, Eric Anholt
Fixes dmesg spam when we just need to wait a moment for the clock
driver to probe.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 818b051..d4f3239 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(i2c_dev->clk)) {
- dev_err(&pdev->dev, "Could not get clock\n");
+ if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Could not get clock\n");
return PTR_ERR(i2c_dev->clk);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock
@ 2016-02-19 1:12 ` Eric Anholt
0 siblings, 0 replies; 6+ messages in thread
From: Eric Anholt @ 2016-02-19 1:12 UTC (permalink / raw)
To: linux-arm-kernel
Fixes dmesg spam when we just need to wait a moment for the clock
driver to probe.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 818b051..d4f3239 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(i2c_dev->clk)) {
- dev_err(&pdev->dev, "Could not get clock\n");
+ if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Could not get clock\n");
return PTR_ERR(i2c_dev->clk);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock
2016-02-19 1:12 ` Eric Anholt
@ 2016-02-24 17:29 ` Stefan Wahren
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2016-02-24 17:29 UTC (permalink / raw)
To: Eric Anholt, Wolfram Sang
Cc: Lee Jones, linux-kernel, linux-i2c, Stephen Warren,
linux-arm-kernel, linux-rpi-kernel
Hi Eric,
> Eric Anholt <eric@anholt.net> hat am 19. Februar 2016 um 02:12 geschrieben:
>
>
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c
> b/drivers/i2c/busses/i2c-bcm2835.c
> index 818b051..d4f3239 100644
> --- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
>
> i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(i2c_dev->clk)) {
> - dev_err(&pdev->dev, "Could not get clock\n");
> + if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Could not get clock\n");
i know it's something different, but how about printing the error code here?
Regards
Stefan
> return PTR_ERR(i2c_dev->clk);
> }
>
> --
> 2.7.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock
@ 2016-02-24 17:29 ` Stefan Wahren
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2016-02-24 17:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Eric,
> Eric Anholt <eric@anholt.net> hat am 19. Februar 2016 um 02:12 geschrieben:
>
>
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c
> b/drivers/i2c/busses/i2c-bcm2835.c
> index 818b051..d4f3239 100644
> --- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -253,7 +253,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
>
> i2c_dev->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(i2c_dev->clk)) {
> - dev_err(&pdev->dev, "Could not get clock\n");
> + if (PTR_ERR(i2c_dev->clk) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Could not get clock\n");
i know it's something different, but how about printing the error code here?
Regards
Stefan
> return PTR_ERR(i2c_dev->clk);
> }
>
> --
> 2.7.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock
2016-02-19 1:12 ` Eric Anholt
@ 2016-07-22 7:28 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-07-22 7:28 UTC (permalink / raw)
To: Eric Anholt
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stephen Warren,
Lee Jones, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Thu, Feb 18, 2016 at 05:12:55PM -0800, Eric Anholt wrote:
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock
@ 2016-07-22 7:28 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-07-22 7:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 18, 2016 at 05:12:55PM -0800, Eric Anholt wrote:
> Fixes dmesg spam when we just need to wait a moment for the clock
> driver to probe.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160722/ce71074e/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-22 7:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-19 1:12 [PATCH] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock Eric Anholt
2016-02-19 1:12 ` Eric Anholt
2016-02-24 17:29 ` Stefan Wahren
2016-02-24 17:29 ` Stefan Wahren
2016-07-22 7:28 ` Wolfram Sang
2016-07-22 7:28 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.