* [PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare
@ 2016-07-20 5:14 Amitoj Kaur Chawla
2016-07-22 7:14 ` Wolfram Sang
2016-07-22 7:28 ` Uwe Kleine-König
0 siblings, 2 replies; 3+ messages in thread
From: Amitoj Kaur Chawla @ 2016-07-20 5:14 UTC (permalink / raw)
To: wsa, linux-i2c, linux-kernel; +Cc: julia.lawall
Replace clk_enable and clk_prepare with clk_enable_prepare and
clk_disable and clk_unprepare with clk_disable_unprepare.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression e;
@@
- clk_prepare(e);
- clk_enable(e);
+ clk_prepare_enable(e);
@@
expression e;
@@
- clk_disable(e);
- clk_unprepare(e);
+ clk_disable_unprepare(e);
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
Changes in v2:
-Rebased patch
drivers/i2c/busses/i2c-mv64xxx.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
index 43207f5..79bae48 100644
--- a/drivers/i2c/busses/i2c-mv64xxx.c
+++ b/drivers/i2c/busses/i2c-mv64xxx.c
@@ -910,10 +910,8 @@ mv64xxx_i2c_probe(struct platform_device *pd)
#if defined(CONFIG_HAVE_CLK)
/* Not all platforms have a clk */
drv_data->clk = devm_clk_get(&pd->dev, NULL);
- if (!IS_ERR(drv_data->clk)) {
- clk_prepare(drv_data->clk);
- clk_enable(drv_data->clk);
- }
+ if (!IS_ERR(drv_data->clk))
+ clk_prepare_enable(drv_data->clk);
#endif
if (pdata) {
drv_data->freq_m = pdata->freq_m;
@@ -966,10 +964,8 @@ exit_reset:
exit_clk:
#if defined(CONFIG_HAVE_CLK)
/* Not all platforms have a clk */
- if (!IS_ERR(drv_data->clk)) {
- clk_disable(drv_data->clk);
- clk_unprepare(drv_data->clk);
- }
+ if (!IS_ERR(drv_data->clk))
+ clk_disable_unprepare(drv_data->clk);
#endif
return rc;
}
@@ -985,10 +981,8 @@ mv64xxx_i2c_remove(struct platform_device *dev)
reset_control_assert(drv_data->rstc);
#if defined(CONFIG_HAVE_CLK)
/* Not all platforms have a clk */
- if (!IS_ERR(drv_data->clk)) {
- clk_disable(drv_data->clk);
- clk_unprepare(drv_data->clk);
- }
+ if (!IS_ERR(drv_data->clk))
+ clk_disable_unprepare(drv_data->clk);
#endif
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare
2016-07-20 5:14 [PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare Amitoj Kaur Chawla
@ 2016-07-22 7:14 ` Wolfram Sang
2016-07-22 7:28 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-07-22 7:14 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: linux-i2c, linux-kernel, julia.lawall
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On Wed, Jul 20, 2016 at 10:44:18AM +0530, Amitoj Kaur Chawla wrote:
> Replace clk_enable and clk_prepare with clk_enable_prepare and
> clk_disable and clk_unprepare with clk_disable_unprepare.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> - clk_prepare(e);
> - clk_enable(e);
> + clk_prepare_enable(e);
>
> @@
> expression e;
> @@
>
> - clk_disable(e);
> - clk_unprepare(e);
> + clk_disable_unprepare(e);
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
> -Rebased patch
I still can't apply and nothing changed to the previous patch you sent?
To what did you rebase?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare
2016-07-20 5:14 [PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare Amitoj Kaur Chawla
2016-07-22 7:14 ` Wolfram Sang
@ 2016-07-22 7:28 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2016-07-22 7:28 UTC (permalink / raw)
To: Amitoj Kaur Chawla; +Cc: wsa, linux-i2c, linux-kernel, julia.lawall
there is an i missing in the Subject.
On Wed, Jul 20, 2016 at 10:44:18AM +0530, Amitoj Kaur Chawla wrote:
> Replace clk_enable and clk_prepare with clk_enable_prepare and
> clk_disable and clk_unprepare with clk_disable_unprepare.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> - clk_prepare(e);
> - clk_enable(e);
> + clk_prepare_enable(e);
>
> @@
> expression e;
> @@
>
> - clk_disable(e);
> - clk_unprepare(e);
> + clk_disable_unprepare(e);
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> Changes in v2:
> -Rebased patch
>
> drivers/i2c/busses/i2c-mv64xxx.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 43207f5..79bae48 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -910,10 +910,8 @@ mv64xxx_i2c_probe(struct platform_device *pd)
> #if defined(CONFIG_HAVE_CLK)
> /* Not all platforms have a clk */
> drv_data->clk = devm_clk_get(&pd->dev, NULL);
> - if (!IS_ERR(drv_data->clk)) {
> - clk_prepare(drv_data->clk);
> - clk_enable(drv_data->clk);
> - }
> + if (!IS_ERR(drv_data->clk))
> + clk_prepare_enable(drv_data->clk);
When you touch this, better add error checking. I wonder why these
functions are not marked __must_check.
Also using IS_ERR(drv_data->clk) is wrong here, becauce devm_clk_get
might return -EPROBE_DEFER.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-22 7:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-20 5:14 [PATCH v2] 2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare Amitoj Kaur Chawla
2016-07-22 7:14 ` Wolfram Sang
2016-07-22 7:28 ` Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.