[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Michal Simek]

Getting this error:
Zynq> sb load hostfs - 100
/home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
Unknown command 'sb' - try 'help'

because sb command is present only for Sandbox
obj-$(CONFIG_SANDBOX) += host.o

that's why mark this test to be run only at Sandbox

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 test/py/tests/test_vboot.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
index c77989591c7e..92b4eccad808 100644
--- a/test/py/tests/test_vboot.py
+++ b/test/py/tests/test_vboot.py
@@ -29,6 +29,7 @@ import pytest
 import sys
 import u_boot_utils as util
 
+ at pytest.mark.boardspec('sandbox')
 @pytest.mark.buildconfigspec('fit_signature')
 def test_vboot(u_boot_console):
     """Test verified boot signing with mkimage and verification with 'bootm'.
-- 
1.9.1

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Simon Glass]

+Stephen

On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
> Getting this error:
> Zynq> sb load hostfs - 100
> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
> Unknown command 'sb' - try 'help'
>
> because sb command is present only for Sandbox
> obj-$(CONFIG_SANDBOX) += host.o
>
> that's why mark this test to be run only at Sandbox
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  test/py/tests/test_vboot.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
> index c77989591c7e..92b4eccad808 100644
> --- a/test/py/tests/test_vboot.py
> +++ b/test/py/tests/test_vboot.py
> @@ -29,6 +29,7 @@ import pytest
>  import sys
>  import u_boot_utils as util
>
> + at pytest.mark.boardspec('sandbox')
>  @pytest.mark.buildconfigspec('fit_signature')

Can we have both conditions, or does it only work as an OR?

>  def test_vboot(u_boot_console):
>      """Test verified boot signing with mkimage and verification with 'bootm'.
> --
> 1.9.1
>

Regards,
Simon

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Michal Simek]

On 20.7.2016 16:19, Simon Glass wrote:
> +Stephen
> 
> On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
>> Getting this error:
>> Zynq> sb load hostfs - 100
>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>> Unknown command 'sb' - try 'help'
>>
>> because sb command is present only for Sandbox
>> obj-$(CONFIG_SANDBOX) += host.o
>>
>> that's why mark this test to be run only at Sandbox
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  test/py/tests/test_vboot.py | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>> index c77989591c7e..92b4eccad808 100644
>> --- a/test/py/tests/test_vboot.py
>> +++ b/test/py/tests/test_vboot.py
>> @@ -29,6 +29,7 @@ import pytest
>>  import sys
>>  import u_boot_utils as util
>>
>> + at pytest.mark.boardspec('sandbox')
>>  @pytest.mark.buildconfigspec('fit_signature')
> 
> Can we have both conditions, or does it only work as an OR?

Test is valid when both options are valid.
Stephen can confirm for sure.

Thanks,
Michal

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Stephen Warren]

On 07/20/2016 08:19 AM, Simon Glass wrote:
> +Stephen
>
> On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
>> Getting this error:
>> Zynq> sb load hostfs - 100
>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>> Unknown command 'sb' - try 'help'
>>
>> because sb command is present only for Sandbox
>> obj-$(CONFIG_SANDBOX) += host.o
>>
>> that's why mark this test to be run only at Sandbox
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>   test/py/tests/test_vboot.py | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>> index c77989591c7e..92b4eccad808 100644
>> --- a/test/py/tests/test_vboot.py
>> +++ b/test/py/tests/test_vboot.py
>> @@ -29,6 +29,7 @@ import pytest
>>   import sys
>>   import u_boot_utils as util
>>
>> + at pytest.mark.boardspec('sandbox')
>>   @pytest.mark.buildconfigspec('fit_signature')
>
> Can we have both conditions, or does it only work as an OR?

I believe marks are conditions that must be individually satisfied, so 
when there are multiple marks, it's treated like an AND, which I imagine 
is the desired thing here.

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Michal Simek]

Hi Simon and Stephen,

On 20.7.2016 17:51, Stephen Warren wrote:
> On 07/20/2016 08:19 AM, Simon Glass wrote:
>> +Stephen
>>
>> On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
>>> Getting this error:
>>> Zynq> sb load hostfs - 100
>>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>>> Unknown command 'sb' - try 'help'
>>>
>>> because sb command is present only for Sandbox
>>> obj-$(CONFIG_SANDBOX) += host.o
>>>
>>> that's why mark this test to be run only at Sandbox
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>> ---
>>>
>>>   test/py/tests/test_vboot.py | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>>> index c77989591c7e..92b4eccad808 100644
>>> --- a/test/py/tests/test_vboot.py
>>> +++ b/test/py/tests/test_vboot.py
>>> @@ -29,6 +29,7 @@ import pytest
>>>   import sys
>>>   import u_boot_utils as util
>>>
>>> + at pytest.mark.boardspec('sandbox')
>>>   @pytest.mark.buildconfigspec('fit_signature')
>>
>> Can we have both conditions, or does it only work as an OR?
> 
> I believe marks are conditions that must be individually satisfied, so
> when there are multiple marks, it's treated like an AND, which I imagine
> is the desired thing here.
> 

ACK then?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160722/67e56772/attachment.sig>

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Simon Glass]

Hi Michal,

On 22 July 2016 at 01:13, Michal Simek <monstr@monstr.eu> wrote:
> Hi Simon and Stephen,
>
> On 20.7.2016 17:51, Stephen Warren wrote:
>> On 07/20/2016 08:19 AM, Simon Glass wrote:
>>> +Stephen
>>>
>>> On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
>>>> Getting this error:
>>>> Zynq> sb load hostfs - 100
>>>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>>>> Unknown command 'sb' - try 'help'
>>>>
>>>> because sb command is present only for Sandbox
>>>> obj-$(CONFIG_SANDBOX) += host.o
>>>>
>>>> that's why mark this test to be run only at Sandbox
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>>   test/py/tests/test_vboot.py | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>>>> index c77989591c7e..92b4eccad808 100644
>>>> --- a/test/py/tests/test_vboot.py
>>>> +++ b/test/py/tests/test_vboot.py
>>>> @@ -29,6 +29,7 @@ import pytest
>>>>   import sys
>>>>   import u_boot_utils as util
>>>>
>>>> + at pytest.mark.boardspec('sandbox')
>>>>   @pytest.mark.buildconfigspec('fit_signature')
>>>
>>> Can we have both conditions, or does it only work as an OR?
>>
>> I believe marks are conditions that must be individually satisfied, so
>> when there are multiple marks, it's treated like an AND, which I imagine
>> is the desired thing here.
>>
>
> ACK then?

Can you add both conditions?

Regards,
Simon

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Michal Simek]

On 22.7.2016 15:33, Simon Glass wrote:
> Hi Michal,
> 
> On 22 July 2016 at 01:13, Michal Simek <monstr@monstr.eu> wrote:
>> Hi Simon and Stephen,
>>
>> On 20.7.2016 17:51, Stephen Warren wrote:
>>> On 07/20/2016 08:19 AM, Simon Glass wrote:
>>>> +Stephen
>>>>
>>>> On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
>>>>> Getting this error:
>>>>> Zynq> sb load hostfs - 100
>>>>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>>>>> Unknown command 'sb' - try 'help'
>>>>>
>>>>> because sb command is present only for Sandbox
>>>>> obj-$(CONFIG_SANDBOX) += host.o
>>>>>
>>>>> that's why mark this test to be run only at Sandbox
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>>> ---
>>>>>
>>>>>   test/py/tests/test_vboot.py | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>>>>> index c77989591c7e..92b4eccad808 100644
>>>>> --- a/test/py/tests/test_vboot.py
>>>>> +++ b/test/py/tests/test_vboot.py
>>>>> @@ -29,6 +29,7 @@ import pytest
>>>>>   import sys
>>>>>   import u_boot_utils as util
>>>>>
>>>>> + at pytest.mark.boardspec('sandbox')
>>>>>   @pytest.mark.buildconfigspec('fit_signature')
>>>>
>>>> Can we have both conditions, or does it only work as an OR?
>>>
>>> I believe marks are conditions that must be individually satisfied, so
>>> when there are multiple marks, it's treated like an AND, which I imagine
>>> is the desired thing here.
>>>
>>
>> ACK then?
> 
> Can you add both conditions?

Sorry I don't get it. Origin there is condition that fit_signature needs
to be enabled. And this patch adds one more when sandbox is enabled.

It means vboot test runs on sandbox when fit_signature is enabled.

Thanks,
Michal

[U-Boot] [PATCH] test/py: vboot can be run only at Sandbox

[Simon Glass]

On 22 July 2016 at 08:02, Michal Simek <michal.simek@xilinx.com> wrote:
> On 22.7.2016 15:33, Simon Glass wrote:
>> Hi Michal,
>>
>> On 22 July 2016 at 01:13, Michal Simek <monstr@monstr.eu> wrote:
>>> Hi Simon and Stephen,
>>>
>>> On 20.7.2016 17:51, Stephen Warren wrote:
>>>> On 07/20/2016 08:19 AM, Simon Glass wrote:
>>>>> +Stephen
>>>>>
>>>>> On 18 July 2016 at 00:49, Michal Simek <michal.simek@xilinx.com> wrote:
>>>>>> Getting this error:
>>>>>> Zynq> sb load hostfs - 100
>>>>>> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
>>>>>> Unknown command 'sb' - try 'help'
>>>>>>
>>>>>> because sb command is present only for Sandbox
>>>>>> obj-$(CONFIG_SANDBOX) += host.o
>>>>>>
>>>>>> that's why mark this test to be run only at Sandbox
>>>>>>
>>>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>>>> ---
>>>>>>
>>>>>>   test/py/tests/test_vboot.py | 1 +
>>>>>>   1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py
>>>>>> index c77989591c7e..92b4eccad808 100644
>>>>>> --- a/test/py/tests/test_vboot.py
>>>>>> +++ b/test/py/tests/test_vboot.py
>>>>>> @@ -29,6 +29,7 @@ import pytest
>>>>>>   import sys
>>>>>>   import u_boot_utils as util
>>>>>>
>>>>>> + at pytest.mark.boardspec('sandbox')
>>>>>>   @pytest.mark.buildconfigspec('fit_signature')
>>>>>
>>>>> Can we have both conditions, or does it only work as an OR?
>>>>
>>>> I believe marks are conditions that must be individually satisfied, so
>>>> when there are multiple marks, it's treated like an AND, which I imagine
>>>> is the desired thing here.
>>>>
>>>
>>> ACK then?
>>
>> Can you add both conditions?
>
> Sorry I don't get it. Origin there is condition that fit_signature needs
> to be enabled. And this patch adds one more when sandbox is enabled.
>
> It means vboot test runs on sandbox when fit_signature is enabled.

OK that sounds good, thanks.

Acked-by: Simon Glass <sjg@chromium.org>

[U-Boot] test/py: vboot can be run only at Sandbox

[Tom Rini]

On Mon, Jul 18, 2016 at 08:49:08AM +0200, Michal Simek wrote:

> Getting this error:
> Zynq> sb load hostfs - 100
> /home/monstr/data/disk/u-boot/build-zynq_zc706/test.fit
> Unknown command 'sb' - try 'help'
> 
> because sb command is present only for Sandbox
> obj-$(CONFIG_SANDBOX) += host.o
> 
> that's why mark this test to be run only at Sandbox
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160722/20e2baec/attachment.sig>