* [PATCH] nvme-fabrics: set sqe.command_id in core, not transports
@ 2016-07-23 0:23 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2016-07-23 0:23 UTC (permalink / raw)
To: linux-nvme, linux-scsi
set sqe.command_id in core, not transports
Patch is cut against the linux-nvme for-4.8/drivers branch
Signed-off-by: James Smart <james.smart@broadcom.com>
---
drivers/nvme/host/core.c | 3 ++-
drivers/nvme/host/rdma.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 74b1d38..b391f54 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -290,7 +290,6 @@ static inline void nvme_setup_rw(struct nvme_ns *ns, struct request *req,
memset(cmnd, 0, sizeof(*cmnd));
cmnd->rw.opcode = (rq_data_dir(req) ? nvme_cmd_write : nvme_cmd_read);
- cmnd->rw.command_id = req->tag;
cmnd->rw.nsid = cpu_to_le32(ns->ns_id);
cmnd->rw.slba = cpu_to_le64(nvme_block_nr(ns, blk_rq_pos(req)));
cmnd->rw.length = cpu_to_le16((blk_rq_bytes(req) >> ns->lba_shift) - 1);
@@ -330,6 +329,8 @@ int nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
else
nvme_setup_rw(ns, req, cmd);
+ cmd->common.command_id = req->tag;
+
return ret;
}
EXPORT_SYMBOL_GPL(nvme_setup_cmd);
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3e3ce2b..0cd7c3e 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1447,7 +1447,6 @@ static int nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx,
if (ret)
return ret;
- c->common.command_id = rq->tag;
blk_mq_start_request(rq);
map_len = nvme_map_len(rq);
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] nvme-fabrics: set sqe.command_id in core, not transports
@ 2016-07-23 0:23 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2016-07-23 0:23 UTC (permalink / raw)
set sqe.command_id in core, not transports
Patch is cut against the linux-nvme for-4.8/drivers branch
Signed-off-by: James Smart <james.smart at broadcom.com>
---
drivers/nvme/host/core.c | 3 ++-
drivers/nvme/host/rdma.c | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 74b1d38..b391f54 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -290,7 +290,6 @@ static inline void nvme_setup_rw(struct nvme_ns *ns, struct request *req,
memset(cmnd, 0, sizeof(*cmnd));
cmnd->rw.opcode = (rq_data_dir(req) ? nvme_cmd_write : nvme_cmd_read);
- cmnd->rw.command_id = req->tag;
cmnd->rw.nsid = cpu_to_le32(ns->ns_id);
cmnd->rw.slba = cpu_to_le64(nvme_block_nr(ns, blk_rq_pos(req)));
cmnd->rw.length = cpu_to_le16((blk_rq_bytes(req) >> ns->lba_shift) - 1);
@@ -330,6 +329,8 @@ int nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
else
nvme_setup_rw(ns, req, cmd);
+ cmd->common.command_id = req->tag;
+
return ret;
}
EXPORT_SYMBOL_GPL(nvme_setup_cmd);
diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 3e3ce2b..0cd7c3e 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1447,7 +1447,6 @@ static int nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx,
if (ret)
return ret;
- c->common.command_id = rq->tag;
blk_mq_start_request(rq);
map_len = nvme_map_len(rq);
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-fabrics: set sqe.command_id in core, not transports
2016-07-23 0:23 ` James Smart
@ 2016-07-25 8:52 ` Johannes Thumshirn
-1 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2016-07-25 8:52 UTC (permalink / raw)
To: James Smart; +Cc: linux-nvme, linux-scsi
On Fri, Jul 22, 2016 at 05:23:52PM -0700, James Smart wrote:
>
> set sqe.command_id in core, not transports
>
> Patch is cut against the linux-nvme for-4.8/drivers branch
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
Acked-by: Johannes Thumshirn <jth@kernel.org>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvme-fabrics: set sqe.command_id in core, not transports
@ 2016-07-25 8:52 ` Johannes Thumshirn
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2016-07-25 8:52 UTC (permalink / raw)
On Fri, Jul 22, 2016@05:23:52PM -0700, James Smart wrote:
>
> set sqe.command_id in core, not transports
>
> Patch is cut against the linux-nvme for-4.8/drivers branch
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
Acked-by: Johannes Thumshirn <jth at kernel.org>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvme-fabrics: set sqe.command_id in core, not transports
2016-07-23 0:23 ` James Smart
@ 2016-08-11 21:02 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-08-11 21:02 UTC (permalink / raw)
To: James Smart; +Cc: linux-nvme, linux-scsi
This needs to cover the loop and PCI driver a swell.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-11 21:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-23 0:23 [PATCH] nvme-fabrics: set sqe.command_id in core, not transports James Smart
2016-07-23 0:23 ` James Smart
2016-07-25 8:52 ` Johannes Thumshirn
2016-07-25 8:52 ` Johannes Thumshirn
2016-08-11 21:02 ` Christoph Hellwig
2016-08-11 21:02 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.