From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Rob Herring <robh@kernel.org>
Cc: Grzegorz Jaszczyk <jaz@semihalf.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Marcin Wojtas <mw@semihalf.com>, Lior Amsalem <alior@marvell.com>
Subject: Re: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family
Date: Mon, 25 Jul 2016 15:50:50 +0200 [thread overview]
Message-ID: <20160725155050.3aee974e@free-electrons.com> (raw)
In-Reply-To: <CAL_JsqJeObuS8OWeErRA5MX-SrMtu_254A-LtP9-A=xdPO7p1Q@mail.gmail.com>
Hello,
On Mon, 25 Jul 2016 08:47:23 -0500, Rob Herring wrote:
> > I am not sure if I get your point. The Armada-398 extends the
> > Armada-395 about 2 additional SATA ports (as you can see in commit
> > "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
> > interfaces"). In this example the a398-db board contains the Armada398
> > SoC, so it is a better match and goes first.
>
> But your patch title is adding 395 support, but you are adding the
> string to a 398 based board. It would make sense to have 395 here if
> the OS already had support for 395 and you want to support the 398
> without updating the OS. That doesn't seem to apply here.
I think the argument of Grzegorz is that the 398 is functionally a
strict superset of the 395, so that anything that applies to the 395
will also apply to 398.
Now, whether it is a good idea to consider them "compatible" in the DT
sense, I'm not sure.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family
Date: Mon, 25 Jul 2016 15:50:50 +0200 [thread overview]
Message-ID: <20160725155050.3aee974e@free-electrons.com> (raw)
In-Reply-To: <CAL_JsqJeObuS8OWeErRA5MX-SrMtu_254A-LtP9-A=xdPO7p1Q@mail.gmail.com>
Hello,
On Mon, 25 Jul 2016 08:47:23 -0500, Rob Herring wrote:
> > I am not sure if I get your point. The Armada-398 extends the
> > Armada-395 about 2 additional SATA ports (as you can see in commit
> > "[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
> > interfaces"). In this example the a398-db board contains the Armada398
> > SoC, so it is a better match and goes first.
>
> But your patch title is adding 395 support, but you are adding the
> string to a 398 based board. It would make sense to have 395 here if
> the OS already had support for 395 and you want to support the 398
> without updating the OS. That doesn't seem to apply here.
I think the argument of Grzegorz is that the 398 is functionally a
strict superset of the 395, so that anything that applies to the 395
will also apply to 398.
Now, whether it is a good idea to consider them "compatible" in the DT
sense, I'm not sure.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-07-25 13:51 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 12:43 [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-21 12:43 ` [PATCH 01/18] ARM: mvebu: enable MTD command line partition table in mvebu_v7_defconfig Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-27 15:57 ` Gregory CLEMENT
2016-07-27 15:57 ` Gregory CLEMENT
2016-07-21 12:43 ` [PATCH 02/18] ARM: mvebu: enable UBI and UBIFS " Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-27 15:58 ` Gregory CLEMENT
2016-07-27 15:58 ` Gregory CLEMENT
2016-07-21 12:43 ` [PATCH 03/18] ARM: mvebu: enable E1000E " Grzegorz Jaszczyk
2016-07-21 12:43 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` Russell King - ARM Linux
2016-07-21 12:44 ` Russell King - ARM Linux
2016-07-21 12:46 ` Thomas Petazzoni
2016-07-21 12:46 ` Thomas Petazzoni
2016-07-21 13:52 ` Grzegorz Jaszczyk
2016-07-21 13:52 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` [PATCH 04/18] ARM: mvebu: a385-db-ap: enable USB (orion-ehci) port Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-27 16:00 ` Gregory CLEMENT
2016-07-27 16:00 ` Gregory CLEMENT
2016-07-27 16:00 ` Gregory CLEMENT
2016-07-27 16:09 ` Gregory CLEMENT
2016-07-27 16:09 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-27 16:04 ` Gregory CLEMENT
2016-07-27 16:04 ` Gregory CLEMENT
2016-07-27 16:04 ` Gregory CLEMENT
2016-07-27 16:10 ` Gregory CLEMENT
2016-07-27 16:10 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 06/18] ARM: mvebu: a390: add missing compatibility string and add missing bracket Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-27 16:13 ` Gregory CLEMENT
2016-07-27 16:13 ` Gregory CLEMENT
2016-07-27 16:13 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 07/18] ARM: mvebu: a39x: update the SDHCI node on Armada 39x Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 9:39 ` Gregory CLEMENT
2016-07-28 9:39 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 08/18] ARM: mvebu: a39x: enable PMU, CA9 MPcore SoC Controller and Coherency fabric Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 9:44 ` Gregory CLEMENT
2016-07-28 9:44 ` Gregory CLEMENT
2016-07-28 9:44 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 08/18] ARM: mvebu: a39x: Enable " Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 9:51 ` Gregory CLEMENT
2016-07-28 9:51 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 09/18] ARM: mvebu: a39x: enable the thermal sensor in Armada-39x SoCs Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 9:52 ` Gregory CLEMENT
2016-07-28 9:52 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 10/18] ARM: mvebu: a39x: enable watchdog for all " Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 10:18 ` Gregory CLEMENT
2016-07-28 10:18 ` Gregory CLEMENT
2016-07-28 10:18 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 11/18] ARM: mvebu: a39x: add missing nodes describing GPIO's Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 10:25 ` Gregory CLEMENT
2016-07-28 10:25 ` Gregory CLEMENT
2016-07-28 10:25 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 12/18] ARM: mvebu: a39x: add missing nodes describing USB2.0 and USB3.0 Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 10:34 ` Gregory CLEMENT
2016-07-28 10:34 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 13/18] ARM: mvebu: a39x: enable rtc for all Armada-39x SoCs Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 10:53 ` Gregory CLEMENT
2016-07-28 10:53 ` Gregory CLEMENT
2016-07-28 10:53 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-21 22:16 ` Rob Herring
2016-07-21 22:16 ` Rob Herring
2016-07-22 9:10 ` Grzegorz Jaszczyk
2016-07-22 9:10 ` Grzegorz Jaszczyk
2016-07-22 9:10 ` Grzegorz Jaszczyk
2016-07-25 13:47 ` Rob Herring
2016-07-25 13:47 ` Rob Herring
2016-07-25 13:47 ` Rob Herring
2016-07-25 13:50 ` Thomas Petazzoni [this message]
2016-07-25 13:50 ` Thomas Petazzoni
2016-07-25 13:50 ` Thomas Petazzoni
2016-07-25 15:12 ` Rob Herring
2016-07-25 15:12 ` Rob Herring
2016-07-25 15:12 ` Rob Herring
2016-07-25 18:22 ` Thomas Petazzoni
2016-07-25 18:22 ` Thomas Petazzoni
2016-07-25 18:22 ` Thomas Petazzoni
2016-07-28 11:19 ` Gregory CLEMENT
2016-07-28 11:19 ` Gregory CLEMENT
2016-07-28 11:19 ` Gregory CLEMENT
2016-07-28 15:59 ` Rob Herring
2016-07-28 15:59 ` Rob Herring
2016-07-28 15:59 ` Rob Herring
2016-07-21 12:44 ` [PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing interfaces Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 12:55 ` Gregory CLEMENT
2016-07-28 12:55 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 16/18] ARM: mvebu: a398-db: enable supported usb interfaces Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 12:55 ` Gregory CLEMENT
2016-07-28 12:55 ` Gregory CLEMENT
2016-07-28 12:55 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 17/18] ARM: mvebu: a390-db: add support for the Armada 390 DB board Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 13:01 ` Gregory CLEMENT
2016-07-28 13:01 ` Gregory CLEMENT
2016-07-28 13:01 ` Gregory CLEMENT
2016-07-21 12:44 ` [PATCH 18/18] ARM: mvebu: a395-gp: add support for the Armada 395 GP Board Grzegorz Jaszczyk
2016-07-21 12:44 ` Grzegorz Jaszczyk
2016-07-28 13:15 ` Gregory CLEMENT
2016-07-28 13:15 ` Gregory CLEMENT
2016-07-21 13:43 ` [PATCH 00/18] ARM: mvebu: misc Armada 38x/39x DT and v7 defconfig improvements Andrew Lunn
2016-07-21 13:43 ` Andrew Lunn
2016-07-22 7:51 ` Grzegorz Jaszczyk
2016-07-22 7:51 ` Grzegorz Jaszczyk
2016-07-22 7:51 ` Grzegorz Jaszczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725155050.3aee974e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mw@semihalf.com \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.