All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus
Date: Thu, 28 Jul 2016 20:17:57 +0200	[thread overview]
Message-ID: <20160728181757.GD6682@lukather> (raw)
In-Reply-To: <74d3b5eb-601a-cc1d-a44e-fea2895fd8b2-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Hi Hans,

On Tue, Jul 26, 2016 at 11:07:23PM +0200, Hans de Goede wrote:
> >>>Nothing prevents you from including the orange pi pc dts, from the
> >>>orange pi plus dts.
> >>>
> >>>It prevents the duplication you were trying to avoid, and it doesn't
> >>>create all those spurious errors and devices.
> >>
> >>That would solve the copy paste problem on the kernel side, but that
> >>would still mean adding a new u-boot defconfig for this, which means that
> >>all the distro's which ship with prebuild u-boot binaries need to build
> >>for yet another board, something which I would like to avoid.
> >
> >Still, registering devices that are not present on the board is not an
> >option.
> 
> Ok, new version send.
> 
> What about the other 3 patches in this series ?

I guess the same comment applies for patch 2.

I'll look at the two others.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus
Date: Thu, 28 Jul 2016 20:17:57 +0200	[thread overview]
Message-ID: <20160728181757.GD6682@lukather> (raw)
In-Reply-To: <74d3b5eb-601a-cc1d-a44e-fea2895fd8b2@redhat.com>

Hi Hans,

On Tue, Jul 26, 2016 at 11:07:23PM +0200, Hans de Goede wrote:
> >>>Nothing prevents you from including the orange pi pc dts, from the
> >>>orange pi plus dts.
> >>>
> >>>It prevents the duplication you were trying to avoid, and it doesn't
> >>>create all those spurious errors and devices.
> >>
> >>That would solve the copy paste problem on the kernel side, but that
> >>would still mean adding a new u-boot defconfig for this, which means that
> >>all the distro's which ship with prebuild u-boot binaries need to build
> >>for yet another board, something which I would like to avoid.
> >
> >Still, registering devices that are not present on the board is not an
> >option.
> 
> Ok, new version send.
> 
> What about the other 3 patches in this series ?

I guess the same comment applies for patch 2.

I'll look at the two others.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160728/24e766f1/attachment.sig>

  parent reply	other threads:[~2016-07-28 18:17 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09 20:21 [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus Hans de Goede
2016-07-09 20:21 ` Hans de Goede
     [not found] ` <1468095718-18515-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-09 20:21   ` [PATCH 2/4] ARM: dts: sun8i: Extend Orange Pi Plus dt to also handle the Plus 2E Hans de Goede
2016-07-09 20:21     ` Hans de Goede
2016-07-09 20:21   ` [PATCH 3/4] ARM: dts: sun8i: Add ethernet1 alias to Orange Pi 2 dts Hans de Goede
2016-07-09 20:21     ` Hans de Goede
     [not found]     ` <1468095718-18515-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-28 18:20       ` Maxime Ripard
2016-07-28 18:20         ` Maxime Ripard
2016-07-09 20:21   ` [PATCH 4/4] ARM: dts: sun8i: Add dts file for the Orange Pi Lite SBC Hans de Goede
2016-07-09 20:21     ` Hans de Goede
     [not found]     ` <1468095718-18515-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-28 18:21       ` Maxime Ripard
2016-07-28 18:21         ` Maxime Ripard
2016-07-13  8:45   ` [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus Maxime Ripard
2016-07-13  8:45     ` Maxime Ripard
2016-07-13 10:01     ` Hans de Goede
2016-07-13 10:01       ` Hans de Goede
     [not found]       ` <bce2b340-a930-8771-4560-dc61bf5828d5-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-25  6:40         ` Maxime Ripard
2016-07-25  6:40           ` Maxime Ripard
2016-07-26 21:00           ` Hans de Goede
2016-07-26 21:00             ` Hans de Goede
2016-07-26 21:07           ` Hans de Goede
2016-07-26 21:07             ` Hans de Goede
     [not found]             ` <74d3b5eb-601a-cc1d-a44e-fea2895fd8b2-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-28 18:17               ` Maxime Ripard [this message]
2016-07-28 18:17                 ` Maxime Ripard
2016-07-28 20:36                 ` Hans de Goede
2016-07-28 20:36                   ` Hans de Goede
     [not found]                   ` <f71f9d2b-00d4-27b8-1535-1ddc58f04ca3-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-08-07 14:25                     ` Hans de Goede
2016-08-07 14:25                       ` Hans de Goede
     [not found]                       ` <b6636083-917e-cc3a-9107-401fbd483fb7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-08-26 18:45                         ` Hans de Goede
2016-08-26 18:45                           ` Hans de Goede
2016-08-31 16:28                       ` Maxime Ripard
2016-08-31 16:28                         ` Maxime Ripard
2016-09-03 11:05                         ` Hans de Goede
2016-09-03 11:05                           ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160728181757.GD6682@lukather \
    --to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.