* [PATCH 2/3] nvme-fabrics: revise host transport option descriptions
@ 2016-07-29 0:00 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2016-07-29 0:00 UTC (permalink / raw)
To: linux-nvme, linux-scsi
Revise some of the comments so not so ethernet-network centric
Signed-off-by: James Smart <james.smart@broadcom.com>
---
drivers/nvme/host/fabrics.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/fabrics.h b/drivers/nvme/host/fabrics.h
index 89df52c..2755efd 100644
--- a/drivers/nvme/host/fabrics.h
+++ b/drivers/nvme/host/fabrics.h
@@ -64,9 +64,10 @@ enum {
* being added.
* @subsysnqn: Hold the fully qualified NQN subystem name (format defined
* in the NVMe specification, "NVMe Qualified Names").
- * @traddr: network address that will be used by the host to communicate
- * to the added NVMe controller.
- * @trsvcid: network port used for host-controller communication.
+ * @traddr: The transport-specific TRADDR field for a port on the
+ * subsystem which is adding a controller.
+ * @trsvcid: The transport-specific TRSVCID field for a port on the
+ * subsystem which is adding a controller.
* @queue_size: Number of IO queue elements.
* @nr_io_queues: Number of controller IO queues that will be established.
* @reconnect_delay: Time between two consecutive reconnect attempts.
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] nvme-fabrics: revise host transport option descriptions
@ 2016-07-29 0:00 ` James Smart
0 siblings, 0 replies; 6+ messages in thread
From: James Smart @ 2016-07-29 0:00 UTC (permalink / raw)
Revise some of the comments so not so ethernet-network centric
Signed-off-by: James Smart <james.smart at broadcom.com>
---
drivers/nvme/host/fabrics.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/nvme/host/fabrics.h b/drivers/nvme/host/fabrics.h
index 89df52c..2755efd 100644
--- a/drivers/nvme/host/fabrics.h
+++ b/drivers/nvme/host/fabrics.h
@@ -64,9 +64,10 @@ enum {
* being added.
* @subsysnqn: Hold the fully qualified NQN subystem name (format defined
* in the NVMe specification, "NVMe Qualified Names").
- * @traddr: network address that will be used by the host to communicate
- * to the added NVMe controller.
- * @trsvcid: network port used for host-controller communication.
+ * @traddr: The transport-specific TRADDR field for a port on the
+ * subsystem which is adding a controller.
+ * @trsvcid: The transport-specific TRSVCID field for a port on the
+ * subsystem which is adding a controller.
* @queue_size: Number of IO queue elements.
* @nr_io_queues: Number of controller IO queues that will be established.
* @reconnect_delay: Time between two consecutive reconnect attempts.
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] nvme-fabrics: revise host transport option descriptions
2016-07-29 0:00 ` James Smart
@ 2016-07-29 8:54 ` Johannes Thumshirn
-1 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2016-07-29 8:54 UTC (permalink / raw)
To: James Smart; +Cc: linux-nvme, linux-scsi
On Thu, Jul 28, 2016 at 05:00:26PM -0700, James Smart wrote:
>
> Revise some of the comments so not so ethernet-network centric
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
Acked-by: Johannes Thumshirn <jth@kernel.org>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] nvme-fabrics: revise host transport option descriptions
@ 2016-07-29 8:54 ` Johannes Thumshirn
0 siblings, 0 replies; 6+ messages in thread
From: Johannes Thumshirn @ 2016-07-29 8:54 UTC (permalink / raw)
On Thu, Jul 28, 2016@05:00:26PM -0700, James Smart wrote:
>
> Revise some of the comments so not so ethernet-network centric
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
Acked-by: Johannes Thumshirn <jth at kernel.org>
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] nvme-fabrics: revise host transport option descriptions
2016-07-29 0:00 ` James Smart
@ 2016-08-01 11:20 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-08-01 11:20 UTC (permalink / raw)
To: James Smart; +Cc: linux-nvme, linux-scsi
On Thu, Jul 28, 2016 at 05:00:26PM -0700, James Smart wrote:
>
> Revise some of the comments so not so ethernet-network centric
>
> Signed-off-by: James Smart <james.smart@broadcom.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] nvme-fabrics: revise host transport option descriptions
@ 2016-08-01 11:20 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2016-08-01 11:20 UTC (permalink / raw)
On Thu, Jul 28, 2016@05:00:26PM -0700, James Smart wrote:
>
> Revise some of the comments so not so ethernet-network centric
>
> Signed-off-by: James Smart <james.smart at broadcom.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-01 12:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-29 0:00 [PATCH 2/3] nvme-fabrics: revise host transport option descriptions James Smart
2016-07-29 0:00 ` James Smart
2016-07-29 8:54 ` Johannes Thumshirn
2016-07-29 8:54 ` Johannes Thumshirn
2016-08-01 11:20 ` Christoph Hellwig
2016-08-01 11:20 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.