* [PATCH -next] fcoe: add missing destroy_workqueue() on error in fcoe_init()
@ 2016-07-29 15:54 Wei Yongjun
[not found] ` <1469807688-32470-1-git-send-email-weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-02 5:18 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-07-29 15:54 UTC (permalink / raw)
To: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen
Cc: Wei Yongjun, fcoe-devel, linux-scsi
Add the missing destroy_workqueue() before return from fcoe_init()
in the fcoe transport register failed error handling case.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/scsi/fcoe/fcoe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index 197dc62..9bd41a3 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2495,7 +2495,7 @@ static int __init fcoe_init(void)
if (rc) {
printk(KERN_ERR "failed to register an fcoe transport, check "
"if libfcoe is loaded\n");
- return rc;
+ goto out_destroy;
}
mutex_lock(&fcoe_config_mutex);
@@ -2518,6 +2518,7 @@ static int __init fcoe_init(void)
out_free:
mutex_unlock(&fcoe_config_mutex);
+out_destroy:
destroy_workqueue(fcoe_wq);
return rc;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fcoe: add missing destroy_workqueue() on error in fcoe_init()
[not found] ` <1469807688-32470-1-git-send-email-weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-08-01 8:21 ` Johannes Thumshirn
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2016-08-01 8:21 UTC (permalink / raw)
To: Wei Yongjun
Cc: fcoe-devel-s9riP+hp16TNLxjTenLetw, Johannes Thumshirn,
James E.J. Bottomley, linux-scsi-u79uwXL29TY76Z2rM5mHXA,
Martin K. Petersen
On Fri, Jul 29, 2016 at 03:54:48PM +0000, Wei Yongjun wrote:
> Add the missing destroy_workqueue() before return from fcoe_init()
> in the fcoe transport register failed error handling case.
>
> Signed-off-by: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Johannes Thumshirn <jth-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
Johannes Thumshirn Storage
jthumshirn-l3A5Bk7waGM@public.gmane.org +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fcoe: add missing destroy_workqueue() on error in fcoe_init()
2016-07-29 15:54 [PATCH -next] fcoe: add missing destroy_workqueue() on error in fcoe_init() Wei Yongjun
[not found] ` <1469807688-32470-1-git-send-email-weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2016-08-02 5:18 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-08-02 5:18 UTC (permalink / raw)
To: Wei Yongjun
Cc: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen,
fcoe-devel, linux-scsi
>>>>> "Wei" == Wei Yongjun <weiyj.lk@gmail.com> writes:
Wei> Add the missing destroy_workqueue() before return from fcoe_init()
Wei> in the fcoe transport register failed error handling case.
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-02 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-29 15:54 [PATCH -next] fcoe: add missing destroy_workqueue() on error in fcoe_init() Wei Yongjun
[not found] ` <1469807688-32470-1-git-send-email-weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-01 8:21 ` Johannes Thumshirn
2016-08-02 5:18 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.