All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
@ 2016-08-01 10:06 Paul Burton
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle Paul Burton
                   ` (11 more replies)
  0 siblings, 12 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:06 UTC (permalink / raw)
  To: u-boot

This series introduces initial support for the MIPS Boston, and FPGA
based development board & successor to the older Malta board. Further
peripheral work is needed but this introduces the basics.

This can be tested in a currently out-of-tree QEMU port if desired,
which can be found in the boston branch of:

  git://git.linux-mips.org/pub/scm/paul/qemu.git

QEMU can be used to run U-Boot like this:

  ./configure --target-list=mips64el-softmmu
  make
  ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
    -bios u-boot.bin -serial stdio

Paul Burton (11):
  serial: ns16550: Support clocks via phandle
  dt-bindings: Add interrupt-controller/mips-gic.h header
  pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge
  pci: Flip condition for detecting non-PCI parent devices
  net: pch_gbe: Use dm_pci_map_bar to discover MMIO base
  net: pch_gbe: Make 64 bit safe
  dm: regmap: Implement simple regmap_read & regmap_write
  dm: core: Match compatible strings in order of priority
  dm: syscon: Provide a generic syscon driver
  clk: boston: Providea simple driver for Boston board clocks
  boston: Introduce support for the MIPS Boston development board

 arch/mips/Kconfig                                  |  16 ++
 arch/mips/dts/Makefile                             |   1 +
 arch/mips/dts/img,boston.dts                       | 216 ++++++++++++++++++++
 board/imgtec/boston/Kconfig                        |  16 ++
 board/imgtec/boston/MAINTAINERS                    |   6 +
 board/imgtec/boston/Makefile                       |   9 +
 board/imgtec/boston/boston-lcd.h                   |  21 ++
 board/imgtec/boston/boston-regs.h                  |  47 +++++
 board/imgtec/boston/checkboard.c                   |  29 +++
 board/imgtec/boston/ddr.c                          |  30 +++
 board/imgtec/boston/lowlevel_init.S                |  56 ++++++
 configs/boston32r2_defconfig                       |  40 ++++
 configs/boston32r2el_defconfig                     |  41 ++++
 configs/boston64r2_defconfig                       |  40 ++++
 configs/boston64r2el_defconfig                     |  41 ++++
 doc/README.boston                                  |  39 ++++
 drivers/clk/Kconfig                                |   8 +
 drivers/clk/Makefile                               |   1 +
 drivers/clk/clk_boston.c                           |  97 +++++++++
 drivers/core/lists.c                               |  83 ++++----
 drivers/core/regmap.c                              |  20 ++
 drivers/core/syscon-uclass.c                       |  11 ++
 drivers/net/pch_gbe.c                              |  28 ++-
 drivers/pci/Kconfig                                |   7 +
 drivers/pci/Makefile                               |   1 +
 drivers/pci/pci-uclass.c                           |   2 +-
 drivers/pci/pcie_xilinx.c                          | 219 +++++++++++++++++++++
 drivers/serial/ns16550.c                           |  19 +-
 include/configs/boston.h                           |  68 +++++++
 include/dt-bindings/clock/boston-clock.h           |  13 ++
 .../dt-bindings/interrupt-controller/mips-gic.h    |   9 +
 31 files changed, 1173 insertions(+), 61 deletions(-)
 create mode 100644 arch/mips/dts/img,boston.dts
 create mode 100644 board/imgtec/boston/Kconfig
 create mode 100644 board/imgtec/boston/MAINTAINERS
 create mode 100644 board/imgtec/boston/Makefile
 create mode 100644 board/imgtec/boston/boston-lcd.h
 create mode 100644 board/imgtec/boston/boston-regs.h
 create mode 100644 board/imgtec/boston/checkboard.c
 create mode 100644 board/imgtec/boston/ddr.c
 create mode 100644 board/imgtec/boston/lowlevel_init.S
 create mode 100644 configs/boston32r2_defconfig
 create mode 100644 configs/boston32r2el_defconfig
 create mode 100644 configs/boston64r2_defconfig
 create mode 100644 configs/boston64r2el_defconfig
 create mode 100644 doc/README.boston
 create mode 100644 drivers/clk/clk_boston.c
 create mode 100644 drivers/pci/pcie_xilinx.c
 create mode 100644 include/configs/boston.h
 create mode 100644 include/dt-bindings/clock/boston-clock.h
 create mode 100644 include/dt-bindings/interrupt-controller/mips-gic.h

-- 
2.9.0

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
@ 2016-08-01 10:06 ` Paul Burton
  2016-08-04  9:50   ` Michal Simek
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 02/11] dt-bindings: Add interrupt-controller/mips-gic.h header Paul Burton
                   ` (10 subsequent siblings)
  11 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:06 UTC (permalink / raw)
  To: u-boot

Previously ns16550 compatible UARTs probed via device tree have needed
their device tree nodes to contain a clock-frequency property. An
alternative to this commonly used with Linux is to reference a clock via
a phandle. This patch allows U-Boot to support that, retrieving the
clock frequency by probing the appropriate clock device.

For example, a system might choose to provide the UART base clock as a
reference to a clock common to multiple devices:

  sys_clk: clock {
    compatible = "fixed-clock";
    #clock-cells = <0>;
    clock-frequency = <10000000>;
  };

  uart0: uart at 10000000 {
    compatible = "ns16550a";
    reg = <0x10000000 0x1000>;
    clocks = <&sys_clk>;
  };

  uart1: uart at 10000000 {
    compatible = "ns16550a";
    reg = <0x10001000 0x1000>;
    clocks = <&sys_clk>;
  };

This removes the need for the frequency information to be duplicated in
multiple nodes and allows the device tree to be more descriptive of the
system.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v4: None
Changes in v3: None
Changes in v2:
- Propogate non-ENODEV errors from clk_get_by_index

 drivers/serial/ns16550.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 88fca15..37da3ed 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -5,6 +5,7 @@
  */
 
 #include <common.h>
+#include <clk.h>
 #include <dm.h>
 #include <errno.h>
 #include <fdtdec.h>
@@ -352,6 +353,8 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
 {
 	struct ns16550_platdata *plat = dev->platdata;
 	fdt_addr_t addr;
+	struct clk clk;
+	int err;
 
 	/* try Processor Local Bus device first */
 	addr = dev_get_addr(dev);
@@ -397,9 +400,19 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
 				     "reg-offset", 0);
 	plat->reg_shift = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
 					 "reg-shift", 0);
-	plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
-				     "clock-frequency",
-				     CONFIG_SYS_NS16550_CLK);
+
+	err = clk_get_by_index(dev, 0, &clk);
+	if (!err) {
+		plat->clock = clk_get_rate(&clk);
+	} else if (err != -ENODEV) {
+		debug("ns16550 failed to get clock\n");
+		return err;
+	}
+
+	if (!plat->clock)
+		plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
+					     "clock-frequency",
+					     CONFIG_SYS_NS16550_CLK);
 	if (!plat->clock) {
 		debug("ns16550 clock not defined\n");
 		return -EINVAL;
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 02/11] dt-bindings: Add interrupt-controller/mips-gic.h header
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle Paul Burton
@ 2016-08-01 10:06 ` Paul Burton
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge Paul Burton
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:06 UTC (permalink / raw)
  To: u-boot

Import a copy of the dt-bindings/interrupt-controller/mips-gic.h header
from Linux, such that we can use device trees which include it without
modification.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

Changes in v4: None
Changes in v3: None
Changes in v2: None

 include/dt-bindings/interrupt-controller/mips-gic.h | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 include/dt-bindings/interrupt-controller/mips-gic.h

diff --git a/include/dt-bindings/interrupt-controller/mips-gic.h b/include/dt-bindings/interrupt-controller/mips-gic.h
new file mode 100644
index 0000000..cf35a57
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/mips-gic.h
@@ -0,0 +1,9 @@
+#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_MIPS_GIC_H
+#define _DT_BINDINGS_INTERRUPT_CONTROLLER_MIPS_GIC_H
+
+#include <dt-bindings/interrupt-controller/irq.h>
+
+#define GIC_SHARED 0
+#define GIC_LOCAL 1
+
+#endif
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle Paul Burton
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 02/11] dt-bindings: Add interrupt-controller/mips-gic.h header Paul Burton
@ 2016-08-01 10:06 ` Paul Burton
  2016-08-04  9:54   ` Michal Simek
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 04/11] pci: Flip condition for detecting non-PCI parent devices Paul Burton
                   ` (8 subsequent siblings)
  11 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:06 UTC (permalink / raw)
  To: u-boot

This patch adds a driver for the Xilinx AXI bridge for PCI express, an
IP block which can be used on some generations of Xilinx FPGAs. This is
mostly a case of implementing PCIe ECAM specification, but with some
quirks about what devices are valid to access.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v4: None
Changes in v3: None
Changes in v2:
- Clean up error returns & documentation

 drivers/pci/Kconfig       |   7 ++
 drivers/pci/Makefile      |   1 +
 drivers/pci/pcie_xilinx.c | 219 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 227 insertions(+)
 create mode 100644 drivers/pci/pcie_xilinx.c

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index 26aa2b0..1f9ea66 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -38,4 +38,11 @@ config PCI_TEGRA
 	  with a total of 5 lanes. Some boards require this for Ethernet
 	  support to work (e.g. beaver, jetson-tk1).
 
+config PCI_XILINX
+	bool "Xilinx AXI Bridge for PCI Express"
+	depends on DM_PCI
+	help
+	  Enable support for the Xilinx AXI bridge for PCI express, an IP block
+	  which can be used on some generations of Xilinx FPGAs.
+
 endmenu
diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
index f8be9bf..9583e91 100644
--- a/drivers/pci/Makefile
+++ b/drivers/pci/Makefile
@@ -31,3 +31,4 @@ obj-$(CONFIG_PCI_TEGRA) += pci_tegra.o
 obj-$(CONFIG_TSI108_PCI) += tsi108_pci.o
 obj-$(CONFIG_WINBOND_83C553) += w83c553f.o
 obj-$(CONFIG_PCIE_LAYERSCAPE) += pcie_layerscape.o
+obj-$(CONFIG_PCI_XILINX) += pcie_xilinx.o
diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c
new file mode 100644
index 0000000..9fe02be
--- /dev/null
+++ b/drivers/pci/pcie_xilinx.c
@@ -0,0 +1,219 @@
+/*
+ * Xilinx AXI Bridge for PCI Express Driver
+ *
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <pci.h>
+
+#include <asm/io.h>
+
+/**
+ * struct xilinx_pcie - Xilinx PCIe controller state
+ * @hose: The parent classes PCI controller state
+ * @cfg_base: The base address of memory mapped configuration space
+ */
+struct xilinx_pcie {
+	struct pci_controller hose;
+	void *cfg_base;
+};
+
+/* Register definitions */
+#define XILINX_PCIE_REG_PSCR		0x144
+#define XILINX_PCIE_REG_PSCR_LNKUP	BIT(11)
+
+/**
+ * pcie_xilinx_link_up() - Check whether the PCIe link is up
+ * @pcie: Pointer to the PCI controller state
+ *
+ * Checks whether the PCIe link for the given device is up or down.
+ *
+ * Return: true if the link is up, else false
+ */
+static bool pcie_xilinx_link_up(struct xilinx_pcie *pcie)
+{
+	uint32_t pscr = __raw_readl(pcie->cfg_base + XILINX_PCIE_REG_PSCR);
+
+	return pscr & XILINX_PCIE_REG_PSCR_LNKUP;
+}
+
+/**
+ * pcie_xilinx_config_address() - Calculate the address of a config access
+ * @pcie: Pointer to the PCI controller state
+ * @bdf: Identifies the PCIe device to access
+ * @offset: The offset into the device's configuration space
+ * @paddress: Pointer to the pointer to write the calculates address to
+ *
+ * Calculates the address that should be accessed to perform a PCIe
+ * configuration space access for a given device identified by the PCIe
+ * controller device @pcie and the bus, device & function numbers in @bdf. If
+ * access to the device is not valid then the function will return an error
+ * code. Otherwise the address to access will be written to the pointer pointed
+ * to by @paddress.
+ *
+ * Return: 0 on success, else -ENODEV
+ */
+static int pcie_xilinx_config_address(struct xilinx_pcie *pcie, pci_dev_t bdf,
+				      uint offset, void **paddress)
+{
+	unsigned int bus = PCI_BUS(bdf);
+	unsigned int dev = PCI_DEV(bdf);
+	unsigned int func = PCI_FUNC(bdf);
+	void *addr;
+
+	if ((bus > 0) && !pcie_xilinx_link_up(pcie))
+		return -ENODEV;
+
+	/*
+	 * Busses 0 (host-PCIe bridge) & 1 (its immediate child) are
+	 * limited to a single device each.
+	 */
+	if ((bus < 2) && (dev > 0))
+		return -ENODEV;
+
+	addr = pcie->cfg_base;
+	addr += bus << 20;
+	addr += dev << 15;
+	addr += func << 12;
+	addr += offset;
+	*paddress = addr;
+
+	return 0;
+}
+
+/**
+ * pcie_xilinx_read_config() - Read from configuration space
+ * @pcie: Pointer to the PCI controller state
+ * @bdf: Identifies the PCIe device to access
+ * @offset: The offset into the device's configuration space
+ * @valuep: A pointer@which to store the read value
+ * @size: Indicates the size of access to perform
+ *
+ * Read a value of size @size from offset @offset within the configuration
+ * space of the device identified by the bus, device & function numbers in @bdf
+ * on the PCI bus @bus.
+ *
+ * Return: 0 on success, else -ENODEV or -EINVAL
+ */
+static int pcie_xilinx_read_config(struct udevice *bus, pci_dev_t bdf,
+				   uint offset, ulong *valuep,
+				   enum pci_size_t size)
+{
+	struct xilinx_pcie *pcie = dev_get_priv(bus);
+	void *address;
+	int err;
+
+	err = pcie_xilinx_config_address(pcie, bdf, offset, &address);
+	if (err < 0) {
+		*valuep = pci_get_ff(size);
+		return 0;
+	}
+
+	switch (size) {
+	case PCI_SIZE_8:
+		*valuep = __raw_readb(address);
+		return 0;
+	case PCI_SIZE_16:
+		*valuep = __raw_readw(address);
+		return 0;
+	case PCI_SIZE_32:
+		*valuep = __raw_readl(address);
+		return 0;
+	default:
+		return -EINVAL;
+	}
+}
+
+/**
+ * pcie_xilinx_write_config() - Write to configuration space
+ * @pcie: Pointer to the PCI controller state
+ * @bdf: Identifies the PCIe device to access
+ * @offset: The offset into the device's configuration space
+ * @value: The value to write
+ * @size: Indicates the size of access to perform
+ *
+ * Write the value @value of size @size from offset @offset within the
+ * configuration space of the device identified by the bus, device & function
+ * numbers in @bdf on the PCI bus @bus.
+ *
+ * Return: 0 on success, else -ENODEV or -EINVAL
+ */
+static int pcie_xilinx_write_config(struct udevice *bus, pci_dev_t bdf,
+				    uint offset, ulong value,
+				    enum pci_size_t size)
+{
+	struct xilinx_pcie *pcie = dev_get_priv(bus);
+	void *address;
+	int err;
+
+	err = pcie_xilinx_config_address(pcie, bdf, offset, &address);
+	if (err < 0)
+		return 0;
+
+	switch (size) {
+	case PCI_SIZE_8:
+		__raw_writeb(value, address);
+		return 0;
+	case PCI_SIZE_16:
+		__raw_writew(value, address);
+		return 0;
+	case PCI_SIZE_32:
+		__raw_writel(value, address);
+		return 0;
+	default:
+		return -EINVAL;
+	}
+}
+
+/**
+ * pcie_xilinx_ofdata_to_platdata() - Translate from DT to device state
+ * @dev: A pointer to the device being operated on
+ *
+ * Translate relevant data from the device tree pertaining to device @dev into
+ * state that the driver will later make use of. This state is stored in the
+ * device's private data structure.
+ *
+ * Return: 0 on success, else -EINVAL
+ */
+static int pcie_xilinx_ofdata_to_platdata(struct udevice *dev)
+{
+	struct xilinx_pcie *pcie = dev_get_priv(dev);
+	struct fdt_resource reg_res;
+	DECLARE_GLOBAL_DATA_PTR;
+	int err;
+
+	err = fdt_get_resource(gd->fdt_blob, dev->of_offset, "reg",
+			       0, &reg_res);
+	if (err < 0) {
+		error("\"reg\" resource not found\n");
+		return err;
+	}
+
+	pcie->cfg_base = ioremap_nocache(reg_res.start,
+					 fdt_resource_size(&reg_res));
+
+	return 0;
+}
+
+static const struct dm_pci_ops pcie_xilinx_ops = {
+	.read_config	= pcie_xilinx_read_config,
+	.write_config	= pcie_xilinx_write_config,
+};
+
+static const struct udevice_id pcie_xilinx_ids[] = {
+	{ .compatible = "xlnx,axi-pcie-host-1.00.a" },
+	{ }
+};
+
+U_BOOT_DRIVER(pcie_xilinx) = {
+	.name			= "pcie_xilinx",
+	.id			= UCLASS_PCI,
+	.of_match		= pcie_xilinx_ids,
+	.ops			= &pcie_xilinx_ops,
+	.ofdata_to_platdata	= pcie_xilinx_ofdata_to_platdata,
+	.priv_auto_alloc_size	= sizeof(struct xilinx_pcie),
+};
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 04/11] pci: Flip condition for detecting non-PCI parent devices
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (2 preceding siblings ...)
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge Paul Burton
@ 2016-08-01 10:06 ` Paul Burton
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 05/11] net: pch_gbe: Use dm_pci_map_bar to discover MMIO base Paul Burton
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:06 UTC (permalink / raw)
  To: u-boot

In pci_uclass_pre_probe an attempt is made to detect whether the parent
of a device is a PCI device and that the device is thus a bridge. This
was being done by checking whether the parent of the device is of the
UCLASS_ROOT class. This causes problems if the PCI controller is a child
of some other non-PCI node, for example a simple-bus node.

For example, if the device tree contains something like the following
then pci_uclass_pre_probe would incorrectly believe that the PCI
controller is a bridge, with a PCI parent:

  / {
    some_child {
      compatible = "simple-bus";
      #address-cells = <1>;
      #size-cells = <1>;
      ranges = <>;

      pci_controller: pci at 10000000 {
        compatible = "my-pci-controller";
        device_type = "pci";
        reg = <0x10000000 0x2000000>;
      };
    };
  };

Avoid this incorrect detection of bridges by instead checking whether
the parent devices class is UCLASS_PCI and treating a device as a bridge
when this is true, making use of device_is_on_pci_bus to perform this
test.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v4: None
Changes in v3: None
Changes in v2:
- Use device_is_on_pci_bus instead of effectively open-coding it

 drivers/pci/pci-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index 32590ce..b9b55e2 100644
--- a/drivers/pci/pci-uclass.c
+++ b/drivers/pci/pci-uclass.c
@@ -859,7 +859,7 @@ static int pci_uclass_pre_probe(struct udevice *bus)
 	hose = bus->uclass_priv;
 
 	/* For bridges, use the top-level PCI controller */
-	if (device_get_uclass_id(bus->parent) == UCLASS_ROOT) {
+	if (!device_is_on_pci_bus(bus)) {
 		hose->ctlr = bus;
 		ret = decode_regions(hose, gd->fdt_blob, bus->parent->of_offset,
 				bus->of_offset);
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 05/11] net: pch_gbe: Use dm_pci_map_bar to discover MMIO base
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (3 preceding siblings ...)
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 04/11] pci: Flip condition for detecting non-PCI parent devices Paul Burton
@ 2016-08-01 10:06 ` Paul Burton
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 06/11] net: pch_gbe: Make 64 bit safe Paul Burton
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:06 UTC (permalink / raw)
  To: u-boot

Reading the PCI BAR & converting the result to a physical address is not
safe across all architectures. For example on MIPS the virtual:physical
mapping is not 1:1, so we cannot directly make use of the physical
address.

Use the more generic BAR-mapping function dm_pci_map_bar to discover the
MMIO base address, which should work across architectures.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/net/pch_gbe.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/pch_gbe.c b/drivers/net/pch_gbe.c
index 137818b..2d0a700 100644
--- a/drivers/net/pch_gbe.c
+++ b/drivers/net/pch_gbe.c
@@ -421,7 +421,7 @@ int pch_gbe_probe(struct udevice *dev)
 {
 	struct pch_gbe_priv *priv;
 	struct eth_pdata *plat = dev_get_platdata(dev);
-	u32 iobase;
+	void *iobase;
 
 	/*
 	 * The priv structure contains the descriptors and frame buffers which
@@ -432,11 +432,9 @@ int pch_gbe_probe(struct udevice *dev)
 
 	priv->dev = dev;
 
-	dm_pci_read_config32(dev, PCI_BASE_ADDRESS_1, &iobase);
-	iobase &= PCI_BASE_ADDRESS_MEM_MASK;
-	iobase = dm_pci_mem_to_phys(dev, iobase);
+	iobase = dm_pci_map_bar(dev, PCI_BASE_ADDRESS_1, PCI_REGION_MEM);
 
-	plat->iobase = iobase;
+	plat->iobase = (ulong)iobase;
 	priv->mac_regs = (struct pch_gbe_regs *)iobase;
 
 	/* Read MAC address from SROM and initialize dev->enetaddr with it */
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 06/11] net: pch_gbe: Make 64 bit safe
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (4 preceding siblings ...)
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 05/11] net: pch_gbe: Use dm_pci_map_bar to discover MMIO base Paul Burton
@ 2016-08-01 10:07 ` Paul Burton
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 07/11] dm: regmap: Implement simple regmap_read & regmap_write Paul Burton
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:07 UTC (permalink / raw)
  To: u-boot

The pch_gbe driver previously casted pointers to & from unsigned 32 bit
integers in many locations. This breaks the driver on 64 bit systems,
producing streams of compiler warnings about mismatched pointer &
integer sizes and then failing to keep track of addresses correctly at
runtime.

Fix the driver for 64 bit systems by using unsigned longs in place of
the previously used 32 bit integers.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/net/pch_gbe.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/pch_gbe.c b/drivers/net/pch_gbe.c
index 2d0a700..d40fff0 100644
--- a/drivers/net/pch_gbe.c
+++ b/drivers/net/pch_gbe.c
@@ -118,14 +118,14 @@ static void pch_gbe_rx_descs_init(struct udevice *dev)
 	memset(rx_desc, 0, sizeof(struct pch_gbe_rx_desc) * PCH_GBE_DESC_NUM);
 	for (i = 0; i < PCH_GBE_DESC_NUM; i++)
 		rx_desc->buffer_addr = dm_pci_phys_to_mem(priv->dev,
-			(u32)(priv->rx_buff[i]));
+			(ulong)(priv->rx_buff[i]));
 
-	writel(dm_pci_phys_to_mem(priv->dev, (u32)rx_desc),
+	writel(dm_pci_phys_to_mem(priv->dev, (ulong)rx_desc),
 	       &mac_regs->rx_dsc_base);
 	writel(sizeof(struct pch_gbe_rx_desc) * (PCH_GBE_DESC_NUM - 1),
 	       &mac_regs->rx_dsc_size);
 
-	writel(dm_pci_phys_to_mem(priv->dev, (u32)(rx_desc + 1)),
+	writel(dm_pci_phys_to_mem(priv->dev, (ulong)(rx_desc + 1)),
 	       &mac_regs->rx_dsc_sw_p);
 }
 
@@ -137,11 +137,11 @@ static void pch_gbe_tx_descs_init(struct udevice *dev)
 
 	memset(tx_desc, 0, sizeof(struct pch_gbe_tx_desc) * PCH_GBE_DESC_NUM);
 
-	writel(dm_pci_phys_to_mem(priv->dev, (u32)tx_desc),
+	writel(dm_pci_phys_to_mem(priv->dev, (ulong)tx_desc),
 	       &mac_regs->tx_dsc_base);
 	writel(sizeof(struct pch_gbe_tx_desc) * (PCH_GBE_DESC_NUM - 1),
 	       &mac_regs->tx_dsc_size);
-	writel(dm_pci_phys_to_mem(priv->dev, (u32)(tx_desc + 1)),
+	writel(dm_pci_phys_to_mem(priv->dev, (ulong)(tx_desc + 1)),
 	       &mac_regs->tx_dsc_sw_p);
 }
 
@@ -251,7 +251,7 @@ static int pch_gbe_send(struct udevice *dev, void *packet, int length)
 	if (length < 64)
 		frame_ctrl |= PCH_GBE_TXD_CTRL_APAD;
 
-	tx_desc->buffer_addr = dm_pci_phys_to_mem(priv->dev, (u32)packet);
+	tx_desc->buffer_addr = dm_pci_phys_to_mem(priv->dev, (ulong)packet);
 	tx_desc->length = length;
 	tx_desc->tx_words_eob = length + 3;
 	tx_desc->tx_frame_ctrl = frame_ctrl;
@@ -262,7 +262,7 @@ static int pch_gbe_send(struct udevice *dev, void *packet, int length)
 	if (++priv->tx_idx >= PCH_GBE_DESC_NUM)
 		priv->tx_idx = 0;
 
-	writel(dm_pci_phys_to_mem(priv->dev, (u32)(tx_head + priv->tx_idx)),
+	writel(dm_pci_phys_to_mem(priv->dev, (ulong)(tx_head + priv->tx_idx)),
 	       &mac_regs->tx_dsc_sw_p);
 
 	start = get_timer(0);
@@ -283,7 +283,7 @@ static int pch_gbe_recv(struct udevice *dev, int flags, uchar **packetp)
 	struct pch_gbe_priv *priv = dev_get_priv(dev);
 	struct pch_gbe_regs *mac_regs = priv->mac_regs;
 	struct pch_gbe_rx_desc *rx_desc;
-	u32 hw_desc, buffer_addr, length;
+	ulong hw_desc, buffer_addr, length;
 
 	rx_desc = &priv->rx_desc[priv->rx_idx];
 
@@ -291,7 +291,7 @@ static int pch_gbe_recv(struct udevice *dev, int flags, uchar **packetp)
 	hw_desc = readl(&mac_regs->rx_dsc_hw_p_hld);
 
 	/* Just return if not receiving any packet */
-	if ((u32)rx_desc == hw_desc)
+	if ((ulong)rx_desc == hw_desc)
 		return -EAGAIN;
 
 	buffer_addr = dm_pci_mem_to_phys(priv->dev, rx_desc->buffer_addr);
@@ -315,7 +315,7 @@ static int pch_gbe_free_pkt(struct udevice *dev, uchar *packet, int length)
 	if (++rx_swp >= PCH_GBE_DESC_NUM)
 		rx_swp = 0;
 
-	writel(dm_pci_phys_to_mem(priv->dev, (u32)(rx_head + rx_swp)),
+	writel(dm_pci_phys_to_mem(priv->dev, (ulong)(rx_head + rx_swp)),
 	       &mac_regs->rx_dsc_sw_p);
 
 	return 0;
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 07/11] dm: regmap: Implement simple regmap_read & regmap_write
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (5 preceding siblings ...)
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 06/11] net: pch_gbe: Make 64 bit safe Paul Burton
@ 2016-08-01 10:07 ` Paul Burton
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 08/11] dm: core: Match compatible strings in order of priority Paul Burton
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:07 UTC (permalink / raw)
  To: u-boot

The regmap_read & regmap_write functions were previously declared in
regmap.h but not implemented anywhere. The regmap implementation &
commit message of 6f98b7504f70 ("dm: Add support for register maps
(regmap)") indicate that only memory mapped accesses are supported for
now, so providing simple implementations of regmap_read & regmap_write
is trivial. The access size is presumed to be 4 bytes & endianness is
presumed native, which are the defaults for the regmap code in Linux.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v4:
- Tweak whitespace

Changes in v3: None
Changes in v2:
- New patch

 drivers/core/regmap.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/core/regmap.c b/drivers/core/regmap.c
index 0299ff0..3177515 100644
--- a/drivers/core/regmap.c
+++ b/drivers/core/regmap.c
@@ -13,6 +13,8 @@
 #include <mapmem.h>
 #include <regmap.h>
 
+#include <asm/io.h>
+
 DECLARE_GLOBAL_DATA_PTR;
 
 static struct regmap *regmap_alloc_count(int count)
@@ -117,3 +119,21 @@ int regmap_uninit(struct regmap *map)
 
 	return 0;
 }
+
+int regmap_read(struct regmap *map, uint offset, uint *valp)
+{
+	uint32_t *ptr = ioremap(map->base + offset, 4);
+
+	*valp = __raw_readl(ptr);
+
+	return 0;
+}
+
+int regmap_write(struct regmap *map, uint offset, uint val)
+{
+	uint32_t *ptr = ioremap(map->base + offset, 4);
+
+	__raw_writel(val, ptr);
+
+	return 0;
+}
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 08/11] dm: core: Match compatible strings in order of priority
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (6 preceding siblings ...)
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 07/11] dm: regmap: Implement simple regmap_read & regmap_write Paul Burton
@ 2016-08-01 10:07 ` Paul Burton
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 09/11] dm: syscon: Provide a generic syscon driver Paul Burton
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:07 UTC (permalink / raw)
  To: u-boot

Device model drivers have previously been matched to FDT nodes by virtue
of being the first driver in the driver list to be compatible with the
node. This ignores the fact that compatible strings in the device tree
are listed in order of priority - that is, if we have a node with 2
compatible strings & a driver that matches each then we should always
probe the driver that matches the first compatible string.

Fix this by looping through the compatible strings for a node when
attempting to bind it in lists_bind_fdt and checking each driver for
a match of the first string, then each driver for a match of the second
string etc. Effectively this inverts the loops over compatible strings &
drivers.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---

Changes in v4: None
Changes in v3: None
Changes in v2: None

 drivers/core/lists.c | 83 ++++++++++++++++++++++++++--------------------------
 1 file changed, 41 insertions(+), 42 deletions(-)

diff --git a/drivers/core/lists.c b/drivers/core/lists.c
index 6a634e6..bde6ec1 100644
--- a/drivers/core/lists.c
+++ b/drivers/core/lists.c
@@ -101,37 +101,21 @@ int device_bind_driver_to_node(struct udevice *parent, const char *drv_name,
 
 #if CONFIG_IS_ENABLED(OF_CONTROL) && !CONFIG_IS_ENABLED(OF_PLATDATA)
 /**
- * driver_check_compatible() - Check if a driver is compatible with this node
+ * driver_check_compatible() - Check if a driver matches a compatible string
  *
- * @param blob:		Device tree pointer
- * @param offset:	Offset of node in device tree
  * @param of_match:	List of compatible strings to match
- * @param of_idp:	Returns the match that was found
- * @return 0 if there is a match, -ENOENT if no match, -ENODEV if the node
- * does not have a compatible string, other error <0 if there is a device
- * tree error
+ * @param compat:	The compatible string to search for
+ * @return 0 if there is a match, -ENOENT if no match
  */
-static int driver_check_compatible(const void *blob, int offset,
-				   const struct udevice_id *of_match,
-				   const struct udevice_id **of_idp)
+static int driver_check_compatible(const struct udevice_id *of_match,
+				   const char *compat)
 {
-	int ret;
-
-	*of_idp = NULL;
 	if (!of_match)
 		return -ENOENT;
 
 	while (of_match->compatible) {
-		ret = fdt_node_check_compatible(blob, offset,
-						of_match->compatible);
-		if (!ret) {
-			*of_idp = of_match;
+		if (!strcmp(of_match->compatible, compat))
 			return 0;
-		} else if (ret == -FDT_ERR_NOTFOUND) {
-			return -ENODEV;
-		} else if (ret < 0) {
-			return -EINVAL;
-		}
 		of_match++;
 	}
 
@@ -143,35 +127,52 @@ int lists_bind_fdt(struct udevice *parent, const void *blob, int offset,
 {
 	struct driver *driver = ll_entry_start(struct driver, driver);
 	const int n_ents = ll_entry_count(struct driver, driver);
-	const struct udevice_id *id;
 	struct driver *entry;
 	struct udevice *dev;
 	bool found = false;
-	const char *name;
+	const char *name, *compat_list, *compat;
+	int compat_length, i;
 	int result = 0;
 	int ret = 0;
 
-	dm_dbg("bind node %s\n", fdt_get_name(blob, offset, NULL));
+	name = fdt_get_name(blob, offset, NULL);
+	dm_dbg("bind node %s\n", name);
 	if (devp)
 		*devp = NULL;
-	for (entry = driver; entry != driver + n_ents; entry++) {
-		ret = driver_check_compatible(blob, offset, entry->of_match,
-					      &id);
-		name = fdt_get_name(blob, offset, NULL);
-		if (ret == -ENOENT) {
-			continue;
-		} else if (ret == -ENODEV) {
+
+	compat_list = fdt_getprop(blob, offset, "compatible", &compat_length);
+	if (!compat_list) {
+		if (compat_length == -FDT_ERR_NOTFOUND) {
 			dm_dbg("Device '%s' has no compatible string\n", name);
-			break;
-		} else if (ret) {
-			dm_warn("Device tree error at offset %d\n", offset);
-			result = ret;
-			break;
+			return 0;
 		}
 
+		dm_warn("Device tree error at offset %d\n", offset);
+		return compat_length;
+	}
+
+	/*
+	 * Walk through the compatible string list, attempting to match each
+	 * compatible string in order such that we match in order of priority
+	 * from the first string to the last.
+	 */
+	for (i = 0; i < compat_length; i += strlen(compat) + 1) {
+		compat = compat_list + i;
+		dm_dbg("   - attempt to match compatible string '%s'\n",
+		       compat);
+
+		for (entry = driver; entry != driver + n_ents; entry++) {
+			ret = driver_check_compatible(entry->of_match, compat);
+			if (!ret)
+				break;
+		}
+		if (entry == driver + n_ents)
+			continue;
+
 		dm_dbg("   - found match at '%s'\n", entry->name);
 		ret = device_bind_with_driver_data(parent, entry, name,
-						   id->data, offset, &dev);
+						   entry->of_match->data,
+						   offset, &dev);
 		if (ret == -ENODEV) {
 			dm_dbg("Driver '%s' refuses to bind\n", entry->name);
 			continue;
@@ -188,10 +189,8 @@ int lists_bind_fdt(struct udevice *parent, const void *blob, int offset,
 		break;
 	}
 
-	if (!found && !result && ret != -ENODEV) {
-		dm_dbg("No match for node '%s'\n",
-		       fdt_get_name(blob, offset, NULL));
-	}
+	if (!found && !result && ret != -ENODEV)
+		dm_dbg("No match for node '%s'\n", name);
 
 	return result;
 }
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 09/11] dm: syscon: Provide a generic syscon driver
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (7 preceding siblings ...)
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 08/11] dm: core: Match compatible strings in order of priority Paul Burton
@ 2016-08-01 10:07 ` Paul Burton
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 10/11] clk: boston: Providea simple driver for Boston board clocks Paul Burton
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:07 UTC (permalink / raw)
  To: u-boot

Provide a trivial syscon driver matching the generic "syscon" compatible
string, allowing for simple system controllers to be used without a
custom driver just as in Linux.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>

---

Changes in v4: None
Changes in v3: None
Changes in v2:
- New patch

 drivers/core/syscon-uclass.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/core/syscon-uclass.c b/drivers/core/syscon-uclass.c
index 01bd968..2148469 100644
--- a/drivers/core/syscon-uclass.c
+++ b/drivers/core/syscon-uclass.c
@@ -95,3 +95,14 @@ UCLASS_DRIVER(syscon) = {
 	.per_device_auto_alloc_size = sizeof(struct syscon_uc_info),
 	.pre_probe = syscon_pre_probe,
 };
+
+static const struct udevice_id generic_syscon_ids[] = {
+	{ .compatible = "syscon" },
+	{ }
+};
+
+U_BOOT_DRIVER(generic_syscon) = {
+	.name	= "syscon",
+	.id	= UCLASS_SYSCON,
+	.of_match = generic_syscon_ids,
+};
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 10/11] clk: boston: Providea simple driver for Boston board clocks
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (8 preceding siblings ...)
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 09/11] dm: syscon: Provide a generic syscon driver Paul Burton
@ 2016-08-01 10:07 ` Paul Burton
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 11/11] boston: Introduce support for the MIPS Boston development board Paul Burton
  2016-08-01 10:46 ` [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Michal Simek
  11 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:07 UTC (permalink / raw)
  To: u-boot

Add a simple driver for the clocks provided by the MIPS Boston
development board. The system provides information about 2 clocks whose
rates are fixed by the bitfile flashed in the boards FPGA, and this
driver simply reads the rates of these 2 clocks.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

---

Changes in v4:
- Replace EXT macro with ext_field function

Changes in v3: None
Changes in v2:
- New patch

 drivers/clk/Kconfig                      |  8 +++
 drivers/clk/Makefile                     |  1 +
 drivers/clk/clk_boston.c                 | 97 ++++++++++++++++++++++++++++++++
 include/dt-bindings/clock/boston-clock.h | 13 +++++
 4 files changed, 119 insertions(+)
 create mode 100644 drivers/clk/clk_boston.c
 create mode 100644 include/dt-bindings/clock/boston-clock.h

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 6eee8eb..85eea0d 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -20,6 +20,14 @@ config SPL_CLK
 	  setting up clocks within SPL, and allows the same drivers to be
 	  used as U-Boot proper.
 
+config CLK_BOSTON
+	def_bool y if TARGET_BOSTON
+	depends on CLK
+	select REGMAP
+	select SYSCON
+	help
+	  Enable this to support the clocks
+
 source "drivers/clk/uniphier/Kconfig"
 source "drivers/clk/exynos/Kconfig"
 
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index f7a8891..9d14122 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -13,3 +13,4 @@ obj-$(CONFIG_SANDBOX) += clk_sandbox_test.o
 obj-$(CONFIG_MACH_PIC32) += clk_pic32.o
 obj-$(CONFIG_CLK_UNIPHIER) += uniphier/
 obj-$(CONFIG_CLK_EXYNOS) += exynos/
+obj-$(CONFIG_CLK_BOSTON) += clk_boston.o
diff --git a/drivers/clk/clk_boston.c b/drivers/clk/clk_boston.c
new file mode 100644
index 0000000..78f1b75
--- /dev/null
+++ b/drivers/clk/clk_boston.c
@@ -0,0 +1,97 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <common.h>
+#include <clk-uclass.h>
+#include <dm.h>
+#include <dt-bindings/clock/boston-clock.h>
+#include <regmap.h>
+#include <syscon.h>
+
+struct clk_boston {
+	struct regmap *regmap;
+};
+
+#define BOSTON_PLAT_MMCMDIV		0x30
+# define BOSTON_PLAT_MMCMDIV_CLK0DIV	(0xff << 0)
+# define BOSTON_PLAT_MMCMDIV_INPUT	(0xff << 8)
+# define BOSTON_PLAT_MMCMDIV_MUL	(0xff << 16)
+# define BOSTON_PLAT_MMCMDIV_CLK1DIV	(0xff << 24)
+
+static uint32_t ext_field(uint32_t val, uint32_t mask)
+{
+	return (val & mask) >> (ffs(mask) - 1);
+}
+
+static ulong clk_boston_get_rate(struct clk *clk)
+{
+	struct clk_boston *state = dev_get_platdata(clk->dev);
+	uint32_t in_rate, mul, div;
+	uint mmcmdiv;
+	int err;
+
+	err = regmap_read(state->regmap, BOSTON_PLAT_MMCMDIV, &mmcmdiv);
+	if (err)
+		return 0;
+
+	in_rate = ext_field(mmcmdiv, BOSTON_PLAT_MMCMDIV_INPUT);
+	mul = ext_field(mmcmdiv, BOSTON_PLAT_MMCMDIV_MUL);
+
+	switch (clk->id) {
+	case BOSTON_CLK_SYS:
+		div = ext_field(mmcmdiv, BOSTON_PLAT_MMCMDIV_CLK0DIV);
+		break;
+	case BOSTON_CLK_CPU:
+		div = ext_field(mmcmdiv, BOSTON_PLAT_MMCMDIV_CLK1DIV);
+		break;
+	default:
+		return 0;
+	}
+
+	return (in_rate * mul * 1000000) / div;
+}
+
+const struct clk_ops clk_boston_ops = {
+	.get_rate = clk_boston_get_rate,
+};
+
+static int clk_boston_ofdata_to_platdata(struct udevice *dev)
+{
+	struct clk_boston *state = dev_get_platdata(dev);
+	struct udevice *syscon;
+	int err;
+
+	err = uclass_get_device_by_phandle(UCLASS_SYSCON, dev,
+					   "regmap", &syscon);
+	if (err) {
+		error("unable to find syscon device\n");
+		return err;
+	}
+
+	state->regmap = syscon_get_regmap(syscon);
+	if (!state->regmap) {
+		error("unable to find regmap\n");
+		return -ENODEV;
+	}
+
+	return 0;
+}
+
+static const struct udevice_id clk_boston_match[] = {
+	{
+		.compatible = "img,boston-clock",
+	},
+	{ /* sentinel */ }
+};
+
+U_BOOT_DRIVER(clk_boston) = {
+	.name = "boston_clock",
+	.id = UCLASS_CLK,
+	.of_match = clk_boston_match,
+	.ofdata_to_platdata = clk_boston_ofdata_to_platdata,
+	.platdata_auto_alloc_size = sizeof(struct clk_boston),
+	.ops = &clk_boston_ops,
+};
diff --git a/include/dt-bindings/clock/boston-clock.h b/include/dt-bindings/clock/boston-clock.h
new file mode 100644
index 0000000..25f9cd2
--- /dev/null
+++ b/include/dt-bindings/clock/boston-clock.h
@@ -0,0 +1,13 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __DT_BINDINGS_CLOCK_BOSTON_CLOCK_H__
+#define __DT_BINDINGS_CLOCK_BOSTON_CLOCK_H__
+
+#define BOSTON_CLK_SYS 0
+#define BOSTON_CLK_CPU 1
+
+#endif /* __DT_BINDINGS_CLOCK_BOSTON_CLOCK_H__ */
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 11/11] boston: Introduce support for the MIPS Boston development board
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (9 preceding siblings ...)
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 10/11] clk: boston: Providea simple driver for Boston board clocks Paul Burton
@ 2016-08-01 10:07 ` Paul Burton
  2016-08-02 13:14   ` [U-Boot] [PATCH v5 " Paul Burton
  2016-08-01 10:46 ` [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Michal Simek
  11 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-01 10:07 UTC (permalink / raw)
  To: u-boot

This patch introduces support for building U-Boot to run on the MIPS
Boston development board. This is a board built around an FPGA & an
Intel EG20T Platform Controller Hub, used largely as part of the
development of new CPUs and their software support. It is essentially
the successor to the older MIPS Malta board.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>

---

Changes in v4:
- Add README.boston

Changes in v3:
- Add defconfigs for 32b & 64b, big & little endian, switch to MIPSr2

Changes in v2:
- Use AT instead of $1
- Use a clock driver instead of patching the DT

 arch/mips/Kconfig                   |  16 +++
 arch/mips/dts/Makefile              |   1 +
 arch/mips/dts/img,boston.dts        | 216 ++++++++++++++++++++++++++++++++++++
 board/imgtec/boston/Kconfig         |  16 +++
 board/imgtec/boston/MAINTAINERS     |   6 +
 board/imgtec/boston/Makefile        |   9 ++
 board/imgtec/boston/boston-lcd.h    |  21 ++++
 board/imgtec/boston/boston-regs.h   |  47 ++++++++
 board/imgtec/boston/checkboard.c    |  29 +++++
 board/imgtec/boston/ddr.c           |  30 +++++
 board/imgtec/boston/lowlevel_init.S |  56 ++++++++++
 configs/boston32r2_defconfig        |  40 +++++++
 configs/boston32r2el_defconfig      |  41 +++++++
 configs/boston64r2_defconfig        |  40 +++++++
 configs/boston64r2el_defconfig      |  41 +++++++
 doc/README.boston                   |  39 +++++++
 include/configs/boston.h            |  68 ++++++++++++
 17 files changed, 716 insertions(+)
 create mode 100644 arch/mips/dts/img,boston.dts
 create mode 100644 board/imgtec/boston/Kconfig
 create mode 100644 board/imgtec/boston/MAINTAINERS
 create mode 100644 board/imgtec/boston/Makefile
 create mode 100644 board/imgtec/boston/boston-lcd.h
 create mode 100644 board/imgtec/boston/boston-regs.h
 create mode 100644 board/imgtec/boston/checkboard.c
 create mode 100644 board/imgtec/boston/ddr.c
 create mode 100644 board/imgtec/boston/lowlevel_init.S
 create mode 100644 configs/boston32r2_defconfig
 create mode 100644 configs/boston32r2el_defconfig
 create mode 100644 configs/boston64r2_defconfig
 create mode 100644 configs/boston64r2el_defconfig
 create mode 100644 doc/README.boston
 create mode 100644 include/configs/boston.h

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 21066f0..7ba0ef2 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -73,9 +73,25 @@ config MACH_PIC32
 	select OF_CONTROL
 	select DM
 
+config TARGET_BOSTON
+	bool "Support Boston"
+	select DM
+	select DM_SERIAL
+	select OF_CONTROL
+	select MIPS_L1_CACHE_SHIFT_6
+	select SUPPORTS_BIG_ENDIAN
+	select SUPPORTS_LITTLE_ENDIAN
+	select SUPPORTS_CPU_MIPS32_R1
+	select SUPPORTS_CPU_MIPS32_R2
+	select SUPPORTS_CPU_MIPS32_R6
+	select SUPPORTS_CPU_MIPS64_R1
+	select SUPPORTS_CPU_MIPS64_R2
+	select SUPPORTS_CPU_MIPS64_R6
+
 endchoice
 
 source "board/dbau1x00/Kconfig"
+source "board/imgtec/boston/Kconfig"
 source "board/imgtec/malta/Kconfig"
 source "board/micronas/vct/Kconfig"
 source "board/pb1x00/Kconfig"
diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile
index 2f04d73..6a5e43e 100644
--- a/arch/mips/dts/Makefile
+++ b/arch/mips/dts/Makefile
@@ -4,6 +4,7 @@
 
 dtb-$(CONFIG_TARGET_AP121) += ap121.dtb
 dtb-$(CONFIG_TARGET_AP143) += ap143.dtb
+dtb-$(CONFIG_TARGET_BOSTON) += img,boston.dtb
 dtb-$(CONFIG_TARGET_MALTA) += mti,malta.dtb
 dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb
 dtb-$(CONFIG_BOARD_TPLINK_WDR4300) += tplink_wdr4300.dtb
diff --git a/arch/mips/dts/img,boston.dts b/arch/mips/dts/img,boston.dts
new file mode 100644
index 0000000..2fbcb93
--- /dev/null
+++ b/arch/mips/dts/img,boston.dts
@@ -0,0 +1,216 @@
+/dts-v1/;
+
+#include <dt-bindings/clock/boston-clock.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/interrupt-controller/mips-gic.h>
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "img,boston";
+
+	chosen {
+		stdout-path = &uart0;
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "img,mips";
+			reg = <0>;
+			clocks = <&clk_boston BOSTON_CLK_CPU>;
+		};
+	};
+
+	memory at 0 {
+		device_type = "memory";
+		reg = <0x00000000 0x10000000>;
+	};
+
+	gic: interrupt-controller {
+		compatible = "mti,gic";
+
+		interrupt-controller;
+		#interrupt-cells = <3>;
+
+		timer {
+			compatible = "mti,gic-timer";
+			interrupts = <GIC_LOCAL 1 IRQ_TYPE_NONE>;
+			clocks = <&clk_boston BOSTON_CLK_CPU>;
+		};
+	};
+
+	pci0: pci at 10000000 {
+		status = "disabled";
+		compatible = "xlnx,axi-pcie-host-1.00.a";
+		device_type = "pci";
+		reg = <0x10000000 0x2000000>;
+
+		#address-cells = <3>;
+		#size-cells = <2>;
+		#interrupt-cells = <1>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 2 IRQ_TYPE_LEVEL_HIGH>;
+
+		ranges = <0x02000000 0 0x40000000
+			  0x40000000 0 0x40000000>;
+
+		interrupt-map-mask = <0 0 0 7>;
+		interrupt-map = <0 0 0 1 &pci0_intc 0>,
+				<0 0 0 2 &pci0_intc 1>,
+				<0 0 0 3 &pci0_intc 2>,
+				<0 0 0 4 &pci0_intc 3>;
+
+		pci0_intc: interrupt-controller {
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+		};
+	};
+
+	pci1: pci at 12000000 {
+		status = "disabled";
+		compatible = "xlnx,axi-pcie-host-1.00.a";
+		device_type = "pci";
+		reg = <0x12000000 0x2000000>;
+
+		#address-cells = <3>;
+		#size-cells = <2>;
+		#interrupt-cells = <1>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 1 IRQ_TYPE_LEVEL_HIGH>;
+
+		ranges = <0x02000000 0 0x20000000
+			  0x20000000 0 0x20000000>;
+
+		interrupt-map-mask = <0 0 0 7>;
+		interrupt-map = <0 0 0 1 &pci1_intc 0>,
+				<0 0 0 2 &pci1_intc 1>,
+				<0 0 0 3 &pci1_intc 2>,
+				<0 0 0 4 &pci1_intc 3>;
+
+		pci1_intc: interrupt-controller {
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+		};
+	};
+
+	pci2: pci at 14000000 {
+		compatible = "xlnx,axi-pcie-host-1.00.a";
+		device_type = "pci";
+		reg = <0x14000000 0x2000000>;
+
+		#address-cells = <3>;
+		#size-cells = <2>;
+		#interrupt-cells = <1>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 0 IRQ_TYPE_LEVEL_HIGH>;
+
+		ranges = <0x02000000 0 0x16000000
+			  0x16000000 0 0x100000>;
+
+		interrupt-map-mask = <0 0 0 7>;
+		interrupt-map = <0 0 0 1 &pci2_intc 0>,
+				<0 0 0 2 &pci2_intc 1>,
+				<0 0 0 3 &pci2_intc 2>,
+				<0 0 0 4 &pci2_intc 3>;
+
+		pci2_intc: interrupt-controller {
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+		};
+
+		pci2_root at 0,0,0 {
+			compatible = "pci10ee,7021";
+			reg = <0x00000000 0 0 0 0>;
+
+			#address-cells = <3>;
+			#size-cells = <2>;
+			#interrupt-cells = <1>;
+
+			eg20t_bridge at 1,0,0 {
+				compatible = "pci8086,8800";
+				reg = <0x00010000 0 0 0 0>;
+
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+
+				eg20t_mac at 2,0,1 {
+					compatible = "pci8086,8802";
+					reg = <0x00020100 0 0 0 0>;
+					phy-reset-gpios = <&eg20t_gpio 6 GPIO_ACTIVE_LOW>;
+				};
+
+				eg20t_gpio: eg20t_gpio at 2,0,2 {
+					compatible = "pci8086,8803";
+					reg = <0x00020200 0 0 0 0>;
+
+					gpio-controller;
+					#gpio-cells = <2>;
+				};
+
+				eg20t_i2c at 2,12,2 {
+					compatible = "pci8086,8817";
+					reg = <0x00026200 0 0 0 0>;
+
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					rtc at 0x68 {
+						compatible = "st,m41t81s";
+						reg = <0x68>;
+					};
+				};
+			};
+		};
+	};
+
+	plat_regs: system-controller at 17ffd000 {
+		compatible = "img,boston-platform-regs", "syscon";
+		reg = <0x17ffd000 0x1000>;
+		u-boot,dm-pre-reloc;
+	};
+
+	clk_boston: clock {
+		compatible = "img,boston-clock";
+		#clock-cells = <1>;
+		regmap = <&plat_regs>;
+		u-boot,dm-pre-reloc;
+	};
+
+	reboot: syscon-reboot {
+		compatible = "syscon-reboot";
+		regmap = <&plat_regs>;
+		offset = <0x10>;
+		mask = <0x10>;
+	};
+
+	uart0: uart at 17ffe000 {
+		compatible = "ns16550a";
+		reg = <0x17ffe000 0x1000>;
+		reg-shift = <2>;
+		reg-io-width = <4>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 3 IRQ_TYPE_LEVEL_HIGH>;
+
+		clocks = <&clk_boston BOSTON_CLK_SYS>;
+
+		u-boot,dm-pre-reloc;
+	};
+
+	lcd: lcd at 17fff000 {
+		compatible = "img,boston-lcd";
+		reg = <0x17fff000 0x8>;
+	};
+};
diff --git a/board/imgtec/boston/Kconfig b/board/imgtec/boston/Kconfig
new file mode 100644
index 0000000..ab76a3c
--- /dev/null
+++ b/board/imgtec/boston/Kconfig
@@ -0,0 +1,16 @@
+if TARGET_BOSTON
+
+config SYS_BOARD
+	default "boston"
+
+config SYS_VENDOR
+	default "imgtec"
+
+config SYS_CONFIG_NAME
+	default "boston"
+
+config SYS_TEXT_BASE
+	default 0x9fc00000 if 32BIT
+	default 0xffffffff9fc00000 if 64BIT
+
+endif
diff --git a/board/imgtec/boston/MAINTAINERS b/board/imgtec/boston/MAINTAINERS
new file mode 100644
index 0000000..30dd481
--- /dev/null
+++ b/board/imgtec/boston/MAINTAINERS
@@ -0,0 +1,6 @@
+BOSTON BOARD
+M:	Paul Burton <paul.burton@imgtec.com>
+S:	Maintained
+F:	board/imgtec/boston/
+F:	include/configs/boston.h
+F:	configs/boston_defconfig
diff --git a/board/imgtec/boston/Makefile b/board/imgtec/boston/Makefile
new file mode 100644
index 0000000..deda457
--- /dev/null
+++ b/board/imgtec/boston/Makefile
@@ -0,0 +1,9 @@
+#
+# Copyright (C) 2016 Imagination Technologies
+#
+# SPDX-License-Identifier:	GPL-2.0
+#
+
+obj-y += checkboard.o
+obj-y += ddr.o
+obj-y += lowlevel_init.o
diff --git a/board/imgtec/boston/boston-lcd.h b/board/imgtec/boston/boston-lcd.h
new file mode 100644
index 0000000..9f5c1b9
--- /dev/null
+++ b/board/imgtec/boston/boston-lcd.h
@@ -0,0 +1,21 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __BOARD_BOSTON_LCD_H__
+#define __BOARD_BOSTON_LCD_H__
+
+/**
+ * lowlevel_display() - Display a message on Boston's LCD
+ * @msg: The string to display
+ *
+ * Display the string @msg on the 7 character LCD display of the Boston board.
+ * This is typically used for debug or to present some form of status
+ * indication to the user, allowing faults to be identified when things go
+ * wrong early enough that the UART isn't up.
+ */
+void lowlevel_display(const char msg[static 8]);
+
+#endif /* __BOARD_BOSTON_LCD_H__ */
diff --git a/board/imgtec/boston/boston-regs.h b/board/imgtec/boston/boston-regs.h
new file mode 100644
index 0000000..c33535e
--- /dev/null
+++ b/board/imgtec/boston/boston-regs.h
@@ -0,0 +1,47 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __BOARD_BOSTON_REGS_H__
+#define __BOARD_BOSTON_REGS_H__
+
+#define BOSTON_PLAT_BASE		0x17ffd000
+#define BOSTON_LCD_BASE			0x17fff000
+
+/*
+ * Platform Register Definitions
+ */
+#define BOSTON_PLAT_CORE_CL		0x04
+
+#define BOSTON_PLAT_DDR3STAT		0x14
+# define BOSTON_PLAT_DDR3STAT_CALIB	(1 << 2)
+
+#define BOSTON_PLAT_MMCMDIV		0x30
+# define BOSTON_PLAT_MMCMDIV_CLK0DIV	(0xff << 0)
+# define BOSTON_PLAT_MMCMDIV_INPUT	(0xff << 8)
+# define BOSTON_PLAT_MMCMDIV_MUL	(0xff << 16)
+# define BOSTON_PLAT_MMCMDIV_CLK1DIV	(0xff << 24)
+
+#define BOSTON_PLAT_DDRCONF0		0x38
+# define BOSTON_PLAT_DDRCONF0_SIZE	(0xf << 0)
+
+#ifndef __ASSEMBLY__
+
+#include <asm/io.h>
+
+#define BUILD_PLAT_ACCESSORS(offset, name)				\
+static inline uint32_t read_boston_##name(void)				\
+{									\
+	uint32_t *reg = (void *)CKSEG1ADDR(BOSTON_PLAT_BASE) + (offset);\
+	return __raw_readl(reg);					\
+}
+
+BUILD_PLAT_ACCESSORS(BOSTON_PLAT_CORE_CL, core_cl)
+BUILD_PLAT_ACCESSORS(BOSTON_PLAT_MMCMDIV, mmcmdiv)
+BUILD_PLAT_ACCESSORS(BOSTON_PLAT_DDRCONF0, ddrconf0)
+
+#endif /* !__ASSEMBLY__ */
+
+#endif /* __BOARD_BOSTON_REGS_H__ */
diff --git a/board/imgtec/boston/checkboard.c b/board/imgtec/boston/checkboard.c
new file mode 100644
index 0000000..417ac4e
--- /dev/null
+++ b/board/imgtec/boston/checkboard.c
@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <common.h>
+
+#include <asm/mipsregs.h>
+
+#include "boston-lcd.h"
+#include "boston-regs.h"
+
+int checkboard(void)
+{
+	u32 changelist;
+
+	lowlevel_display("U-boot  ");
+
+	printf("Board: MIPS Boston\n");
+
+	printf("CPU:   0x%08x", read_c0_prid());
+	changelist = read_boston_core_cl();
+	if (changelist > 1)
+		printf(" cl%x", changelist);
+	putc('\n');
+
+	return 0;
+}
diff --git a/board/imgtec/boston/ddr.c b/board/imgtec/boston/ddr.c
new file mode 100644
index 0000000..7caed4b
--- /dev/null
+++ b/board/imgtec/boston/ddr.c
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <common.h>
+
+#include <asm/addrspace.h>
+
+#include "boston-regs.h"
+
+phys_size_t initdram(int board_type)
+{
+	u32 ddrconf0 = read_boston_ddrconf0();
+
+	return (phys_size_t)(ddrconf0 & BOSTON_PLAT_DDRCONF0_SIZE) << 30;
+}
+
+ulong board_get_usable_ram_top(ulong total_size)
+{
+	DECLARE_GLOBAL_DATA_PTR;
+
+	if (gd->ram_top < CONFIG_SYS_SDRAM_BASE) {
+		/* 2GB wrapped around to 0 */
+		return CKSEG0ADDR(256 << 20);
+	}
+
+	return min_t(unsigned long, gd->ram_top, CKSEG0ADDR(256 << 20));
+}
diff --git a/board/imgtec/boston/lowlevel_init.S b/board/imgtec/boston/lowlevel_init.S
new file mode 100644
index 0000000..8928172
--- /dev/null
+++ b/board/imgtec/boston/lowlevel_init.S
@@ -0,0 +1,56 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <config.h>
+
+#include <asm/addrspace.h>
+#include <asm/asm.h>
+#include <asm/mipsregs.h>
+#include <asm/regdef.h>
+
+#include "boston-regs.h"
+
+.data
+
+msg_ddr_cal:	.ascii "DDR Cal "
+msg_ddr_ok:	.ascii "DDR OK  "
+
+.text
+
+LEAF(lowlevel_init)
+	move	s0, ra
+
+	PTR_LA	a0, msg_ddr_cal
+	bal	lowlevel_display
+
+	PTR_LI	t0, CKSEG1ADDR(BOSTON_PLAT_BASE)
+1:	lw	t1, BOSTON_PLAT_DDR3STAT(t0)
+	andi	t1, t1, BOSTON_PLAT_DDR3STAT_CALIB
+	beqz	t1, 1b
+
+	PTR_LA	a0, msg_ddr_ok
+	bal	lowlevel_display
+
+	move	v0, zero
+	jr	s0
+	END(lowlevel_init)
+
+LEAF(lowlevel_display)
+	.set	push
+	.set	noat
+	PTR_LI	AT, CKSEG1ADDR(BOSTON_LCD_BASE)
+#ifdef CONFIG_64BIT
+	ld	k1, 0(a0)
+	sd	k1, 0(AT)
+#else
+	lw	k1, 0(a0)
+	sw	k1, 0(AT)
+	lw	k1, 4(a0)
+	sw	k1, 4(AT)
+#endif
+	.set	pop
+1:	jr	ra
+	END(lowlevel_display)
diff --git a/configs/boston32r2_defconfig b/configs/boston32r2_defconfig
new file mode 100644
index 0000000..b4b4b6f
--- /dev/null
+++ b/configs/boston32r2_defconfig
@@ -0,0 +1,40 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_SYS_TEXT_BASE=0xffffffff9fc00000
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/configs/boston32r2el_defconfig b/configs/boston32r2el_defconfig
new file mode 100644
index 0000000..4a89bfe
--- /dev/null
+++ b/configs/boston32r2el_defconfig
@@ -0,0 +1,41 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_SYS_TEXT_BASE=0xffffffff9fc00000
+CONFIG_SYS_LITTLE_ENDIAN=y
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/configs/boston64r2_defconfig b/configs/boston64r2_defconfig
new file mode 100644
index 0000000..fdbb505
--- /dev/null
+++ b/configs/boston64r2_defconfig
@@ -0,0 +1,40 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_CPU_MIPS64_R2=y
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/configs/boston64r2el_defconfig b/configs/boston64r2el_defconfig
new file mode 100644
index 0000000..69368e9
--- /dev/null
+++ b/configs/boston64r2el_defconfig
@@ -0,0 +1,41 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_SYS_LITTLE_ENDIAN=y
+CONFIG_CPU_MIPS64_R2=y
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/doc/README.boston b/doc/README.boston
new file mode 100644
index 0000000..2fcb7ca
--- /dev/null
+++ b/doc/README.boston
@@ -0,0 +1,39 @@
+MIPS Boston Development Board
+
+---------
+  About
+---------
+
+The MIPS Boston development board is built around an FPGA & 3 PCIe controllers,
+one of which is connected to an Intel EG20T Platform Controller Hub which
+provides most connectivity to the board. It is used during the development &
+testing of both new CPUs and the software support for them. It is essentially
+the successor of the older MIPS Malta board.
+
+--------
+  QEMU
+--------
+
+U-Boot can be run on a currently out-of-tree branch of QEMU with support for
+the Boston board added. This QEMU code can currently be found in the "boston"
+branch of git://git.linux-mips.org/pub/scm/paul/qemu.git and used like so:
+
+  $ git clone git://git.linux-mips.org/pub/scm/paul/qemu.git -b boston
+  $ cd qemu
+  $ ./configure --target-list=mips64el-softmmu
+  $ make
+  $ ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
+      -bios u-boot.bin -serial stdio
+
+--------
+  TODO
+--------
+
+  - AHCI support
+  - CPU driver
+  - Exception handling (+UHI?)
+  - Flash support
+  - IOCU support
+  - L2 cache support
+  - More general LCD display driver
+  - Multi-arch-variant multi-endian fat binary
diff --git a/include/configs/boston.h b/include/configs/boston.h
new file mode 100644
index 0000000..e25c8d5
--- /dev/null
+++ b/include/configs/boston.h
@@ -0,0 +1,68 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __CONFIGS_BOSTON_H__
+#define __CONFIGS_BOSTON_H__
+
+/*
+ * General board configuration
+ */
+#define CONFIG_DISPLAY_BOARDINFO
+
+/*
+ * CPU
+ */
+#define CONFIG_SYS_MIPS_TIMER_FREQ	30000000
+
+/*
+ * PCI
+ */
+#define CONFIG_PCI
+#define CONFIG_PCI_PNP
+#define CONFIG_CMD_PCI
+
+/*
+ * Environment
+ */
+#define CONFIG_ENV_IS_NOWHERE
+#define CONFIG_ENV_SIZE 1024
+
+/*
+ * Memory map
+ */
+#ifdef CONFIG_64BIT
+# define CONFIG_SYS_SDRAM_BASE		0xffffffff80000000
+#else
+# define CONFIG_SYS_SDRAM_BASE		0x80000000
+#endif
+
+#define CONFIG_SYS_INIT_SP_OFFSET	0x400000
+
+#define CONFIG_SYS_MONITOR_BASE		CONFIG_SYS_TEXT_BASE
+
+#define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x100000)
+
+#define CONFIG_SYS_MEMTEST_START	(CONFIG_SYS_SDRAM_BASE + 0)
+#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x10000000)
+
+#define CONFIG_SYS_MALLOC_LEN		(256 * 1024)
+
+/*
+ * Console
+ */
+#define CONFIG_SYS_MAXARGS		16
+#define CONFIG_SYS_CBSIZE		256
+#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
+					 sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_LONGHELP
+#define CONFIG_BAUDRATE			115200
+
+/*
+ * Flash
+ */
+#define CONFIG_SYS_MAX_FLASH_BANKS	1
+
+#endif /* __CONFIGS_BOSTON_H__ */
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
  2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
                   ` (10 preceding siblings ...)
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 11/11] boston: Introduce support for the MIPS Boston development board Paul Burton
@ 2016-08-01 10:46 ` Michal Simek
  2016-08-01 12:09   ` Paul Burton
  11 siblings, 1 reply; 25+ messages in thread
From: Michal Simek @ 2016-08-01 10:46 UTC (permalink / raw)
  To: u-boot

On 1.8.2016 12:06, Paul Burton wrote:
> This series introduces initial support for the MIPS Boston, and FPGA
> based development board & successor to the older Malta board. Further
> peripheral work is needed but this introduces the basics.
> 
> This can be tested in a currently out-of-tree QEMU port if desired,
> which can be found in the boston branch of:
> 
>   git://git.linux-mips.org/pub/scm/paul/qemu.git
> 
> QEMU can be used to run U-Boot like this:
> 
>   ./configure --target-list=mips64el-softmmu
>   make
>   ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
>     -bios u-boot.bin -serial stdio

I have tried it and nothing is coming up.

Latest u-boot + your patches
make boston64r2el_defconfig

and your qemu on ubuntu 14.

Can you recheck it?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
  2016-08-01 10:46 ` [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Michal Simek
@ 2016-08-01 12:09   ` Paul Burton
  2016-08-01 12:41     ` Michal Simek
  0 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-01 12:09 UTC (permalink / raw)
  To: u-boot

On 01/08/16 11:46, Michal Simek wrote:
> On 1.8.2016 12:06, Paul Burton wrote:
>> This series introduces initial support for the MIPS Boston, and FPGA
>> based development board & successor to the older Malta board. Further
>> peripheral work is needed but this introduces the basics.
>>
>> This can be tested in a currently out-of-tree QEMU port if desired,
>> which can be found in the boston branch of:
>>
>>   git://git.linux-mips.org/pub/scm/paul/qemu.git
>>
>> QEMU can be used to run U-Boot like this:
>>
>>   ./configure --target-list=mips64el-softmmu
>>   make
>>   ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
>>     -bios u-boot.bin -serial stdio
>
> I have tried it and nothing is coming up.
>
> Latest u-boot + your patches
> make boston64r2el_defconfig
>
> and your qemu on ubuntu 14.
>
> Can you recheck it?
>
> Thanks,
> Michal

Hi Michal,

This would be because U-Boot is being built for MIPS64r2 whilst QEMU is 
emulating the MIPS64r6-implementing I6400, and MIPSr6 isn't entirely 
backwards compatible with MIPSr2. If you reconfigure U-Boot to build for 
MIPS64r6 then you should find that it runs correctly. I'll add mention 
of that to the README file.

Thanks,
     Paul

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
  2016-08-01 12:09   ` Paul Burton
@ 2016-08-01 12:41     ` Michal Simek
  2016-08-01 12:51       ` Paul Burton
  0 siblings, 1 reply; 25+ messages in thread
From: Michal Simek @ 2016-08-01 12:41 UTC (permalink / raw)
  To: u-boot

On 1.8.2016 14:09, Paul Burton wrote:
> On 01/08/16 11:46, Michal Simek wrote:
>> On 1.8.2016 12:06, Paul Burton wrote:
>>> This series introduces initial support for the MIPS Boston, and FPGA
>>> based development board & successor to the older Malta board. Further
>>> peripheral work is needed but this introduces the basics.
>>>
>>> This can be tested in a currently out-of-tree QEMU port if desired,
>>> which can be found in the boston branch of:
>>>
>>>   git://git.linux-mips.org/pub/scm/paul/qemu.git
>>>
>>> QEMU can be used to run U-Boot like this:
>>>
>>>   ./configure --target-list=mips64el-softmmu
>>>   make
>>>   ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
>>>     -bios u-boot.bin -serial stdio
>>
>> I have tried it and nothing is coming up.
>>
>> Latest u-boot + your patches
>> make boston64r2el_defconfig
>>
>> and your qemu on ubuntu 14.
>>
>> Can you recheck it?
>>
>> Thanks,
>> Michal
> 
> Hi Michal,
> 
> This would be because U-Boot is being built for MIPS64r2 whilst QEMU is
> emulating the MIPS64r6-implementing I6400, and MIPSr6 isn't entirely
> backwards compatible with MIPSr2. If you reconfigure U-Boot to build for
> MIPS64r6 then you should find that it runs correctly. I'll add mention
> of that to the README file.

sorry don't have any overview about mips at all.
But last patch is adding 4 defconfigs 32r2 and 64r2 (big and little)
endian.

I do use
.buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin//mips-linux-gcc

And getting this when I change it to mips64r6
mips-linux-gcc: error: unrecognized argument in option '-march=mips64r6'

Are there any toolchain at generic location which buildman can use?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
  2016-08-01 12:41     ` Michal Simek
@ 2016-08-01 12:51       ` Paul Burton
  2016-08-04 10:00         ` Michal Simek
  0 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-01 12:51 UTC (permalink / raw)
  To: u-boot

On 01/08/16 13:41, Michal Simek wrote:
> On 1.8.2016 14:09, Paul Burton wrote:
>> On 01/08/16 11:46, Michal Simek wrote:
>>> On 1.8.2016 12:06, Paul Burton wrote:
>>>> This series introduces initial support for the MIPS Boston, and FPGA
>>>> based development board & successor to the older Malta board. Further
>>>> peripheral work is needed but this introduces the basics.
>>>>
>>>> This can be tested in a currently out-of-tree QEMU port if desired,
>>>> which can be found in the boston branch of:
>>>>
>>>>   git://git.linux-mips.org/pub/scm/paul/qemu.git
>>>>
>>>> QEMU can be used to run U-Boot like this:
>>>>
>>>>   ./configure --target-list=mips64el-softmmu
>>>>   make
>>>>   ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
>>>>     -bios u-boot.bin -serial stdio
>>>
>>> I have tried it and nothing is coming up.
>>>
>>> Latest u-boot + your patches
>>> make boston64r2el_defconfig
>>>
>>> and your qemu on ubuntu 14.
>>>
>>> Can you recheck it?
>>>
>>> Thanks,
>>> Michal
>>
>> Hi Michal,
>>
>> This would be because U-Boot is being built for MIPS64r2 whilst QEMU is
>> emulating the MIPS64r6-implementing I6400, and MIPSr6 isn't entirely
>> backwards compatible with MIPSr2. If you reconfigure U-Boot to build for
>> MIPS64r6 then you should find that it runs correctly. I'll add mention
>> of that to the README file.
>
> sorry don't have any overview about mips at all.
> But last patch is adding 4 defconfigs 32r2 and 64r2 (big and little)
> endian.
>
> I do use
> .buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin//mips-linux-gcc
>
> And getting this when I change it to mips64r6
> mips-linux-gcc: error: unrecognized argument in option '-march=mips64r6'

Hi Michal,

Ah, and that's why the defconfigs were changed to MIPSr2 in v3 of the 
patchset. The Boston board can technically use CPUs implementing any 
architecture revision, but is most commonly used with ones implementing 
MIPSr6 hence the QEMU default. If it weren't for that buildman failure 
with MIPSr6 it'd be the Boston defconfig default too.

> Are there any toolchain at generic location which buildman can use?

The toolchain I use is the codescape one available from imgtec.com:

     http://codescape-mips-sdk.imgtec.com/components/toolchain/2015.06-05/

The "IMG GNU Linux Toolchain" from that page will suffice. Anything with 
gcc 5.x or newer should work too if you wanted to use crosstool-ng, 
buildroot or similar to produce a toolchain.

Thanks,
     Paul

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v5 11/11] boston: Introduce support for the MIPS Boston development board
  2016-08-01 10:07 ` [U-Boot] [PATCH v4 11/11] boston: Introduce support for the MIPS Boston development board Paul Burton
@ 2016-08-02 13:14   ` Paul Burton
  0 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-02 13:14 UTC (permalink / raw)
  To: u-boot

This patch introduces support for building U-Boot to run on the MIPS
Boston development board. This is a board built around an FPGA & an
Intel EG20T Platform Controller Hub, used largely as part of the
development of new CPUs and their software support. It is essentially
the successor to the older MIPS Malta board.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>

---

Changes in v5:
- Mention arch revision & toolchain in README.boston
- Drop platform register access now only 2 are used since clock changes

Changes in v4:
- Add README.boston

Changes in v3:
- Add defconfigs for 32b & 64b, big & little endian, switch to MIPSr2

Changes in v2:
- Use AT instead of $1
- Use a clock driver instead of patching the DT

 arch/mips/Kconfig                   |  16 +++
 arch/mips/dts/Makefile              |   1 +
 arch/mips/dts/img,boston.dts        | 216 ++++++++++++++++++++++++++++++++++++
 board/imgtec/boston/Kconfig         |  16 +++
 board/imgtec/boston/MAINTAINERS     |   6 +
 board/imgtec/boston/Makefile        |   9 ++
 board/imgtec/boston/boston-lcd.h    |  21 ++++
 board/imgtec/boston/boston-regs.h   |  26 +++++
 board/imgtec/boston/checkboard.c    |  30 +++++
 board/imgtec/boston/ddr.c           |  30 +++++
 board/imgtec/boston/lowlevel_init.S |  56 ++++++++++
 configs/boston32r2_defconfig        |  40 +++++++
 configs/boston32r2el_defconfig      |  41 +++++++
 configs/boston64r2_defconfig        |  40 +++++++
 configs/boston64r2el_defconfig      |  41 +++++++
 doc/README.boston                   |  58 ++++++++++
 include/configs/boston.h            |  68 ++++++++++++
 17 files changed, 715 insertions(+)
 create mode 100644 arch/mips/dts/img,boston.dts
 create mode 100644 board/imgtec/boston/Kconfig
 create mode 100644 board/imgtec/boston/MAINTAINERS
 create mode 100644 board/imgtec/boston/Makefile
 create mode 100644 board/imgtec/boston/boston-lcd.h
 create mode 100644 board/imgtec/boston/boston-regs.h
 create mode 100644 board/imgtec/boston/checkboard.c
 create mode 100644 board/imgtec/boston/ddr.c
 create mode 100644 board/imgtec/boston/lowlevel_init.S
 create mode 100644 configs/boston32r2_defconfig
 create mode 100644 configs/boston32r2el_defconfig
 create mode 100644 configs/boston64r2_defconfig
 create mode 100644 configs/boston64r2el_defconfig
 create mode 100644 doc/README.boston
 create mode 100644 include/configs/boston.h

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 21066f0..7ba0ef2 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -73,9 +73,25 @@ config MACH_PIC32
 	select OF_CONTROL
 	select DM
 
+config TARGET_BOSTON
+	bool "Support Boston"
+	select DM
+	select DM_SERIAL
+	select OF_CONTROL
+	select MIPS_L1_CACHE_SHIFT_6
+	select SUPPORTS_BIG_ENDIAN
+	select SUPPORTS_LITTLE_ENDIAN
+	select SUPPORTS_CPU_MIPS32_R1
+	select SUPPORTS_CPU_MIPS32_R2
+	select SUPPORTS_CPU_MIPS32_R6
+	select SUPPORTS_CPU_MIPS64_R1
+	select SUPPORTS_CPU_MIPS64_R2
+	select SUPPORTS_CPU_MIPS64_R6
+
 endchoice
 
 source "board/dbau1x00/Kconfig"
+source "board/imgtec/boston/Kconfig"
 source "board/imgtec/malta/Kconfig"
 source "board/micronas/vct/Kconfig"
 source "board/pb1x00/Kconfig"
diff --git a/arch/mips/dts/Makefile b/arch/mips/dts/Makefile
index 2f04d73..6a5e43e 100644
--- a/arch/mips/dts/Makefile
+++ b/arch/mips/dts/Makefile
@@ -4,6 +4,7 @@
 
 dtb-$(CONFIG_TARGET_AP121) += ap121.dtb
 dtb-$(CONFIG_TARGET_AP143) += ap143.dtb
+dtb-$(CONFIG_TARGET_BOSTON) += img,boston.dtb
 dtb-$(CONFIG_TARGET_MALTA) += mti,malta.dtb
 dtb-$(CONFIG_TARGET_PIC32MZDASK) += pic32mzda_sk.dtb
 dtb-$(CONFIG_BOARD_TPLINK_WDR4300) += tplink_wdr4300.dtb
diff --git a/arch/mips/dts/img,boston.dts b/arch/mips/dts/img,boston.dts
new file mode 100644
index 0000000..2fbcb93
--- /dev/null
+++ b/arch/mips/dts/img,boston.dts
@@ -0,0 +1,216 @@
+/dts-v1/;
+
+#include <dt-bindings/clock/boston-clock.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/interrupt-controller/mips-gic.h>
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	compatible = "img,boston";
+
+	chosen {
+		stdout-path = &uart0;
+	};
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "img,mips";
+			reg = <0>;
+			clocks = <&clk_boston BOSTON_CLK_CPU>;
+		};
+	};
+
+	memory at 0 {
+		device_type = "memory";
+		reg = <0x00000000 0x10000000>;
+	};
+
+	gic: interrupt-controller {
+		compatible = "mti,gic";
+
+		interrupt-controller;
+		#interrupt-cells = <3>;
+
+		timer {
+			compatible = "mti,gic-timer";
+			interrupts = <GIC_LOCAL 1 IRQ_TYPE_NONE>;
+			clocks = <&clk_boston BOSTON_CLK_CPU>;
+		};
+	};
+
+	pci0: pci at 10000000 {
+		status = "disabled";
+		compatible = "xlnx,axi-pcie-host-1.00.a";
+		device_type = "pci";
+		reg = <0x10000000 0x2000000>;
+
+		#address-cells = <3>;
+		#size-cells = <2>;
+		#interrupt-cells = <1>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 2 IRQ_TYPE_LEVEL_HIGH>;
+
+		ranges = <0x02000000 0 0x40000000
+			  0x40000000 0 0x40000000>;
+
+		interrupt-map-mask = <0 0 0 7>;
+		interrupt-map = <0 0 0 1 &pci0_intc 0>,
+				<0 0 0 2 &pci0_intc 1>,
+				<0 0 0 3 &pci0_intc 2>,
+				<0 0 0 4 &pci0_intc 3>;
+
+		pci0_intc: interrupt-controller {
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+		};
+	};
+
+	pci1: pci at 12000000 {
+		status = "disabled";
+		compatible = "xlnx,axi-pcie-host-1.00.a";
+		device_type = "pci";
+		reg = <0x12000000 0x2000000>;
+
+		#address-cells = <3>;
+		#size-cells = <2>;
+		#interrupt-cells = <1>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 1 IRQ_TYPE_LEVEL_HIGH>;
+
+		ranges = <0x02000000 0 0x20000000
+			  0x20000000 0 0x20000000>;
+
+		interrupt-map-mask = <0 0 0 7>;
+		interrupt-map = <0 0 0 1 &pci1_intc 0>,
+				<0 0 0 2 &pci1_intc 1>,
+				<0 0 0 3 &pci1_intc 2>,
+				<0 0 0 4 &pci1_intc 3>;
+
+		pci1_intc: interrupt-controller {
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+		};
+	};
+
+	pci2: pci at 14000000 {
+		compatible = "xlnx,axi-pcie-host-1.00.a";
+		device_type = "pci";
+		reg = <0x14000000 0x2000000>;
+
+		#address-cells = <3>;
+		#size-cells = <2>;
+		#interrupt-cells = <1>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 0 IRQ_TYPE_LEVEL_HIGH>;
+
+		ranges = <0x02000000 0 0x16000000
+			  0x16000000 0 0x100000>;
+
+		interrupt-map-mask = <0 0 0 7>;
+		interrupt-map = <0 0 0 1 &pci2_intc 0>,
+				<0 0 0 2 &pci2_intc 1>,
+				<0 0 0 3 &pci2_intc 2>,
+				<0 0 0 4 &pci2_intc 3>;
+
+		pci2_intc: interrupt-controller {
+			interrupt-controller;
+			#address-cells = <0>;
+			#interrupt-cells = <1>;
+		};
+
+		pci2_root at 0,0,0 {
+			compatible = "pci10ee,7021";
+			reg = <0x00000000 0 0 0 0>;
+
+			#address-cells = <3>;
+			#size-cells = <2>;
+			#interrupt-cells = <1>;
+
+			eg20t_bridge at 1,0,0 {
+				compatible = "pci8086,8800";
+				reg = <0x00010000 0 0 0 0>;
+
+				#address-cells = <3>;
+				#size-cells = <2>;
+				#interrupt-cells = <1>;
+
+				eg20t_mac at 2,0,1 {
+					compatible = "pci8086,8802";
+					reg = <0x00020100 0 0 0 0>;
+					phy-reset-gpios = <&eg20t_gpio 6 GPIO_ACTIVE_LOW>;
+				};
+
+				eg20t_gpio: eg20t_gpio at 2,0,2 {
+					compatible = "pci8086,8803";
+					reg = <0x00020200 0 0 0 0>;
+
+					gpio-controller;
+					#gpio-cells = <2>;
+				};
+
+				eg20t_i2c at 2,12,2 {
+					compatible = "pci8086,8817";
+					reg = <0x00026200 0 0 0 0>;
+
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					rtc at 0x68 {
+						compatible = "st,m41t81s";
+						reg = <0x68>;
+					};
+				};
+			};
+		};
+	};
+
+	plat_regs: system-controller at 17ffd000 {
+		compatible = "img,boston-platform-regs", "syscon";
+		reg = <0x17ffd000 0x1000>;
+		u-boot,dm-pre-reloc;
+	};
+
+	clk_boston: clock {
+		compatible = "img,boston-clock";
+		#clock-cells = <1>;
+		regmap = <&plat_regs>;
+		u-boot,dm-pre-reloc;
+	};
+
+	reboot: syscon-reboot {
+		compatible = "syscon-reboot";
+		regmap = <&plat_regs>;
+		offset = <0x10>;
+		mask = <0x10>;
+	};
+
+	uart0: uart at 17ffe000 {
+		compatible = "ns16550a";
+		reg = <0x17ffe000 0x1000>;
+		reg-shift = <2>;
+		reg-io-width = <4>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 3 IRQ_TYPE_LEVEL_HIGH>;
+
+		clocks = <&clk_boston BOSTON_CLK_SYS>;
+
+		u-boot,dm-pre-reloc;
+	};
+
+	lcd: lcd at 17fff000 {
+		compatible = "img,boston-lcd";
+		reg = <0x17fff000 0x8>;
+	};
+};
diff --git a/board/imgtec/boston/Kconfig b/board/imgtec/boston/Kconfig
new file mode 100644
index 0000000..ab76a3c
--- /dev/null
+++ b/board/imgtec/boston/Kconfig
@@ -0,0 +1,16 @@
+if TARGET_BOSTON
+
+config SYS_BOARD
+	default "boston"
+
+config SYS_VENDOR
+	default "imgtec"
+
+config SYS_CONFIG_NAME
+	default "boston"
+
+config SYS_TEXT_BASE
+	default 0x9fc00000 if 32BIT
+	default 0xffffffff9fc00000 if 64BIT
+
+endif
diff --git a/board/imgtec/boston/MAINTAINERS b/board/imgtec/boston/MAINTAINERS
new file mode 100644
index 0000000..30dd481
--- /dev/null
+++ b/board/imgtec/boston/MAINTAINERS
@@ -0,0 +1,6 @@
+BOSTON BOARD
+M:	Paul Burton <paul.burton@imgtec.com>
+S:	Maintained
+F:	board/imgtec/boston/
+F:	include/configs/boston.h
+F:	configs/boston_defconfig
diff --git a/board/imgtec/boston/Makefile b/board/imgtec/boston/Makefile
new file mode 100644
index 0000000..deda457
--- /dev/null
+++ b/board/imgtec/boston/Makefile
@@ -0,0 +1,9 @@
+#
+# Copyright (C) 2016 Imagination Technologies
+#
+# SPDX-License-Identifier:	GPL-2.0
+#
+
+obj-y += checkboard.o
+obj-y += ddr.o
+obj-y += lowlevel_init.o
diff --git a/board/imgtec/boston/boston-lcd.h b/board/imgtec/boston/boston-lcd.h
new file mode 100644
index 0000000..9f5c1b9
--- /dev/null
+++ b/board/imgtec/boston/boston-lcd.h
@@ -0,0 +1,21 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __BOARD_BOSTON_LCD_H__
+#define __BOARD_BOSTON_LCD_H__
+
+/**
+ * lowlevel_display() - Display a message on Boston's LCD
+ * @msg: The string to display
+ *
+ * Display the string @msg on the 7 character LCD display of the Boston board.
+ * This is typically used for debug or to present some form of status
+ * indication to the user, allowing faults to be identified when things go
+ * wrong early enough that the UART isn't up.
+ */
+void lowlevel_display(const char msg[static 8]);
+
+#endif /* __BOARD_BOSTON_LCD_H__ */
diff --git a/board/imgtec/boston/boston-regs.h b/board/imgtec/boston/boston-regs.h
new file mode 100644
index 0000000..b9dfbb4
--- /dev/null
+++ b/board/imgtec/boston/boston-regs.h
@@ -0,0 +1,26 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __BOARD_BOSTON_REGS_H__
+#define __BOARD_BOSTON_REGS_H__
+
+#include <asm/addrspace.h>
+
+#define BOSTON_PLAT_BASE		CKSEG1ADDR(0x17ffd000)
+#define BOSTON_LCD_BASE			CKSEG1ADDR(0x17fff000)
+
+/*
+ * Platform Register Definitions
+ */
+#define BOSTON_PLAT_CORE_CL		(BOSTON_PLAT_BASE + 0x04)
+
+#define BOSTON_PLAT_DDR3STAT		(BOSTON_PLAT_BASE + 0x14)
+# define BOSTON_PLAT_DDR3STAT_CALIB	(1 << 2)
+
+#define BOSTON_PLAT_DDRCONF0		(BOSTON_PLAT_BASE + 0x38)
+# define BOSTON_PLAT_DDRCONF0_SIZE	(0xf << 0)
+
+#endif /* __BOARD_BOSTON_REGS_H__ */
diff --git a/board/imgtec/boston/checkboard.c b/board/imgtec/boston/checkboard.c
new file mode 100644
index 0000000..93eae7f
--- /dev/null
+++ b/board/imgtec/boston/checkboard.c
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <common.h>
+
+#include <asm/io.h>
+#include <asm/mipsregs.h>
+
+#include "boston-lcd.h"
+#include "boston-regs.h"
+
+int checkboard(void)
+{
+	u32 changelist;
+
+	lowlevel_display("U-boot  ");
+
+	printf("Board: MIPS Boston\n");
+
+	printf("CPU:   0x%08x", read_c0_prid());
+	changelist = __raw_readl((uint32_t *)BOSTON_PLAT_CORE_CL);
+	if (changelist > 1)
+		printf(" cl%x", changelist);
+	putc('\n');
+
+	return 0;
+}
diff --git a/board/imgtec/boston/ddr.c b/board/imgtec/boston/ddr.c
new file mode 100644
index 0000000..ceffef6
--- /dev/null
+++ b/board/imgtec/boston/ddr.c
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <common.h>
+
+#include <asm/io.h>
+
+#include "boston-regs.h"
+
+phys_size_t initdram(int board_type)
+{
+	u32 ddrconf0 = __raw_readl((uint32_t *)BOSTON_PLAT_DDRCONF0);
+
+	return (phys_size_t)(ddrconf0 & BOSTON_PLAT_DDRCONF0_SIZE) << 30;
+}
+
+ulong board_get_usable_ram_top(ulong total_size)
+{
+	DECLARE_GLOBAL_DATA_PTR;
+
+	if (gd->ram_top < CONFIG_SYS_SDRAM_BASE) {
+		/* 2GB wrapped around to 0 */
+		return CKSEG0ADDR(256 << 20);
+	}
+
+	return min_t(unsigned long, gd->ram_top, CKSEG0ADDR(256 << 20));
+}
diff --git a/board/imgtec/boston/lowlevel_init.S b/board/imgtec/boston/lowlevel_init.S
new file mode 100644
index 0000000..0c01aa9
--- /dev/null
+++ b/board/imgtec/boston/lowlevel_init.S
@@ -0,0 +1,56 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#include <config.h>
+
+#include <asm/addrspace.h>
+#include <asm/asm.h>
+#include <asm/mipsregs.h>
+#include <asm/regdef.h>
+
+#include "boston-regs.h"
+
+.data
+
+msg_ddr_cal:	.ascii "DDR Cal "
+msg_ddr_ok:	.ascii "DDR OK  "
+
+.text
+
+LEAF(lowlevel_init)
+	move	s0, ra
+
+	PTR_LA	a0, msg_ddr_cal
+	bal	lowlevel_display
+
+	PTR_LI	t0, BOSTON_PLAT_DDR3STAT
+1:	lw	t1, 0(t0)
+	andi	t1, t1, BOSTON_PLAT_DDR3STAT_CALIB
+	beqz	t1, 1b
+
+	PTR_LA	a0, msg_ddr_ok
+	bal	lowlevel_display
+
+	move	v0, zero
+	jr	s0
+	END(lowlevel_init)
+
+LEAF(lowlevel_display)
+	.set	push
+	.set	noat
+	PTR_LI	AT, BOSTON_LCD_BASE
+#ifdef CONFIG_64BIT
+	ld	k1, 0(a0)
+	sd	k1, 0(AT)
+#else
+	lw	k1, 0(a0)
+	sw	k1, 0(AT)
+	lw	k1, 4(a0)
+	sw	k1, 4(AT)
+#endif
+	.set	pop
+1:	jr	ra
+	END(lowlevel_display)
diff --git a/configs/boston32r2_defconfig b/configs/boston32r2_defconfig
new file mode 100644
index 0000000..b4b4b6f
--- /dev/null
+++ b/configs/boston32r2_defconfig
@@ -0,0 +1,40 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_SYS_TEXT_BASE=0xffffffff9fc00000
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/configs/boston32r2el_defconfig b/configs/boston32r2el_defconfig
new file mode 100644
index 0000000..4a89bfe
--- /dev/null
+++ b/configs/boston32r2el_defconfig
@@ -0,0 +1,41 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_SYS_TEXT_BASE=0xffffffff9fc00000
+CONFIG_SYS_LITTLE_ENDIAN=y
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/configs/boston64r2_defconfig b/configs/boston64r2_defconfig
new file mode 100644
index 0000000..fdbb505
--- /dev/null
+++ b/configs/boston64r2_defconfig
@@ -0,0 +1,40 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_CPU_MIPS64_R2=y
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/configs/boston64r2el_defconfig b/configs/boston64r2el_defconfig
new file mode 100644
index 0000000..69368e9
--- /dev/null
+++ b/configs/boston64r2el_defconfig
@@ -0,0 +1,41 @@
+CONFIG_MIPS=y
+CONFIG_TARGET_BOSTON=y
+CONFIG_SYS_LITTLE_ENDIAN=y
+CONFIG_CPU_MIPS64_R2=y
+# CONFIG_MIPS_BOOT_CMDLINE_LEGACY is not set
+# CONFIG_MIPS_BOOT_ENV_LEGACY is not set
+CONFIG_MIPS_BOOT_FDT=y
+CONFIG_DEFAULT_DEVICE_TREE="img,boston"
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_FIT_BEST_MATCH=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_SYS_NO_FLASH=y
+CONFIG_HUSH_PARSER=y
+CONFIG_SYS_PROMPT="boston # "
+# CONFIG_CMD_ELF is not set
+# CONFIG_CMD_IMLS is not set
+CONFIG_CMD_GREPENV=y
+CONFIG_CMD_MEMTEST=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_TIME=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_OF_EMBED=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_CLK=y
+CONFIG_DM_ETH=y
+CONFIG_PCH_GBE=y
+CONFIG_DM_PCI=y
+CONFIG_PCI_XILINX=y
+CONFIG_SYS_NS16550=y
+CONFIG_LZ4=y
diff --git a/doc/README.boston b/doc/README.boston
new file mode 100644
index 0000000..38f6710
--- /dev/null
+++ b/doc/README.boston
@@ -0,0 +1,58 @@
+MIPS Boston Development Board
+
+---------
+  About
+---------
+
+The MIPS Boston development board is built around an FPGA & 3 PCIe controllers,
+one of which is connected to an Intel EG20T Platform Controller Hub which
+provides most connectivity to the board. It is used during the development &
+testing of both new CPUs and the software support for them. It is essentially
+the successor of the older MIPS Malta board.
+
+--------
+  QEMU
+--------
+
+U-Boot can be run on a currently out-of-tree branch of QEMU with support for
+the Boston board added. This QEMU code can currently be found in the "boston"
+branch of git://git.linux-mips.org/pub/scm/paul/qemu.git and used like so:
+
+  $ git clone git://git.linux-mips.org/pub/scm/paul/qemu.git -b boston
+  $ cd qemu
+  $ ./configure --target-list=mips64el-softmmu
+  $ make
+  $ ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
+      -bios u-boot.bin -serial stdio
+
+Please note that QEMU will default to emulating the I6400 CPU which implements
+the MIPS64r6 ISA, and at the time of writing doesn't implement any earlier CPUs
+with support for the CPS features the Boston board relies upon. You will
+therefore need to configure U-Boot to build for MIPSr6 in order to obtain a
+binary that will work in QEMU.
+
+-------------
+  Toolchain
+-------------
+
+If building for MIPSr6 then you will need a toolchain including GCC 5.x or
+newer, or the Codescape toolchain available for download from Imagination
+Technologies:
+
+  http://codescape-mips-sdk.imgtec.com/components/toolchain/2015.06-05/
+
+The "IMG GNU Linux Toolchain" is capable of building for all current MIPS ISAs,
+architecture revisions & both endiannesses.
+
+--------
+  TODO
+--------
+
+  - AHCI support
+  - CPU driver
+  - Exception handling (+UHI?)
+  - Flash support
+  - IOCU support
+  - L2 cache support
+  - More general LCD display driver
+  - Multi-arch-variant multi-endian fat binary
diff --git a/include/configs/boston.h b/include/configs/boston.h
new file mode 100644
index 0000000..e25c8d5
--- /dev/null
+++ b/include/configs/boston.h
@@ -0,0 +1,68 @@
+/*
+ * Copyright (C) 2016 Imagination Technologies
+ *
+ * SPDX-License-Identifier:	GPL-2.0
+ */
+
+#ifndef __CONFIGS_BOSTON_H__
+#define __CONFIGS_BOSTON_H__
+
+/*
+ * General board configuration
+ */
+#define CONFIG_DISPLAY_BOARDINFO
+
+/*
+ * CPU
+ */
+#define CONFIG_SYS_MIPS_TIMER_FREQ	30000000
+
+/*
+ * PCI
+ */
+#define CONFIG_PCI
+#define CONFIG_PCI_PNP
+#define CONFIG_CMD_PCI
+
+/*
+ * Environment
+ */
+#define CONFIG_ENV_IS_NOWHERE
+#define CONFIG_ENV_SIZE 1024
+
+/*
+ * Memory map
+ */
+#ifdef CONFIG_64BIT
+# define CONFIG_SYS_SDRAM_BASE		0xffffffff80000000
+#else
+# define CONFIG_SYS_SDRAM_BASE		0x80000000
+#endif
+
+#define CONFIG_SYS_INIT_SP_OFFSET	0x400000
+
+#define CONFIG_SYS_MONITOR_BASE		CONFIG_SYS_TEXT_BASE
+
+#define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x100000)
+
+#define CONFIG_SYS_MEMTEST_START	(CONFIG_SYS_SDRAM_BASE + 0)
+#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x10000000)
+
+#define CONFIG_SYS_MALLOC_LEN		(256 * 1024)
+
+/*
+ * Console
+ */
+#define CONFIG_SYS_MAXARGS		16
+#define CONFIG_SYS_CBSIZE		256
+#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
+					 sizeof(CONFIG_SYS_PROMPT) + 16)
+#define CONFIG_SYS_LONGHELP
+#define CONFIG_BAUDRATE			115200
+
+/*
+ * Flash
+ */
+#define CONFIG_SYS_MAX_FLASH_BANKS	1
+
+#endif /* __CONFIGS_BOSTON_H__ */
-- 
2.9.2

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle Paul Burton
@ 2016-08-04  9:50   ` Michal Simek
  2016-08-04  9:59     ` Paul Burton
  0 siblings, 1 reply; 25+ messages in thread
From: Michal Simek @ 2016-08-04  9:50 UTC (permalink / raw)
  To: u-boot

On 1.8.2016 12:06, Paul Burton wrote:
> Previously ns16550 compatible UARTs probed via device tree have needed
> their device tree nodes to contain a clock-frequency property. An
> alternative to this commonly used with Linux is to reference a clock via
> a phandle. This patch allows U-Boot to support that, retrieving the
> clock frequency by probing the appropriate clock device.
> 
> For example, a system might choose to provide the UART base clock as a
> reference to a clock common to multiple devices:
> 
>   sys_clk: clock {
>     compatible = "fixed-clock";
>     #clock-cells = <0>;
>     clock-frequency = <10000000>;
>   };
> 
>   uart0: uart at 10000000 {
>     compatible = "ns16550a";
>     reg = <0x10000000 0x1000>;
>     clocks = <&sys_clk>;
>   };
> 
>   uart1: uart at 10000000 {
>     compatible = "ns16550a";
>     reg = <0x10001000 0x1000>;
>     clocks = <&sys_clk>;
>   };
> 
> This removes the need for the frequency information to be duplicated in
> multiple nodes and allows the device tree to be more descriptive of the
> system.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - Propogate non-ENODEV errors from clk_get_by_index
> 
>  drivers/serial/ns16550.c | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 88fca15..37da3ed 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -5,6 +5,7 @@
>   */
>  
>  #include <common.h>
> +#include <clk.h>
>  #include <dm.h>
>  #include <errno.h>
>  #include <fdtdec.h>
> @@ -352,6 +353,8 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
>  {
>  	struct ns16550_platdata *plat = dev->platdata;
>  	fdt_addr_t addr;
> +	struct clk clk;
> +	int err;
>  
>  	/* try Processor Local Bus device first */
>  	addr = dev_get_addr(dev);
> @@ -397,9 +400,19 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
>  				     "reg-offset", 0);
>  	plat->reg_shift = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>  					 "reg-shift", 0);
> -	plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
> -				     "clock-frequency",
> -				     CONFIG_SYS_NS16550_CLK);
> +
> +	err = clk_get_by_index(dev, 0, &clk);
> +	if (!err) {
> +		plat->clock = clk_get_rate(&clk);
> +	} else if (err != -ENODEV) {
> +		debug("ns16550 failed to get clock\n");
> +		return err;
> +	}
> +
> +	if (!plat->clock)
> +		plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
> +					     "clock-frequency",
> +					     CONFIG_SYS_NS16550_CLK);
>  	if (!plat->clock) {
>  		debug("ns16550 clock not defined\n");
>  		return -EINVAL;
> 


NACK. It is missing dependency on clk uclass which is not enabled by
default on Microblaze. Maybe also on others. You should add some ifs around.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160804/b66361bd/attachment.sig>

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge
  2016-08-01 10:06 ` [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge Paul Burton
@ 2016-08-04  9:54   ` Michal Simek
  2016-08-04 10:24     ` Paul Burton
  0 siblings, 1 reply; 25+ messages in thread
From: Michal Simek @ 2016-08-04  9:54 UTC (permalink / raw)
  To: u-boot

On 1.8.2016 12:06, Paul Burton wrote:
> This patch adds a driver for the Xilinx AXI bridge for PCI express, an
> IP block which can be used on some generations of Xilinx FPGAs. This is
> mostly a case of implementing PCIe ECAM specification, but with some
> quirks about what devices are valid to access.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2:
> - Clean up error returns & documentation
> 
>  drivers/pci/Kconfig       |   7 ++
>  drivers/pci/Makefile      |   1 +
>  drivers/pci/pcie_xilinx.c | 219 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 227 insertions(+)
>  create mode 100644 drivers/pci/pcie_xilinx.c
> 
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 26aa2b0..1f9ea66 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -38,4 +38,11 @@ config PCI_TEGRA
>  	  with a total of 5 lanes. Some boards require this for Ethernet
>  	  support to work (e.g. beaver, jetson-tk1).
>  
> +config PCI_XILINX
> +	bool "Xilinx AXI Bridge for PCI Express"
> +	depends on DM_PCI

There is also dependency on PCI which should be added to Kconfig.
And it can be compiled only for MB and Mips.
It means you should limit it like that or fix that problem with
ioremap_nocache.

> +	help
> +	  Enable support for the Xilinx AXI bridge for PCI express, an IP block
> +	  which can be used on some generations of Xilinx FPGAs.
> +
>  endmenu
> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
> index f8be9bf..9583e91 100644
> --- a/drivers/pci/Makefile
> +++ b/drivers/pci/Makefile
> @@ -31,3 +31,4 @@ obj-$(CONFIG_PCI_TEGRA) += pci_tegra.o
>  obj-$(CONFIG_TSI108_PCI) += tsi108_pci.o
>  obj-$(CONFIG_WINBOND_83C553) += w83c553f.o
>  obj-$(CONFIG_PCIE_LAYERSCAPE) += pcie_layerscape.o
> +obj-$(CONFIG_PCI_XILINX) += pcie_xilinx.o
> diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c
> new file mode 100644
> index 0000000..9fe02be
> --- /dev/null
> +++ b/drivers/pci/pcie_xilinx.c
> @@ -0,0 +1,219 @@
> +/*
> + * Xilinx AXI Bridge for PCI Express Driver
> + *
> + * Copyright (C) 2016 Imagination Technologies
> + *
> + * SPDX-License-Identifier:	GPL-2.0
> + */
> +
> +#include <common.h>
> +#include <dm.h>
> +#include <pci.h>
> +
> +#include <asm/io.h>
> +
> +/**
> + * struct xilinx_pcie - Xilinx PCIe controller state
> + * @hose: The parent classes PCI controller state
> + * @cfg_base: The base address of memory mapped configuration space
> + */
> +struct xilinx_pcie {
> +	struct pci_controller hose;
> +	void *cfg_base;
> +};
> +
> +/* Register definitions */
> +#define XILINX_PCIE_REG_PSCR		0x144
> +#define XILINX_PCIE_REG_PSCR_LNKUP	BIT(11)
> +
> +/**
> + * pcie_xilinx_link_up() - Check whether the PCIe link is up
> + * @pcie: Pointer to the PCI controller state
> + *
> + * Checks whether the PCIe link for the given device is up or down.
> + *
> + * Return: true if the link is up, else false
> + */
> +static bool pcie_xilinx_link_up(struct xilinx_pcie *pcie)
> +{
> +	uint32_t pscr = __raw_readl(pcie->cfg_base + XILINX_PCIE_REG_PSCR);
> +
> +	return pscr & XILINX_PCIE_REG_PSCR_LNKUP;
> +}
> +
> +/**
> + * pcie_xilinx_config_address() - Calculate the address of a config access
> + * @pcie: Pointer to the PCI controller state
> + * @bdf: Identifies the PCIe device to access
> + * @offset: The offset into the device's configuration space
> + * @paddress: Pointer to the pointer to write the calculates address to
> + *
> + * Calculates the address that should be accessed to perform a PCIe
> + * configuration space access for a given device identified by the PCIe
> + * controller device @pcie and the bus, device & function numbers in @bdf. If
> + * access to the device is not valid then the function will return an error
> + * code. Otherwise the address to access will be written to the pointer pointed
> + * to by @paddress.
> + *
> + * Return: 0 on success, else -ENODEV
> + */
> +static int pcie_xilinx_config_address(struct xilinx_pcie *pcie, pci_dev_t bdf,
> +				      uint offset, void **paddress)
> +{
> +	unsigned int bus = PCI_BUS(bdf);
> +	unsigned int dev = PCI_DEV(bdf);
> +	unsigned int func = PCI_FUNC(bdf);
> +	void *addr;
> +
> +	if ((bus > 0) && !pcie_xilinx_link_up(pcie))
> +		return -ENODEV;
> +
> +	/*
> +	 * Busses 0 (host-PCIe bridge) & 1 (its immediate child) are
> +	 * limited to a single device each.
> +	 */
> +	if ((bus < 2) && (dev > 0))
> +		return -ENODEV;
> +
> +	addr = pcie->cfg_base;
> +	addr += bus << 20;
> +	addr += dev << 15;
> +	addr += func << 12;
> +	addr += offset;
> +	*paddress = addr;
> +
> +	return 0;
> +}
> +
> +/**
> + * pcie_xilinx_read_config() - Read from configuration space
> + * @pcie: Pointer to the PCI controller state
> + * @bdf: Identifies the PCIe device to access
> + * @offset: The offset into the device's configuration space
> + * @valuep: A pointer at which to store the read value
> + * @size: Indicates the size of access to perform
> + *
> + * Read a value of size @size from offset @offset within the configuration
> + * space of the device identified by the bus, device & function numbers in @bdf
> + * on the PCI bus @bus.
> + *
> + * Return: 0 on success, else -ENODEV or -EINVAL
> + */
> +static int pcie_xilinx_read_config(struct udevice *bus, pci_dev_t bdf,
> +				   uint offset, ulong *valuep,
> +				   enum pci_size_t size)
> +{
> +	struct xilinx_pcie *pcie = dev_get_priv(bus);
> +	void *address;
> +	int err;
> +
> +	err = pcie_xilinx_config_address(pcie, bdf, offset, &address);
> +	if (err < 0) {
> +		*valuep = pci_get_ff(size);
> +		return 0;
> +	}
> +
> +	switch (size) {
> +	case PCI_SIZE_8:
> +		*valuep = __raw_readb(address);
> +		return 0;
> +	case PCI_SIZE_16:
> +		*valuep = __raw_readw(address);
> +		return 0;
> +	case PCI_SIZE_32:
> +		*valuep = __raw_readl(address);
> +		return 0;
> +	default:
> +		return -EINVAL;
> +	}
> +}
> +
> +/**
> + * pcie_xilinx_write_config() - Write to configuration space
> + * @pcie: Pointer to the PCI controller state
> + * @bdf: Identifies the PCIe device to access
> + * @offset: The offset into the device's configuration space
> + * @value: The value to write
> + * @size: Indicates the size of access to perform
> + *
> + * Write the value @value of size @size from offset @offset within the
> + * configuration space of the device identified by the bus, device & function
> + * numbers in @bdf on the PCI bus @bus.
> + *
> + * Return: 0 on success, else -ENODEV or -EINVAL
> + */
> +static int pcie_xilinx_write_config(struct udevice *bus, pci_dev_t bdf,
> +				    uint offset, ulong value,
> +				    enum pci_size_t size)
> +{
> +	struct xilinx_pcie *pcie = dev_get_priv(bus);
> +	void *address;
> +	int err;
> +
> +	err = pcie_xilinx_config_address(pcie, bdf, offset, &address);
> +	if (err < 0)
> +		return 0;
> +
> +	switch (size) {
> +	case PCI_SIZE_8:
> +		__raw_writeb(value, address);
> +		return 0;
> +	case PCI_SIZE_16:
> +		__raw_writew(value, address);
> +		return 0;
> +	case PCI_SIZE_32:
> +		__raw_writel(value, address);
> +		return 0;
> +	default:
> +		return -EINVAL;
> +	}
> +}
> +
> +/**
> + * pcie_xilinx_ofdata_to_platdata() - Translate from DT to device state
> + * @dev: A pointer to the device being operated on
> + *
> + * Translate relevant data from the device tree pertaining to device @dev into
> + * state that the driver will later make use of. This state is stored in the
> + * device's private data structure.
> + *
> + * Return: 0 on success, else -EINVAL
> + */
> +static int pcie_xilinx_ofdata_to_platdata(struct udevice *dev)
> +{
> +	struct xilinx_pcie *pcie = dev_get_priv(dev);
> +	struct fdt_resource reg_res;
> +	DECLARE_GLOBAL_DATA_PTR;
> +	int err;
> +
> +	err = fdt_get_resource(gd->fdt_blob, dev->of_offset, "reg",
> +			       0, &reg_res);
> +	if (err < 0) {
> +		error("\"reg\" resource not found\n");
> +		return err;
> +	}
> +
> +	pcie->cfg_base = ioremap_nocache(reg_res.start,
> +					 fdt_resource_size(&reg_res));
> +

Getting error here.
  CC      cmd/mem.o
  CC      drivers/net/phy/atheros.o
  CC      drivers/net/xilinx_emaclite.o
drivers/pci/pcie_xilinx.c: In function 'pcie_xilinx_ofdata_to_platdata':
drivers/pci/pcie_xilinx.c:196:17: warning: assignment makes pointer from
integer without a cast
  pcie->cfg_base = ioremap_nocache(reg_res.start,
                 ^
  CC      drivers/net/phy/broadcom.o
  CC      cmd/mfsl.o


Simon: Is this the right place for doing ioremap?
IRC There should be probe function where you call this and this function
will just fill platdata structure.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160804/3587699b/attachment.sig>

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle
  2016-08-04  9:50   ` Michal Simek
@ 2016-08-04  9:59     ` Paul Burton
  2016-08-04 10:02       ` Michal Simek
  0 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-04  9:59 UTC (permalink / raw)
  To: u-boot

On 04/08/16 10:50, Michal Simek wrote:
>> @@ -352,6 +353,8 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
>>  {
>>  	struct ns16550_platdata *plat = dev->platdata;
>>  	fdt_addr_t addr;
>> +	struct clk clk;
>> +	int err;
>>
>>  	/* try Processor Local Bus device first */
>>  	addr = dev_get_addr(dev);
>> @@ -397,9 +400,19 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
>>  				     "reg-offset", 0);
>>  	plat->reg_shift = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>>  					 "reg-shift", 0);
>> -	plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>> -				     "clock-frequency",
>> -				     CONFIG_SYS_NS16550_CLK);
>> +
>> +	err = clk_get_by_index(dev, 0, &clk);
>> +	if (!err) {
>> +		plat->clock = clk_get_rate(&clk);
>> +	} else if (err != -ENODEV) {
>> +		debug("ns16550 failed to get clock\n");
>> +		return err;
>> +	}
>> +
>> +	if (!plat->clock)
>> +		plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>> +					     "clock-frequency",
>> +					     CONFIG_SYS_NS16550_CLK);
>>  	if (!plat->clock) {
>>  		debug("ns16550 clock not defined\n");
>>  		return -EINVAL;
>>
>
>
> NACK. It is missing dependency on clk uclass which is not enabled by
> default on Microblaze. Maybe also on others. You should add some ifs around.
>
> Thanks,
> Michal

I'm not sure #ifdef'ing in this code is the nicest solution. How about 
if we allow -ENOSYS through the error handling above like -ENODEV, and 
provide the dummy clk_get_by_* implementations when CONFIG_CLK is 
disabled? As in:

diff --git a/include/clk.h b/include/clk.h
index 161bc28..328f364 100644
--- a/include/clk.h
+++ b/include/clk.h
@@ -59,7 +59,7 @@ struct clk {
         unsigned long id;
  };

-#if CONFIG_IS_ENABLED(OF_CONTROL)
+#if CONFIG_IS_ENABLED(OF_CONTROL) && CONFIG_IS_ENABLED(CONFIG_CLK)
  struct phandle_2_cell;
  int clk_get_by_index_platdata(struct udevice *dev, int index,
                               struct phandle_2_cell *cells, struct clk 
*clk);

Thanks,
     Paul

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
  2016-08-01 12:51       ` Paul Burton
@ 2016-08-04 10:00         ` Michal Simek
  2016-08-04 10:04           ` Paul Burton
  0 siblings, 1 reply; 25+ messages in thread
From: Michal Simek @ 2016-08-04 10:00 UTC (permalink / raw)
  To: u-boot

On 1.8.2016 14:51, Paul Burton wrote:
> On 01/08/16 13:41, Michal Simek wrote:
>> On 1.8.2016 14:09, Paul Burton wrote:
>>> On 01/08/16 11:46, Michal Simek wrote:
>>>> On 1.8.2016 12:06, Paul Burton wrote:
>>>>> This series introduces initial support for the MIPS Boston, and FPGA
>>>>> based development board & successor to the older Malta board. Further
>>>>> peripheral work is needed but this introduces the basics.
>>>>>
>>>>> This can be tested in a currently out-of-tree QEMU port if desired,
>>>>> which can be found in the boston branch of:
>>>>>
>>>>>   git://git.linux-mips.org/pub/scm/paul/qemu.git
>>>>>
>>>>> QEMU can be used to run U-Boot like this:
>>>>>
>>>>>   ./configure --target-list=mips64el-softmmu
>>>>>   make
>>>>>   ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
>>>>>     -bios u-boot.bin -serial stdio
>>>>
>>>> I have tried it and nothing is coming up.
>>>>
>>>> Latest u-boot + your patches
>>>> make boston64r2el_defconfig
>>>>
>>>> and your qemu on ubuntu 14.
>>>>
>>>> Can you recheck it?
>>>>
>>>> Thanks,
>>>> Michal
>>>
>>> Hi Michal,
>>>
>>> This would be because U-Boot is being built for MIPS64r2 whilst QEMU is
>>> emulating the MIPS64r6-implementing I6400, and MIPSr6 isn't entirely
>>> backwards compatible with MIPSr2. If you reconfigure U-Boot to build for
>>> MIPS64r6 then you should find that it runs correctly. I'll add mention
>>> of that to the README file.
>>
>> sorry don't have any overview about mips at all.
>> But last patch is adding 4 defconfigs 32r2 and 64r2 (big and little)
>> endian.
>>
>> I do use
>> .buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin//mips-linux-gcc
>>
>> And getting this when I change it to mips64r6
>> mips-linux-gcc: error: unrecognized argument in option '-march=mips64r6'
> 
> Hi Michal,
> 
> Ah, and that's why the defconfigs were changed to MIPSr2 in v3 of the
> patchset. The Boston board can technically use CPUs implementing any
> architecture revision, but is most commonly used with ones implementing
> MIPSr6 hence the QEMU default. If it weren't for that buildman failure
> with MIPSr6 it'd be the Boston defconfig default too.
> 
>> Are there any toolchain at generic location which buildman can use?
> 
> The toolchain I use is the codescape one available from imgtec.com:
> 
>     http://codescape-mips-sdk.imgtec.com/components/toolchain/2015.06-05/
> 
> The "IMG GNU Linux Toolchain" from that page will suffice. Anything with
> gcc 5.x or newer should work too if you wanted to use crosstool-ng,
> buildroot or similar to produce a toolchain.

Ok. That toolchain work and qemu too.

There is this compilation warning.

  CC      common/autoboot.o
  CC      common/board_f.o
  CC      common/board_r.o
common/autoboot.c: In function ?process_fdt_options?:
common/autoboot.c:281:27: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
   setenv_addr("kernaddr", (void *)(CONFIG_SYS_TEXT_BASE + addr));
                           ^
common/autoboot.c:286:27: warning: cast to pointer from integer of
different size [-Wint-to-pointer-cast]
   setenv_addr("rootaddr", (void *)(CONFIG_SYS_TEXT_BASE + addr));
                           ^
In file included from ././include/linux/kconfig.h:4:0,
                 from <command-line>:0:
common/board_f.c: In function ?display_text_info?:
include/generated/autoconf.h:94:30: warning: large integer implicitly
truncated to unsigned type [-Woverflow]
 #define CONFIG_SYS_TEXT_BASE 0xffffffff9fc00000
                              ^
common/board_f.c:158:14: note: in expansion of macro ?CONFIG_SYS_TEXT_BASE?
  text_base = CONFIG_SYS_TEXT_BASE;
              ^
  CC      cmd/itest.o
  CC      cmd/load.o
  CC      cmd/mem.o
  LD      drivers/dfu/built-in.o
  CC      common/board_info.o
  LD      drivers/hwmon/built-in.o
  CC      drivers/input/input.o
  CC      common/bootm.o


I personally prefer if you can integrate this to buildman and maybe you
can use qemu defconfig. Description in Readme would be also helpful that
everybody understands what to do.

Toolchain at kernel.org which support this will be useful too.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle
  2016-08-04  9:59     ` Paul Burton
@ 2016-08-04 10:02       ` Michal Simek
  0 siblings, 0 replies; 25+ messages in thread
From: Michal Simek @ 2016-08-04 10:02 UTC (permalink / raw)
  To: u-boot

On 4.8.2016 11:59, Paul Burton wrote:
> On 04/08/16 10:50, Michal Simek wrote:
>>> @@ -352,6 +353,8 @@ int ns16550_serial_ofdata_to_platdata(struct
>>> udevice *dev)
>>>  {
>>>      struct ns16550_platdata *plat = dev->platdata;
>>>      fdt_addr_t addr;
>>> +    struct clk clk;
>>> +    int err;
>>>
>>>      /* try Processor Local Bus device first */
>>>      addr = dev_get_addr(dev);
>>> @@ -397,9 +400,19 @@ int ns16550_serial_ofdata_to_platdata(struct
>>> udevice *dev)
>>>                       "reg-offset", 0);
>>>      plat->reg_shift = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>>>                       "reg-shift", 0);
>>> -    plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>>> -                     "clock-frequency",
>>> -                     CONFIG_SYS_NS16550_CLK);
>>> +
>>> +    err = clk_get_by_index(dev, 0, &clk);
>>> +    if (!err) {
>>> +        plat->clock = clk_get_rate(&clk);
>>> +    } else if (err != -ENODEV) {
>>> +        debug("ns16550 failed to get clock\n");
>>> +        return err;
>>> +    }
>>> +
>>> +    if (!plat->clock)
>>> +        plat->clock = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>>> +                         "clock-frequency",
>>> +                         CONFIG_SYS_NS16550_CLK);
>>>      if (!plat->clock) {
>>>          debug("ns16550 clock not defined\n");
>>>          return -EINVAL;
>>>
>>
>>
>> NACK. It is missing dependency on clk uclass which is not enabled by
>> default on Microblaze. Maybe also on others. You should add some ifs
>> around.
>>
>> Thanks,
>> Michal
> 
> I'm not sure #ifdef'ing in this code is the nicest solution. How about
> if we allow -ENOSYS through the error handling above like -ENODEV, and
> provide the dummy clk_get_by_* implementations when CONFIG_CLK is
> disabled? As in:
> 
> diff --git a/include/clk.h b/include/clk.h
> index 161bc28..328f364 100644
> --- a/include/clk.h
> +++ b/include/clk.h
> @@ -59,7 +59,7 @@ struct clk {
>         unsigned long id;
>  };
> 
> -#if CONFIG_IS_ENABLED(OF_CONTROL)
> +#if CONFIG_IS_ENABLED(OF_CONTROL) && CONFIG_IS_ENABLED(CONFIG_CLK)
>  struct phandle_2_cell;
>  int clk_get_by_index_platdata(struct udevice *dev, int index,
>                               struct phandle_2_cell *cells, struct clk
> *clk);

No problem with it from my side.
Just to make sure that you can build it on other archs and there is no
big overhead.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support
  2016-08-04 10:00         ` Michal Simek
@ 2016-08-04 10:04           ` Paul Burton
  0 siblings, 0 replies; 25+ messages in thread
From: Paul Burton @ 2016-08-04 10:04 UTC (permalink / raw)
  To: u-boot

On 04/08/16 11:00, Michal Simek wrote:
> On 1.8.2016 14:51, Paul Burton wrote:
>> On 01/08/16 13:41, Michal Simek wrote:
>>> On 1.8.2016 14:09, Paul Burton wrote:
>>>> On 01/08/16 11:46, Michal Simek wrote:
>>>>> On 1.8.2016 12:06, Paul Burton wrote:
>>>>>> This series introduces initial support for the MIPS Boston, and FPGA
>>>>>> based development board & successor to the older Malta board. Further
>>>>>> peripheral work is needed but this introduces the basics.
>>>>>>
>>>>>> This can be tested in a currently out-of-tree QEMU port if desired,
>>>>>> which can be found in the boston branch of:
>>>>>>
>>>>>>   git://git.linux-mips.org/pub/scm/paul/qemu.git
>>>>>>
>>>>>> QEMU can be used to run U-Boot like this:
>>>>>>
>>>>>>   ./configure --target-list=mips64el-softmmu
>>>>>>   make
>>>>>>   ./mips64el-softmmu/qemu-system-mips64el -M boston -m 2G \
>>>>>>     -bios u-boot.bin -serial stdio
>>>>>
>>>>> I have tried it and nothing is coming up.
>>>>>
>>>>> Latest u-boot + your patches
>>>>> make boston64r2el_defconfig
>>>>>
>>>>> and your qemu on ubuntu 14.
>>>>>
>>>>> Can you recheck it?
>>>>>
>>>>> Thanks,
>>>>> Michal
>>>>
>>>> Hi Michal,
>>>>
>>>> This would be because U-Boot is being built for MIPS64r2 whilst QEMU is
>>>> emulating the MIPS64r6-implementing I6400, and MIPSr6 isn't entirely
>>>> backwards compatible with MIPSr2. If you reconfigure U-Boot to build for
>>>> MIPS64r6 then you should find that it runs correctly. I'll add mention
>>>> of that to the README file.
>>>
>>> sorry don't have any overview about mips at all.
>>> But last patch is adding 4 defconfigs 32r2 and 64r2 (big and little)
>>> endian.
>>>
>>> I do use
>>> .buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin//mips-linux-gcc
>>>
>>> And getting this when I change it to mips64r6
>>> mips-linux-gcc: error: unrecognized argument in option '-march=mips64r6'
>>
>> Hi Michal,
>>
>> Ah, and that's why the defconfigs were changed to MIPSr2 in v3 of the
>> patchset. The Boston board can technically use CPUs implementing any
>> architecture revision, but is most commonly used with ones implementing
>> MIPSr6 hence the QEMU default. If it weren't for that buildman failure
>> with MIPSr6 it'd be the Boston defconfig default too.
>>
>>> Are there any toolchain at generic location which buildman can use?
>>
>> The toolchain I use is the codescape one available from imgtec.com:
>>
>>     http://codescape-mips-sdk.imgtec.com/components/toolchain/2015.06-05/
>>
>> The "IMG GNU Linux Toolchain" from that page will suffice. Anything with
>> gcc 5.x or newer should work too if you wanted to use crosstool-ng,
>> buildroot or similar to produce a toolchain.
>
> Ok. That toolchain work and qemu too.
>
> There is this compilation warning.
>
>   CC      common/autoboot.o
>   CC      common/board_f.o
>   CC      common/board_r.o
> common/autoboot.c: In function ?process_fdt_options?:
> common/autoboot.c:281:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>    setenv_addr("kernaddr", (void *)(CONFIG_SYS_TEXT_BASE + addr));
>                            ^
> common/autoboot.c:286:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>    setenv_addr("rootaddr", (void *)(CONFIG_SYS_TEXT_BASE + addr));
>                            ^
> In file included from ././include/linux/kconfig.h:4:0,
>                  from <command-line>:0:
> common/board_f.c: In function ?display_text_info?:
> include/generated/autoconf.h:94:30: warning: large integer implicitly
> truncated to unsigned type [-Woverflow]
>  #define CONFIG_SYS_TEXT_BASE 0xffffffff9fc00000
>                               ^
> common/board_f.c:158:14: note: in expansion of macro ?CONFIG_SYS_TEXT_BASE?
>   text_base = CONFIG_SYS_TEXT_BASE;
>               ^

Hi Michal,

Interesting, I haven't been seeing this. Did you build for 32 bit by any 
chance? If so then I think you've somehow ended up with the 
CONFIG_SYS_TEXT_BASE appropriate for a 64 bit build. I'll doublecheck 
the defconfigs.

>   CC      cmd/itest.o
>   CC      cmd/load.o
>   CC      cmd/mem.o
>   LD      drivers/dfu/built-in.o
>   CC      common/board_info.o
>   LD      drivers/hwmon/built-in.o
>   CC      drivers/input/input.o
>   CC      common/bootm.o
>
>
> I personally prefer if you can integrate this to buildman and maybe you
> can use qemu defconfig. Description in Readme would be also helpful that
> everybody understands what to do.
>
> Toolchain at kernel.org which support this will be useful too.

I added a section to README.boston describing the situation with 
architecture revisions & toolchains in v5. Daniel mentioned he was going 
to look at supporting a newer toolchain in buildman.

Thanks,
     Paul

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge
  2016-08-04  9:54   ` Michal Simek
@ 2016-08-04 10:24     ` Paul Burton
  2016-08-05  1:36       ` Simon Glass
  0 siblings, 1 reply; 25+ messages in thread
From: Paul Burton @ 2016-08-04 10:24 UTC (permalink / raw)
  To: u-boot



On 04/08/16 10:54, Michal Simek wrote:
> On 1.8.2016 12:06, Paul Burton wrote:
>> This patch adds a driver for the Xilinx AXI bridge for PCI express, an
>> IP block which can be used on some generations of Xilinx FPGAs. This is
>> mostly a case of implementing PCIe ECAM specification, but with some
>> quirks about what devices are valid to access.
>>
>> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2:
>> - Clean up error returns & documentation
>>
>>  drivers/pci/Kconfig       |   7 ++
>>  drivers/pci/Makefile      |   1 +
>>  drivers/pci/pcie_xilinx.c | 219 ++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 227 insertions(+)
>>  create mode 100644 drivers/pci/pcie_xilinx.c
>>
>> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
>> index 26aa2b0..1f9ea66 100644
>> --- a/drivers/pci/Kconfig
>> +++ b/drivers/pci/Kconfig
>> @@ -38,4 +38,11 @@ config PCI_TEGRA
>>  	  with a total of 5 lanes. Some boards require this for Ethernet
>>  	  support to work (e.g. beaver, jetson-tk1).
>>
>> +config PCI_XILINX
>> +	bool "Xilinx AXI Bridge for PCI Express"
>> +	depends on DM_PCI
>
> There is also dependency on PCI which should be added to Kconfig.
> And it can be compiled only for MB and Mips.
> It means you should limit it like that or fix that problem with
> ioremap_nocache.
>
>> +	help
>> +	  Enable support for the Xilinx AXI bridge for PCI express, an IP block
>> +	  which can be used on some generations of Xilinx FPGAs.
>> +
>>  endmenu
>> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile
>> index f8be9bf..9583e91 100644
>> --- a/drivers/pci/Makefile
>> +++ b/drivers/pci/Makefile
>> @@ -31,3 +31,4 @@ obj-$(CONFIG_PCI_TEGRA) += pci_tegra.o
>>  obj-$(CONFIG_TSI108_PCI) += tsi108_pci.o
>>  obj-$(CONFIG_WINBOND_83C553) += w83c553f.o
>>  obj-$(CONFIG_PCIE_LAYERSCAPE) += pcie_layerscape.o
>> +obj-$(CONFIG_PCI_XILINX) += pcie_xilinx.o
>> diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c
>> new file mode 100644
>> index 0000000..9fe02be
>> --- /dev/null
>> +++ b/drivers/pci/pcie_xilinx.c
>> @@ -0,0 +1,219 @@
>> +/*
>> + * Xilinx AXI Bridge for PCI Express Driver
>> + *
>> + * Copyright (C) 2016 Imagination Technologies
>> + *
>> + * SPDX-License-Identifier:	GPL-2.0
>> + */
>> +
>> +#include <common.h>
>> +#include <dm.h>
>> +#include <pci.h>
>> +
>> +#include <asm/io.h>
>> +
>> +/**
>> + * struct xilinx_pcie - Xilinx PCIe controller state
>> + * @hose: The parent classes PCI controller state
>> + * @cfg_base: The base address of memory mapped configuration space
>> + */
>> +struct xilinx_pcie {
>> +	struct pci_controller hose;
>> +	void *cfg_base;
>> +};
>> +
>> +/* Register definitions */
>> +#define XILINX_PCIE_REG_PSCR		0x144
>> +#define XILINX_PCIE_REG_PSCR_LNKUP	BIT(11)
>> +
>> +/**
>> + * pcie_xilinx_link_up() - Check whether the PCIe link is up
>> + * @pcie: Pointer to the PCI controller state
>> + *
>> + * Checks whether the PCIe link for the given device is up or down.
>> + *
>> + * Return: true if the link is up, else false
>> + */
>> +static bool pcie_xilinx_link_up(struct xilinx_pcie *pcie)
>> +{
>> +	uint32_t pscr = __raw_readl(pcie->cfg_base + XILINX_PCIE_REG_PSCR);
>> +
>> +	return pscr & XILINX_PCIE_REG_PSCR_LNKUP;
>> +}
>> +
>> +/**
>> + * pcie_xilinx_config_address() - Calculate the address of a config access
>> + * @pcie: Pointer to the PCI controller state
>> + * @bdf: Identifies the PCIe device to access
>> + * @offset: The offset into the device's configuration space
>> + * @paddress: Pointer to the pointer to write the calculates address to
>> + *
>> + * Calculates the address that should be accessed to perform a PCIe
>> + * configuration space access for a given device identified by the PCIe
>> + * controller device @pcie and the bus, device & function numbers in @bdf. If
>> + * access to the device is not valid then the function will return an error
>> + * code. Otherwise the address to access will be written to the pointer pointed
>> + * to by @paddress.
>> + *
>> + * Return: 0 on success, else -ENODEV
>> + */
>> +static int pcie_xilinx_config_address(struct xilinx_pcie *pcie, pci_dev_t bdf,
>> +				      uint offset, void **paddress)
>> +{
>> +	unsigned int bus = PCI_BUS(bdf);
>> +	unsigned int dev = PCI_DEV(bdf);
>> +	unsigned int func = PCI_FUNC(bdf);
>> +	void *addr;
>> +
>> +	if ((bus > 0) && !pcie_xilinx_link_up(pcie))
>> +		return -ENODEV;
>> +
>> +	/*
>> +	 * Busses 0 (host-PCIe bridge) & 1 (its immediate child) are
>> +	 * limited to a single device each.
>> +	 */
>> +	if ((bus < 2) && (dev > 0))
>> +		return -ENODEV;
>> +
>> +	addr = pcie->cfg_base;
>> +	addr += bus << 20;
>> +	addr += dev << 15;
>> +	addr += func << 12;
>> +	addr += offset;
>> +	*paddress = addr;
>> +
>> +	return 0;
>> +}
>> +
>> +/**
>> + * pcie_xilinx_read_config() - Read from configuration space
>> + * @pcie: Pointer to the PCI controller state
>> + * @bdf: Identifies the PCIe device to access
>> + * @offset: The offset into the device's configuration space
>> + * @valuep: A pointer at which to store the read value
>> + * @size: Indicates the size of access to perform
>> + *
>> + * Read a value of size @size from offset @offset within the configuration
>> + * space of the device identified by the bus, device & function numbers in @bdf
>> + * on the PCI bus @bus.
>> + *
>> + * Return: 0 on success, else -ENODEV or -EINVAL
>> + */
>> +static int pcie_xilinx_read_config(struct udevice *bus, pci_dev_t bdf,
>> +				   uint offset, ulong *valuep,
>> +				   enum pci_size_t size)
>> +{
>> +	struct xilinx_pcie *pcie = dev_get_priv(bus);
>> +	void *address;
>> +	int err;
>> +
>> +	err = pcie_xilinx_config_address(pcie, bdf, offset, &address);
>> +	if (err < 0) {
>> +		*valuep = pci_get_ff(size);
>> +		return 0;
>> +	}
>> +
>> +	switch (size) {
>> +	case PCI_SIZE_8:
>> +		*valuep = __raw_readb(address);
>> +		return 0;
>> +	case PCI_SIZE_16:
>> +		*valuep = __raw_readw(address);
>> +		return 0;
>> +	case PCI_SIZE_32:
>> +		*valuep = __raw_readl(address);
>> +		return 0;
>> +	default:
>> +		return -EINVAL;
>> +	}
>> +}
>> +
>> +/**
>> + * pcie_xilinx_write_config() - Write to configuration space
>> + * @pcie: Pointer to the PCI controller state
>> + * @bdf: Identifies the PCIe device to access
>> + * @offset: The offset into the device's configuration space
>> + * @value: The value to write
>> + * @size: Indicates the size of access to perform
>> + *
>> + * Write the value @value of size @size from offset @offset within the
>> + * configuration space of the device identified by the bus, device & function
>> + * numbers in @bdf on the PCI bus @bus.
>> + *
>> + * Return: 0 on success, else -ENODEV or -EINVAL
>> + */
>> +static int pcie_xilinx_write_config(struct udevice *bus, pci_dev_t bdf,
>> +				    uint offset, ulong value,
>> +				    enum pci_size_t size)
>> +{
>> +	struct xilinx_pcie *pcie = dev_get_priv(bus);
>> +	void *address;
>> +	int err;
>> +
>> +	err = pcie_xilinx_config_address(pcie, bdf, offset, &address);
>> +	if (err < 0)
>> +		return 0;
>> +
>> +	switch (size) {
>> +	case PCI_SIZE_8:
>> +		__raw_writeb(value, address);
>> +		return 0;
>> +	case PCI_SIZE_16:
>> +		__raw_writew(value, address);
>> +		return 0;
>> +	case PCI_SIZE_32:
>> +		__raw_writel(value, address);
>> +		return 0;
>> +	default:
>> +		return -EINVAL;
>> +	}
>> +}
>> +
>> +/**
>> + * pcie_xilinx_ofdata_to_platdata() - Translate from DT to device state
>> + * @dev: A pointer to the device being operated on
>> + *
>> + * Translate relevant data from the device tree pertaining to device @dev into
>> + * state that the driver will later make use of. This state is stored in the
>> + * device's private data structure.
>> + *
>> + * Return: 0 on success, else -EINVAL
>> + */
>> +static int pcie_xilinx_ofdata_to_platdata(struct udevice *dev)
>> +{
>> +	struct xilinx_pcie *pcie = dev_get_priv(dev);
>> +	struct fdt_resource reg_res;
>> +	DECLARE_GLOBAL_DATA_PTR;
>> +	int err;
>> +
>> +	err = fdt_get_resource(gd->fdt_blob, dev->of_offset, "reg",
>> +			       0, &reg_res);
>> +	if (err < 0) {
>> +		error("\"reg\" resource not found\n");
>> +		return err;
>> +	}
>> +
>> +	pcie->cfg_base = ioremap_nocache(reg_res.start,
>> +					 fdt_resource_size(&reg_res));
>> +
>
> Getting error here.
>   CC      cmd/mem.o
>   CC      drivers/net/phy/atheros.o
>   CC      drivers/net/xilinx_emaclite.o
> drivers/pci/pcie_xilinx.c: In function 'pcie_xilinx_ofdata_to_platdata':
> drivers/pci/pcie_xilinx.c:196:17: warning: assignment makes pointer from
> integer without a cast
>   pcie->cfg_base = ioremap_nocache(reg_res.start,
>                  ^

Thanks, I'll switch to map_physmem.

>   CC      drivers/net/phy/broadcom.o
>   CC      cmd/mfsl.o
>
>
> Simon: Is this the right place for doing ioremap?
> IRC There should be probe function where you call this and this function
> will just fill platdata structure.

ofdata_to_platdata is called right before probe, so I'm not sure there's 
any point in passing the physical address via the private data struct 
just to map it very shortly after & ignore it forevermore.

Thanks,
     Paul

> Thanks,
> Michal
>
>

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge
  2016-08-04 10:24     ` Paul Burton
@ 2016-08-05  1:36       ` Simon Glass
  0 siblings, 0 replies; 25+ messages in thread
From: Simon Glass @ 2016-08-05  1:36 UTC (permalink / raw)
  To: u-boot

Hi Paul,

On 4 August 2016 at 04:24, Paul Burton <paul.burton@imgtec.com> wrote:
>
>
> On 04/08/16 10:54, Michal Simek wrote:
>>
>> On 1.8.2016 12:06, Paul Burton wrote:
>>>
>>> This patch adds a driver for the Xilinx AXI bridge for PCI express, an
>>> IP block which can be used on some generations of Xilinx FPGAs. This is
>>> mostly a case of implementing PCIe ECAM specification, but with some
>>> quirks about what devices are valid to access.
>>>
>>> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>
>>> ---
>>>
>>> Changes in v4: None
>>> Changes in v3: None
>>> Changes in v2:
>>> - Clean up error returns & documentation
>>>
>>>  drivers/pci/Kconfig       |   7 ++
>>>  drivers/pci/Makefile      |   1 +
>>>  drivers/pci/pcie_xilinx.c | 219
>>> ++++++++++++++++++++++++++++++++++++++++++++++
>>>  3 files changed, 227 insertions(+)
>>>  create mode 100644 drivers/pci/pcie_xilinx.c

[...]

>>> +
>>> +/**
>>> + * pcie_xilinx_ofdata_to_platdata() - Translate from DT to device state
>>> + * @dev: A pointer to the device being operated on
>>> + *
>>> + * Translate relevant data from the device tree pertaining to device
>>> @dev into
>>> + * state that the driver will later make use of. This state is stored in
>>> the
>>> + * device's private data structure.
>>> + *
>>> + * Return: 0 on success, else -EINVAL
>>> + */
>>> +static int pcie_xilinx_ofdata_to_platdata(struct udevice *dev)
>>> +{
>>> +       struct xilinx_pcie *pcie = dev_get_priv(dev);
>>> +       struct fdt_resource reg_res;
>>> +       DECLARE_GLOBAL_DATA_PTR;
>>> +       int err;
>>> +
>>> +       err = fdt_get_resource(gd->fdt_blob, dev->of_offset, "reg",
>>> +                              0, &reg_res);
>>> +       if (err < 0) {
>>> +               error("\"reg\" resource not found\n");
>>> +               return err;
>>> +       }
>>> +
>>> +       pcie->cfg_base = ioremap_nocache(reg_res.start,
>>> +                                        fdt_resource_size(&reg_res));
>>> +
>>
>>
>> Getting error here.
>>   CC      cmd/mem.o
>>   CC      drivers/net/phy/atheros.o
>>   CC      drivers/net/xilinx_emaclite.o
>> drivers/pci/pcie_xilinx.c: In function 'pcie_xilinx_ofdata_to_platdata':
>> drivers/pci/pcie_xilinx.c:196:17: warning: assignment makes pointer from
>> integer without a cast
>>   pcie->cfg_base = ioremap_nocache(reg_res.start,
>>                  ^
>
>
> Thanks, I'll switch to map_physmem.
>
>>   CC      drivers/net/phy/broadcom.o
>>   CC      cmd/mfsl.o
>>
>>
>> Simon: Is this the right place for doing ioremap?
>> IRC There should be probe function where you call this and this function
>> will just fill platdata structure.
>
>
> ofdata_to_platdata is called right before probe, so I'm not sure there's any
> point in passing the physical address via the private data struct just to
> map it very shortly after & ignore it forevermore.

It is more correct though. If you don't want to do that, I suggest
moving it to probe().

Regards,
Simon

^ permalink raw reply	[flat|nested] 25+ messages in thread
end of thread, other threads:[~2016-08-05  1:36 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-01 10:06 [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Paul Burton
2016-08-01 10:06 ` [U-Boot] [PATCH v4 01/11] serial: ns16550: Support clocks via phandle Paul Burton
2016-08-04  9:50   ` Michal Simek
2016-08-04  9:59     ` Paul Burton
2016-08-04 10:02       ` Michal Simek
2016-08-01 10:06 ` [U-Boot] [PATCH v4 02/11] dt-bindings: Add interrupt-controller/mips-gic.h header Paul Burton
2016-08-01 10:06 ` [U-Boot] [PATCH v4 03/11] pci: xilinx: Add a driver for Xilinx AXI to PCIe bridge Paul Burton
2016-08-04  9:54   ` Michal Simek
2016-08-04 10:24     ` Paul Burton
2016-08-05  1:36       ` Simon Glass
2016-08-01 10:06 ` [U-Boot] [PATCH v4 04/11] pci: Flip condition for detecting non-PCI parent devices Paul Burton
2016-08-01 10:06 ` [U-Boot] [PATCH v4 05/11] net: pch_gbe: Use dm_pci_map_bar to discover MMIO base Paul Burton
2016-08-01 10:07 ` [U-Boot] [PATCH v4 06/11] net: pch_gbe: Make 64 bit safe Paul Burton
2016-08-01 10:07 ` [U-Boot] [PATCH v4 07/11] dm: regmap: Implement simple regmap_read & regmap_write Paul Burton
2016-08-01 10:07 ` [U-Boot] [PATCH v4 08/11] dm: core: Match compatible strings in order of priority Paul Burton
2016-08-01 10:07 ` [U-Boot] [PATCH v4 09/11] dm: syscon: Provide a generic syscon driver Paul Burton
2016-08-01 10:07 ` [U-Boot] [PATCH v4 10/11] clk: boston: Providea simple driver for Boston board clocks Paul Burton
2016-08-01 10:07 ` [U-Boot] [PATCH v4 11/11] boston: Introduce support for the MIPS Boston development board Paul Burton
2016-08-02 13:14   ` [U-Boot] [PATCH v5 " Paul Burton
2016-08-01 10:46 ` [U-Boot] [PATCH v4 00/11] MIPS Boston Development Board Support Michal Simek
2016-08-01 12:09   ` Paul Burton
2016-08-01 12:41     ` Michal Simek
2016-08-01 12:51       ` Paul Burton
2016-08-04 10:00         ` Michal Simek
2016-08-04 10:04           ` Paul Burton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.