* [radeon-alex:drm-next-4.9-si 117/127] drivers/gpu/drm/amd/amdgpu/si.c:1017:8-9: WARNING: return of 0/1 in function 'si_read_disabled_bios' with return type bool
@ 2016-08-01 22:55 kbuild test robot
2016-08-01 22:55 ` [PATCH] drm/amdgpu: fix boolreturn.cocci warnings kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2016-08-01 22:55 UTC (permalink / raw)
To: Ken Wang; +Cc: Alex Deucher, kbuild-all, dri-devel, Christian König
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.9-si
head: 80c6bf7b975077c63b6506d7dd6cb895d72afab2
commit: d1f7ef0f00bbbc985bf5ce8bdecf1944df11681a [117/127] drm/amdgpu: add all the components for si into Makefile/kconfig v3
coccinelle warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/amd/amdgpu/si.c:1017:8-9: WARNING: return of 0/1 in function 'si_read_disabled_bios' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] drm/amdgpu: fix boolreturn.cocci warnings
2016-08-01 22:55 [radeon-alex:drm-next-4.9-si 117/127] drivers/gpu/drm/amd/amdgpu/si.c:1017:8-9: WARNING: return of 0/1 in function 'si_read_disabled_bios' with return type bool kbuild test robot
@ 2016-08-01 22:55 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2016-08-01 22:55 UTC (permalink / raw)
To: Ken Wang; +Cc: Alex Deucher, kbuild-all, dri-devel, Christian König
drivers/gpu/drm/amd/amdgpu/si.c:1017:8-9: WARNING: return of 0/1 in function 'si_read_disabled_bios' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Ken Wang <Qingqing.Wang@amd.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
si.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@ -1014,7 +1014,7 @@ static int si_read_register(struct amdgp
static bool si_read_disabled_bios(struct amdgpu_device *adev)
{
- return 0;
+ return false;
}
//xxx: not implemented
static int si_asic_reset(struct amdgpu_device *adev)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-01 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-01 22:55 [radeon-alex:drm-next-4.9-si 117/127] drivers/gpu/drm/amd/amdgpu/si.c:1017:8-9: WARNING: return of 0/1 in function 'si_read_disabled_bios' with return type bool kbuild test robot
2016-08-01 22:55 ` [PATCH] drm/amdgpu: fix boolreturn.cocci warnings kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.