* [PATCH 0004/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:33 ` Baole Ni
0 siblings, 0 replies; 2+ messages in thread
From: Baole Ni @ 2016-08-02 10:33 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, linux
Cc: linux-arm-kernel, linux-kernel, chuansheng.liu, baolex.ni
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
arch/arm/mach-imx/mach-mx31lite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-mx31lite.c b/arch/arm/mach-imx/mach-mx31lite.c
index 4822a17..0da699c 100644
--- a/arch/arm/mach-imx/mach-mx31lite.c
+++ b/arch/arm/mach-imx/mach-mx31lite.c
@@ -224,7 +224,7 @@ void __init mx31lite_map_io(void)
}
static int mx31lite_baseboard;
-core_param(mx31lite_baseboard, mx31lite_baseboard, int, 0444);
+core_param(mx31lite_baseboard, mx31lite_baseboard, int, S_IRUSR | S_IRGRP | S_IROTH);
static struct regulator_consumer_supply dummy_supplies[] = {
REGULATOR_SUPPLY("vdd33a", "smsc911x"),
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 0004/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 10:33 ` Baole Ni
0 siblings, 0 replies; 2+ messages in thread
From: Baole Ni @ 2016-08-02 10:33 UTC (permalink / raw)
To: linux-arm-kernel
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
arch/arm/mach-imx/mach-mx31lite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-mx31lite.c b/arch/arm/mach-imx/mach-mx31lite.c
index 4822a17..0da699c 100644
--- a/arch/arm/mach-imx/mach-mx31lite.c
+++ b/arch/arm/mach-imx/mach-mx31lite.c
@@ -224,7 +224,7 @@ void __init mx31lite_map_io(void)
}
static int mx31lite_baseboard;
-core_param(mx31lite_baseboard, mx31lite_baseboard, int, 0444);
+core_param(mx31lite_baseboard, mx31lite_baseboard, int, S_IRUSR | S_IRGRP | S_IROTH);
static struct regulator_consumer_supply dummy_supplies[] = {
REGULATOR_SUPPLY("vdd33a", "smsc911x"),
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 10:33 [PATCH 0004/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 10:33 ` Baole Ni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.