All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0969/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:03 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:03 UTC (permalink / raw)
  To: gregkh, jslaby, m.chehab, m.szyprowski, kyungmin.park, k.kozlowski
  Cc: linux-serial, linux-kernel, chuansheng.liu, baolex.ni,
	andriy.shevchenko, wan.ahmad.zainie.wan.mohamad, mail, matwey

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/tty/serial/kgdb_nmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c
index 117df15..522c980 100644
--- a/drivers/tty/serial/kgdb_nmi.c
+++ b/drivers/tty/serial/kgdb_nmi.c
@@ -31,7 +31,7 @@
 #include <linux/kdb.h>
 
 static int kgdb_nmi_knock = 1;
-module_param_named(knock, kgdb_nmi_knock, int, 0600);
+module_param_named(knock, kgdb_nmi_knock, int, S_IRUSR | S_IWUSR);
 MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " \
 			"must be used to enter the debugger; when set to 0, " \
 			"hitting return key is enough to enter the debugger; " \
@@ -39,7 +39,7 @@ MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " \
 			"upon NMI");
 
 static char *kgdb_nmi_magic = "$3#33";
-module_param_named(magic, kgdb_nmi_magic, charp, 0600);
+module_param_named(magic, kgdb_nmi_magic, charp, S_IRUSR | S_IWUSR);
 MODULE_PARM_DESC(magic, "magic sequence to enter NMI debugger (default $3#33)");
 
 static atomic_t kgdb_nmi_num_readers = ATOMIC_INIT(0);
-- 
2.9.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 12:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:03 [PATCH 0969/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.