* [PATCH 1024/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:09 ` Baole Ni
0 siblings, 0 replies; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:09 UTC (permalink / raw)
To: mst, plagnioj, tomi.valkeinen, m.chehab, gregkh, m.szyprowski,
kyungmin.park, k.kozlowski
Cc: virtualization, linux-kernel, chuansheng.liu, baolex.ni, oneukum
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/virtio/virtio_pci_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
index d9a9058..f7d2262 100644
--- a/drivers/virtio/virtio_pci_common.c
+++ b/drivers/virtio/virtio_pci_common.c
@@ -22,7 +22,7 @@
static bool force_legacy = false;
#if IS_ENABLED(CONFIG_VIRTIO_PCI_LEGACY)
-module_param(force_legacy, bool, 0444);
+module_param(force_legacy, bool, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(force_legacy,
"Force legacy mode for transitional virtio 1 devices");
#endif
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 1024/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:09 ` Baole Ni
0 siblings, 0 replies; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:09 UTC (permalink / raw)
To: mst, plagnioj, tomi.valkeinen, m.chehab, gregkh, m.szyprowski,
kyungmin.park, k.kozlowski
Cc: baolex.ni, oneukum, chuansheng.liu, linux-kernel, virtualization
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/virtio/virtio_pci_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
index d9a9058..f7d2262 100644
--- a/drivers/virtio/virtio_pci_common.c
+++ b/drivers/virtio/virtio_pci_common.c
@@ -22,7 +22,7 @@
static bool force_legacy = false;
#if IS_ENABLED(CONFIG_VIRTIO_PCI_LEGACY)
-module_param(force_legacy, bool, 0444);
+module_param(force_legacy, bool, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(force_legacy,
"Force legacy mode for transitional virtio 1 devices");
#endif
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 14:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:09 [PATCH 1024/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:09 ` Baole Ni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.