[PATCH 1055/1285] Replace numeric parameter like 0444 with macro

* [PATCH 1055/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:12 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:12 UTC (permalink / raw)
  To: bfields, jlayton, trond.myklebust, anna.schumaker,
	tomi.valkeinen, m.chehab, gregkh, m.szyprowski, kyungmin.park,
	k.kozlowski
  Cc: linux-nfs, linux-kernel, chuansheng.liu, baolex.ni, oneukum

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 fs/nfsd/nfs4idmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
index 5b20577..7d4722c 100644
--- a/fs/nfsd/nfs4idmap.c
+++ b/fs/nfsd/nfs4idmap.c
@@ -46,7 +46,7 @@
  * Turn off idmapping when using AUTH_SYS.
  */
 static bool nfs4_disable_idmapping = true;
-module_param(nfs4_disable_idmapping, bool, 0644);
+module_param(nfs4_disable_idmapping, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(nfs4_disable_idmapping,
 		"Turn off server's NFSv4 idmapping when using 'sec=sys'");
 
-- 
2.9.2

^ permalink raw reply related	[flat|nested] only message in thread