All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1066/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:13 Baole Ni
  0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 12:13 UTC (permalink / raw)
  To: peterz, mingo, keescook, tony.luck, tomi.valkeinen, m.chehab,
	gregkh, m.szyprowski, kyungmin.park, k.kozlowski
  Cc: linux-kernel, chuansheng.liu, baolex.ni, rusty, jkosina

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 kernel/locking/locktorture.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index f8c5af5..265030a 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -59,7 +59,7 @@ torture_param(bool, verbose, true,
 	     "Enable verbose debugging printk()s");
 
 static char *torture_type = "spin_lock";
-module_param(torture_type, charp, 0444);
+module_param(torture_type, charp, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(torture_type,
 		 "Type of lock to torture (spin_lock, spin_lock_irq, mutex_lock, ...)");
 
@@ -76,7 +76,7 @@ struct lock_stress_stats {
 };
 
 int torture_runnable = IS_ENABLED(MODULE);
-module_param(torture_runnable, int, 0444);
+module_param(torture_runnable, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(torture_runnable, "Start locktorture at module init");
 
 /* Forward reference. */
-- 
2.9.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-02 14:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 12:13 [PATCH 1066/1285] Replace numeric parameter like 0444 with macro Baole Ni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.