All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	dyoung@redhat.com, d.hatayama@jp.fujitsu.com
Subject: Re: [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus
Date: Wed, 3 Aug 2016 09:23:41 +0800	[thread overview]
Message-ID: <20160803012341.GA3637@x1.redhat.com> (raw)
In-Reply-To: <1470185952-23477-1-git-send-email-zhouwj-fnst@cn.fujitsu.com>

On 08/03/16 at 08:59am, Zhou Wenjian wrote:
> v2->v3: add description of nr_cpus.
> v1->v2: change nr_cpus to maxcpus
> 
> nr_cpus can help to save memory. So we should remind user of it.
> 
> Signed-off-by: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com>
> ---
>  Documentation/kdump/kdump.txt | 2 ++
>  1 file changed, 2 insertions(+)

Looks good to me! Thanks, Wenjian.

Ack this series
Acked-by: Baoquan He <bhe@redhat.com>


Hi Andrew,

Could you please help merge this patchset?

Thanks
Baoquan

> 
> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
> index 88ff63d..4aa194e 100644
> --- a/Documentation/kdump/kdump.txt
> +++ b/Documentation/kdump/kdump.txt
> @@ -393,6 +393,8 @@ Notes on loading the dump-capture kernel:
>  * We generally don' have to bring up a SMP kernel just to capture the
>    dump. Hence generally it is useful either to build a UP dump-capture
>    kernel or specify maxcpus=1 option while loading dump-capture kernel.
> +  Note, though maxcpus always works, we should replace it by nr_cpus to
> +  save memory if supported by the current ARCH, such as x86. 
>  
>  * For s390x there are two kdump modes: If a ELF header is specified with
>    the elfcorehdr= kernel parameter, it is used by the kdump kernel as it
> -- 
> 1.8.3.1
> 
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com>, akpm@linux-foundation.org
Cc: dyoung@redhat.com, d.hatayama@jp.fujitsu.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus
Date: Wed, 3 Aug 2016 09:23:41 +0800	[thread overview]
Message-ID: <20160803012341.GA3637@x1.redhat.com> (raw)
In-Reply-To: <1470185952-23477-1-git-send-email-zhouwj-fnst@cn.fujitsu.com>

On 08/03/16 at 08:59am, Zhou Wenjian wrote:
> v2->v3: add description of nr_cpus.
> v1->v2: change nr_cpus to maxcpus
> 
> nr_cpus can help to save memory. So we should remind user of it.
> 
> Signed-off-by: Zhou Wenjian <zhouwj-fnst@cn.fujitsu.com>
> ---
>  Documentation/kdump/kdump.txt | 2 ++
>  1 file changed, 2 insertions(+)

Looks good to me! Thanks, Wenjian.

Ack this series
Acked-by: Baoquan He <bhe@redhat.com>


Hi Andrew,

Could you please help merge this patchset?

Thanks
Baoquan

> 
> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
> index 88ff63d..4aa194e 100644
> --- a/Documentation/kdump/kdump.txt
> +++ b/Documentation/kdump/kdump.txt
> @@ -393,6 +393,8 @@ Notes on loading the dump-capture kernel:
>  * We generally don' have to bring up a SMP kernel just to capture the
>    dump. Hence generally it is useful either to build a UP dump-capture
>    kernel or specify maxcpus=1 option while loading dump-capture kernel.
> +  Note, though maxcpus always works, we should replace it by nr_cpus to
> +  save memory if supported by the current ARCH, such as x86. 
>  
>  * For s390x there are two kdump modes: If a ELF header is specified with
>    the elfcorehdr= kernel parameter, it is used by the kdump kernel as it
> -- 
> 1.8.3.1
> 
> 
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2016-08-03  1:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  0:59 [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus Zhou Wenjian
2016-08-03  0:59 ` Zhou Wenjian
2016-08-03  0:59 ` [PATCH v3 2/2] Documentation: kdump: add description of bringing up SMP dump-capture kernel Zhou Wenjian
2016-08-03  0:59   ` Zhou Wenjian
2016-08-03  1:58   ` Baoquan He
2016-08-03  1:58     ` Baoquan He
2016-08-03  2:05     ` "Zhou, Wenjian/周文剑"
2016-08-03  2:05       ` "Zhou, Wenjian/周文剑"
2016-08-03  2:18       ` Baoquan He
2016-08-03  2:18         ` Baoquan He
2016-08-03  2:19         ` "Zhou, Wenjian/周文剑"
2016-08-03  2:19           ` "Zhou, Wenjian/周文剑"
2016-08-03  1:23 ` Baoquan He [this message]
2016-08-03  1:23   ` [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus Baoquan He
2016-08-08  2:14 ` Dave Young
2016-08-08  2:14   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160803012341.GA3637@x1.redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=dyoung@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhouwj-fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.