All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	Jay Freyensee
	<james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 3/5] nvme-rdma: Free the I/O tags when we delete the controller
Date: Wed, 3 Aug 2016 11:03:30 +0200	[thread overview]
Message-ID: <20160803090330.GB11321@lst.de> (raw)
In-Reply-To: <1470124419-30405-4-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

On Tue, Aug 02, 2016 at 10:53:37AM +0300, Sagi Grimberg wrote:
> If we wait until we free the controller (free_ctrl) we might
> lose our rdma device without any notification while we still
> have open resources (tags mrs and dma mappings).
> 
> Instead, destroy the tags with their rdma resources once we
> delete the device and not when freeing it.
> 
> Note that we don't do that in nvme_rdma_shutdown_ctrl because
> controller reset uses it as well and we want to give active I/O
> a chance to complete successfully.
> 
> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

Looks fine:

Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2 3/5] nvme-rdma: Free the I/O tags when we delete the controller
Date: Wed, 3 Aug 2016 11:03:30 +0200	[thread overview]
Message-ID: <20160803090330.GB11321@lst.de> (raw)
In-Reply-To: <1470124419-30405-4-git-send-email-sagi@grimberg.me>

On Tue, Aug 02, 2016@10:53:37AM +0300, Sagi Grimberg wrote:
> If we wait until we free the controller (free_ctrl) we might
> lose our rdma device without any notification while we still
> have open resources (tags mrs and dma mappings).
> 
> Instead, destroy the tags with their rdma resources once we
> delete the device and not when freeing it.
> 
> Note that we don't do that in nvme_rdma_shutdown_ctrl because
> controller reset uses it as well and we want to give active I/O
> a chance to complete successfully.
> 
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>

Looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>

  parent reply	other threads:[~2016-08-03  9:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  7:53 [PATCH v2 0/5] Some fabrics fixes Sagi Grimberg
2016-08-02  7:53 ` Sagi Grimberg
     [not found] ` <1470124419-30405-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-02  7:53   ` [PATCH v2 1/5] nvme-rdma: Fix device removal handling Sagi Grimberg
2016-08-02  7:53     ` Sagi Grimberg
2016-08-02  7:53   ` [PATCH v2 2/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces Sagi Grimberg
2016-08-02  7:53     ` Sagi Grimberg
     [not found]     ` <1470124419-30405-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-03  9:03       ` Christoph Hellwig
2016-08-03  9:03         ` Christoph Hellwig
2016-08-02  7:53   ` [PATCH v2 3/5] nvme-rdma: Free the I/O tags when we delete the controller Sagi Grimberg
2016-08-02  7:53     ` Sagi Grimberg
     [not found]     ` <1470124419-30405-4-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-03  9:03       ` Christoph Hellwig [this message]
2016-08-03  9:03         ` Christoph Hellwig
2016-08-02  7:53   ` [PATCH v2 4/5] nvme-loop: Remove duplicate call to nvme_remove_namespaces Sagi Grimberg
2016-08-02  7:53     ` Sagi Grimberg
     [not found]     ` <1470124419-30405-5-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-03  9:03       ` Christoph Hellwig
2016-08-03  9:03         ` Christoph Hellwig
2016-08-02  7:53   ` [PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can Sagi Grimberg
2016-08-02  7:53     ` Sagi Grimberg
     [not found]     ` <1470124419-30405-6-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-03  9:04       ` Christoph Hellwig
2016-08-03  9:04         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160803090330.GB11321@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.