From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Daniel Kurtz" <djkurtz@chromium.org>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
stonea168@163.com,
"ML dri-devel" <dri-devel@lists.freedesktop.org>,
"Ajay Kumar" <ajaykumar.rs@samsung.com>,
"Vincent Palatin" <vpalatin@chromium.org>,
"cawa cheng" <cawa.cheng@mediatek.com>,
"Yingjoe Chen" <yingjoe.chen@mediatek.com>,
"Thierry Reding" <treding@nvidia.com>,
devicetree <devicetree@vger.kernel.org>,
"Jitao Shi" <jitao.shi@mediatek.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Herring" <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
LAKML <linux-arm-kernel@lists.infradead.org>,
"Rahul Sharma" <rahul.sharma@samsung.com>,
srv_heupstream <srv_heupstream@mediatek.com>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Kumar Gala" <galak@codeaurora.org>,
"Andy Yan" <andy.yan@rock-chips.com>
Subject: Re: [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Thu, 4 Aug 2016 13:23:29 +0100 [thread overview]
Message-ID: <20160804122329.GT1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAKMK7uEkUOq1CB3tj_1Qx50fBpw9B39+c3asX6MPNexT=dv9fA@mail.gmail.com>
On Tue, Jul 12, 2016 at 12:13:52PM +0200, Daniel Vetter wrote:
> Might be better to just do a request_firmware on driver load, and
> simply proceed if it's not there.
That is almost never a good idea - if the driver is built-in, then
the request_firmware call happens before the real rootfs is mounted,
which makes it complicated to get the firmware delivered to the
driver.
Sure, it works nicely if the drivers are built as modules, but not
everyone wants to deal with modules and initramfs images.
If we're wanting to just update the firmware, that should be an
explicit administrative decision requiring an explicit action by the
system administrator, and not done by placing a file in some magic
location so that request_firmware() can find it, which then gets
picked up at boot time/driver load time. Consider what could happen
if linux-firmware picks up the file and places it in the appropriate
location by default.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
To: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Cc: "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
stonea168-9Onoh4P/yGk@public.gmane.org,
"ML dri-devel"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"Ajay Kumar"
<ajaykumar.rs-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"Vincent Palatin"
<vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"cawa cheng" <cawa.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"Yingjoe Chen"
<yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"Thierry Reding"
<treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Jitao Shi" <jitao.shi-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Matthias Brugger"
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Eddie Huang (黃智傑)"
<eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
LAKML
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Rahul Sharma"
<rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
srv_heupstream
<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"Emil Velikov"
<emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linux-Kernel@Vger.Kerne
Subject: Re: [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Thu, 4 Aug 2016 13:23:29 +0100 [thread overview]
Message-ID: <20160804122329.GT1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAKMK7uEkUOq1CB3tj_1Qx50fBpw9B39+c3asX6MPNexT=dv9fA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Jul 12, 2016 at 12:13:52PM +0200, Daniel Vetter wrote:
> Might be better to just do a request_firmware on driver load, and
> simply proceed if it's not there.
That is almost never a good idea - if the driver is built-in, then
the request_firmware call happens before the real rootfs is mounted,
which makes it complicated to get the firmware delivered to the
driver.
Sure, it works nicely if the drivers are built as modules, but not
everyone wants to deal with modules and initramfs images.
If we're wanting to just update the firmware, that should be an
explicit administrative decision requiring an explicit action by the
system administrator, and not done by placing a file in some magic
location so that request_firmware() can find it, which then gets
picked up at boot time/driver load time. Consider what could happen
if linux-firmware picks up the file and places it in the appropriate
location by default.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge
Date: Thu, 4 Aug 2016 13:23:29 +0100 [thread overview]
Message-ID: <20160804122329.GT1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAKMK7uEkUOq1CB3tj_1Qx50fBpw9B39+c3asX6MPNexT=dv9fA@mail.gmail.com>
On Tue, Jul 12, 2016 at 12:13:52PM +0200, Daniel Vetter wrote:
> Might be better to just do a request_firmware on driver load, and
> simply proceed if it's not there.
That is almost never a good idea - if the driver is built-in, then
the request_firmware call happens before the real rootfs is mounted,
which makes it complicated to get the firmware delivered to the
driver.
Sure, it works nicely if the drivers are built as modules, but not
everyone wants to deal with modules and initramfs images.
If we're wanting to just update the firmware, that should be an
explicit administrative decision requiring an explicit action by the
system administrator, and not done by placing a file in some magic
location so that request_firmware() can find it, which then gets
picked up at boot time/driver load time. Consider what could happen
if linux-firmware picks up the file and places it in the appropriate
location by default.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-08-04 12:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:57 [PATCH 1/2 v16] Documentation: bridge: Add documentation for ps8640 DT properties Jitao Shi
2016-06-02 9:57 ` Jitao Shi
2016-06-02 9:57 ` Jitao Shi
2016-06-02 9:57 ` [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge Jitao Shi
2016-06-02 9:57 ` Jitao Shi
2016-06-02 9:57 ` Jitao Shi
2016-06-14 8:09 ` Daniel Kurtz
2016-06-14 8:09 ` Daniel Kurtz
2016-06-14 8:09 ` Daniel Kurtz
2016-06-16 19:14 ` Emil Velikov
2016-06-16 19:14 ` Emil Velikov
2016-06-16 19:14 ` Emil Velikov
2016-06-29 4:31 ` Daniel Kurtz
2016-06-29 4:31 ` Daniel Kurtz
2016-06-29 4:31 ` Daniel Kurtz
2016-07-12 10:13 ` Daniel Vetter
2016-07-12 10:13 ` Daniel Vetter
2016-07-12 10:13 ` Daniel Vetter
2016-08-04 10:35 ` Enric Balletbo Serra
2016-08-04 10:35 ` Enric Balletbo Serra
2016-08-04 10:35 ` Enric Balletbo Serra
2016-08-04 10:58 ` Daniel Vetter
2016-08-04 10:58 ` Daniel Vetter
2016-08-04 10:58 ` Daniel Vetter
2016-08-04 12:23 ` Russell King - ARM Linux [this message]
2016-08-04 12:23 ` Russell King - ARM Linux
2016-08-04 12:23 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804122329.GT1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ajaykumar.rs@samsung.com \
--cc=andy.yan@rock-chips.com \
--cc=cawa.cheng@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=emil.l.velikov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jitao.shi@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=rahul.sharma@samsung.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=treding@nvidia.com \
--cc=vpalatin@chromium.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.