All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-virtualization][PATCH] Fix build error for arm
@ 2016-08-08  2:33 kai.kang
  2016-08-08  2:33 ` [PATCH] libvirt: fix " kai.kang
  2016-08-08 14:22   ` [yocto] [PATCH] " Bruce Ashfield
  0 siblings, 2 replies; 4+ messages in thread
From: kai.kang @ 2016-08-08  2:33 UTC (permalink / raw)
  To: bruce.ashfield; +Cc: yocto

From: Kai Kang <kai.kang@windriver.com>

When build for qemuarm, it fails to do compile_ptest_base.

Kai Kang (1):
  libvirt: fix build error for arm

 .../0001-nsslinktest-also-build-virAtomic.h.patch  | 40 ++++++++++++++++++++++
 recipes-extended/libvirt/libvirt_1.3.5.bb          |  1 +
 2 files changed, 41 insertions(+)
 create mode 100644 recipes-extended/libvirt/libvirt/0001-nsslinktest-also-build-virAtomic.h.patch

-- 
2.9.2.368.g08bb350



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] libvirt: fix build error for arm
  2016-08-08  2:33 [meta-virtualization][PATCH] Fix build error for arm kai.kang
@ 2016-08-08  2:33 ` kai.kang
  2016-08-08 14:22   ` [yocto] [PATCH] " Bruce Ashfield
  1 sibling, 0 replies; 4+ messages in thread
From: kai.kang @ 2016-08-08  2:33 UTC (permalink / raw)
  To: bruce.ashfield; +Cc: yocto

From: Kai Kang <kai.kang@windriver.com>

When build for architecture that don't use gcc atomic ops but pthread,
it fails to build for arm:

| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virClassNew':
| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:153: undefined reference to `virAtomicLock'
| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectNew':
| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:205: undefined reference to `virAtomicLock'
| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectUnref':
| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:277: undefined reference to `virAtomicLock'
| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectRef':
| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:298: undefined reference to `virAtomicLock'
| collect2: error: ld returned 1 exit status

It is similar with:

http://libvirt.org/git/?p=libvirt.git;a=commit;h=12dc729

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 .../0001-nsslinktest-also-build-virAtomic.h.patch  | 40 ++++++++++++++++++++++
 recipes-extended/libvirt/libvirt_1.3.5.bb          |  1 +
 2 files changed, 41 insertions(+)
 create mode 100644 recipes-extended/libvirt/libvirt/0001-nsslinktest-also-build-virAtomic.h.patch

diff --git a/recipes-extended/libvirt/libvirt/0001-nsslinktest-also-build-virAtomic.h.patch b/recipes-extended/libvirt/libvirt/0001-nsslinktest-also-build-virAtomic.h.patch
new file mode 100644
index 0000000..6ab1c4e
--- /dev/null
+++ b/recipes-extended/libvirt/libvirt/0001-nsslinktest-also-build-virAtomic.h.patch
@@ -0,0 +1,40 @@
+Upstream-Status: Submitted [http://www.redhat.com/archives/libvir-list/2016-August/msg00389.html]
+
+When build for architecture that don't use gcc atomic ops but pthread,
+it fails to build for arm:
+
+| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virClassNew':
+| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:153: undefined reference to `virAtomicLock'
+| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectNew':
+| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:205: undefined reference to `virAtomicLock'
+| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectUnref':
+| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:277: undefined reference to `virAtomicLock'
+| ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectRef':
+| /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:298: undefined reference to `virAtomicLock'
+| collect2: error: ld returned 1 exit status
+
+It is similar with:
+
+http://libvirt.org/git/?p=libvirt.git;a=commit;h=12dc729
+
+Signed-off-by: Kai Kang <kai.kang@windriver.com>
+---
+ src/Makefile.am | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/src/Makefile.am b/src/Makefile.am
+index 12b66c2..6e55972 100644
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -2989,6 +2989,8 @@ noinst_LTLIBRARIES += libvirt-nss.la
+ libvirt_nss_la_SOURCES =		\
+ 		util/viralloc.c			\
+ 		util/viralloc.h			\
++		util/viratomic.c		\
++		util/viratomic.h		\
+ 		util/virbitmap.c		\
+ 		util/virbitmap.h		\
+ 		util/virbuffer.c		\
+-- 
+2.9.0
+
diff --git a/recipes-extended/libvirt/libvirt_1.3.5.bb b/recipes-extended/libvirt/libvirt_1.3.5.bb
index f4a8f38..7ff2c5f 100644
--- a/recipes-extended/libvirt/libvirt_1.3.5.bb
+++ b/recipes-extended/libvirt/libvirt_1.3.5.bb
@@ -33,6 +33,7 @@ SRC_URI = "http://libvirt.org/sources/libvirt-${PV}.tar.gz;name=libvirt \
            file://0001-to-fix-build-error.patch \
            file://Revert-build-add-prefix-to-SYSTEMD_UNIT_DIR.patch \
            file://install-missing-file.patch \
+           file://0001-nsslinktest-also-build-virAtomic.h.patch \
           "
 
 SRC_URI[libvirt.md5sum] = "f9dc1e63d559eca50ae0ee798a4c6c6d"
-- 
2.9.2.368.g08bb350



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-virtualization][PATCH] Fix build error for arm
  2016-08-08  2:33 [meta-virtualization][PATCH] Fix build error for arm kai.kang
@ 2016-08-08 14:22   ` Bruce Ashfield
  2016-08-08 14:22   ` [yocto] [PATCH] " Bruce Ashfield
  1 sibling, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2016-08-08 14:22 UTC (permalink / raw)
  To: Kang Kai, meta-virtualization; +Cc: Yocto Project Discussion

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

On Sun, Aug 7, 2016 at 10:33 PM, <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
>
> When build for qemuarm, it fails to do compile_ptest_base.
>
>
Wrong mailing list (use meta-virtualization@yoctoproject.org).

But I've grabbed this and merged it anyway.

Bruce


> Kai Kang (1):
>   libvirt: fix build error for arm
>
>  .../0001-nsslinktest-also-build-virAtomic.h.patch  | 40
> ++++++++++++++++++++++
>  recipes-extended/libvirt/libvirt_1.3.5.bb          |  1 +
>  2 files changed, 41 insertions(+)
>  create mode 100644 recipes-extended/libvirt/
> libvirt/0001-nsslinktest-also-build-virAtomic.h.patch
>
> --
> 2.9.2.368.g08bb350
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 1974 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [yocto] [PATCH] Fix build error for arm
@ 2016-08-08 14:22   ` Bruce Ashfield
  0 siblings, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2016-08-08 14:22 UTC (permalink / raw)
  To: Kang Kai, meta-virtualization; +Cc: Yocto Project Discussion

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

On Sun, Aug 7, 2016 at 10:33 PM, <kai.kang@windriver.com> wrote:

> From: Kai Kang <kai.kang@windriver.com>
>
> When build for qemuarm, it fails to do compile_ptest_base.
>
>
Wrong mailing list (use meta-virtualization@yoctoproject.org).

But I've grabbed this and merged it anyway.

Bruce


> Kai Kang (1):
>   libvirt: fix build error for arm
>
>  .../0001-nsslinktest-also-build-virAtomic.h.patch  | 40
> ++++++++++++++++++++++
>  recipes-extended/libvirt/libvirt_1.3.5.bb          |  1 +
>  2 files changed, 41 insertions(+)
>  create mode 100644 recipes-extended/libvirt/
> libvirt/0001-nsslinktest-also-build-virAtomic.h.patch
>
> --
> 2.9.2.368.g08bb350
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 1974 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-08 14:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-08  2:33 [meta-virtualization][PATCH] Fix build error for arm kai.kang
2016-08-08  2:33 ` [PATCH] libvirt: fix " kai.kang
2016-08-08 14:22 ` [meta-virtualization][PATCH] Fix " Bruce Ashfield
2016-08-08 14:22   ` [yocto] [PATCH] " Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.