Re: [oe-commits] [meta-openembedded] 24/39: qpdf: add new recipe

Re: [oe-commits] [meta-openembedded] 24/39: qpdf: add new recipe

[Andreas Müller]

On Fri, Aug 5, 2016 at 12:26 PM,  <git@git.openembedded.org> wrote:
> martin_jansa pushed a commit to branch master-next
> in repository meta-openembedded.
>
> commit 183ecb3a05823343525d7acc1a650d4b2a0e4183
> Author: fan.xin <fan.xin@jp.fujitsu.com>
> AuthorDate: Mon Aug 1 18:46:35 2016 +0900
>
>     qpdf: add new recipe
>
>     QPDF is a command-line program that does structural,
>     content-preserving transformation on PDF files.
>
>     Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
>     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb b/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb
> new file mode 100644
> index 0000000..d5645d7
> --- /dev/null
> +++ b/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "QPDF is a command-line program that does structural, content-preserving transformations on PDF files"
> +DESCRIPTION = "QPDF is capable of creating linearized files and encrypted files. It is also capable of \
> +converting PDF files with object streams to files with no compressed objects or to generate object streams \
> +from files that don't have them. QPDF also supports a special mode designed to allow you to edit the content \
> +of PDF files in a text editor."
> +HOMEPAGE = "http://qpdf.sourceforge.net/"
> +
> +PR = "r0"
^ Nit
> +
> +RDEPENDS_${PN} = "libpcre zlib"
> +
> +LICENSE = "Artistic-2.0"
> +LIC_FILES_CHKSUM = "file://${WORKDIR}/qpdf-${PV}/Artistic-2.0;md5=7806296b9fae874361e6fb10072b7ee3"
> +
> +SRC_URI = "http://nchc.dl.sourceforge.net/project/qpdf/qpdf/${PV}/qpdf-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "e014bd3ecf1c4d1a520bbc14d84ac20e"
> +SRC_URI[sha256sum] = "a9fdc7e94d38fcd3831f37b6e0fe36492bf79aa6d54f8f66062cf7f9c4155233"
> +
> +inherit autotools-brokensep pkgconfig
> +
> +EXTRA_OECONF += "--with-random=/dev/urandom"
> +
> +do_configure_prepend() {
> +      sh autogen.sh
> +}
>
> --
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> --
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

Re: [oe-commits] [meta-openembedded] 24/39: qpdf: add new recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3156 bytes --]

On Fri, Aug 05, 2016 at 01:22:08PM +0200, Andreas Müller wrote:
> On Fri, Aug 5, 2016 at 12:26 PM,  <git@git.openembedded.org> wrote:
> > martin_jansa pushed a commit to branch master-next
> > in repository meta-openembedded.
> >
> > commit 183ecb3a05823343525d7acc1a650d4b2a0e4183
> > Author: fan.xin <fan.xin@jp.fujitsu.com>
> > AuthorDate: Mon Aug 1 18:46:35 2016 +0900
> >
> >     qpdf: add new recipe
> >
> >     QPDF is a command-line program that does structural,
> >     content-preserving transformation on PDF files.
> >
> >     Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
> >     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb b/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb
> > new file mode 100644
> > index 0000000..d5645d7
> > --- /dev/null
> > +++ b/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb
> > @@ -0,0 +1,26 @@
> > +SUMMARY = "QPDF is a command-line program that does structural, content-preserving transformations on PDF files"
> > +DESCRIPTION = "QPDF is capable of creating linearized files and encrypted files. It is also capable of \
> > +converting PDF files with object streams to files with no compressed objects or to generate object streams \
> > +from files that don't have them. QPDF also supports a special mode designed to allow you to edit the content \
> > +of PDF files in a text editor."
> > +HOMEPAGE = "http://qpdf.sourceforge.net/"
> > +
> > +PR = "r0"
> ^ Nit

All 4 changes done in master-next.

> > +
> > +RDEPENDS_${PN} = "libpcre zlib"
> > +
> > +LICENSE = "Artistic-2.0"
> > +LIC_FILES_CHKSUM = "file://${WORKDIR}/qpdf-${PV}/Artistic-2.0;md5=7806296b9fae874361e6fb10072b7ee3"

Dropped ${S} - "${WORKDIR}/qpdf-${PV}"

> > +
> > +SRC_URI = "http://nchc.dl.sourceforge.net/project/qpdf/qpdf/${PV}/qpdf-${PV}.tar.gz"

SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BPN}/${PV}/${BP}.tar.gz"

> > +
> > +SRC_URI[md5sum] = "e014bd3ecf1c4d1a520bbc14d84ac20e"
> > +SRC_URI[sha256sum] = "a9fdc7e94d38fcd3831f37b6e0fe36492bf79aa6d54f8f66062cf7f9c4155233"
> > +
> > +inherit autotools-brokensep pkgconfig
> > +
> > +EXTRA_OECONF += "--with-random=/dev/urandom"
> > +
> > +do_configure_prepend() {
> > +      sh autogen.sh

4 spaces for indentation

Isn't this the only reason for brokensep? Would it work with sh ${S}/autogen.sh?

> > +}
> >
> > --
> > To stop receiving notification emails like this one, please contact
> > the administrator of this repository.
> > --
> > _______________________________________________
> > Openembedded-commits mailing list
> > Openembedded-commits@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-commits
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

[meta-oe][PATCH] qpdf: add new recipe

[Martin Jansa]

From: "fan.xin" <fan.xin@jp.fujitsu.com>

QPDF is a command-line program that does structural,
content-preserving transformation on PDF files.

Signed-off-by: Fan Xin <fan.xin@jp.fujitsu.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb

diff --git a/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb b/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb
new file mode 100644
index 0000000..cec1d5c
--- /dev/null
+++ b/meta-oe/recipes-extended/qpdf/qpdf_6.0.0.bb
@@ -0,0 +1,23 @@
+SUMMARY = "CLI for structural, content-preserving transformations on PDF files"
+DESCRIPTION = "QPDF is capable of creating linearized files and encrypted files. It is also capable of \
+converting PDF files with object streams to files with no compressed objects or to generate object streams \
+from files that don't have them. QPDF also supports a special mode designed to allow you to edit the content \
+of PDF files in a text editor."
+HOMEPAGE = "http://qpdf.sourceforge.net/"
+
+DEPENDS = "libpcre zlib"
+
+LICENSE = "Artistic-2.0"
+LIC_FILES_CHKSUM = "file://Artistic-2.0;md5=7806296b9fae874361e6fb10072b7ee3"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BPN}/${PV}/${BP}.tar.gz"
+SRC_URI[md5sum] = "e014bd3ecf1c4d1a520bbc14d84ac20e"
+SRC_URI[sha256sum] = "a9fdc7e94d38fcd3831f37b6e0fe36492bf79aa6d54f8f66062cf7f9c4155233"
+
+inherit autotools pkgconfig
+
+EXTRA_OECONF += "--with-random=/dev/urandom"
+
+do_configure_prepend() {
+    sh ${S}/autogen.sh
+}
-- 
2.9.2

Re: [meta-oe][PATCH] qpdf: add new recipe

[Burton, Ross]

On 8 August 2016 at 13:03, Martin Jansa <martin.jansa@gmail.com> wrote:

> +do_configure_prepend() {
> +    sh ${S}/autogen.sh
> +}
>

https://github.com/qpdf/qpdf/blob/master/autogen.sh says that this is just

aclocal -I m4
autoheader
autoconf

So I don't see what this achieves as we're about to run this again anyway
via autoreconf.

Ross

Re: [meta-oe][PATCH] qpdf: add new recipe

[Martin Jansa]

I'll leave that to original submitter to resolve, test and resend.

On Mon, Aug 8, 2016 at 5:21 PM, Burton, Ross <ross.burton@intel.com> wrote:

> On 8 August 2016 at 13:03, Martin Jansa <martin.jansa@gmail.com> wrote:
>
> > +do_configure_prepend() {
> > +    sh ${S}/autogen.sh
> > +}
> >
>
> https://github.com/qpdf/qpdf/blob/master/autogen.sh says that this is just
>
> aclocal -I m4
> autoheader
> autoconf
>
> So I don't see what this achieves as we're about to run this again anyway
> via autoreconf.
>
> Ross
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>