All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] owfs: disable PHP support
@ 2016-08-05 21:58 Thomas Petazzoni
  2016-08-08 18:01 ` Yann E. MORIN
  2016-08-08 21:48 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-08-05 21:58 UTC (permalink / raw)
  To: buildroot

Since we upgraded PHP to PHP 7.x, the PHP support of OWFS started
failing to build. Since we can hardly fix that on our own, the issue was
reported upstream (https://sourceforge.net/p/owfs/support-requests/32/)
and for now, we will disable PHP support in OWFS.

Fixes:

  http://autobuild.buildroot.net/results/fe6843ec53fbed452d2e38a8577a235f73abb8db/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/owfs/owfs.mk | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/package/owfs/owfs.mk b/package/owfs/owfs.mk
index 0092603..83614af 100644
--- a/package/owfs/owfs.mk
+++ b/package/owfs/owfs.mk
@@ -17,6 +17,10 @@ OWFS_LICENSE = GPLv2+, LGPLv2 (owtcl)
 OWFS_LICENSE_FILES = COPYING COPYING.LIB
 OWFS_INSTALL_STAGING = YES
 
+# owfs PHP support is not PHP 7 compliant
+# https://sourceforge.net/p/owfs/support-requests/32/
+OWFS_CONF_OPTS += --disable-owphp --without-php
+
 ifeq ($(BR2_PACKAGE_LIBFUSE),y)
 OWFS_DEPENDENCIES += libfuse
 OWFS_CONF_OPTS += \
@@ -49,13 +53,6 @@ else
 OWFS_CONF_OPTS += --disable-avahi
 endif
 
-ifeq ($(BR2_PACKAGE_PHP),y)
-OWFS_CONF_OPTS += --enable-owphp --with-php --with-phpconfig=$(STAGING_DIR)/usr/bin/php-config
-OWFS_DEPENDENCIES += php host-swig
-else
-OWFS_CONF_OPTS += --disable-owphp --without-php
-endif
-
 # setup.py isn't python3 compliant
 ifeq ($(BR2_PACKAGE_PYTHON),y)
 OWFS_CONF_OPTS += \
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] owfs: disable PHP support
  2016-08-05 21:58 [Buildroot] [PATCH] owfs: disable PHP support Thomas Petazzoni
@ 2016-08-08 18:01 ` Yann E. MORIN
  2016-08-08 21:48 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2016-08-08 18:01 UTC (permalink / raw)
  To: buildroot

Thomas, All,

On 2016-08-05 23:58 +0200, Thomas Petazzoni spake thusly:
> Since we upgraded PHP to PHP 7.x, the PHP support of OWFS started
> failing to build. Since we can hardly fix that on our own, the issue was
> reported upstream (https://sourceforge.net/p/owfs/support-requests/32/)
> and for now, we will disable PHP support in OWFS.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/fe6843ec53fbed452d2e38a8577a235f73abb8db/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/owfs/owfs.mk | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/package/owfs/owfs.mk b/package/owfs/owfs.mk
> index 0092603..83614af 100644
> --- a/package/owfs/owfs.mk
> +++ b/package/owfs/owfs.mk
> @@ -17,6 +17,10 @@ OWFS_LICENSE = GPLv2+, LGPLv2 (owtcl)
>  OWFS_LICENSE_FILES = COPYING COPYING.LIB
>  OWFS_INSTALL_STAGING = YES
>  
> +# owfs PHP support is not PHP 7 compliant
> +# https://sourceforge.net/p/owfs/support-requests/32/
> +OWFS_CONF_OPTS += --disable-owphp --without-php
> +
>  ifeq ($(BR2_PACKAGE_LIBFUSE),y)
>  OWFS_DEPENDENCIES += libfuse
>  OWFS_CONF_OPTS += \
> @@ -49,13 +53,6 @@ else
>  OWFS_CONF_OPTS += --disable-avahi
>  endif
>  
> -ifeq ($(BR2_PACKAGE_PHP),y)
> -OWFS_CONF_OPTS += --enable-owphp --with-php --with-phpconfig=$(STAGING_DIR)/usr/bin/php-config
> -OWFS_DEPENDENCIES += php host-swig
> -else
> -OWFS_CONF_OPTS += --disable-owphp --without-php
> -endif
> -
>  # setup.py isn't python3 compliant
>  ifeq ($(BR2_PACKAGE_PYTHON),y)
>  OWFS_CONF_OPTS += \
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] owfs: disable PHP support
  2016-08-05 21:58 [Buildroot] [PATCH] owfs: disable PHP support Thomas Petazzoni
  2016-08-08 18:01 ` Yann E. MORIN
@ 2016-08-08 21:48 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-08-08 21:48 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri,  5 Aug 2016 23:58:53 +0200, Thomas Petazzoni wrote:
> Since we upgraded PHP to PHP 7.x, the PHP support of OWFS started
> failing to build. Since we can hardly fix that on our own, the issue was
> reported upstream (https://sourceforge.net/p/owfs/support-requests/32/)
> and for now, we will disable PHP support in OWFS.
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/fe6843ec53fbed452d2e38a8577a235f73abb8db/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/owfs/owfs.mk | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-08 21:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-05 21:58 [Buildroot] [PATCH] owfs: disable PHP support Thomas Petazzoni
2016-08-08 18:01 ` Yann E. MORIN
2016-08-08 21:48 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.