All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@arm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, peterz@infradead.org,
	vincent.guittot@linaro.org, robh+dt@kernel.org,
	mark.rutland@arm.com, linux@arm.linux.org.uk,
	sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com,
	morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
	broonie@kernel.org
Subject: Re: [PATCH v6 4/8] arm64: parse cpu capacity-dmips-mhz from DT
Date: Tue, 9 Aug 2016 10:42:38 +0100	[thread overview]
Message-ID: <20160809094238.GA23236@e106622-lin> (raw)
In-Reply-To: <1468932048-31635-5-git-send-email-juri.lelli@arm.com>

Hi,

this patch needs the fix below, since platforms can boot without a
cpu-map.

On 19/07/16 13:40, Juri Lelli wrote:
[...]
> @@ -185,6 +328,8 @@ static int __init parse_dt_topology(void)
>  	if (ret != 0)
>  		goto out_map;
>  
> +	normalize_cpu_capacity();
> +
>  	/*
>  	 * Check that all cores are in the topology; the SMP code will
>  	 * only mark cores described in the DT as possible.
> -- 

--->8---
 arch/arm64/kernel/topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 56bbd6d41daf..288f511a5f29 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -394,8 +394,10 @@ static int __init parse_dt_topology(void)
 	 * cluster with restricted subnodes.
 	 */
 	map = of_get_child_by_name(cn, "cpu-map");
-	if (!map)
+	if (!map) {
+		cap_parsing_failed = true;
 		goto out;
+	}
 
 	ret = parse_cluster(map, 0);
 	if (ret != 0)
-- 
2.7.0

WARNING: multiple messages have this Message-ID (diff)
From: Juri Lelli <juri.lelli-5wv7dgnIgG8@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	sudeep.holla-5wv7dgnIgG8@public.gmane.org,
	lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org,
	catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	morten.rasmussen-5wv7dgnIgG8@public.gmane.org,
	dietmar.eggemann-5wv7dgnIgG8@public.gmane.org,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v6 4/8] arm64: parse cpu capacity-dmips-mhz from DT
Date: Tue, 9 Aug 2016 10:42:38 +0100	[thread overview]
Message-ID: <20160809094238.GA23236@e106622-lin> (raw)
In-Reply-To: <1468932048-31635-5-git-send-email-juri.lelli-5wv7dgnIgG8@public.gmane.org>

Hi,

this patch needs the fix below, since platforms can boot without a
cpu-map.

On 19/07/16 13:40, Juri Lelli wrote:
[...]
> @@ -185,6 +328,8 @@ static int __init parse_dt_topology(void)
>  	if (ret != 0)
>  		goto out_map;
>  
> +	normalize_cpu_capacity();
> +
>  	/*
>  	 * Check that all cores are in the topology; the SMP code will
>  	 * only mark cores described in the DT as possible.
> -- 

--->8---
 arch/arm64/kernel/topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 56bbd6d41daf..288f511a5f29 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -394,8 +394,10 @@ static int __init parse_dt_topology(void)
 	 * cluster with restricted subnodes.
 	 */
 	map = of_get_child_by_name(cn, "cpu-map");
-	if (!map)
+	if (!map) {
+		cap_parsing_failed = true;
 		goto out;
+	}
 
 	ret = parse_cluster(map, 0);
 	if (ret != 0)
-- 
2.7.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: juri.lelli@arm.com (Juri Lelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 4/8] arm64: parse cpu capacity-dmips-mhz from DT
Date: Tue, 9 Aug 2016 10:42:38 +0100	[thread overview]
Message-ID: <20160809094238.GA23236@e106622-lin> (raw)
In-Reply-To: <1468932048-31635-5-git-send-email-juri.lelli@arm.com>

Hi,

this patch needs the fix below, since platforms can boot without a
cpu-map.

On 19/07/16 13:40, Juri Lelli wrote:
[...]
> @@ -185,6 +328,8 @@ static int __init parse_dt_topology(void)
>  	if (ret != 0)
>  		goto out_map;
>  
> +	normalize_cpu_capacity();
> +
>  	/*
>  	 * Check that all cores are in the topology; the SMP code will
>  	 * only mark cores described in the DT as possible.
> -- 

--->8---
 arch/arm64/kernel/topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 56bbd6d41daf..288f511a5f29 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -394,8 +394,10 @@ static int __init parse_dt_topology(void)
 	 * cluster with restricted subnodes.
 	 */
 	map = of_get_child_by_name(cn, "cpu-map");
-	if (!map)
+	if (!map) {
+		cap_parsing_failed = true;
 		goto out;
+	}
 
 	ret = parse_cluster(map, 0);
 	if (ret != 0)
-- 
2.7.0

  reply	other threads:[~2016-08-09  9:43 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 12:40 [PATCH v6 0/8] CPUs capacity information for heterogeneous systems Juri Lelli
2016-07-19 12:40 ` Juri Lelli
2016-07-19 12:40 ` [PATCH v6 1/8] Documentation: arm: define DT cpu capacity-dmips-mhz bindings Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-07-20 18:56   ` Rob Herring
2016-07-20 18:56     ` Rob Herring
2016-07-21 11:43     ` Juri Lelli
2016-07-21 11:43       ` Juri Lelli
2016-08-16  9:02   ` Vincent Guittot
2016-08-16  9:02     ` Vincent Guittot
2016-08-16  9:02     ` Vincent Guittot
2016-08-30 16:11     ` Juri Lelli
2016-08-30 16:11       ` Juri Lelli
2016-08-30 16:11       ` Juri Lelli
2016-07-19 12:40 ` [PATCH v6 2/8] arm: parse cpu capacity-dmips-mhz from DT Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-08-16  8:20   ` Vincent Guittot
2016-08-16  8:20     ` Vincent Guittot
2016-08-30 16:28     ` Juri Lelli
2016-08-30 16:28       ` Juri Lelli
2016-08-30 16:28       ` Juri Lelli
2016-08-31  8:14       ` Vincent Guittot
2016-08-31  8:14         ` Vincent Guittot
2016-08-31 17:08         ` Juri Lelli
2016-08-31 17:08           ` Juri Lelli
2016-09-01  8:22           ` Vincent Guittot
2016-09-01  8:22             ` Vincent Guittot
2016-09-01  8:50             ` Juri Lelli
2016-09-01  8:50               ` Juri Lelli
2016-09-01  8:50               ` Juri Lelli
2016-07-19 12:40 ` [PATCH v6 3/8] arm, dts: add TC2 cpu capacity-dmips-mhz information Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-08-10 15:33   ` Sudeep Holla
2016-08-10 15:33     ` Sudeep Holla
2016-08-10 15:33     ` Sudeep Holla
2016-08-10 15:43     ` Juri Lelli
2016-08-10 15:43       ` Juri Lelli
2016-08-10 15:43       ` Juri Lelli
2016-08-10 15:52       ` Sudeep Holla
2016-08-10 15:52         ` Sudeep Holla
2016-08-10 15:52         ` Sudeep Holla
2016-08-10 16:06         ` Juri Lelli
2016-08-10 16:06           ` Juri Lelli
2016-08-10 16:06           ` Juri Lelli
2016-07-19 12:40 ` [PATCH v6 4/8] arm64: parse cpu capacity-dmips-mhz from DT Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-08-09  9:42   ` Juri Lelli [this message]
2016-08-09  9:42     ` Juri Lelli
2016-08-09  9:42     ` Juri Lelli
2016-07-19 12:40 ` [PATCH v6 5/8] arm64, dts: add Juno cpu capacity-dmips-mhz information Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-08-10 15:38   ` Sudeep Holla
2016-08-10 15:38     ` Sudeep Holla
2016-08-10 15:38     ` Sudeep Holla
2016-07-19 12:40 ` [PATCH v6 6/8] arm64, dts: add Juno r2 " Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-08-10 15:41   ` Sudeep Holla
2016-08-10 15:41     ` Sudeep Holla
2016-08-10 15:41     ` Sudeep Holla
2016-07-19 12:40 ` [PATCH v6 7/8] arm: add sysfs cpu_capacity attribute Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-07-19 12:40 ` [PATCH v6 8/8] arm64: " Juri Lelli
2016-07-19 12:40   ` Juri Lelli
2016-08-08 16:49 ` [PATCH v6 0/8] CPUs capacity information for heterogeneous systems Peter Zijlstra
2016-08-08 16:49   ` Peter Zijlstra
2016-08-09 10:08   ` Juri Lelli
2016-08-09 10:08     ` Juri Lelli
2016-08-09 10:08     ` Juri Lelli
2016-08-10 10:53 ` Juri Lelli
2016-08-10 10:53   ` Juri Lelli
2016-08-10 10:53   ` Juri Lelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160809094238.GA23236@e106622-lin \
    --to=juri.lelli@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.