[PATCH] ASoC: core: fix shift used for second item in snd_soc_get_enum_double

[PATCH] ASoC: core: fix shift used for second item in snd_soc_get_enum_double

[jjassal]

Incorrect shift value was being used to extract the second item.

Signed-off-by: jjassal <jjassal@opensource.wolfsonmicro.com>
---
 sound/soc/soc-ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c
index a513a34..9fc1a7b 100644
--- a/sound/soc/soc-ops.c
+++ b/sound/soc/soc-ops.c
@@ -77,7 +77,7 @@ int snd_soc_get_enum_double(struct snd_kcontrol *kcontrol,
 	item = snd_soc_enum_val_to_item(e, val);
 	ucontrol->value.enumerated.item[0] = item;
 	if (e->shift_l != e->shift_r) {
-		val = (reg_val >> e->shift_l) & e->mask;
+		val = (reg_val >> e->shift_r) & e->mask;
 		item = snd_soc_enum_val_to_item(e, val);
 		ucontrol->value.enumerated.item[1] = item;
 	}
-- 
2.1.4

Re: [PATCH] ASoC: core: fix shift used for second item in snd_soc_get_enum_double

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 800 bytes --]

On Tue, Aug 09, 2016 at 07:09:05PM +0100, jjassal wrote:
> Incorrect shift value was being used to extract the second item.
> 
> Signed-off-by: jjassal <jjassal@opensource.wolfsonmicro.com>

This doesn't match the e-mail address this was sent from and so looks
like a non-author signoff though I'm guessing both addresses belong to a
single person.  You should ensure that your git configuration is
consistent in which e-mail address it uses.  Making sure that the
signoff comes from the author is important for licensing reasons, see
SubmttingPatches for details, and so using different e-mail addresses
sets off alarm bells.

You really should also use something other than your login for the real
name - it's the more common thing and it's less likely to be
misidentified as spam.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]