All of lore.kernel.org
 help / color / mirror / Atom feed
* [rtc-linux] [PATCH] rtc: ds1390: Fix the SPI chip select number
@ 2016-08-03  3:48 Fabio Estevam
  2016-08-11 21:40 ` [rtc-linux] " Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2016-08-03  3:48 UTC (permalink / raw)
  To: alexandre.belloni; +Cc: grimaldi.ivan, rtc-linux, Fabio Estevam

From: Fabio Estevam <fabio.estevam@nxp.com>

The number after the '@' symbol should be the SPI chip select
number associated with the ds1390 and it should match the 'reg'
field.

So change it the address to zero, to make it consistent.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 Documentation/devicetree/bindings/rtc/dallas,ds1390.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1390.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1390.txt
index 8e76f26..9882b81 100644
--- a/Documentation/devicetree/bindings/rtc/dallas,ds1390.txt
+++ b/Documentation/devicetree/bindings/rtc/dallas,ds1390.txt
@@ -11,7 +11,7 @@ Optional properties:
 - trickle-diode-disable : Do not use internal trickle charger diode
 	Should be given if internal trickle charger diode should be disabled
 Example:
-	ds1390: rtc@68 {
+	ds1390: rtc@0 {
 		compatible = "dallas,ds1390";
 		trickle-resistor-ohms = <250>;
 		reg = <0>;
-- 
1.9.1

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [rtc-linux] Re: [PATCH] rtc: ds1390: Fix the SPI chip select number
  2016-08-03  3:48 [rtc-linux] [PATCH] rtc: ds1390: Fix the SPI chip select number Fabio Estevam
@ 2016-08-11 21:40 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-08-11 21:40 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: grimaldi.ivan, rtc-linux, Fabio Estevam

On 03/08/2016 at 00:48:22 -0300, Fabio Estevam wrote :
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The number after the '@' symbol should be the SPI chip select
> number associated with the ds1390 and it should match the 'reg'
> field.
> 
> So change it the address to zero, to make it consistent.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  Documentation/devicetree/bindings/rtc/dallas,ds1390.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-11 21:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03  3:48 [rtc-linux] [PATCH] rtc: ds1390: Fix the SPI chip select number Fabio Estevam
2016-08-11 21:40 ` [rtc-linux] " Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.