[PATCH] timekeeping: Prints the amounts of time spent during suspend

[PATCH] timekeeping: Prints the amounts of time spent during suspend

[Ruchi Kandoi]

This helps to keep track of real time while debugging using kernel logs.

Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Ruchi Kandoi <kandoiruchi@google.com>
---
 kernel/time/timekeeping_debug.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/time/timekeeping_debug.c b/kernel/time/timekeeping_debug.c
index f6bd652..b67abe8 100644
--- a/kernel/time/timekeeping_debug.c
+++ b/kernel/time/timekeeping_debug.c
@@ -70,5 +70,7 @@ late_initcall(tk_debug_sleep_time_init);
 void tk_debug_account_sleep_time(struct timespec64 *t)
 {
 	sleep_time_bin[fls(t->tv_sec)]++;
+	pr_info("Suspended for %lu.%03lu seconds\n", t->tv_sec,
+			t->tv_nsec / NSEC_PER_MSEC);
 }
 
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH] timekeeping: Prints the amounts of time spent during suspend

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

Hi Ruchi,

[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ruchi-Kandoi/timekeeping-Prints-the-amounts-of-time-spent-during-suspend/20160812-034700
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   kernel/time/timekeeping_debug.c: In function 'tk_debug_account_sleep_time':
>> kernel/time/timekeeping_debug.c:73:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'time64_t' [-Wformat=]
     pr_info("Suspended for %lu.%03lu seconds\n", t->tv_sec,
     ^

vim +73 kernel/time/timekeeping_debug.c

    57		struct dentry *d;
    58	
    59		d = debugfs_create_file("sleep_time", 0444, NULL, NULL,
    60			&tk_debug_sleep_time_fops);
    61		if (!d) {
    62			pr_err("Failed to create sleep_time debug file\n");
    63			return -ENOMEM;
    64		}
    65	
    66		return 0;
    67	}
    68	late_initcall(tk_debug_sleep_time_init);
    69	
    70	void tk_debug_account_sleep_time(struct timespec64 *t)
    71	{
    72		sleep_time_bin[fls(t->tv_sec)]++;
  > 73		pr_info("Suspended for %lu.%03lu seconds\n", t->tv_sec,
    74				t->tv_nsec / NSEC_PER_MSEC);
    75	}
    76	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 37236 bytes --]

Re: [PATCH] timekeeping: Prints the amounts of time spent during suspend

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2667 bytes --]

Hi Ruchi,

[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ruchi-Kandoi/timekeeping-Prints-the-amounts-of-time-spent-during-suspend/20160812-034700
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from include/linux/wait.h:6,
                    from include/linux/fs.h:5,
                    from include/linux/debugfs.h:18,
                    from kernel/time/timekeeping_debug.c:17:
   kernel/time/timekeeping_debug.c: In function 'tk_debug_account_sleep_time':
>> include/linux/kern_levels.h:4:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'time64_t {aka long long int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:13:19: note: in expansion of macro 'KERN_SOH'
    #define KERN_INFO KERN_SOH "6" /* informational */
                      ^
   include/linux/printk.h:271:9: note: in expansion of macro 'KERN_INFO'
     printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
            ^
>> kernel/time/timekeeping_debug.c:73:2: note: in expansion of macro 'pr_info'
     pr_info("Suspended for %lu.%03lu seconds\n", t->tv_sec,
     ^

vim +/pr_info +73 kernel/time/timekeeping_debug.c

    57		struct dentry *d;
    58	
    59		d = debugfs_create_file("sleep_time", 0444, NULL, NULL,
    60			&tk_debug_sleep_time_fops);
    61		if (!d) {
    62			pr_err("Failed to create sleep_time debug file\n");
    63			return -ENOMEM;
    64		}
    65	
    66		return 0;
    67	}
    68	late_initcall(tk_debug_sleep_time_init);
    69	
    70	void tk_debug_account_sleep_time(struct timespec64 *t)
    71	{
    72		sleep_time_bin[fls(t->tv_sec)]++;
  > 73		pr_info("Suspended for %lu.%03lu seconds\n", t->tv_sec,
    74				t->tv_nsec / NSEC_PER_MSEC);
    75	}
    76	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 42515 bytes --]

Re: [PATCH] timekeeping: Prints the amounts of time spent during suspend

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]

Hi Ruchi,

[auto build test WARNING on tip/timers/core]
[also build test WARNING on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ruchi-Kandoi/timekeeping-Prints-the-amounts-of-time-spent-during-suspend/20160812-034700
config: openrisc-allmodconfig (attached as .config)
compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All warnings (new ones prefixed by >>):

   kernel/time/timekeeping_debug.c: In function 'tk_debug_account_sleep_time':
>> kernel/time/timekeeping_debug.c:73:2: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'time64_t'

vim +73 kernel/time/timekeeping_debug.c

    57		struct dentry *d;
    58	
    59		d = debugfs_create_file("sleep_time", 0444, NULL, NULL,
    60			&tk_debug_sleep_time_fops);
    61		if (!d) {
    62			pr_err("Failed to create sleep_time debug file\n");
    63			return -ENOMEM;
    64		}
    65	
    66		return 0;
    67	}
    68	late_initcall(tk_debug_sleep_time_init);
    69	
    70	void tk_debug_account_sleep_time(struct timespec64 *t)
    71	{
    72		sleep_time_bin[fls(t->tv_sec)]++;
  > 73		pr_info("Suspended for %lu.%03lu seconds\n", t->tv_sec,
    74				t->tv_nsec / NSEC_PER_MSEC);
    75	}
    76	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 37944 bytes --]