All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter
@ 2016-08-11 18:35 James Smart
  2016-08-12  9:08 ` Johannes Thumshirn
  2016-08-12  9:15 ` Johannes Thumshirn
  0 siblings, 2 replies; 3+ messages in thread
From: James Smart @ 2016-08-11 18:35 UTC (permalink / raw)
  To: linux-scsi


Code clean up for lpfc_iocb_cnt parameter

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_attr.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index be81e61..e5092dc 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -2827,14 +2827,8 @@ lpfc_txcmplq_hw_show(struct device *dev, struct device_attribute *attr,
 static DEVICE_ATTR(txcmplq_hw, S_IRUGO,
 			 lpfc_txcmplq_hw_show, NULL);
 
-int lpfc_iocb_cnt = 2;
-module_param(lpfc_iocb_cnt, int, S_IRUGO);
-MODULE_PARM_DESC(lpfc_iocb_cnt,
+LPFC_ATTR_R(iocb_cnt, 2, 1, 5,
 	"Number of IOCBs alloc for ELS, CT, and ABTS: 1k to 5k IOCBs");
-lpfc_param_show(iocb_cnt);
-lpfc_param_init(iocb_cnt, 2, 1, 5);
-static DEVICE_ATTR(lpfc_iocb_cnt, S_IRUGO,
-			 lpfc_iocb_cnt_show, NULL);
 
 /*
 # lpfc_nodev_tmo: If set, it will hold all I/O errors on devices that disappear
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter
  2016-08-11 18:35 [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter James Smart
@ 2016-08-12  9:08 ` Johannes Thumshirn
  2016-08-12  9:15 ` Johannes Thumshirn
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2016-08-12  9:08 UTC (permalink / raw)
  To: James Smart; +Cc: linux-scsi

On Thu, Aug 11, 2016 at 11:35:52AM -0700, James Smart wrote:
> 
> Code clean up for lpfc_iocb_cnt parameter
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter
  2016-08-11 18:35 [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter James Smart
  2016-08-12  9:08 ` Johannes Thumshirn
@ 2016-08-12  9:15 ` Johannes Thumshirn
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2016-08-12  9:15 UTC (permalink / raw)
  To: James Smart; +Cc: linux-scsi

On Thu, Aug 11, 2016 at 11:35:52AM -0700, James Smart wrote:
> 
> Code clean up for lpfc_iocb_cnt parameter
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-08-12  9:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-11 18:35 [PATCH 05/14] lpfc: Code clean up for lpfc_iocb_cnt parameter James Smart
2016-08-12  9:08 ` Johannes Thumshirn
2016-08-12  9:15 ` Johannes Thumshirn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.